Commit Graph

15531 Commits

Author SHA1 Message Date
Mark Salyzyn c1e9d6dada logd: filters remove leading expire messages and rate
(cherry pick from commit 047cc0729f)

- Cleanup resulting from experience and feedback
- When filtering inside logd, drop any leading expire messages, they
  are cluttering up leading edge of tombstones (which filter by pid)
- Increase and introduce EXPIRE_RATELIMIT from 1 to 10 seconds
- Increase EXPIRE_THRESHOLD from 4 to 10 count
- Improve the expire messages from:
   logd : uid=1000(system) too chatty comm=com.google.android.phone,
                                                   expire 2800 lines
  change tag to be more descriptive, and reduce accusatory tone to:
   chatty : uid=1000(system) com.google.android.phone expire 2800
                                                               lines
- if the UID name forms a prefix for comm name, then drop UID name

Change-Id: Ied7cc04c0ab3ae02167649a0b97378e44ef7b588
2015-06-05 10:20:55 -07:00
Mark Salyzyn 515d581d2d Merge "logd: filters remove leading expire messages and rate" 2015-06-05 17:18:26 +00:00
Mark Salyzyn 047cc0729f logd: filters remove leading expire messages and rate
- Cleanup resulting from experience and feedback
- When filtering inside logd, drop any leading expire messages, they
  are cluttering up leading edge of tombstones (which filter by pid)
- Increase and introduce EXPIRE_RATELIMIT from 1 to 10 seconds
- Increase EXPIRE_THRESHOLD from 4 to 10 count
- Improve the expire messages from:
   logd : uid=1000(system) too chatty comm=com.google.android.phone,
                                                   expire 2800 lines
  change tag to be more descriptive, and reduce accusatory tone to:
   chatty : uid=1000(system) com.google.android.phone expire 2800
                                                               lines
- if the UID name forms a prefix for comm name, then drop UID name

Change-Id: Ied7cc04c0ab3ae02167649a0b97378e44ef7b588
2015-06-05 08:05:05 -07:00
Christopher Ferris 1c29da79ac am 3d376871: am 5a923344: Merge "Change the 64 bit map address format." into mnc-dev
* commit '3d376871cdde362d08d91f722b2619deb9cb661e':
  Change the 64 bit map address format.
2015-06-05 01:40:53 +00:00
Christopher Ferris 3d376871cd am 5a923344: Merge "Change the 64 bit map address format." into mnc-dev
* commit '5a9233444b519cb866cc657a4dce27c45f089a97':
  Change the 64 bit map address format.
2015-06-05 01:27:35 +00:00
Elliott Hughes d56d7cc248 am 3fa276aa: am 473629d5: am f9ae390f: Merge "adb: win32: get test_adb.py running and passing 100%"
* commit '3fa276aab5455b2ece4dd9d25208097e3aa9820e':
  adb: win32: get test_adb.py running and passing 100%
2015-06-05 01:23:12 +00:00
Elliott Hughes 3fa276aab5 am 473629d5: am f9ae390f: Merge "adb: win32: get test_adb.py running and passing 100%"
* commit '473629d564fbb90e5c08bc7006685fe47b8cadd0':
  adb: win32: get test_adb.py running and passing 100%
2015-06-05 01:08:36 +00:00
Christopher Ferris 5a9233444b Merge "Change the 64 bit map address format." into mnc-dev 2015-06-05 01:02:42 +00:00
Elliott Hughes 473629d564 am f9ae390f: Merge "adb: win32: get test_adb.py running and passing 100%"
* commit 'f9ae390f63aa7bfc4e93ba1e18240aa1e05d122b':
  adb: win32: get test_adb.py running and passing 100%
2015-06-05 01:01:15 +00:00
Elliott Hughes f9ae390f63 Merge "adb: win32: get test_adb.py running and passing 100%" 2015-06-05 00:50:08 +00:00
Paul Lawrence b183361199 am a7dcec1d: am 3678a5fb: Merge "Move crypt commands to a different listener in vold" into mnc-dev
* commit 'a7dcec1da38c15d5e5ede7bfdec7ffd880cb6b82':
  Move crypt commands to a different listener in vold
2015-06-05 00:47:36 +00:00
Paul Lawrence a7dcec1da3 am 3678a5fb: Merge "Move crypt commands to a different listener in vold" into mnc-dev
* commit '3678a5fb8d1094c4796c1316f3b571cb63cf7246':
  Move crypt commands to a different listener in vold
2015-06-04 23:07:32 +00:00
Elliott Hughes 575719a0a0 am d41dee7f: am 641fd2e4: am ebce1470: Merge "adb: fix adb_close() vs. unix_close() usage"
* commit 'd41dee7fc84c81f61ddc4d2ba3dc648559bc68e9':
  adb: fix adb_close() vs. unix_close() usage
2015-06-04 22:57:28 +00:00
Elliott Hughes a736395c43 am 53a8ccc5: am 0895894c: am e1a06a55: Merge "Fix whitespace in debug logging."
* commit '53a8ccc57474330d595d48a419a5034d0328c68c':
  Fix whitespace in debug logging.
2015-06-04 22:57:27 +00:00
Elliott Hughes d41dee7fc8 am 641fd2e4: am ebce1470: Merge "adb: fix adb_close() vs. unix_close() usage"
* commit '641fd2e443607aadd2cb98177308241cb633dcbd':
  adb: fix adb_close() vs. unix_close() usage
2015-06-04 22:44:55 +00:00
Elliott Hughes 53a8ccc574 am 0895894c: am e1a06a55: Merge "Fix whitespace in debug logging."
* commit '0895894c4b2dbee3c9b572ecc4b96879971f6185':
  Fix whitespace in debug logging.
2015-06-04 22:44:52 +00:00
Elliott Hughes 641fd2e443 am ebce1470: Merge "adb: fix adb_close() vs. unix_close() usage"
* commit 'ebce1470779ad424bc220ada590ee274dbdfaaa4':
  adb: fix adb_close() vs. unix_close() usage
2015-06-04 22:32:41 +00:00
Elliott Hughes 0895894c4b am e1a06a55: Merge "Fix whitespace in debug logging."
* commit 'e1a06a550275a1b0c385059c1f19061f4b0f8ffa':
  Fix whitespace in debug logging.
2015-06-04 22:32:40 +00:00
Elliott Hughes ebce147077 Merge "adb: fix adb_close() vs. unix_close() usage" 2015-06-04 22:28:50 +00:00
Elliott Hughes e1a06a5502 Merge "Fix whitespace in debug logging." 2015-06-04 22:23:45 +00:00
Elliott Hughes e49236b3da Fix whitespace in debug logging.
Change-Id: I949317deaf782fea18b5c38b22dfd41811608276
2015-06-04 15:21:59 -07:00
Paul Lawrence 3678a5fb8d Merge "Move crypt commands to a different listener in vold" into mnc-dev 2015-06-04 21:32:44 +00:00
Elliott Hughes 4dfdd0f5bf am 1e9d1c5d: am 25a1341f: Merge changes from topic \'fastboot\' into mnc-dev
* commit '1e9d1c5d41c175ec2c3e2bb2ec30071f343e1cb8':
  Don't say "update package missing" unless we mean it.
  'usb' doesn't need to be global in fastboot.
  Add "fastboot --version".
  libziparchive: fix fallocate failures
  Use base::WriteFully in zip_archive.
  libziparchive: fix clang build
  Avoid mapping output to memory while writing to a file.
2015-06-04 21:22:13 +00:00
Elliott Hughes 1e9d1c5d41 am 25a1341f: Merge changes from topic \'fastboot\' into mnc-dev
* commit '25a1341f44749eb20e4c8c4cf5c42a5f34a8446f':
  Don't say "update package missing" unless we mean it.
  'usb' doesn't need to be global in fastboot.
  Add "fastboot --version".
  libziparchive: fix fallocate failures
  Use base::WriteFully in zip_archive.
  libziparchive: fix clang build
  Avoid mapping output to memory while writing to a file.
2015-06-04 21:09:08 +00:00
Elliott Hughes 25a1341f44 Merge changes from topic 'fastboot' into mnc-dev
* changes:
  Don't say "update package missing" unless we mean it.
  'usb' doesn't need to be global in fastboot.
  Add "fastboot --version".
  libziparchive: fix fallocate failures
  Use base::WriteFully in zip_archive.
  libziparchive: fix clang build
  Avoid mapping output to memory while writing to a file.
2015-06-04 20:47:23 +00:00
Elliott Hughes 966339b2d6 Don't say "update package missing" unless we mean it.
unzip_to_file reports failures itself these days, so there's it's unhelpful
of the caller to just guess what might have gone wrong.

Bug: http://b/21558406
Change-Id: I1e3d06c6cf902b8c6ef333dc60fd8f49680a493b
(cherry picked from commit acdbe92c60)
2015-06-04 13:26:57 -07:00
Elliott Hughes c688c23286 'usb' doesn't need to be global in fastboot.
Bug: http://b/21558406
Change-Id: Id014399640865d889918661bae0161b3165eee48
(cherry picked from commit c0ce65f961)
2015-06-04 13:26:48 -07:00
Elliott Hughes e283ca29c5 Add "fastboot --version".
So bug reporters can actually tell us what they're running.

Bug: http://b/21558406
Bug: http://b/21583225
Change-Id: If2a4ae97b4792aa321566603ce2c354a72d32307
(cherry picked from commit 379646b2ca)
2015-06-04 13:26:40 -07:00
Badhri Jagan Sridharan 71aebefe49 libziparchive: fix fallocate failures
The objective of fallocate call seems to be to
make sure that we have enough enough space left
in the disk to house the uncompressed file.
But, fallocate is only supported in the following
file systems:
btrfs, ext4, ocfs2, and xfs

Return error only when fallocate fails due to
lack of space. The immediate ftruncate call is
going to take of the majority of other errors.

Bug: http://b/21558406
Bug: 21561449
Change-Id: I7083f3c7e5d745bd6e8a190ac9020297d638d9d4
(cherry picked from commit a68d0d1fe4)
2015-06-04 13:26:29 -07:00
Narayan Kamath 67ab5d9505 Use base::WriteFully in zip_archive.
We're already linking against libbase but we'll have to add
a libbase dependency to every target that includes libziparchive
as a STATIC_LIBRARY dependency, given that there's no way to
express that what we want (except by adding a LOCAL_WHOLE_STATIC_LIBRARY
dependency on libbase to libziparchive but that seems bad too)

Bug: http://b/21558406
Change-Id: I294ad389a9c61a1134a7bc323da25b0004a8f1e0
(cherry picked from commit e97e66ea7c)
2015-06-04 13:26:22 -07:00
Greg Hackmann 4ba18cf3ff libziparchive: fix clang build
Bug: http://b/21558406
Change-Id: I69105a9cde05b182f65c7e574282bb4b48b66e95
Signed-off-by: Greg Hackmann <ghackmann@google.com>
(cherry picked from commit d6eac24aac)
2015-06-04 13:26:12 -07:00
Narayan Kamath 785a128aec Avoid mapping output to memory while writing to a file.
It's unnecessary, and causes issues when the uncompressed
output is large.

Bug: http://b/21558406
Change-Id: I99cfb3933b094c2826c7e6c6de9aab03478fcc53
(cherry picked from commit f899bd534b)
2015-06-04 13:25:52 -07:00
Mark Salyzyn 6c12ce3d24 am 59119550: am 6f1457ad: logd: switch to unordered_map from BasicHashtable
* commit '591195508b001a228938a4a5491c060bdb297736':
  logd: switch to unordered_map from BasicHashtable
2015-06-04 19:16:04 +00:00
Mark Salyzyn ce0542b874 am fa165ba4: am 1a9f875d: am 7ea9e8d2: Merge "logd: switch to unordered_map from BasicHashtable"
* commit 'fa165ba4c22c4cfbcd8627ba3240b33ad03a5fe1':
  logd: switch to unordered_map from BasicHashtable
2015-06-04 19:16:02 +00:00
Rom Lemarchand 58f0a7f067 am 3c1bebf4: am f46dda96: am 4d2c1ee1: Merge "mkbootimg: misc typo fixes"
* commit '3c1bebf40766d50fee69199cdb96d9125435f83d':
  mkbootimg: misc typo fixes
2015-06-04 19:16:01 +00:00
Mark Salyzyn 591195508b am 6f1457ad: logd: switch to unordered_map from BasicHashtable
* commit '6f1457adc58644f7c68829fd0872947bd7e63bfd':
  logd: switch to unordered_map from BasicHashtable
2015-06-04 19:08:51 +00:00
Mark Salyzyn fa165ba4c2 am 1a9f875d: am 7ea9e8d2: Merge "logd: switch to unordered_map from BasicHashtable"
* commit '1a9f875d3c2de051a9a67392f4b134eceef34ac6':
  logd: switch to unordered_map from BasicHashtable
2015-06-04 19:00:31 +00:00
Rom Lemarchand 3c1bebf407 am f46dda96: am 4d2c1ee1: Merge "mkbootimg: misc typo fixes"
* commit 'f46dda96650a7d3e3791a6f4c034ce4d9f9e3f36':
  mkbootimg: misc typo fixes
2015-06-04 19:00:05 +00:00
Mark Salyzyn 1a9f875d3c am 7ea9e8d2: Merge "logd: switch to unordered_map from BasicHashtable"
* commit '7ea9e8d2662b54bc16f0c7a615c5ee650bf42ffa':
  logd: switch to unordered_map from BasicHashtable
2015-06-04 18:10:37 +00:00
Mark Salyzyn 6f1457adc5 logd: switch to unordered_map from BasicHashtable
(charry pick from commit 511338dd57)

BasicHashtable is relatively untested, move over to
a C++ template library that has more bake time.

Bug: 20419786
Bug: 21590652
Bug: 20500228
Change-Id: I926aaecdc8345eca75c08fdd561b0473504c5d95
2015-06-04 11:03:37 -07:00
Mark Salyzyn 7ea9e8d266 Merge "logd: switch to unordered_map from BasicHashtable" 2015-06-04 18:01:01 +00:00
Rom Lemarchand f46dda9665 am 4d2c1ee1: Merge "mkbootimg: misc typo fixes"
* commit '4d2c1ee1411fecfedc47ff90c25b2729e7984195':
  mkbootimg: misc typo fixes
2015-06-04 17:09:15 +00:00
Rom Lemarchand 4d2c1ee141 Merge "mkbootimg: misc typo fixes" 2015-06-04 17:01:00 +00:00
Rom Lemarchand a8221d3427 mkbootimg: misc typo fixes
- Fix whitespace in parse_int
- Use two dashes for kernel_offset instead of four

Change-Id: I59667da457d0f0d78a946e543d1aa0aec5e682d5
2015-06-04 09:59:01 -07:00
Mark Salyzyn 160c6e2a57 am 1f3507ac: am 5d332907: liblog: logcat: Add printable format modifier
* commit '1f3507ac3adb92b60679857123d685a696671950':
  liblog: logcat: Add printable format modifier
2015-06-04 16:16:15 +00:00
Mark Salyzyn 1f3507ac3a am 5d332907: liblog: logcat: Add printable format modifier
* commit '5d332907f0f845227847c31a122578dc910f1072':
  liblog: logcat: Add printable format modifier
2015-06-04 16:04:12 +00:00
Mark Salyzyn cf54d005bf am 8a5fe055: am 3ae69bbe: am 79ae578e: Merge "liblog: logcat: Add printable format modifier"
* commit '8a5fe05531fc0858682025c60319a068d3bd54a9':
  liblog: logcat: Add printable format modifier
2015-06-04 16:03:56 +00:00
Mark Salyzyn 8a5fe05531 am 3ae69bbe: am 79ae578e: Merge "liblog: logcat: Add printable format modifier"
* commit '3ae69bbe03e1992ef08578ec8597fdb7b871694a':
  liblog: logcat: Add printable format modifier
2015-06-04 15:56:14 +00:00
Mark Salyzyn 3ae69bbe03 am 79ae578e: Merge "liblog: logcat: Add printable format modifier"
* commit '79ae578eddaf0af5ef84ac7d71b3330d1a8c41ae':
  liblog: logcat: Add printable format modifier
2015-06-04 15:44:52 +00:00
Mark Salyzyn 5d332907f0 liblog: logcat: Add printable format modifier
(cherry pick from commit b932b2f8ba)

- added printable format modifier:
  logcat -v printable
- opencoded borrowed individual utf8 validity checking algorithm
  from utf8_length() in libutils/Unicode.cpp
- if considered basic one-character ASCII, use popular \x escape
  sequences for non-printable
- logprint convert to C comments to drop mixed-mode

Bug: 19000361
Change-Id: I122a5b8fb41216fc0bc816178c0b768f3df56586
2015-06-04 08:37:14 -07:00