Josh Gao
f3dde2f869
debuggerd: set the name of the signal sender.
...
Change-Id: I6bff938e229d2368250d4b5c268fa24bd4badea0
2016-03-29 17:56:47 -07:00
Josh Gao
8aeabe15dd
Merge "debuggerd: waitpid for all children, and log the result."
2016-03-23 21:10:38 +00:00
Josh Gao
6e183586e3
Merge "debuggerd: always send SIGCONT after detaching."
2016-03-23 21:09:21 +00:00
Josh Gao
2808005521
debuggerd: waitpid for all children, and log the result.
...
Change-Id: Ic575e6db76ab153b4b238589a8cd299812d0e046
2016-03-23 14:07:58 -07:00
Josh Gao
24464185eb
debuggerd: always send SIGCONT after detaching.
...
Bug: http://b/27330889
Change-Id: I104248af1cde03dbdbacc03c87fe7e2dffd6c037
2016-03-23 14:07:58 -07:00
Elliott Hughes
ae38923c3e
Switch debuggerd over to unique_fd.
...
Change-Id: I858b9ac6a3ed47b4cc81cfe49f1ceb1e06356a03
2016-03-22 20:03:13 -07:00
Josh Gao
676a756b7b
debuggerd: don't apply timeout when wait_for_gdb is on.
...
Change-Id: Ic632dde4a0510c212a4b1c01890df9a41e9771c9
2016-03-17 15:29:00 -07:00
Josh Gao
b17f228ff6
debuggerd: don't send SIGSTOP to crashing processes.
...
This was actually nonfunctional until f5e8f0b
, because it was using kill
after privileges were dropped. This doesn't seem necessary after the
changes to the sibling thread ptrace logic, though.
Bug: http://b/27427439
Change-Id: I6bffbc14e0cf5e377bbfa39c945518e0d436c223
2016-03-17 13:47:48 -07:00
Josh Gao
1b301836bb
debuggerd: fix stupid typo.
...
Change-Id: Icd9a25a71e1e8580a200fe68bce0b17d09c51642
2016-03-17 13:21:56 -07:00
Josh Gao
630bc80e18
debuggerd: monitor the worker process for failure.
...
Use sigtimedwait on SIGCHLD to watch our forked worker processes for
failure, so that we can guarantee that we always resume/kill the target
process if libunwind crashes.
Bug: http://b/27427439
Change-Id: I5a5da1f1abd7dc9d01223f5b3778e946e2d47d20
2016-03-17 11:43:55 -07:00
Josh Gao
f5e8f0b9cd
debuggerd: fork the signal sender once.
...
Bug: http://b/27427439
Change-Id: I6294ff68a150bc9950a300264c31d2141307ac66
2016-03-17 11:27:31 -07:00
Josh Gao
561497c0a8
debuggerd: kill crashing processes with the signal they died with.
...
Bug: http://b/27675306
Change-Id: I951c5d7e54c35d88c65c5dc856e0b9d5a93d47b2
2016-03-16 16:10:48 -07:00
Christopher Ferris
3f9c22c34c
Merge "Add error reporting mechanism for failing Unwind."
2016-03-10 22:12:35 +00:00
Christopher Ferris
206a3b9798
Add error reporting mechanism for failing Unwind.
...
Remove the logging of an error if a thread disappears before the unwind
can begin. This can happen, so allow the caller to determine if this
is really a problem worth logging.
Bug: 27449879
Change-Id: Ie81718d53fb0e519fa0a7db9fd5f314b72bfa431
2016-03-10 12:39:15 -08:00
Josh Gao
f0c8723bdd
debuggerd: make sure that we kill the process after dumping.
...
Bug: http://b/27367422
Change-Id: Icd704b1effd558904975cfc524714b51917a653f
2016-03-09 15:59:27 -08:00
Elliott Hughes
dbab798695
Merge "Clean up CLOEXEC in debuggerd."
...
am: f405d245eb
* commit 'f405d245eb1288c8085cfdeaa3e02b4af707c4f1':
Clean up CLOEXEC in debuggerd.
2016-02-23 18:46:21 +00:00
Elliott Hughes
17ba68d0cd
Clean up CLOEXEC in debuggerd.
...
Change-Id: I1cd75f6a8f98e99f4a4fedfc706103ce34035765
2016-02-19 18:13:02 -08:00
Elliott Hughes
bdf9d18c34
Merge "Remove dead code from debuggerd."
...
am: fbaefc4d9d
* commit 'fbaefc4d9d4e7e40ec0262123cd54762b81ed47a':
Remove dead code from debuggerd.
2016-02-19 19:42:29 +00:00
Elliott Hughes
fbaefc4d9d
Merge "Remove dead code from debuggerd."
2016-02-19 19:36:22 +00:00
Elliott Hughes
6da1353863
Remove dead code from debuggerd.
...
system/core/debuggerd/debuggerd.cpp:683:5: warning: Value stored to 'logsocket' is never read
logsocket = -1;
^ ~~
Bug: http://b/27264392
Change-Id: I8eab8a02b67f219c32aea49e4d4957e5642df38f
2016-02-19 10:41:17 -08:00
James Hawkins
0f5d443d0c
Merge "system/core: Cleanup direct calls to opendir by containing in a std::unique_ptr."
...
am: bd04bb0d29
* commit 'bd04bb0d297c1a7cd5aabdc258b1829905fb067d':
system/core: Cleanup direct calls to opendir by containing in a std::unique_ptr.
2016-02-19 17:51:44 +00:00
James Hawkins
588a2cad7f
system/core: Cleanup direct calls to opendir by containing in a
...
std::unique_ptr.
Bug: 26643633
Change-Id: Ia3491fdbff086558da694ae949cf08e4c89d0307
2016-02-18 14:52:46 -08:00
Bill Yi
4409f1446c
Merge commit '4352ee87fd74b931d4b58192fb8974e91aa899d0' into HEAD
2016-02-17 11:37:00 -08:00
Christopher Ferris
5d56e28537
Newer kernels added SEGV_BNDERR.
...
Bug: 23789423
Change-Id: I6fdce75715edfce179df8c0e6a7205f26341ebd0
2016-02-04 14:07:23 -08:00
Elliott Hughes
2f74a5dae5
Start debuggerd as soon as logd is up.
...
Makes debugging early boot crashes easier.
Bug: http://b/26918597
Change-Id: I5bb883f1350ea5f7a545cb0e9f1034ecfcf47cdb
2016-02-02 13:03:41 -08:00
Josh Gao
f983e6ce5a
Merge "debuggerd: fix debug.debuggerd.wait_for_gdb."
...
am: a590596dca
* commit 'a590596dcac8cc6a2ffaab110bdd89fdb5f837d8':
debuggerd: fix debug.debuggerd.wait_for_gdb.
2016-01-15 19:40:49 +00:00
Josh Gao
2318cc0155
Merge "debuggerd: fix several bugs caused by fork/setuid change."
...
am: 1bf7000033
* commit '1bf700003368e8b68b34a0f9968ae5afd25dd4f2':
debuggerd: fix several bugs caused by fork/setuid change.
2016-01-15 19:40:41 +00:00
Josh Gao
c362c45949
debuggerd: fix debug.debuggerd.wait_for_gdb.
...
Bug: http://b/26513486
Change-Id: I01c28ce810a49f8a4e0e2a86c7d018d95f9617c8
2016-01-15 11:31:17 -08:00
Josh Gao
7c89f9e955
debuggerd: fix several bugs caused by fork/setuid change.
...
Previously, we weren't PTRACE_ATTACHing to all of the threads of a
process, and we were also trying to do it after forking and dropping
privileges. This patch ensures that all ptrace attaching/detaching
happens in one place, before forking/exiting respectively.
Bug: http://b/26443860
Bug: http://b/26436605
Bug: http://b/26436486
Change-Id: Id94e0c1d9d56c051d0dd281d895aaa3285079198
2016-01-14 15:06:37 -08:00
Colin Cross
ce93dd6fcc
Merge "debuggerd_test: provide stub selinux/android.h"
...
am: 5e19382e1c
* commit '5e19382e1c585967ee07b14fbb36a8027c92c394':
debuggerd_test: provide stub selinux/android.h
2016-01-08 20:54:20 +00:00
Colin Cross
5e19382e1c
Merge "debuggerd_test: provide stub selinux/android.h"
2016-01-08 20:49:47 +00:00
Dan Willemsen
3be0a0df2c
Merge "Turn off -Wdate-time for crasher"
...
am: 392867cff1
* commit '392867cff1584f2ee475aae4b8f89778085a7de0':
Turn off -Wdate-time for crasher
2016-01-06 00:35:00 +00:00
Dan Willemsen
392867cff1
Merge "Turn off -Wdate-time for crasher"
2016-01-06 00:23:37 +00:00
Josh Gao
8a43d6ae06
Merge "debuggerd: fork and drop privileges when dumping."
...
am: b8e9ebf8b4
* commit 'b8e9ebf8b4b840e4421534ffccce84d7ef49dc0f':
debuggerd: fork and drop privileges when dumping.
2016-01-06 00:05:32 +00:00
Josh Gao
e7a9e52740
debuggerd: fork and drop privileges when dumping.
...
Bug: http://b/25195825
Change-Id: I913d8425232e79df3f7a051a8cc63de9c60f4780
2016-01-05 15:59:01 -08:00
Colin Cross
061e4a7d59
debuggerd_test: provide stub selinux/android.h
...
debuggerd_test stubs out the selinux/android.h interface, but was
relying on copied selinux headers to declare the interface. Create a
stub selinux/android.h header included by the test to declare the
interface.
Change-Id: I6a2d402dda1797deb2515f10b663b1a84d498eac
2015-12-21 16:29:02 -08:00
Erik Kline
cbc6f68e32
Merge "Switch from using sockaddr to sockaddr_storage." am: 46b0b1c694
...
am: 4c1b3840f0
* commit '4c1b3840f092e63b0b8db8998b3bbc3465ff7c91':
Switch from using sockaddr to sockaddr_storage.
2015-12-08 01:48:58 +00:00
Erik Kline
46b0b1c694
Merge "Switch from using sockaddr to sockaddr_storage."
2015-12-08 01:41:38 +00:00
Elliott Hughes
3608ee5e90
Merge "Track rename of base/ to android-base/." am: 912ed3d8ca
...
am: e2a9563be1
* commit 'e2a9563be1d540a1fb91489986bf6a72d54b59c8':
Track rename of base/ to android-base/.
2015-12-07 23:36:59 +00:00
Erik Kline
7e16cc15b5
Switch from using sockaddr to sockaddr_storage.
...
This is to ensure sufficient space is always available.
Change-Id: Ifa87b93ecdc90dcacbfb24446c872344da6703d3
2015-12-07 16:07:46 +09:00
Elliott Hughes
4f71319df0
Track rename of base/ to android-base/.
...
Change-Id: Idf9444fece4aa89c93e15640de59a91f6e758ccf
2015-12-04 22:00:26 -08:00
Josh Gao
729ed79c51
Merge "debuggerd: remove some levels of indentation." am: cdff80c446
...
am: e2773a3f8e
* commit 'e2773a3f8eb1c770c1214fb43089f35cf4ca47c7':
debuggerd: remove some levels of indentation.
2015-11-18 17:19:33 +00:00
Josh Gao
8ab7fd4017
debuggerd: remove some levels of indentation.
...
Use ScopedFd and unique_ptr to manage resources, so that we can early
exit instead of having 9 levels of indentation.
Change-Id: Ia5fed76c7d959f1f198ea540c56c508f7e1585c4
2015-11-17 14:44:50 -08:00
Josh Gao
93621bbf19
Merge "debuggerd: add .clang-format." am: c5a85f71ab
...
am: b4362070fc
* commit 'b4362070fc4c9b8178d75aaa6ab7932db5b845e1':
debuggerd: add .clang-format.
2015-11-17 22:32:17 +00:00
Josh Gao
d918eedf29
debuggerd: add .clang-format.
...
Change-Id: I3584c170aadc3707638e407c7a8ca502f3670058
2015-11-16 17:26:22 -08:00
Nick Kralevich
7dafe5b818
Merge "Enable hidepid=2 on /proc" am: 2d8f1d4c47
...
am: ea8452cc72
* commit 'ea8452cc720cfcf2d8d1f469bbaafec968202e99':
Enable hidepid=2 on /proc
2015-11-09 20:35:18 +00:00
Nick Kralevich
c39ba5ae32
Enable hidepid=2 on /proc
...
Add the following mount options to the /proc filesystem:
hidepid=2,gid=3009
This change blocks /proc access unless you're in group 3009
(aka AID_READPROC).
Please see
https://github.com/torvalds/linux/blob/master/Documentation/filesystems/proc.txt
for documentation on the hidepid option.
hidepid=2 is preferred over hidepid=1 since it leaks less information
and doesn't generate SELinux ptrace denials when trying to access
/proc without being in the proper group.
Add AID_READPROC to processes which need to access /proc entries for
other UIDs.
Bug: 23310674
Change-Id: I22bb55ff7b80ff722945e224845215196f09dafa
2015-11-09 09:08:46 -08:00
Dan Willemsen
9bef9660fd
Turn off -Wdate-time for crasher
...
This is an optional diagnostic tool where it's useful to know if you are
running the version that you just built. Allow the use of __TIME__
without a warning or error.
Bug: 24204119
Change-Id: I78063c2694b80ccaf5891d1cd649ea17eda978cb
2015-11-02 15:41:59 -08:00
Christopher Ferris
0dac031b03
Fix incorrect check of descsz value. am: d917514bd6
am: 69406d904a
...
am: 3f5fdc3522
* commit '3f5fdc35228b4bf9c86a91a35fc73a06d14391c5':
Fix incorrect check of descsz value.
2015-10-29 19:23:54 +00:00
Christopher Ferris
d917514bd6
Fix incorrect check of descsz value.
...
Bug: 25187394
(cherry picked from commit 1fa55234d6
)
Change-Id: Idbc9071e8b2b25a062c4e94118808d6e19d443d9
2015-10-22 17:54:24 -07:00