platform_system_core/liblog
Tom Cherry 0315b29497 liblog: remove faulty logic in __android_logger_valid_buffer_size
In testing, I saw that the 'main' and 'events' log buffers were set to
incorrect sizes when they were intended to be >= 4MB.  The bug is
tracked down to an invalid line in
__android_logger_valid_buffer_size():

  /* maximum memory impact a somewhat arbitrary ~3% */
  pages = (pages + 31) / 32;

There are two issues with this line:
1) That is not the right calculation for 3%.
2) `pages` is a static variable, so it repeatedly is decremented until
   reaching 1.

The consequence is that this function gives invalid results for the
first few calls, then returns true as long as the input is between
LOG_BUFFER_MIN_SIZE and LOG_BUFFER_MAX_SIZE.  That check is enough, so
the rest of this logic is removed.

Test: buffers are set to the right sizes.
Change-Id: I4d19b1d0fdbd83843d2d61a484ac083d571ef37b
2020-07-09 20:39:17 -07:00
..
include liblog: remove unused log_time functions, inline the others 2020-05-18 15:40:26 -07:00
include_vndk liblog: cleanup log_read.h header 2020-04-14 08:59:41 -07:00
tests liblog: remove unused log_time functions, inline the others 2020-05-18 15:40:26 -07:00
.clang-format Use the existing .clang-format-2 for liblog 2019-01-09 13:08:10 -08:00
Android.bp libbase/liblog: set min_sdk_version 2020-04-23 23:40:14 +09:00
NOTICE liblog: update timestamp on NOTICE file 2014-01-27 15:20:59 -08:00
OWNERS Add OWNERS. 2017-12-07 13:30:03 -08:00
README.md Remove the monotonic option for logging 2020-05-06 13:37:33 -07:00
README.protocol.md liblog: include all structures in README.protocol.md 2020-04-03 14:34:58 -07:00
event.logtags liblog: logprint supports number of seconds time event field 2017-04-14 12:54:25 -07:00
event_tag_map.cpp liblog: use libbase_headers for TEMP_FAILURE_RETRY 2020-01-14 09:56:25 -08:00
liblog.map.txt Merge "Move crash_dump into the runtime APEX." 2020-03-30 19:03:41 +00:00
log_event_list.cpp liblog: use libbase_headers for TEMP_FAILURE_RETRY 2020-01-14 09:56:25 -08:00
log_event_write.cpp liblog: use libbase_headers for TEMP_FAILURE_RETRY 2020-01-14 09:56:25 -08:00
log_time.cpp liblog: remove unused log_time functions, inline the others 2020-05-18 15:40:26 -07:00
logd_reader.cpp liblog: remove more unused code 2020-01-08 17:11:09 -08:00
logd_reader.h liblog: remove log_portability.h 2020-01-14 09:56:30 -08:00
logd_writer.cpp liblog: remove Rwlocks for logd_socket and pmsg_fd 2020-04-27 18:24:38 -07:00
logd_writer.h liblog: remove the last of the transport structs 2020-01-08 17:11:06 -08:00
logger.h liblog: remove log_portability.h 2020-01-14 09:56:30 -08:00
logger_name.cpp liblog: use int32_t and uint32_t for new NDK APIs 2020-03-12 11:11:24 -07:00
logger_read.cpp liblog: null terminate log_msg 2020-02-05 15:04:32 -08:00
logger_write.cpp Remove the monotonic option for logging 2020-05-06 13:37:33 -07:00
logger_write.h Remove thread safety from libbase logging / liblog 2020-04-22 13:12:11 -07:00
logprint.cpp Use standard colors in logcat color output 2020-06-20 03:26:12 +00:00
pmsg_reader.cpp liblog: fix reading pmsg 2020-06-17 09:34:51 -07:00
pmsg_reader.h liblog: remove log_portability.h 2020-01-14 09:56:30 -08:00
pmsg_writer.cpp Remove the monotonic option for logging 2020-05-06 13:37:33 -07:00
pmsg_writer.h liblog: remove the last of the transport structs 2020-01-08 17:11:06 -08:00
properties.cpp liblog: remove faulty logic in __android_logger_valid_buffer_size 2020-07-09 20:39:17 -07:00
uio.h Remove liblog/uio.c and <log/uio.h> 2019-01-16 14:26:36 -08:00

README.md

Android liblog

Public Functions and Macros

/*
 * Please limit to 24 characters for runtime is loggable,
 * 16 characters for persist is loggable, and logcat pretty
 * alignment with limit of 7 characters.
*/
#define LOG_TAG "yourtag"
#include <log/log.h>

ALOG(android_priority, tag, format, ...)
IF_ALOG(android_priority, tag)
LOG_PRI(priority, tag, format, ...)
LOG_PRI_VA(priority, tag, format, args)
#define LOG_TAG NULL
ALOGV(format, ...)
SLOGV(format, ...)
RLOGV(format, ...)
ALOGV_IF(cond, format, ...)
SLOGV_IF(cond, format, ...)
RLOGV_IF(cond, format, ...)
IF_ALOGC()
ALOGD(format, ...)
SLOGD(format, ...)
RLOGD(format, ...)
ALOGD_IF(cond, format, ...)
SLOGD_IF(cond, format, ...)
RLOGD_IF(cond, format, ...)
IF_ALOGD()
ALOGI(format, ...)
SLOGI(format, ...)
RLOGI(format, ...)
ALOGI_IF(cond, format, ...)
SLOGI_IF(cond, format, ...)
RLOGI_IF(cond, format, ...)
IF_ALOGI()
ALOGW(format, ...)
SLOGW(format, ...)
RLOGW(format, ...)
ALOGW_IF(cond, format, ...)
SLOGW_IF(cond, format, ...)
RLOGW_IF(cond, format, ...)
IF_ALOGW()
ALOGE(format, ...)
SLOGE(format, ...)
RLOGE(format, ...)
ALOGE_IF(cond, format, ...)
SLOGE_IF(cond, format, ...)
RLOGE_IF(cond, format, ...)
IF_ALOGE()
LOG_FATAL(format, ...)
LOG_ALWAYS_FATAL(format, ...)
LOG_FATAL_IF(cond, format, ...)
LOG_ALWAYS_FATAL_IF(cond, format, ...)
ALOG_ASSERT(cond, format, ...)
LOG_EVENT_INT(tag, value)
LOG_EVENT_LONG(tag, value)

log_id_t android_logger_get_id(struct logger *logger)
int android_logger_clear(struct logger *logger)
int android_logger_get_log_size(struct logger *logger)
int android_logger_get_log_readable_size(struct logger *logger)
int android_logger_get_log_version(struct logger *logger)

struct logger_list *android_logger_list_alloc(int mode, unsigned int tail, pid_t pid)
struct logger *android_logger_open(struct logger_list *logger_list, log_id_t id)
struct logger_list *android_logger_list_open(log_id_t id, int mode, unsigned int tail, pid_t pid)
int android_logger_list_read(struct logger_list *logger_list, struct log_msg *log_msg)
void android_logger_list_free(struct logger_list *logger_list)

log_id_t android_name_to_log_id(const char *logName)
const char *android_log_id_to_name(log_id_t log_id)

android_log_context create_android_logger(uint32_t tag)

int android_log_write_list_begin(android_log_context ctx)
int android_log_write_list_end(android_log_context ctx)

int android_log_write_int32(android_log_context ctx, int32_t value)
int android_log_write_int64(android_log_context ctx, int64_t value)
int android_log_write_string8(android_log_context ctx, const char *value)
int android_log_write_string8_len(android_log_context ctx, const char *value, size_t maxlen)
int android_log_write_float32(android_log_context ctx, float value)

int android_log_write_list(android_log_context ctx, log_id_t id = LOG_ID_EVENTS)

android_log_context create_android_log_parser(const char *msg, size_t len)
android_log_list_element android_log_read_next(android_log_context ctx)
android_log_list_element android_log_peek_next(android_log_context ctx)

int android_log_destroy(android_log_context *ctx)

Description

liblog represents an interface to the volatile Android Logging system for NDK (Native) applications and libraries. Interfaces for either writing or reading logs. The log buffers are divided up in Main, System, Radio and Events sub-logs.

The logging interfaces are a series of macros, all of which can be overridden individually in order to control the verbosity of the application or library. [ASR]LOG[VDIWE] calls are used to log to BAsic, System or Radio sub-logs in either the Verbose, Debug, Info, Warning or Error priorities. [ASR]LOG[VDIWE]_IF calls are used to perform thus based on a condition being true. IF_ALOG[VDIWE] calls are true if the current LOG_TAG is enabled at the specified priority. LOG_ALWAYS_FATAL is used to ALOG a message, then kill the process. LOG_FATAL call is a variant of LOG_ALWAYS_FATAL, only enabled in engineering, and not release builds. ALOG_ASSERT is used to ALOG a message if the condition is false; the condition is part of the logged message. LOG_EVENT_(INT|LONG) is used to drop binary content into the Events sub-log.

The log reading interfaces permit opening the logs either singly or multiply, retrieving a log entry at a time in time sorted order, optionally limited to a specific pid and tail of the log(s) and finally a call closing the logs. A single log can be opened with android_logger_list_open(); or multiple logs can be opened with android_logger_list_alloc(), calling in turn the android_logger_open() for each log id. Each entry can be retrieved with android_logger_list_read(). The log(s) can be closed with android_logger_list_free(). ANDROID_LOG_NONBLOCK mode will report when the log reading is done with an EAGAIN error return code, otherwise the android_logger_list_read() call will block for new entries.

The ANDROID_LOG_WRAP mode flag to the android_logger_list_alloc_time() signals logd to quiesce the reader until the buffer is about to prune at the start time then proceed to dumping content.

The ANDROID_LOG_PSTORE mode flag to the android_logger_open() is used to switch from the active logs to the persistent logs from before the last reboot.

The value returned by android_logger_open() can be used as a parameter to the android_logger_clear() function to empty the sub-log.

The value returned by android_logger_open() can be used as a parameter to the android_logger_get_log_(size|readable_size|version) to retrieve the sub-log maximum size, readable size and log buffer format protocol version respectively. android_logger_get_id() returns the id that was used when opening the sub-log.

Errors

If messages fail, a negative error code will be returned to the caller.

The -ENOTCONN return code indicates that the logger daemon is stopped.

The -EBADF return code indicates that the log access point can not be opened, or the log buffer id is out of range.

For the -EAGAIN return code, this means that the logging message was temporarily backed-up either because of Denial Of Service (DOS) logging pressure from some chatty application or service in the Android system, or if too small of a value is set in /proc/sys/net/unix/max_dgram_qlen. To aid in diagnosing the occurence of this, a binary event from liblog will be sent to the log daemon once a new message can get through indicating how many messages were dropped as a result. Please take action to resolve the structural problems at the source.

It is generally not advised for the caller to retry the -EAGAIN return code as this will only make the problem(s) worse and cause your application to temporarily drop to the logger daemon priority, BATCH scheduling policy and background task cgroup. If you require a group of messages to be passed atomically, merge them into one message with embedded newlines to the maximum length LOGGER_ENTRY_MAX_PAYLOAD.

Other return codes from writing operation can be returned. Since the library retries on EINTR, -EINTR should never be returned.