From 8e9c8720e8500051dd92c131a215aae06ddbe06a Mon Sep 17 00:00:00 2001 From: Ubuntu Developers Date: Sat, 14 May 2022 02:43:52 +0800 Subject: [PATCH] fix_linkpidfile make sure that the linkpidfile is always created Subject: Bug#284382: ppp: linkpidfile is not created upon detachment From: Package: ppp Version: 2.4.2+20040428-2 Severity: wishlist When pppd detaches from the parent normally, that is, without nodetach or updetach set, the linkpidfile is not created even when linkname is set. This is because the create_linkpidfile call in detach() is only made if the linkpidfile is filled in. However, linkpidfile is never filled in until create_linkpidfile has been called. IMHO the call should be made uncondtionally in detach() since create_linkpidfile does its own check on linkname anyway. Please note that the version of pppd in woody always wrote the linkpidfile after detaching. It did so in main() however. That call has now been removed which is why I'm seeing this problem. [...] -- Gbp-Pq: Name fix_linkpidfile --- pppd/main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pppd/main.c b/pppd/main.c index 76b67d2..8e31365 100644 --- a/pppd/main.c +++ b/pppd/main.c @@ -765,8 +765,7 @@ detach() /* update pid files if they have been written already */ if (pidfilename[0]) create_pidfile(pid); - if (linkpidfile[0]) - create_linkpidfile(pid); + create_linkpidfile(pid); exit(0); /* parent dies */ } setsid();