2012-02-12 00:26:17 +08:00
|
|
|
/*
|
|
|
|
* QEMU SuperH CPU
|
|
|
|
*
|
2012-04-13 08:16:02 +08:00
|
|
|
* Copyright (c) 2005 Samuel Tardieu
|
2012-02-12 00:26:17 +08:00
|
|
|
* Copyright (c) 2012 SUSE LINUX Products GmbH
|
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
* License along with this library; if not, see
|
|
|
|
* <http://www.gnu.org/licenses/lgpl-2.1.html>
|
|
|
|
*/
|
|
|
|
|
2016-01-27 02:17:20 +08:00
|
|
|
#include "qemu/osdep.h"
|
include/qemu/osdep.h: Don't include qapi/error.h
Commit 57cb38b included qapi/error.h into qemu/osdep.h to get the
Error typedef. Since then, we've moved to include qemu/osdep.h
everywhere. Its file comment explains: "To avoid getting into
possible circular include dependencies, this file should not include
any other QEMU headers, with the exceptions of config-host.h,
compiler.h, os-posix.h and os-win32.h, all of which are doing a
similar job to this file and are under similar constraints."
qapi/error.h doesn't do a similar job, and it doesn't adhere to
similar constraints: it includes qapi-types.h. That's in excess of
100KiB of crap most .c files don't actually need.
Add the typedef to qemu/typedefs.h, and include that instead of
qapi/error.h. Include qapi/error.h in .c files that need it and don't
get it now. Include qapi-types.h in qom/object.h for uint16List.
Update scripts/clean-includes accordingly. Update it further to match
reality: replace config.h by config-target.h, add sysemu/os-posix.h,
sysemu/os-win32.h. Update the list of includes in the qemu/osdep.h
comment quoted above similarly.
This reduces the number of objects depending on qapi/error.h from "all
of them" to less than a third. Unfortunately, the number depending on
qapi-types.h shrinks only a little. More work is needed for that one.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
[Fix compilation without the spice devel packages. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2016-03-14 16:01:28 +08:00
|
|
|
#include "qapi/error.h"
|
2012-02-12 00:26:17 +08:00
|
|
|
#include "cpu.h"
|
|
|
|
#include "qemu-common.h"
|
2013-01-21 02:32:33 +08:00
|
|
|
#include "migration/vmstate.h"
|
2012-02-12 00:26:17 +08:00
|
|
|
|
|
|
|
|
2013-06-22 01:09:18 +08:00
|
|
|
static void superh_cpu_set_pc(CPUState *cs, vaddr value)
|
|
|
|
{
|
|
|
|
SuperHCPU *cpu = SUPERH_CPU(cs);
|
|
|
|
|
|
|
|
cpu->env.pc = value;
|
|
|
|
}
|
|
|
|
|
2013-06-29 01:31:32 +08:00
|
|
|
static void superh_cpu_synchronize_from_tb(CPUState *cs, TranslationBlock *tb)
|
|
|
|
{
|
|
|
|
SuperHCPU *cpu = SUPERH_CPU(cs);
|
|
|
|
|
|
|
|
cpu->env.pc = tb->pc;
|
|
|
|
cpu->env.flags = tb->flags;
|
|
|
|
}
|
|
|
|
|
2013-08-26 00:53:55 +08:00
|
|
|
static bool superh_cpu_has_work(CPUState *cs)
|
|
|
|
{
|
|
|
|
return cs->interrupt_request & CPU_INTERRUPT_HARD;
|
|
|
|
}
|
|
|
|
|
2012-02-12 00:26:17 +08:00
|
|
|
/* CPUClass::reset() */
|
|
|
|
static void superh_cpu_reset(CPUState *s)
|
|
|
|
{
|
|
|
|
SuperHCPU *cpu = SUPERH_CPU(s);
|
|
|
|
SuperHCPUClass *scc = SUPERH_CPU_GET_CLASS(cpu);
|
|
|
|
CPUSH4State *env = &cpu->env;
|
|
|
|
|
|
|
|
scc->parent_reset(s);
|
|
|
|
|
2013-08-27 03:22:53 +08:00
|
|
|
memset(env, 0, offsetof(CPUSH4State, id));
|
2013-09-04 08:19:44 +08:00
|
|
|
tlb_flush(s, 1);
|
2012-04-13 08:16:02 +08:00
|
|
|
|
|
|
|
env->pc = 0xA0000000;
|
|
|
|
#if defined(CONFIG_USER_ONLY)
|
|
|
|
env->fpscr = FPSCR_PR; /* value for userspace according to the kernel */
|
|
|
|
set_float_rounding_mode(float_round_nearest_even, &env->fp_status); /* ?! */
|
|
|
|
#else
|
2015-05-25 07:28:56 +08:00
|
|
|
env->sr = (1u << SR_MD) | (1u << SR_RB) | (1u << SR_BL) |
|
|
|
|
(1u << SR_I3) | (1u << SR_I2) | (1u << SR_I1) | (1u << SR_I0);
|
2012-04-13 08:16:02 +08:00
|
|
|
env->fpscr = FPSCR_DN | FPSCR_RM_ZERO; /* CPU reset value according to SH4 manual */
|
|
|
|
set_float_rounding_mode(float_round_to_zero, &env->fp_status);
|
|
|
|
set_flush_to_zero(1, &env->fp_status);
|
|
|
|
#endif
|
|
|
|
set_default_nan_mode(1, &env->fp_status);
|
2012-02-12 00:26:17 +08:00
|
|
|
}
|
|
|
|
|
2015-07-12 10:00:03 +08:00
|
|
|
static void superh_cpu_disas_set_info(CPUState *cpu, disassemble_info *info)
|
|
|
|
{
|
|
|
|
info->mach = bfd_mach_sh4;
|
|
|
|
info->print_insn = print_insn_sh;
|
|
|
|
}
|
|
|
|
|
2012-11-19 09:42:18 +08:00
|
|
|
typedef struct SuperHCPUListState {
|
|
|
|
fprintf_function cpu_fprintf;
|
|
|
|
FILE *file;
|
|
|
|
} SuperHCPUListState;
|
|
|
|
|
|
|
|
/* Sort alphabetically by type name. */
|
|
|
|
static gint superh_cpu_list_compare(gconstpointer a, gconstpointer b)
|
|
|
|
{
|
|
|
|
ObjectClass *class_a = (ObjectClass *)a;
|
|
|
|
ObjectClass *class_b = (ObjectClass *)b;
|
|
|
|
const char *name_a, *name_b;
|
|
|
|
|
|
|
|
name_a = object_class_get_name(class_a);
|
|
|
|
name_b = object_class_get_name(class_b);
|
|
|
|
return strcmp(name_a, name_b);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void superh_cpu_list_entry(gpointer data, gpointer user_data)
|
|
|
|
{
|
|
|
|
ObjectClass *oc = data;
|
|
|
|
SuperHCPUClass *scc = SUPERH_CPU_CLASS(oc);
|
|
|
|
SuperHCPUListState *s = user_data;
|
|
|
|
|
|
|
|
(*s->cpu_fprintf)(s->file, "%s\n",
|
|
|
|
scc->name);
|
|
|
|
}
|
|
|
|
|
|
|
|
void sh4_cpu_list(FILE *f, fprintf_function cpu_fprintf)
|
|
|
|
{
|
|
|
|
SuperHCPUListState s = {
|
|
|
|
.cpu_fprintf = cpu_fprintf,
|
|
|
|
.file = f,
|
|
|
|
};
|
|
|
|
GSList *list;
|
|
|
|
|
|
|
|
list = object_class_get_list(TYPE_SUPERH_CPU, false);
|
|
|
|
list = g_slist_sort(list, superh_cpu_list_compare);
|
|
|
|
g_slist_foreach(list, superh_cpu_list_entry, &s);
|
|
|
|
g_slist_free(list);
|
|
|
|
}
|
|
|
|
|
|
|
|
static gint superh_cpu_name_compare(gconstpointer a, gconstpointer b)
|
|
|
|
{
|
|
|
|
const SuperHCPUClass *scc = SUPERH_CPU_CLASS(a);
|
|
|
|
const char *name = b;
|
|
|
|
|
|
|
|
return strcasecmp(scc->name, name);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ObjectClass *superh_cpu_class_by_name(const char *cpu_model)
|
|
|
|
{
|
|
|
|
ObjectClass *oc;
|
|
|
|
GSList *list, *item;
|
|
|
|
|
|
|
|
if (cpu_model == NULL) {
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
if (strcasecmp(cpu_model, "any") == 0) {
|
|
|
|
return object_class_by_name(TYPE_SH7750R_CPU);
|
|
|
|
}
|
|
|
|
|
|
|
|
oc = object_class_by_name(cpu_model);
|
|
|
|
if (oc != NULL && object_class_dynamic_cast(oc, TYPE_SUPERH_CPU) != NULL
|
|
|
|
&& !object_class_is_abstract(oc)) {
|
|
|
|
return oc;
|
|
|
|
}
|
|
|
|
|
|
|
|
oc = NULL;
|
|
|
|
list = object_class_get_list(TYPE_SUPERH_CPU, false);
|
|
|
|
item = g_slist_find_custom(list, cpu_model, superh_cpu_name_compare);
|
|
|
|
if (item != NULL) {
|
|
|
|
oc = item->data;
|
|
|
|
}
|
|
|
|
g_slist_free(list);
|
|
|
|
return oc;
|
|
|
|
}
|
|
|
|
|
|
|
|
SuperHCPU *cpu_sh4_init(const char *cpu_model)
|
|
|
|
{
|
2014-03-04 10:17:10 +08:00
|
|
|
return SUPERH_CPU(cpu_generic_init(TYPE_SUPERH_CPU, cpu_model));
|
2012-11-19 09:42:18 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void sh7750r_cpu_initfn(Object *obj)
|
|
|
|
{
|
|
|
|
SuperHCPU *cpu = SUPERH_CPU(obj);
|
|
|
|
CPUSH4State *env = &cpu->env;
|
|
|
|
|
|
|
|
env->id = SH_CPU_SH7750R;
|
|
|
|
env->features = SH_FEATURE_BCR3_AND_BCR4;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void sh7750r_class_init(ObjectClass *oc, void *data)
|
|
|
|
{
|
|
|
|
SuperHCPUClass *scc = SUPERH_CPU_CLASS(oc);
|
|
|
|
|
|
|
|
scc->name = "SH7750R";
|
2012-11-20 23:15:47 +08:00
|
|
|
scc->pvr = 0x00050000;
|
|
|
|
scc->prr = 0x00000100;
|
|
|
|
scc->cvr = 0x00110000;
|
2012-11-19 09:42:18 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static const TypeInfo sh7750r_type_info = {
|
|
|
|
.name = TYPE_SH7750R_CPU,
|
|
|
|
.parent = TYPE_SUPERH_CPU,
|
|
|
|
.class_init = sh7750r_class_init,
|
|
|
|
.instance_init = sh7750r_cpu_initfn,
|
|
|
|
};
|
|
|
|
|
|
|
|
static void sh7751r_cpu_initfn(Object *obj)
|
|
|
|
{
|
|
|
|
SuperHCPU *cpu = SUPERH_CPU(obj);
|
|
|
|
CPUSH4State *env = &cpu->env;
|
|
|
|
|
|
|
|
env->id = SH_CPU_SH7751R;
|
|
|
|
env->features = SH_FEATURE_BCR3_AND_BCR4;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void sh7751r_class_init(ObjectClass *oc, void *data)
|
|
|
|
{
|
|
|
|
SuperHCPUClass *scc = SUPERH_CPU_CLASS(oc);
|
|
|
|
|
|
|
|
scc->name = "SH7751R";
|
2012-11-20 23:15:47 +08:00
|
|
|
scc->pvr = 0x04050005;
|
|
|
|
scc->prr = 0x00000113;
|
|
|
|
scc->cvr = 0x00110000; /* Neutered caches, should be 0x20480000 */
|
2012-11-19 09:42:18 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static const TypeInfo sh7751r_type_info = {
|
|
|
|
.name = TYPE_SH7751R_CPU,
|
|
|
|
.parent = TYPE_SUPERH_CPU,
|
|
|
|
.class_init = sh7751r_class_init,
|
|
|
|
.instance_init = sh7751r_cpu_initfn,
|
|
|
|
};
|
|
|
|
|
|
|
|
static void sh7785_cpu_initfn(Object *obj)
|
|
|
|
{
|
|
|
|
SuperHCPU *cpu = SUPERH_CPU(obj);
|
|
|
|
CPUSH4State *env = &cpu->env;
|
|
|
|
|
|
|
|
env->id = SH_CPU_SH7785;
|
|
|
|
env->features = SH_FEATURE_SH4A;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void sh7785_class_init(ObjectClass *oc, void *data)
|
|
|
|
{
|
|
|
|
SuperHCPUClass *scc = SUPERH_CPU_CLASS(oc);
|
|
|
|
|
|
|
|
scc->name = "SH7785";
|
2012-11-20 23:15:47 +08:00
|
|
|
scc->pvr = 0x10300700;
|
|
|
|
scc->prr = 0x00000200;
|
|
|
|
scc->cvr = 0x71440211;
|
2012-11-19 09:42:18 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static const TypeInfo sh7785_type_info = {
|
|
|
|
.name = TYPE_SH7785_CPU,
|
|
|
|
.parent = TYPE_SUPERH_CPU,
|
|
|
|
.class_init = sh7785_class_init,
|
|
|
|
.instance_init = sh7785_cpu_initfn,
|
|
|
|
};
|
|
|
|
|
2012-04-24 00:16:02 +08:00
|
|
|
static void superh_cpu_realizefn(DeviceState *dev, Error **errp)
|
|
|
|
{
|
2013-07-27 08:53:25 +08:00
|
|
|
CPUState *cs = CPU(dev);
|
2012-04-24 00:16:02 +08:00
|
|
|
SuperHCPUClass *scc = SUPERH_CPU_GET_CLASS(dev);
|
|
|
|
|
2013-07-27 08:53:25 +08:00
|
|
|
cpu_reset(cs);
|
|
|
|
qemu_init_vcpu(cs);
|
2012-04-24 00:16:02 +08:00
|
|
|
|
|
|
|
scc->parent_realize(dev, errp);
|
|
|
|
}
|
|
|
|
|
2012-04-13 08:32:12 +08:00
|
|
|
static void superh_cpu_initfn(Object *obj)
|
|
|
|
{
|
2013-01-17 19:13:41 +08:00
|
|
|
CPUState *cs = CPU(obj);
|
2012-04-13 08:32:12 +08:00
|
|
|
SuperHCPU *cpu = SUPERH_CPU(obj);
|
|
|
|
CPUSH4State *env = &cpu->env;
|
|
|
|
|
2013-01-17 19:13:41 +08:00
|
|
|
cs->env_ptr = env;
|
2015-06-24 10:31:18 +08:00
|
|
|
cpu_exec_init(cs, &error_abort);
|
2012-04-13 08:32:12 +08:00
|
|
|
|
|
|
|
env->movcal_backup_tail = &(env->movcal_backup);
|
2013-01-20 08:30:32 +08:00
|
|
|
|
|
|
|
if (tcg_enabled()) {
|
|
|
|
sh4_translate_init();
|
|
|
|
}
|
2012-04-13 08:32:12 +08:00
|
|
|
}
|
|
|
|
|
2013-01-21 02:32:33 +08:00
|
|
|
static const VMStateDescription vmstate_sh_cpu = {
|
|
|
|
.name = "cpu",
|
|
|
|
.unmigratable = 1,
|
|
|
|
};
|
|
|
|
|
2012-02-12 00:26:17 +08:00
|
|
|
static void superh_cpu_class_init(ObjectClass *oc, void *data)
|
|
|
|
{
|
2013-01-21 02:32:33 +08:00
|
|
|
DeviceClass *dc = DEVICE_CLASS(oc);
|
2012-02-12 00:26:17 +08:00
|
|
|
CPUClass *cc = CPU_CLASS(oc);
|
|
|
|
SuperHCPUClass *scc = SUPERH_CPU_CLASS(oc);
|
|
|
|
|
2012-04-24 00:16:02 +08:00
|
|
|
scc->parent_realize = dc->realize;
|
|
|
|
dc->realize = superh_cpu_realizefn;
|
|
|
|
|
2012-02-12 00:26:17 +08:00
|
|
|
scc->parent_reset = cc->reset;
|
|
|
|
cc->reset = superh_cpu_reset;
|
2013-01-21 02:32:33 +08:00
|
|
|
|
2012-11-19 09:42:18 +08:00
|
|
|
cc->class_by_name = superh_cpu_class_by_name;
|
2013-08-26 00:53:55 +08:00
|
|
|
cc->has_work = superh_cpu_has_work;
|
2013-02-02 17:57:51 +08:00
|
|
|
cc->do_interrupt = superh_cpu_do_interrupt;
|
2014-09-14 00:45:23 +08:00
|
|
|
cc->cpu_exec_interrupt = superh_cpu_exec_interrupt;
|
2013-05-27 07:33:50 +08:00
|
|
|
cc->dump_state = superh_cpu_dump_state;
|
2013-06-22 01:09:18 +08:00
|
|
|
cc->set_pc = superh_cpu_set_pc;
|
2013-06-29 01:31:32 +08:00
|
|
|
cc->synchronize_from_tb = superh_cpu_synchronize_from_tb;
|
2013-06-29 10:18:45 +08:00
|
|
|
cc->gdb_read_register = superh_cpu_gdb_read_register;
|
|
|
|
cc->gdb_write_register = superh_cpu_gdb_write_register;
|
2013-08-26 09:01:33 +08:00
|
|
|
#ifdef CONFIG_USER_ONLY
|
|
|
|
cc->handle_mmu_fault = superh_cpu_handle_mmu_fault;
|
|
|
|
#else
|
2013-06-30 00:55:54 +08:00
|
|
|
cc->get_phys_page_debug = superh_cpu_get_phys_page_debug;
|
|
|
|
#endif
|
2015-07-12 10:00:03 +08:00
|
|
|
cc->disas_set_info = superh_cpu_disas_set_info;
|
|
|
|
|
2013-06-29 05:18:47 +08:00
|
|
|
cc->gdb_num_core_regs = 59;
|
qdev: Protect device-list-properties against broken devices
Several devices don't survive object_unref(object_new(T)): they crash
or hang during cleanup, or they leave dangling pointers behind.
This breaks at least device-list-properties, because
qmp_device_list_properties() needs to create a device to find its
properties. Broken in commit f4eb32b "qmp: show QOM properties in
device-list-properties", v2.1. Example reproducer:
$ qemu-system-aarch64 -nodefaults -display none -machine none -S -qmp stdio
{"QMP": {"version": {"qemu": {"micro": 50, "minor": 4, "major": 2}, "package": ""}, "capabilities": []}}
{ "execute": "qmp_capabilities" }
{"return": {}}
{ "execute": "device-list-properties", "arguments": { "typename": "pxa2xx-pcmcia" } }
qemu-system-aarch64: /home/armbru/work/qemu/memory.c:1307: memory_region_finalize: Assertion `((&mr->subregions)->tqh_first == ((void *)0))' failed.
Aborted (core dumped)
[Exit 134 (SIGABRT)]
Unfortunately, I can't fix the problems in these devices right now.
Instead, add DeviceClass member cannot_destroy_with_object_finalize_yet
to mark them:
* Hang during cleanup (didn't debug, so I can't say why):
"realview_pci", "versatile_pci".
* Dangling pointer in cpus: most CPUs, plus "allwinner-a10", "digic",
"fsl,imx25", "fsl,imx31", "xlnx,zynqmp", because they create such
CPUs
* Assert kvm_enabled(): "host-x86_64-cpu", host-i386-cpu",
"host-powerpc64-cpu", "host-embedded-powerpc-cpu",
"host-powerpc-cpu" (the powerpc ones can't currently reach the
assertion, because the CPUs are only registered when KVM is enabled,
but the assertion is arguably in the wrong place all the same)
Make qmp_device_list_properties() fail cleanly when the device is so
marked. This improves device-list-properties from "crashes, hangs or
leaves dangling pointers behind" to "fails". Not a complete fix, just
a better-than-nothing work-around. In the above reproducer,
device-list-properties now fails with "Can't list properties of device
'pxa2xx-pcmcia'".
This also protects -device FOO,help, which uses the same machinery
since commit ef52358 "qdev-monitor: include QOM properties in -device
FOO, help output", v2.2. Example reproducer:
$ qemu-system-aarch64 -machine none -device pxa2xx-pcmcia,help
Before:
qemu-system-aarch64: .../memory.c:1307: memory_region_finalize: Assertion `((&mr->subregions)->tqh_first == ((void *)0))' failed.
After:
Can't list properties of device 'pxa2xx-pcmcia'
Cc: "Andreas Färber" <afaerber@suse.de>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: Alexander Graf <agraf@suse.de>
Cc: Anthony Green <green@moxielogic.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>
Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Cc: Blue Swirl <blauwirbel@gmail.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
Cc: Jia Liu <proljc@gmail.com>
Cc: Leon Alrae <leon.alrae@imgtec.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Cc: Michael Walle <michael@walle.cc>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Richard Henderson <rth@twiddle.net>
Cc: qemu-ppc@nongnu.org
Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <1443689999-12182-10-git-send-email-armbru@redhat.com>
2015-10-01 16:59:58 +08:00
|
|
|
|
2015-07-12 10:00:03 +08:00
|
|
|
dc->vmsd = &vmstate_sh_cpu;
|
|
|
|
|
qdev: Protect device-list-properties against broken devices
Several devices don't survive object_unref(object_new(T)): they crash
or hang during cleanup, or they leave dangling pointers behind.
This breaks at least device-list-properties, because
qmp_device_list_properties() needs to create a device to find its
properties. Broken in commit f4eb32b "qmp: show QOM properties in
device-list-properties", v2.1. Example reproducer:
$ qemu-system-aarch64 -nodefaults -display none -machine none -S -qmp stdio
{"QMP": {"version": {"qemu": {"micro": 50, "minor": 4, "major": 2}, "package": ""}, "capabilities": []}}
{ "execute": "qmp_capabilities" }
{"return": {}}
{ "execute": "device-list-properties", "arguments": { "typename": "pxa2xx-pcmcia" } }
qemu-system-aarch64: /home/armbru/work/qemu/memory.c:1307: memory_region_finalize: Assertion `((&mr->subregions)->tqh_first == ((void *)0))' failed.
Aborted (core dumped)
[Exit 134 (SIGABRT)]
Unfortunately, I can't fix the problems in these devices right now.
Instead, add DeviceClass member cannot_destroy_with_object_finalize_yet
to mark them:
* Hang during cleanup (didn't debug, so I can't say why):
"realview_pci", "versatile_pci".
* Dangling pointer in cpus: most CPUs, plus "allwinner-a10", "digic",
"fsl,imx25", "fsl,imx31", "xlnx,zynqmp", because they create such
CPUs
* Assert kvm_enabled(): "host-x86_64-cpu", host-i386-cpu",
"host-powerpc64-cpu", "host-embedded-powerpc-cpu",
"host-powerpc-cpu" (the powerpc ones can't currently reach the
assertion, because the CPUs are only registered when KVM is enabled,
but the assertion is arguably in the wrong place all the same)
Make qmp_device_list_properties() fail cleanly when the device is so
marked. This improves device-list-properties from "crashes, hangs or
leaves dangling pointers behind" to "fails". Not a complete fix, just
a better-than-nothing work-around. In the above reproducer,
device-list-properties now fails with "Can't list properties of device
'pxa2xx-pcmcia'".
This also protects -device FOO,help, which uses the same machinery
since commit ef52358 "qdev-monitor: include QOM properties in -device
FOO, help output", v2.2. Example reproducer:
$ qemu-system-aarch64 -machine none -device pxa2xx-pcmcia,help
Before:
qemu-system-aarch64: .../memory.c:1307: memory_region_finalize: Assertion `((&mr->subregions)->tqh_first == ((void *)0))' failed.
After:
Can't list properties of device 'pxa2xx-pcmcia'
Cc: "Andreas Färber" <afaerber@suse.de>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: Alexander Graf <agraf@suse.de>
Cc: Anthony Green <green@moxielogic.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>
Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Cc: Blue Swirl <blauwirbel@gmail.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
Cc: Jia Liu <proljc@gmail.com>
Cc: Leon Alrae <leon.alrae@imgtec.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Cc: Michael Walle <michael@walle.cc>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Richard Henderson <rth@twiddle.net>
Cc: qemu-ppc@nongnu.org
Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <1443689999-12182-10-git-send-email-armbru@redhat.com>
2015-10-01 16:59:58 +08:00
|
|
|
/*
|
|
|
|
* Reason: superh_cpu_initfn() calls cpu_exec_init(), which saves
|
|
|
|
* the object in cpus -> dangling pointer after final
|
|
|
|
* object_unref().
|
|
|
|
*/
|
|
|
|
dc->cannot_destroy_with_object_finalize_yet = true;
|
2012-02-12 00:26:17 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static const TypeInfo superh_cpu_type_info = {
|
|
|
|
.name = TYPE_SUPERH_CPU,
|
|
|
|
.parent = TYPE_CPU,
|
|
|
|
.instance_size = sizeof(SuperHCPU),
|
2012-04-13 08:32:12 +08:00
|
|
|
.instance_init = superh_cpu_initfn,
|
2012-11-19 09:42:18 +08:00
|
|
|
.abstract = true,
|
2012-02-12 00:26:17 +08:00
|
|
|
.class_size = sizeof(SuperHCPUClass),
|
|
|
|
.class_init = superh_cpu_class_init,
|
|
|
|
};
|
|
|
|
|
|
|
|
static void superh_cpu_register_types(void)
|
|
|
|
{
|
|
|
|
type_register_static(&superh_cpu_type_info);
|
2012-11-19 09:42:18 +08:00
|
|
|
type_register_static(&sh7750r_type_info);
|
|
|
|
type_register_static(&sh7751r_type_info);
|
|
|
|
type_register_static(&sh7785_type_info);
|
2012-02-12 00:26:17 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
type_init(superh_cpu_register_types)
|