2018-02-01 21:27:54 +08:00
|
|
|
/*
|
|
|
|
|
* QEMU host memfd memory backend
|
|
|
|
|
*
|
|
|
|
|
* Copyright (C) 2018 Red Hat Inc
|
|
|
|
|
*
|
|
|
|
|
* Authors:
|
|
|
|
|
* Marc-André Lureau <marcandre.lureau@redhat.com>
|
|
|
|
|
*
|
|
|
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
|
|
|
* See the COPYING file in the top-level directory.
|
|
|
|
|
*/
|
2019-05-23 22:35:07 +08:00
|
|
|
|
2018-02-01 21:27:54 +08:00
|
|
|
#include "qemu/osdep.h"
|
|
|
|
|
#include "sysemu/hostmem.h"
|
|
|
|
|
#include "sysemu/sysemu.h"
|
|
|
|
|
#include "qom/object_interfaces.h"
|
|
|
|
|
#include "qemu/memfd.h"
|
2019-05-23 22:35:07 +08:00
|
|
|
#include "qemu/module.h"
|
2018-02-01 21:27:54 +08:00
|
|
|
#include "qapi/error.h"
|
2020-09-04 04:43:22 +08:00
|
|
|
#include "qom/object.h"
|
2018-02-01 21:27:54 +08:00
|
|
|
|
|
|
|
|
#define TYPE_MEMORY_BACKEND_MEMFD "memory-backend-memfd"
|
|
|
|
|
|
2020-09-04 04:43:22 +08:00
|
|
|
typedef struct HostMemoryBackendMemfd HostMemoryBackendMemfd;
|
2020-09-01 05:07:33 +08:00
|
|
|
DECLARE_INSTANCE_CHECKER(HostMemoryBackendMemfd, MEMORY_BACKEND_MEMFD,
|
|
|
|
|
TYPE_MEMORY_BACKEND_MEMFD)
|
2018-02-01 21:27:54 +08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
struct HostMemoryBackendMemfd {
|
|
|
|
|
HostMemoryBackend parent_obj;
|
|
|
|
|
|
|
|
|
|
bool hugetlb;
|
|
|
|
|
uint64_t hugetlbsize;
|
|
|
|
|
bool seal;
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
memfd_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
|
|
|
|
|
{
|
|
|
|
|
HostMemoryBackendMemfd *m = MEMORY_BACKEND_MEMFD(backend);
|
|
|
|
|
char *name;
|
|
|
|
|
int fd;
|
|
|
|
|
|
|
|
|
|
if (!backend->size) {
|
|
|
|
|
error_setg(errp, "can't create backend with size 0");
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fd = qemu_memfd_create(TYPE_MEMORY_BACKEND_MEMFD, backend->size,
|
|
|
|
|
m->hugetlb, m->hugetlbsize, m->seal ?
|
|
|
|
|
F_SEAL_GROW | F_SEAL_SHRINK | F_SEAL_SEAL : 0,
|
|
|
|
|
errp);
|
|
|
|
|
if (fd == -1) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
hostmem: use object id for memory region name with >= 4.0
hostmem-file and hostmem-memfd use the whole object path for the
memory region name, and hostname-ram uses only the path component (the
object id, or canonical path basename):
qemu -m 1024 -object memory-backend-file,id=mem,size=1G,mem-path=/tmp/foo -numa node,memdev=mem -monitor stdio
(qemu) info ramblock
Block Name PSize Offset Used Total
/objects/mem 4 KiB 0x0000000000000000 0x0000000040000000 0x0000000040000000
qemu -m 1024 -object memory-backend-memfd,id=mem,size=1G -numa node,memdev=mem -monitor stdio
(qemu) info ramblock
Block Name PSize Offset Used Total
/objects/mem 4 KiB 0x0000000000000000 0x0000000040000000 0x0000000040000000
qemu -m 1024 -object memory-backend-ram,id=mem,size=1G -numa node,memdev=mem -monitor stdio
(qemu) info ramblock
Block Name PSize Offset Used Total
mem 4 KiB 0x0000000000000000 0x0000000040000000 0x0000000040000000
For consistency, change to use object id for -file and -memfd as well
with >= 4.0.
Having a consistent naming allows to migrate to different hostmem
backends.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
2018-09-12 20:18:00 +08:00
|
|
|
name = host_memory_backend_get_name(backend);
|
2018-02-01 21:27:54 +08:00
|
|
|
memory_region_init_ram_from_fd(&backend->mr, OBJECT(backend),
|
2018-08-28 23:38:40 +08:00
|
|
|
name, backend->size,
|
|
|
|
|
backend->share, fd, errp);
|
2018-02-01 21:27:54 +08:00
|
|
|
g_free(name);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static bool
|
|
|
|
|
memfd_backend_get_hugetlb(Object *o, Error **errp)
|
|
|
|
|
{
|
|
|
|
|
return MEMORY_BACKEND_MEMFD(o)->hugetlb;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
memfd_backend_set_hugetlb(Object *o, bool value, Error **errp)
|
|
|
|
|
{
|
|
|
|
|
MEMORY_BACKEND_MEMFD(o)->hugetlb = value;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
memfd_backend_set_hugetlbsize(Object *obj, Visitor *v, const char *name,
|
|
|
|
|
void *opaque, Error **errp)
|
|
|
|
|
{
|
|
|
|
|
HostMemoryBackendMemfd *m = MEMORY_BACKEND_MEMFD(obj);
|
|
|
|
|
uint64_t value;
|
|
|
|
|
|
|
|
|
|
if (host_memory_backend_mr_inited(MEMORY_BACKEND(obj))) {
|
error: Avoid unnecessary error_propagate() after error_setg()
Replace
error_setg(&err, ...);
error_propagate(errp, err);
by
error_setg(errp, ...);
Related pattern:
if (...) {
error_setg(&err, ...);
goto out;
}
...
out:
error_propagate(errp, err);
return;
When all paths to label out are that way, replace by
if (...) {
error_setg(errp, ...);
return;
}
and delete the label along with the error_propagate().
When we have at most one other path that actually needs to propagate,
and maybe one at the end that where propagation is unnecessary, e.g.
foo(..., &err);
if (err) {
goto out;
}
...
bar(..., &err);
out:
error_propagate(errp, err);
return;
move the error_propagate() to where it's needed, like
if (...) {
foo(..., &err);
error_propagate(errp, err);
return;
}
...
bar(..., errp);
return;
and transform the error_setg() as above.
In some places, the transformation results in obviously unnecessary
error_propagate(). The next few commits will eliminate them.
Bonus: the elimination of gotos will make later patches in this series
easier to review.
Candidates for conversion tracked down with this Coccinelle script:
@@
identifier err, errp;
expression list args;
@@
- error_setg(&err, args);
+ error_setg(errp, args);
... when != err
error_propagate(errp, err);
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-34-armbru@redhat.com>
2020-07-08 00:06:01 +08:00
|
|
|
error_setg(errp, "cannot change property value");
|
|
|
|
|
return;
|
2018-02-01 21:27:54 +08:00
|
|
|
}
|
|
|
|
|
|
error: Eliminate error_propagate() with Coccinelle, part 1
When all we do with an Error we receive into a local variable is
propagating to somewhere else, we can just as well receive it there
right away. Convert
if (!foo(..., &err)) {
...
error_propagate(errp, err);
...
return ...
}
to
if (!foo(..., errp)) {
...
...
return ...
}
where nothing else needs @err. Coccinelle script:
@rule1 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
binary operator op;
constant c1, c2;
symbol false;
@@
if (
(
- fun(args, &err, args2)
+ fun(args, errp, args2)
|
- !fun(args, &err, args2)
+ !fun(args, errp, args2)
|
- fun(args, &err, args2) op c1
+ fun(args, errp, args2) op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
)
}
@rule2 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
expression var;
binary operator op;
constant c1, c2;
symbol false;
@@
- var = fun(args, &err, args2);
+ var = fun(args, errp, args2);
... when != err
if (
(
var
|
!var
|
var op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
|
return var;
)
}
@depends on rule1 || rule2@
identifier err;
@@
- Error *err = NULL;
... when != err
Not exactly elegant, I'm afraid.
The "when != lbl:" is necessary to avoid transforming
if (fun(args, &err)) {
goto out
}
...
out:
error_propagate(errp, err);
even though other paths to label out still need the error_propagate().
For an actual example, see sclp_realize().
Without the "when strict", Coccinelle transforms vfio_msix_setup(),
incorrectly. I don't know what exactly "when strict" does, only that
it helps here.
The match of return is narrower than what I want, but I can't figure
out how to express "return where the operand doesn't use @err". For
an example where it's too narrow, see vfio_intx_enable().
Silently fails to convert hw/arm/armsse.c, because Coccinelle gets
confused by ARMSSE being used both as typedef and function-like macro
there. Converted manually.
Line breaks tidied up manually. One nested declaration of @local_err
deleted manually. Preexisting unwanted blank line dropped in
hw/riscv/sifive_e.c.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-35-armbru@redhat.com>
2020-07-08 00:06:02 +08:00
|
|
|
if (!visit_type_size(v, name, &value, errp)) {
|
error: Avoid unnecessary error_propagate() after error_setg()
Replace
error_setg(&err, ...);
error_propagate(errp, err);
by
error_setg(errp, ...);
Related pattern:
if (...) {
error_setg(&err, ...);
goto out;
}
...
out:
error_propagate(errp, err);
return;
When all paths to label out are that way, replace by
if (...) {
error_setg(errp, ...);
return;
}
and delete the label along with the error_propagate().
When we have at most one other path that actually needs to propagate,
and maybe one at the end that where propagation is unnecessary, e.g.
foo(..., &err);
if (err) {
goto out;
}
...
bar(..., &err);
out:
error_propagate(errp, err);
return;
move the error_propagate() to where it's needed, like
if (...) {
foo(..., &err);
error_propagate(errp, err);
return;
}
...
bar(..., errp);
return;
and transform the error_setg() as above.
In some places, the transformation results in obviously unnecessary
error_propagate(). The next few commits will eliminate them.
Bonus: the elimination of gotos will make later patches in this series
easier to review.
Candidates for conversion tracked down with this Coccinelle script:
@@
identifier err, errp;
expression list args;
@@
- error_setg(&err, args);
+ error_setg(errp, args);
... when != err
error_propagate(errp, err);
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-34-armbru@redhat.com>
2020-07-08 00:06:01 +08:00
|
|
|
return;
|
2018-02-01 21:27:54 +08:00
|
|
|
}
|
|
|
|
|
if (!value) {
|
error: Avoid unnecessary error_propagate() after error_setg()
Replace
error_setg(&err, ...);
error_propagate(errp, err);
by
error_setg(errp, ...);
Related pattern:
if (...) {
error_setg(&err, ...);
goto out;
}
...
out:
error_propagate(errp, err);
return;
When all paths to label out are that way, replace by
if (...) {
error_setg(errp, ...);
return;
}
and delete the label along with the error_propagate().
When we have at most one other path that actually needs to propagate,
and maybe one at the end that where propagation is unnecessary, e.g.
foo(..., &err);
if (err) {
goto out;
}
...
bar(..., &err);
out:
error_propagate(errp, err);
return;
move the error_propagate() to where it's needed, like
if (...) {
foo(..., &err);
error_propagate(errp, err);
return;
}
...
bar(..., errp);
return;
and transform the error_setg() as above.
In some places, the transformation results in obviously unnecessary
error_propagate(). The next few commits will eliminate them.
Bonus: the elimination of gotos will make later patches in this series
easier to review.
Candidates for conversion tracked down with this Coccinelle script:
@@
identifier err, errp;
expression list args;
@@
- error_setg(&err, args);
+ error_setg(errp, args);
... when != err
error_propagate(errp, err);
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-34-armbru@redhat.com>
2020-07-08 00:06:01 +08:00
|
|
|
error_setg(errp, "Property '%s.%s' doesn't take value '%" PRIu64 "'",
|
|
|
|
|
object_get_typename(obj), name, value);
|
|
|
|
|
return;
|
2018-02-01 21:27:54 +08:00
|
|
|
}
|
|
|
|
|
m->hugetlbsize = value;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
memfd_backend_get_hugetlbsize(Object *obj, Visitor *v, const char *name,
|
|
|
|
|
void *opaque, Error **errp)
|
|
|
|
|
{
|
|
|
|
|
HostMemoryBackendMemfd *m = MEMORY_BACKEND_MEMFD(obj);
|
|
|
|
|
uint64_t value = m->hugetlbsize;
|
|
|
|
|
|
|
|
|
|
visit_type_size(v, name, &value, errp);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static bool
|
|
|
|
|
memfd_backend_get_seal(Object *o, Error **errp)
|
|
|
|
|
{
|
|
|
|
|
return MEMORY_BACKEND_MEMFD(o)->seal;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
memfd_backend_set_seal(Object *o, bool value, Error **errp)
|
|
|
|
|
{
|
|
|
|
|
MEMORY_BACKEND_MEMFD(o)->seal = value;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
memfd_backend_instance_init(Object *obj)
|
|
|
|
|
{
|
|
|
|
|
HostMemoryBackendMemfd *m = MEMORY_BACKEND_MEMFD(obj);
|
|
|
|
|
|
|
|
|
|
/* default to sealed file */
|
|
|
|
|
m->seal = true;
|
2018-08-28 23:38:40 +08:00
|
|
|
MEMORY_BACKEND(m)->share = true;
|
2018-02-01 21:27:54 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
memfd_backend_class_init(ObjectClass *oc, void *data)
|
|
|
|
|
{
|
|
|
|
|
HostMemoryBackendClass *bc = MEMORY_BACKEND_CLASS(oc);
|
|
|
|
|
|
|
|
|
|
bc->alloc = memfd_backend_memory_alloc;
|
|
|
|
|
|
2018-09-07 00:14:15 +08:00
|
|
|
if (qemu_memfd_check(MFD_HUGETLB)) {
|
|
|
|
|
object_class_property_add_bool(oc, "hugetlb",
|
|
|
|
|
memfd_backend_get_hugetlb,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
memfd_backend_set_hugetlb);
|
2018-09-06 22:39:08 +08:00
|
|
|
object_class_property_set_description(oc, "hugetlb",
|
2020-05-05 23:29:15 +08:00
|
|
|
"Use huge pages");
|
2018-09-07 00:14:15 +08:00
|
|
|
object_class_property_add(oc, "hugetlbsize", "int",
|
|
|
|
|
memfd_backend_get_hugetlbsize,
|
|
|
|
|
memfd_backend_set_hugetlbsize,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
NULL, NULL);
|
2018-09-06 22:39:08 +08:00
|
|
|
object_class_property_set_description(oc, "hugetlbsize",
|
2020-05-05 23:29:15 +08:00
|
|
|
"Huge pages size (ex: 2M, 1G)");
|
2018-09-07 00:14:15 +08:00
|
|
|
}
|
2019-03-11 21:58:47 +08:00
|
|
|
object_class_property_add_bool(oc, "seal",
|
|
|
|
|
memfd_backend_get_seal,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 23:29:22 +08:00
|
|
|
memfd_backend_set_seal);
|
2019-03-11 21:58:47 +08:00
|
|
|
object_class_property_set_description(oc, "seal",
|
2020-05-05 23:29:15 +08:00
|
|
|
"Seal growing & shrinking");
|
2018-02-01 21:27:54 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static const TypeInfo memfd_backend_info = {
|
|
|
|
|
.name = TYPE_MEMORY_BACKEND_MEMFD,
|
|
|
|
|
.parent = TYPE_MEMORY_BACKEND,
|
|
|
|
|
.instance_init = memfd_backend_instance_init,
|
|
|
|
|
.class_init = memfd_backend_class_init,
|
|
|
|
|
.instance_size = sizeof(HostMemoryBackendMemfd),
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
static void register_types(void)
|
|
|
|
|
{
|
2019-03-11 21:58:47 +08:00
|
|
|
if (qemu_memfd_check(MFD_ALLOW_SEALING)) {
|
2018-09-07 00:14:15 +08:00
|
|
|
type_register_static(&memfd_backend_info);
|
|
|
|
|
}
|
2018-02-01 21:27:54 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
type_init(register_types);
|