2008-07-03 21:41:03 +08:00
|
|
|
/*
|
|
|
|
* QEMU Block driver for NBD
|
|
|
|
*
|
|
|
|
* Copyright (C) 2008 Bull S.A.S.
|
2008-07-09 02:57:05 +08:00
|
|
|
* Author: Laurent Vivier <Laurent.Vivier@bull.net>
|
2008-07-03 21:41:03 +08:00
|
|
|
*
|
|
|
|
* Some parts:
|
|
|
|
* Copyright (C) 2007 Anthony Liguori <anthony@codemonkey.ws>
|
|
|
|
*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
|
|
* in the Software without restriction, including without limitation the rights
|
|
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
|
|
* furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice shall be included in
|
|
|
|
* all copies or substantial portions of the Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
|
|
* THE SOFTWARE.
|
|
|
|
*/
|
|
|
|
|
2016-01-19 02:01:42 +08:00
|
|
|
#include "qemu/osdep.h"
|
2018-05-04 03:50:20 +08:00
|
|
|
#include "nbd-client.h"
|
2018-06-15 03:14:28 +08:00
|
|
|
#include "block/qdict.h"
|
include/qemu/osdep.h: Don't include qapi/error.h
Commit 57cb38b included qapi/error.h into qemu/osdep.h to get the
Error typedef. Since then, we've moved to include qemu/osdep.h
everywhere. Its file comment explains: "To avoid getting into
possible circular include dependencies, this file should not include
any other QEMU headers, with the exceptions of config-host.h,
compiler.h, os-posix.h and os-win32.h, all of which are doing a
similar job to this file and are under similar constraints."
qapi/error.h doesn't do a similar job, and it doesn't adhere to
similar constraints: it includes qapi-types.h. That's in excess of
100KiB of crap most .c files don't actually need.
Add the typedef to qemu/typedefs.h, and include that instead of
qapi/error.h. Include qapi/error.h in .c files that need it and don't
get it now. Include qapi-types.h in qom/object.h for uint16List.
Update scripts/clean-includes accordingly. Update it further to match
reality: replace config.h by config-target.h, add sysemu/os-posix.h,
sysemu/os-win32.h. Update the list of includes in the qemu/osdep.h
comment quoted above similarly.
This reduces the number of objects depending on qapi/error.h from "all
of them" to less than a third. Unfortunately, the number depending on
qapi-types.h shrinks only a little. More work is needed for that one.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
[Fix compilation without the spice devel packages. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2016-03-14 16:01:28 +08:00
|
|
|
#include "qapi/error.h"
|
2012-12-18 01:20:00 +08:00
|
|
|
#include "qemu/uri.h"
|
2012-12-18 01:19:44 +08:00
|
|
|
#include "block/block_int.h"
|
2012-12-18 01:20:00 +08:00
|
|
|
#include "qemu/module.h"
|
2018-02-01 19:18:46 +08:00
|
|
|
#include "qemu/option.h"
|
2018-02-11 17:36:01 +08:00
|
|
|
#include "qapi/qapi-visit-sockets.h"
|
2016-10-25 21:11:34 +08:00
|
|
|
#include "qapi/qobject-input-visitor.h"
|
|
|
|
#include "qapi/qobject-output-visitor.h"
|
2014-07-19 02:24:59 +08:00
|
|
|
#include "qapi/qmp/qdict.h"
|
|
|
|
#include "qapi/qmp/qstring.h"
|
2016-03-21 01:16:19 +08:00
|
|
|
#include "qemu/cutils.h"
|
2008-07-03 21:41:03 +08:00
|
|
|
|
2010-08-26 04:48:33 +08:00
|
|
|
#define EN_OPTSTR ":exportname="
|
|
|
|
|
2008-07-03 21:41:03 +08:00
|
|
|
typedef struct BDRVNBDState {
|
2016-10-15 02:33:06 +08:00
|
|
|
NBDClientSession client;
|
2016-08-15 21:29:26 +08:00
|
|
|
|
|
|
|
/* For nbd_refresh_filename() */
|
2017-04-26 15:36:40 +08:00
|
|
|
SocketAddress *saddr;
|
2016-10-25 21:11:34 +08:00
|
|
|
char *export, *tlscredsid;
|
2008-07-03 21:41:03 +08:00
|
|
|
} BDRVNBDState;
|
|
|
|
|
2013-03-07 23:15:11 +08:00
|
|
|
static int nbd_parse_uri(const char *filename, QDict *options)
|
2012-11-04 20:04:24 +08:00
|
|
|
{
|
|
|
|
URI *uri;
|
|
|
|
const char *p;
|
|
|
|
QueryParams *qp = NULL;
|
|
|
|
int ret = 0;
|
2013-03-07 23:15:11 +08:00
|
|
|
bool is_unix;
|
2012-11-04 20:04:24 +08:00
|
|
|
|
|
|
|
uri = uri_parse(filename);
|
|
|
|
if (!uri) {
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* transport */
|
2017-06-14 04:57:26 +08:00
|
|
|
if (!g_strcmp0(uri->scheme, "nbd")) {
|
2013-03-07 23:15:11 +08:00
|
|
|
is_unix = false;
|
2017-06-14 04:57:26 +08:00
|
|
|
} else if (!g_strcmp0(uri->scheme, "nbd+tcp")) {
|
2013-03-07 23:15:11 +08:00
|
|
|
is_unix = false;
|
2017-06-14 04:57:26 +08:00
|
|
|
} else if (!g_strcmp0(uri->scheme, "nbd+unix")) {
|
2013-03-07 23:15:11 +08:00
|
|
|
is_unix = true;
|
2012-11-04 20:04:24 +08:00
|
|
|
} else {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
p = uri->path ? uri->path : "/";
|
|
|
|
p += strspn(p, "/");
|
|
|
|
if (p[0]) {
|
2017-04-28 05:58:17 +08:00
|
|
|
qdict_put_str(options, "export", p);
|
2012-11-04 20:04:24 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
qp = query_params_parse(uri->query);
|
2013-03-07 23:15:11 +08:00
|
|
|
if (qp->n > 1 || (is_unix && !qp->n) || (!is_unix && qp->n)) {
|
2012-11-04 20:04:24 +08:00
|
|
|
ret = -EINVAL;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2013-03-07 23:15:11 +08:00
|
|
|
if (is_unix) {
|
2012-11-04 20:04:24 +08:00
|
|
|
/* nbd+unix:///export?socket=path */
|
|
|
|
if (uri->server || uri->port || strcmp(qp->p[0].name, "socket")) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out;
|
|
|
|
}
|
2017-04-28 05:58:17 +08:00
|
|
|
qdict_put_str(options, "server.type", "unix");
|
|
|
|
qdict_put_str(options, "server.path", qp->p[0].value);
|
2012-11-04 20:04:24 +08:00
|
|
|
} else {
|
2013-06-03 23:54:56 +08:00
|
|
|
QString *host;
|
2016-10-25 21:11:35 +08:00
|
|
|
char *port_str;
|
|
|
|
|
2013-03-18 23:56:05 +08:00
|
|
|
/* nbd[+tcp]://host[:port]/export */
|
2012-11-04 20:04:24 +08:00
|
|
|
if (!uri->server) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out;
|
|
|
|
}
|
2013-03-15 18:55:29 +08:00
|
|
|
|
2013-06-03 23:54:56 +08:00
|
|
|
/* strip braces from literal IPv6 address */
|
|
|
|
if (uri->server[0] == '[') {
|
|
|
|
host = qstring_from_substr(uri->server, 1,
|
2018-07-27 14:22:04 +08:00
|
|
|
strlen(uri->server) - 1);
|
2013-06-03 23:54:56 +08:00
|
|
|
} else {
|
|
|
|
host = qstring_from_str(uri->server);
|
|
|
|
}
|
|
|
|
|
2017-04-28 05:58:17 +08:00
|
|
|
qdict_put_str(options, "server.type", "inet");
|
nbd: Tidy up blockdev-add interface
SocketAddress is a simple union, and simple unions are awkward: they
have their variant members wrapped in a "data" object on the wire, and
require additional indirections in C. I intend to limit its use to
existing external interfaces, and convert all internal interfaces to
SocketAddressFlat.
BlockdevOptionsNbd is an external interface using SocketAddress. We
already use SocketAddressFlat elsewhere in blockdev-add. Replace it
by SocketAddressFlat while we can (it's new in 2.9) for simplicity and
consistency. For example,
{ "execute": "blockdev-add",
"arguments": { "node-name": "foo", "driver": "nbd",
"server": { "type": "inet",
"data": { "host": "localhost",
"port": "12345" } } } }
becomes
{ "execute": "blockdev-add",
"arguments": { "node-name": "foo", "driver": "nbd",
"server": { "type": "inet",
"host": "localhost", "port": "12345" } } }
Since the internal interfaces still take SocketAddress, this requires
conversion function socket_address_crumple(). It'll go away when I
update the interfaces.
Unfortunately, SocketAddress is also visible in -drive since 2.8:
-drive if=none,driver=nbd,server.type=inet,server.data.host=127.0.0.1,server.data.port=12345
Nobody should be using it, as it's fairly new and has never been
documented, so adding still more compatibility gunk to keep it working
isn't worth the trouble. You now have to use
-drive if=none,driver=nbd,server.type=inet,server.host=127.0.0.1,server.port=12345
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1490895797-29094-9-git-send-email-armbru@redhat.com
[mreitz: Change iotest 147 accordingly]
Because of this interface change, iotest 147 has to be adapted.
Unfortunately, we cannot just flatten all of the addresses because
nbd-server-start still takes a plain SocketAddress. Therefore, we need
both and this is most easily achieved by writing the SocketAddress into
the code and flattening it where necessary.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-id: 20170330221243.17333-1-mreitz@redhat.com
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
2017-03-31 01:43:16 +08:00
|
|
|
qdict_put(options, "server.host", host);
|
2016-10-25 21:11:35 +08:00
|
|
|
|
|
|
|
port_str = g_strdup_printf("%d", uri->port ?: NBD_DEFAULT_PORT);
|
2017-04-28 05:58:17 +08:00
|
|
|
qdict_put_str(options, "server.port", port_str);
|
2016-10-25 21:11:35 +08:00
|
|
|
g_free(port_str);
|
2012-11-04 20:04:24 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
out:
|
|
|
|
if (qp) {
|
|
|
|
query_params_free(qp);
|
|
|
|
}
|
|
|
|
uri_free(uri);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2016-10-25 21:11:33 +08:00
|
|
|
static bool nbd_has_filename_options_conflict(QDict *options, Error **errp)
|
|
|
|
{
|
|
|
|
const QDictEntry *e;
|
|
|
|
|
|
|
|
for (e = qdict_first(options); e; e = qdict_next(options, e)) {
|
|
|
|
if (!strcmp(e->key, "host") ||
|
|
|
|
!strcmp(e->key, "port") ||
|
|
|
|
!strcmp(e->key, "path") ||
|
2016-10-25 21:11:34 +08:00
|
|
|
!strcmp(e->key, "export") ||
|
|
|
|
strstart(e->key, "server.", NULL))
|
2016-10-25 21:11:33 +08:00
|
|
|
{
|
|
|
|
error_setg(errp, "Option '%s' cannot be used with a file name",
|
|
|
|
e->key);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2013-03-16 01:47:22 +08:00
|
|
|
static void nbd_parse_filename(const char *filename, QDict *options,
|
|
|
|
Error **errp)
|
2008-07-03 21:41:03 +08:00
|
|
|
{
|
2010-08-26 04:48:33 +08:00
|
|
|
char *file;
|
2011-02-22 23:44:54 +08:00
|
|
|
char *export_name;
|
|
|
|
const char *host_spec;
|
2008-07-03 21:41:03 +08:00
|
|
|
const char *unixpath;
|
|
|
|
|
2016-10-25 21:11:33 +08:00
|
|
|
if (nbd_has_filename_options_conflict(options, errp)) {
|
2013-03-21 02:23:23 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2012-11-04 20:04:24 +08:00
|
|
|
if (strstr(filename, "://")) {
|
2013-03-16 01:47:22 +08:00
|
|
|
int ret = nbd_parse_uri(filename, options);
|
|
|
|
if (ret < 0) {
|
|
|
|
error_setg(errp, "No valid URL specified");
|
|
|
|
}
|
|
|
|
return;
|
2012-11-04 20:04:24 +08:00
|
|
|
}
|
|
|
|
|
2011-08-21 11:09:37 +08:00
|
|
|
file = g_strdup(filename);
|
2010-08-26 04:48:33 +08:00
|
|
|
|
2011-02-22 23:44:54 +08:00
|
|
|
export_name = strstr(file, EN_OPTSTR);
|
|
|
|
if (export_name) {
|
|
|
|
if (export_name[strlen(EN_OPTSTR)] == 0) {
|
2010-08-26 04:48:33 +08:00
|
|
|
goto out;
|
|
|
|
}
|
2011-02-22 23:44:54 +08:00
|
|
|
export_name[0] = 0; /* truncate 'file' */
|
|
|
|
export_name += strlen(EN_OPTSTR);
|
2013-03-07 23:15:11 +08:00
|
|
|
|
2017-04-28 05:58:17 +08:00
|
|
|
qdict_put_str(options, "export", export_name);
|
2010-08-26 04:48:33 +08:00
|
|
|
}
|
|
|
|
|
2011-02-22 23:44:54 +08:00
|
|
|
/* extract the host_spec - fail if it's not nbd:... */
|
|
|
|
if (!strstart(file, "nbd:", &host_spec)) {
|
2013-03-16 01:47:22 +08:00
|
|
|
error_setg(errp, "File name string for NBD must start with 'nbd:'");
|
2010-08-26 04:48:33 +08:00
|
|
|
goto out;
|
|
|
|
}
|
2008-07-03 21:41:03 +08:00
|
|
|
|
2013-03-07 23:15:11 +08:00
|
|
|
if (!*host_spec) {
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2011-02-22 23:44:54 +08:00
|
|
|
/* are we a UNIX or TCP socket? */
|
|
|
|
if (strstart(host_spec, "unix:", &unixpath)) {
|
2017-04-28 05:58:17 +08:00
|
|
|
qdict_put_str(options, "server.type", "unix");
|
|
|
|
qdict_put_str(options, "server.path", unixpath);
|
2008-07-03 21:41:03 +08:00
|
|
|
} else {
|
2017-04-26 15:36:37 +08:00
|
|
|
InetSocketAddress *addr = g_new(InetSocketAddress, 1);
|
2013-03-07 23:15:11 +08:00
|
|
|
|
2017-04-26 15:36:37 +08:00
|
|
|
if (inet_parse(addr, host_spec, errp)) {
|
|
|
|
goto out_inet;
|
2013-03-15 18:55:29 +08:00
|
|
|
}
|
2008-07-03 21:41:03 +08:00
|
|
|
|
2017-04-28 05:58:17 +08:00
|
|
|
qdict_put_str(options, "server.type", "inet");
|
|
|
|
qdict_put_str(options, "server.host", addr->host);
|
|
|
|
qdict_put_str(options, "server.port", addr->port);
|
2017-04-26 15:36:37 +08:00
|
|
|
out_inet:
|
2013-03-07 23:15:11 +08:00
|
|
|
qapi_free_InetSocketAddress(addr);
|
|
|
|
}
|
2008-07-03 21:41:03 +08:00
|
|
|
|
2011-02-22 23:44:54 +08:00
|
|
|
out:
|
2011-08-21 11:09:37 +08:00
|
|
|
g_free(file);
|
2013-03-07 23:15:11 +08:00
|
|
|
}
|
|
|
|
|
2016-10-25 21:11:34 +08:00
|
|
|
static bool nbd_process_legacy_socket_options(QDict *output_options,
|
|
|
|
QemuOpts *legacy_opts,
|
|
|
|
Error **errp)
|
2013-03-07 23:15:11 +08:00
|
|
|
{
|
2016-10-25 21:11:34 +08:00
|
|
|
const char *path = qemu_opt_get(legacy_opts, "path");
|
|
|
|
const char *host = qemu_opt_get(legacy_opts, "host");
|
|
|
|
const char *port = qemu_opt_get(legacy_opts, "port");
|
|
|
|
const QDictEntry *e;
|
2013-03-07 23:15:11 +08:00
|
|
|
|
2016-10-25 21:11:34 +08:00
|
|
|
if (!path && !host && !port) {
|
|
|
|
return true;
|
|
|
|
}
|
2016-08-15 21:29:26 +08:00
|
|
|
|
2016-10-25 21:11:34 +08:00
|
|
|
for (e = qdict_first(output_options); e; e = qdict_next(output_options, e))
|
|
|
|
{
|
|
|
|
if (strstart(e->key, "server.", NULL)) {
|
|
|
|
error_setg(errp, "Cannot use 'server' and path/host/port at the "
|
|
|
|
"same time");
|
|
|
|
return false;
|
2013-03-21 02:23:23 +08:00
|
|
|
}
|
2011-02-22 23:44:54 +08:00
|
|
|
}
|
2016-10-25 21:11:34 +08:00
|
|
|
|
|
|
|
if (path && host) {
|
|
|
|
error_setg(errp, "path and host may not be used at the same time");
|
|
|
|
return false;
|
|
|
|
} else if (path) {
|
|
|
|
if (port) {
|
|
|
|
error_setg(errp, "port may not be used without host");
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2017-04-28 05:58:17 +08:00
|
|
|
qdict_put_str(output_options, "server.type", "unix");
|
|
|
|
qdict_put_str(output_options, "server.path", path);
|
2016-10-25 21:11:34 +08:00
|
|
|
} else if (host) {
|
2017-04-28 05:58:17 +08:00
|
|
|
qdict_put_str(output_options, "server.type", "inet");
|
|
|
|
qdict_put_str(output_options, "server.host", host);
|
|
|
|
qdict_put_str(output_options, "server.port",
|
|
|
|
port ?: stringify(NBD_DEFAULT_PORT));
|
2016-10-25 21:11:30 +08:00
|
|
|
}
|
2013-03-07 23:15:11 +08:00
|
|
|
|
2016-10-25 21:11:34 +08:00
|
|
|
return true;
|
|
|
|
}
|
2013-03-07 23:15:11 +08:00
|
|
|
|
2017-04-26 15:36:40 +08:00
|
|
|
static SocketAddress *nbd_config(BDRVNBDState *s, QDict *options,
|
|
|
|
Error **errp)
|
2016-10-25 21:11:34 +08:00
|
|
|
{
|
2017-04-26 15:36:40 +08:00
|
|
|
SocketAddress *saddr = NULL;
|
2016-10-25 21:11:34 +08:00
|
|
|
QDict *addr = NULL;
|
|
|
|
Visitor *iv = NULL;
|
|
|
|
Error *local_err = NULL;
|
|
|
|
|
|
|
|
qdict_extract_subqdict(options, &addr, "server.");
|
|
|
|
if (!qdict_size(addr)) {
|
|
|
|
error_setg(errp, "NBD server address missing");
|
|
|
|
goto done;
|
2013-03-07 23:15:11 +08:00
|
|
|
}
|
|
|
|
|
2018-06-15 03:14:33 +08:00
|
|
|
iv = qobject_input_visitor_new_flat_confused(addr, errp);
|
|
|
|
if (!iv) {
|
2016-10-25 21:11:34 +08:00
|
|
|
goto done;
|
|
|
|
}
|
2013-03-18 23:56:05 +08:00
|
|
|
|
2017-04-26 15:36:40 +08:00
|
|
|
visit_type_SocketAddress(iv, NULL, &saddr, &local_err);
|
2016-10-25 21:11:34 +08:00
|
|
|
if (local_err) {
|
|
|
|
error_propagate(errp, local_err);
|
|
|
|
goto done;
|
|
|
|
}
|
2015-09-16 21:52:22 +08:00
|
|
|
|
2016-10-25 21:11:34 +08:00
|
|
|
done:
|
2018-04-19 23:01:43 +08:00
|
|
|
qobject_unref(addr);
|
2016-10-25 21:11:34 +08:00
|
|
|
visit_free(iv);
|
2015-09-16 21:52:22 +08:00
|
|
|
return saddr;
|
2011-02-22 23:44:54 +08:00
|
|
|
}
|
2010-08-26 04:48:33 +08:00
|
|
|
|
2016-10-15 02:33:06 +08:00
|
|
|
NBDClientSession *nbd_get_client_session(BlockDriverState *bs)
|
2015-02-07 05:06:16 +08:00
|
|
|
{
|
|
|
|
BDRVNBDState *s = bs->opaque;
|
|
|
|
return &s->client;
|
|
|
|
}
|
|
|
|
|
2017-04-26 15:36:41 +08:00
|
|
|
static QIOChannelSocket *nbd_establish_connection(SocketAddress *saddr,
|
2016-02-11 02:41:01 +08:00
|
|
|
Error **errp)
|
2011-02-22 23:44:54 +08:00
|
|
|
{
|
2016-02-11 02:41:01 +08:00
|
|
|
QIOChannelSocket *sioc;
|
|
|
|
Error *local_err = NULL;
|
2008-07-03 21:41:03 +08:00
|
|
|
|
2016-02-11 02:41:01 +08:00
|
|
|
sioc = qio_channel_socket_new();
|
2016-09-30 18:57:14 +08:00
|
|
|
qio_channel_set_name(QIO_CHANNEL(sioc), "nbd-client");
|
2008-07-03 21:41:03 +08:00
|
|
|
|
2016-02-11 02:41:01 +08:00
|
|
|
qio_channel_socket_connect_sync(sioc,
|
|
|
|
saddr,
|
|
|
|
&local_err);
|
|
|
|
if (local_err) {
|
2017-04-01 08:15:09 +08:00
|
|
|
object_unref(OBJECT(sioc));
|
2016-02-11 02:41:01 +08:00
|
|
|
error_propagate(errp, local_err);
|
|
|
|
return NULL;
|
2010-08-26 04:48:33 +08:00
|
|
|
}
|
2008-07-03 21:41:03 +08:00
|
|
|
|
2016-02-11 02:41:01 +08:00
|
|
|
qio_channel_set_delay(QIO_CHANNEL(sioc), false);
|
2015-09-16 21:52:22 +08:00
|
|
|
|
2016-02-11 02:41:01 +08:00
|
|
|
return sioc;
|
2011-02-22 23:44:54 +08:00
|
|
|
}
|
|
|
|
|
2016-02-11 02:41:12 +08:00
|
|
|
|
|
|
|
static QCryptoTLSCreds *nbd_get_tls_creds(const char *id, Error **errp)
|
|
|
|
{
|
|
|
|
Object *obj;
|
|
|
|
QCryptoTLSCreds *creds;
|
|
|
|
|
|
|
|
obj = object_resolve_path_component(
|
|
|
|
object_get_objects_root(), id);
|
|
|
|
if (!obj) {
|
|
|
|
error_setg(errp, "No TLS credentials with id '%s'",
|
|
|
|
id);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
creds = (QCryptoTLSCreds *)
|
|
|
|
object_dynamic_cast(obj, TYPE_QCRYPTO_TLS_CREDS);
|
|
|
|
if (!creds) {
|
|
|
|
error_setg(errp, "Object with id '%s' is not TLS credentials",
|
|
|
|
id);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (creds->endpoint != QCRYPTO_TLS_CREDS_ENDPOINT_CLIENT) {
|
|
|
|
error_setg(errp,
|
|
|
|
"Expecting TLS credentials with a client endpoint");
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
object_ref(obj);
|
|
|
|
return creds;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2016-08-15 21:29:24 +08:00
|
|
|
static QemuOptsList nbd_runtime_opts = {
|
|
|
|
.name = "nbd",
|
|
|
|
.head = QTAILQ_HEAD_INITIALIZER(nbd_runtime_opts.head),
|
|
|
|
.desc = {
|
|
|
|
{
|
|
|
|
.name = "host",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "TCP host to connect to",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.name = "port",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "TCP port to connect to",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.name = "path",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "Unix socket path to connect to",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.name = "export",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "Name of the NBD export to open",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.name = "tls-creds",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "ID of the TLS credentials to use",
|
|
|
|
},
|
2018-07-03 03:14:57 +08:00
|
|
|
{
|
|
|
|
.name = "x-dirty-bitmap",
|
|
|
|
.type = QEMU_OPT_STRING,
|
|
|
|
.help = "experimental: expose named dirty bitmap in place of "
|
|
|
|
"block status",
|
|
|
|
},
|
block/nbd: fix segmentation fault when .desc is not null-terminated
The find_desc_by_name() from util/qemu-option.c relies on the .name not being
NULL to call strcmp(). This check becomes unsafe when the list is not
NULL-terminated, which is the case of nbd_runtime_opts in block/nbd.c, and can
result in segmentation fault when strcmp() tries to access an invalid memory:
#0 0x00007fff8c75f7d4 in __strcmp_power9 () from /lib64/libc.so.6
#1 0x00000000102d3ec8 in find_desc_by_name (desc=0x1036d6f0, name=0x28e46670 "server.path") at util/qemu-option.c:166
#2 0x00000000102d93e0 in qemu_opts_absorb_qdict (opts=0x28e47a80, qdict=0x28e469a0, errp=0x7fffec247c98) at util/qemu-option.c:1026
#3 0x000000001012a2e4 in nbd_open (bs=0x28e42290, options=0x28e469a0, flags=24578, errp=0x7fffec247d80) at block/nbd.c:406
#4 0x00000000100144e8 in bdrv_open_driver (bs=0x28e42290, drv=0x1036e070 <bdrv_nbd_unix>, node_name=0x0, options=0x28e469a0, open_flags=24578, errp=0x7fffec247f50) at block.c:1135
#5 0x0000000010015b04 in bdrv_open_common (bs=0x28e42290, file=0x0, options=0x28e469a0, errp=0x7fffec247f50) at block.c:1395
>From gdb, the desc[i].name was not NULL and resulted in strcmp() accessing an
invalid memory:
>>> p desc[5]
$8 = {
name = 0x1037f098 "R27A",
type = 1561964883,
help = 0xc0bbb23e <error: Cannot access memory at address 0xc0bbb23e>,
def_value_str = 0x2 <error: Cannot access memory at address 0x2>
}
>>> p desc[6]
$9 = {
name = 0x103dac78 <__gcov0.do_qemu_init_bdrv_nbd_init> "\001",
type = 272101528,
help = 0x29ec0b754403e31f <error: Cannot access memory at address 0x29ec0b754403e31f>,
def_value_str = 0x81f343b9 <error: Cannot access memory at address 0x81f343b9>
}
This patch fixes the segmentation fault in strcmp() by adding a NULL element at
the end of nbd_runtime_opts.desc list, which is the common practice to most of
other structs like runtime_opts in block/null.c. Thus, the desc[i].name != NULL
check becomes safe because it will not evaluate to true when .desc list reached
its end.
Reported-by: R. Nageswara Sastry <nasastry@in.ibm.com>
Buglink: https://bugs.launchpad.net/qemu/+bug/1727259
Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.vnet.ibm.com>
Message-Id: <20180105133241.14141-2-muriloo@linux.vnet.ibm.com>
CC: qemu-stable@nongnu.org
Fixes: 7ccc44fd7d1dfa62c4d6f3a680df809d6e7068ce
Signed-off-by: Eric Blake <eblake@redhat.com>
2018-01-05 21:32:41 +08:00
|
|
|
{ /* end of list */ }
|
2016-08-15 21:29:24 +08:00
|
|
|
},
|
|
|
|
};
|
|
|
|
|
2013-09-05 20:22:29 +08:00
|
|
|
static int nbd_open(BlockDriverState *bs, QDict *options, int flags,
|
|
|
|
Error **errp)
|
2011-02-22 23:44:54 +08:00
|
|
|
{
|
|
|
|
BDRVNBDState *s = bs->opaque;
|
2016-08-15 21:29:24 +08:00
|
|
|
QemuOpts *opts = NULL;
|
|
|
|
Error *local_err = NULL;
|
2016-02-11 02:41:12 +08:00
|
|
|
QIOChannelSocket *sioc = NULL;
|
|
|
|
QCryptoTLSCreds *tlscreds = NULL;
|
|
|
|
const char *hostname = NULL;
|
|
|
|
int ret = -EINVAL;
|
2011-09-08 20:28:59 +08:00
|
|
|
|
2016-08-15 21:29:24 +08:00
|
|
|
opts = qemu_opts_create(&nbd_runtime_opts, NULL, 0, &error_abort);
|
|
|
|
qemu_opts_absorb_qdict(opts, options, &local_err);
|
|
|
|
if (local_err) {
|
|
|
|
error_propagate(errp, local_err);
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
2017-04-26 15:36:40 +08:00
|
|
|
/* Translate @host, @port, and @path to a SocketAddress */
|
2016-10-25 21:11:34 +08:00
|
|
|
if (!nbd_process_legacy_socket_options(options, opts, errp)) {
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
2011-02-22 23:44:54 +08:00
|
|
|
/* Pop the config into our state object. Exit if invalid. */
|
2016-10-25 21:11:34 +08:00
|
|
|
s->saddr = nbd_config(s, options, errp);
|
|
|
|
if (!s->saddr) {
|
2016-02-11 02:41:12 +08:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
2016-10-25 21:11:34 +08:00
|
|
|
s->export = g_strdup(qemu_opt_get(opts, "export"));
|
|
|
|
|
2016-08-15 21:29:26 +08:00
|
|
|
s->tlscredsid = g_strdup(qemu_opt_get(opts, "tls-creds"));
|
|
|
|
if (s->tlscredsid) {
|
|
|
|
tlscreds = nbd_get_tls_creds(s->tlscredsid, errp);
|
2016-02-11 02:41:12 +08:00
|
|
|
if (!tlscreds) {
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
2017-03-31 01:43:09 +08:00
|
|
|
/* TODO SOCKET_ADDRESS_KIND_FD where fd has AF_INET or AF_INET6 */
|
2017-04-26 15:36:40 +08:00
|
|
|
if (s->saddr->type != SOCKET_ADDRESS_TYPE_INET) {
|
2016-02-11 02:41:12 +08:00
|
|
|
error_setg(errp, "TLS only supported over IP sockets");
|
|
|
|
goto error;
|
|
|
|
}
|
nbd: Tidy up blockdev-add interface
SocketAddress is a simple union, and simple unions are awkward: they
have their variant members wrapped in a "data" object on the wire, and
require additional indirections in C. I intend to limit its use to
existing external interfaces, and convert all internal interfaces to
SocketAddressFlat.
BlockdevOptionsNbd is an external interface using SocketAddress. We
already use SocketAddressFlat elsewhere in blockdev-add. Replace it
by SocketAddressFlat while we can (it's new in 2.9) for simplicity and
consistency. For example,
{ "execute": "blockdev-add",
"arguments": { "node-name": "foo", "driver": "nbd",
"server": { "type": "inet",
"data": { "host": "localhost",
"port": "12345" } } } }
becomes
{ "execute": "blockdev-add",
"arguments": { "node-name": "foo", "driver": "nbd",
"server": { "type": "inet",
"host": "localhost", "port": "12345" } } }
Since the internal interfaces still take SocketAddress, this requires
conversion function socket_address_crumple(). It'll go away when I
update the interfaces.
Unfortunately, SocketAddress is also visible in -drive since 2.8:
-drive if=none,driver=nbd,server.type=inet,server.data.host=127.0.0.1,server.data.port=12345
Nobody should be using it, as it's fairly new and has never been
documented, so adding still more compatibility gunk to keep it working
isn't worth the trouble. You now have to use
-drive if=none,driver=nbd,server.type=inet,server.host=127.0.0.1,server.port=12345
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1490895797-29094-9-git-send-email-armbru@redhat.com
[mreitz: Change iotest 147 accordingly]
Because of this interface change, iotest 147 has to be adapted.
Unfortunately, we cannot just flatten all of the addresses because
nbd-server-start still takes a plain SocketAddress. Therefore, we need
both and this is most easily achieved by writing the SocketAddress into
the code and flattening it where necessary.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-id: 20170330221243.17333-1-mreitz@redhat.com
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
2017-03-31 01:43:16 +08:00
|
|
|
hostname = s->saddr->u.inet.host;
|
2011-02-22 23:44:54 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* establish TCP connection, return error if it fails
|
|
|
|
* TODO: Configurable retry-until-timeout behaviour.
|
|
|
|
*/
|
2016-10-25 21:11:34 +08:00
|
|
|
sioc = nbd_establish_connection(s->saddr, errp);
|
2016-02-11 02:41:01 +08:00
|
|
|
if (!sioc) {
|
2016-02-11 02:41:12 +08:00
|
|
|
ret = -ECONNREFUSED;
|
|
|
|
goto error;
|
2011-10-21 19:16:28 +08:00
|
|
|
}
|
|
|
|
|
2013-12-02 05:23:41 +08:00
|
|
|
/* NBD handshake */
|
2018-07-03 03:14:57 +08:00
|
|
|
ret = nbd_client_init(bs, sioc, s->export, tlscreds, hostname,
|
|
|
|
qemu_opt_get(opts, "x-dirty-bitmap"), errp);
|
2016-02-11 02:41:12 +08:00
|
|
|
error:
|
|
|
|
if (sioc) {
|
|
|
|
object_unref(OBJECT(sioc));
|
|
|
|
}
|
|
|
|
if (tlscreds) {
|
|
|
|
object_unref(OBJECT(tlscreds));
|
|
|
|
}
|
2016-08-15 21:29:26 +08:00
|
|
|
if (ret < 0) {
|
2017-04-26 15:36:40 +08:00
|
|
|
qapi_free_SocketAddress(s->saddr);
|
2016-08-15 21:29:26 +08:00
|
|
|
g_free(s->export);
|
|
|
|
g_free(s->tlscredsid);
|
|
|
|
}
|
2016-08-15 21:29:24 +08:00
|
|
|
qemu_opts_del(opts);
|
2016-02-11 02:41:12 +08:00
|
|
|
return ret;
|
2011-10-20 19:16:23 +08:00
|
|
|
}
|
|
|
|
|
2011-10-21 19:17:14 +08:00
|
|
|
static int nbd_co_flush(BlockDriverState *bs)
|
|
|
|
{
|
2015-02-07 05:06:16 +08:00
|
|
|
return nbd_client_co_flush(bs);
|
2011-10-21 19:17:14 +08:00
|
|
|
}
|
|
|
|
|
2015-02-06 19:24:43 +08:00
|
|
|
static void nbd_refresh_limits(BlockDriverState *bs, Error **errp)
|
|
|
|
{
|
nbd: Implement NBD_INFO_BLOCK_SIZE on client
The upstream NBD Protocol has defined a new extension to allow
the server to advertise block sizes to the client, as well as
a way for the client to inform the server whether it intends to
obey block sizes.
When using the block layer as the client, we will obey block
sizes; but when used as 'qemu-nbd -c' to hand off to the
kernel nbd module as the client, we are still waiting for the
kernel to implement a way for us to learn if it will honor
block sizes (perhaps by an addition to sysfs, rather than an
ioctl), as well as any way to tell the kernel what additional
block sizes to obey (NBD_SET_BLKSIZE appears to be accurate
for the minimum size, but preferred and maximum sizes would
probably be new ioctl()s), so until then, we need to make our
request for block sizes conditional.
When using ioctl(NBD_SET_BLKSIZE) to hand off to the kernel,
use the minimum block size as the sector size if it is larger
than 512, which also has the nice effect of cooperating with
(non-qemu) servers that don't do read-modify-write when
exposing a block device with 4k sectors; it might also allow
us to visit a file larger than 2T on a 32-bit kernel.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20170707203049.534-10-eblake@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2017-07-08 04:30:49 +08:00
|
|
|
NBDClientSession *s = nbd_get_client_session(bs);
|
nbd: Honor server's advertised minimum block size
Commit 79ba8c98 (v2.7) changed the setting of request_alignment
to occur only during bdrv_refresh_limits(), rather than at at
bdrv_open() time; but at the time, NBD was unaffected, because
it still used sector-based callbacks, so the block layer
defaulted NBD to use 512 request_alignment.
Later, commit 70c4fb26 (also v2.7) changed NBD to use byte-based
callbacks, without setting request_alignment. This resulted in
NBD using request_alignment of 1, which works great when the
server supports it (as is the case for qemu-nbd), but falls apart
miserably if the server requires alignment (but only if qemu
actually sends a sub-sector request; qemu-io can do it, but
most qemu operations still perform on sectors or larger).
Even later, the NBD protocol was updated to document that clients
should learn the server's minimum alignment during NBD_OPT_GO;
and recommended that clients should assume a minimum size of 512
unless the server understands NBD_OPT_GO and replied with a smaller
size. Commit 081dd1fe (v2.10) attempted to do that, by assigning
request_alignment to whatever was learned from the server; but
it has two flaws: the assignment is done during bdrv_open() so
it gets unconditionally wiped out back to 1 during any later
bdrv_refresh_limits(); and the code is not using a default of 512
when the server did not report a minimum size.
Fix these issues by moving the assignment to request_alignment
to the right function, and by using a sane default when the
server does not advertise a minimum size.
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20180215032905.27146-1-eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy<vsementsov@virtuozzo.com>
2018-02-15 11:29:05 +08:00
|
|
|
uint32_t min = s->info.min_block;
|
nbd: Implement NBD_INFO_BLOCK_SIZE on client
The upstream NBD Protocol has defined a new extension to allow
the server to advertise block sizes to the client, as well as
a way for the client to inform the server whether it intends to
obey block sizes.
When using the block layer as the client, we will obey block
sizes; but when used as 'qemu-nbd -c' to hand off to the
kernel nbd module as the client, we are still waiting for the
kernel to implement a way for us to learn if it will honor
block sizes (perhaps by an addition to sysfs, rather than an
ioctl), as well as any way to tell the kernel what additional
block sizes to obey (NBD_SET_BLKSIZE appears to be accurate
for the minimum size, but preferred and maximum sizes would
probably be new ioctl()s), so until then, we need to make our
request for block sizes conditional.
When using ioctl(NBD_SET_BLKSIZE) to hand off to the kernel,
use the minimum block size as the sector size if it is larger
than 512, which also has the nice effect of cooperating with
(non-qemu) servers that don't do read-modify-write when
exposing a block device with 4k sectors; it might also allow
us to visit a file larger than 2T on a 32-bit kernel.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20170707203049.534-10-eblake@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2017-07-08 04:30:49 +08:00
|
|
|
uint32_t max = MIN_NON_ZERO(NBD_MAX_BUFFER_SIZE, s->info.max_block);
|
|
|
|
|
nbd: Honor server's advertised minimum block size
Commit 79ba8c98 (v2.7) changed the setting of request_alignment
to occur only during bdrv_refresh_limits(), rather than at at
bdrv_open() time; but at the time, NBD was unaffected, because
it still used sector-based callbacks, so the block layer
defaulted NBD to use 512 request_alignment.
Later, commit 70c4fb26 (also v2.7) changed NBD to use byte-based
callbacks, without setting request_alignment. This resulted in
NBD using request_alignment of 1, which works great when the
server supports it (as is the case for qemu-nbd), but falls apart
miserably if the server requires alignment (but only if qemu
actually sends a sub-sector request; qemu-io can do it, but
most qemu operations still perform on sectors or larger).
Even later, the NBD protocol was updated to document that clients
should learn the server's minimum alignment during NBD_OPT_GO;
and recommended that clients should assume a minimum size of 512
unless the server understands NBD_OPT_GO and replied with a smaller
size. Commit 081dd1fe (v2.10) attempted to do that, by assigning
request_alignment to whatever was learned from the server; but
it has two flaws: the assignment is done during bdrv_open() so
it gets unconditionally wiped out back to 1 during any later
bdrv_refresh_limits(); and the code is not using a default of 512
when the server did not report a minimum size.
Fix these issues by moving the assignment to request_alignment
to the right function, and by using a sane default when the
server does not advertise a minimum size.
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20180215032905.27146-1-eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy<vsementsov@virtuozzo.com>
2018-02-15 11:29:05 +08:00
|
|
|
bs->bl.request_alignment = min ? min : BDRV_SECTOR_SIZE;
|
nbd: Implement NBD_INFO_BLOCK_SIZE on client
The upstream NBD Protocol has defined a new extension to allow
the server to advertise block sizes to the client, as well as
a way for the client to inform the server whether it intends to
obey block sizes.
When using the block layer as the client, we will obey block
sizes; but when used as 'qemu-nbd -c' to hand off to the
kernel nbd module as the client, we are still waiting for the
kernel to implement a way for us to learn if it will honor
block sizes (perhaps by an addition to sysfs, rather than an
ioctl), as well as any way to tell the kernel what additional
block sizes to obey (NBD_SET_BLKSIZE appears to be accurate
for the minimum size, but preferred and maximum sizes would
probably be new ioctl()s), so until then, we need to make our
request for block sizes conditional.
When using ioctl(NBD_SET_BLKSIZE) to hand off to the kernel,
use the minimum block size as the sector size if it is larger
than 512, which also has the nice effect of cooperating with
(non-qemu) servers that don't do read-modify-write when
exposing a block device with 4k sectors; it might also allow
us to visit a file larger than 2T on a 32-bit kernel.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20170707203049.534-10-eblake@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2017-07-08 04:30:49 +08:00
|
|
|
bs->bl.max_pdiscard = max;
|
|
|
|
bs->bl.max_pwrite_zeroes = max;
|
|
|
|
bs->bl.max_transfer = max;
|
|
|
|
|
|
|
|
if (s->info.opt_block &&
|
|
|
|
s->info.opt_block > bs->bl.opt_transfer) {
|
|
|
|
bs->bl.opt_transfer = s->info.opt_block;
|
|
|
|
}
|
2015-02-06 19:24:43 +08:00
|
|
|
}
|
|
|
|
|
2008-07-03 21:41:03 +08:00
|
|
|
static void nbd_close(BlockDriverState *bs)
|
|
|
|
{
|
2016-08-15 21:29:26 +08:00
|
|
|
BDRVNBDState *s = bs->opaque;
|
|
|
|
|
2015-02-07 05:06:16 +08:00
|
|
|
nbd_client_close(bs);
|
2016-08-15 21:29:26 +08:00
|
|
|
|
2017-04-26 15:36:40 +08:00
|
|
|
qapi_free_SocketAddress(s->saddr);
|
2016-08-15 21:29:26 +08:00
|
|
|
g_free(s->export);
|
|
|
|
g_free(s->tlscredsid);
|
2008-07-03 21:41:03 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static int64_t nbd_getlength(BlockDriverState *bs)
|
|
|
|
{
|
|
|
|
BDRVNBDState *s = bs->opaque;
|
|
|
|
|
2017-07-08 04:30:41 +08:00
|
|
|
return s->client.info.size;
|
2008-07-03 21:41:03 +08:00
|
|
|
}
|
|
|
|
|
2014-05-08 22:34:43 +08:00
|
|
|
static void nbd_detach_aio_context(BlockDriverState *bs)
|
|
|
|
{
|
2015-02-07 05:06:16 +08:00
|
|
|
nbd_client_detach_aio_context(bs);
|
2014-05-08 22:34:43 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void nbd_attach_aio_context(BlockDriverState *bs,
|
|
|
|
AioContext *new_context)
|
|
|
|
{
|
2015-02-07 05:06:16 +08:00
|
|
|
nbd_client_attach_aio_context(bs, new_context);
|
2014-05-08 22:34:43 +08:00
|
|
|
}
|
|
|
|
|
2015-04-27 19:50:54 +08:00
|
|
|
static void nbd_refresh_filename(BlockDriverState *bs, QDict *options)
|
2014-07-19 02:24:59 +08:00
|
|
|
{
|
2016-08-15 21:29:26 +08:00
|
|
|
BDRVNBDState *s = bs->opaque;
|
2014-07-19 02:24:59 +08:00
|
|
|
QDict *opts = qdict_new();
|
2016-10-25 21:11:34 +08:00
|
|
|
QObject *saddr_qdict;
|
|
|
|
Visitor *ov;
|
|
|
|
const char *host = NULL, *port = NULL, *path = NULL;
|
|
|
|
|
2017-04-26 15:36:40 +08:00
|
|
|
if (s->saddr->type == SOCKET_ADDRESS_TYPE_INET) {
|
nbd: Tidy up blockdev-add interface
SocketAddress is a simple union, and simple unions are awkward: they
have their variant members wrapped in a "data" object on the wire, and
require additional indirections in C. I intend to limit its use to
existing external interfaces, and convert all internal interfaces to
SocketAddressFlat.
BlockdevOptionsNbd is an external interface using SocketAddress. We
already use SocketAddressFlat elsewhere in blockdev-add. Replace it
by SocketAddressFlat while we can (it's new in 2.9) for simplicity and
consistency. For example,
{ "execute": "blockdev-add",
"arguments": { "node-name": "foo", "driver": "nbd",
"server": { "type": "inet",
"data": { "host": "localhost",
"port": "12345" } } } }
becomes
{ "execute": "blockdev-add",
"arguments": { "node-name": "foo", "driver": "nbd",
"server": { "type": "inet",
"host": "localhost", "port": "12345" } } }
Since the internal interfaces still take SocketAddress, this requires
conversion function socket_address_crumple(). It'll go away when I
update the interfaces.
Unfortunately, SocketAddress is also visible in -drive since 2.8:
-drive if=none,driver=nbd,server.type=inet,server.data.host=127.0.0.1,server.data.port=12345
Nobody should be using it, as it's fairly new and has never been
documented, so adding still more compatibility gunk to keep it working
isn't worth the trouble. You now have to use
-drive if=none,driver=nbd,server.type=inet,server.host=127.0.0.1,server.port=12345
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1490895797-29094-9-git-send-email-armbru@redhat.com
[mreitz: Change iotest 147 accordingly]
Because of this interface change, iotest 147 has to be adapted.
Unfortunately, we cannot just flatten all of the addresses because
nbd-server-start still takes a plain SocketAddress. Therefore, we need
both and this is most easily achieved by writing the SocketAddress into
the code and flattening it where necessary.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-id: 20170330221243.17333-1-mreitz@redhat.com
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
2017-03-31 01:43:16 +08:00
|
|
|
const InetSocketAddress *inet = &s->saddr->u.inet;
|
2016-10-25 21:11:34 +08:00
|
|
|
if (!inet->has_ipv4 && !inet->has_ipv6 && !inet->has_to) {
|
|
|
|
host = inet->host;
|
|
|
|
port = inet->port;
|
|
|
|
}
|
2017-04-26 15:36:40 +08:00
|
|
|
} else if (s->saddr->type == SOCKET_ADDRESS_TYPE_UNIX) {
|
nbd: Tidy up blockdev-add interface
SocketAddress is a simple union, and simple unions are awkward: they
have their variant members wrapped in a "data" object on the wire, and
require additional indirections in C. I intend to limit its use to
existing external interfaces, and convert all internal interfaces to
SocketAddressFlat.
BlockdevOptionsNbd is an external interface using SocketAddress. We
already use SocketAddressFlat elsewhere in blockdev-add. Replace it
by SocketAddressFlat while we can (it's new in 2.9) for simplicity and
consistency. For example,
{ "execute": "blockdev-add",
"arguments": { "node-name": "foo", "driver": "nbd",
"server": { "type": "inet",
"data": { "host": "localhost",
"port": "12345" } } } }
becomes
{ "execute": "blockdev-add",
"arguments": { "node-name": "foo", "driver": "nbd",
"server": { "type": "inet",
"host": "localhost", "port": "12345" } } }
Since the internal interfaces still take SocketAddress, this requires
conversion function socket_address_crumple(). It'll go away when I
update the interfaces.
Unfortunately, SocketAddress is also visible in -drive since 2.8:
-drive if=none,driver=nbd,server.type=inet,server.data.host=127.0.0.1,server.data.port=12345
Nobody should be using it, as it's fairly new and has never been
documented, so adding still more compatibility gunk to keep it working
isn't worth the trouble. You now have to use
-drive if=none,driver=nbd,server.type=inet,server.host=127.0.0.1,server.port=12345
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1490895797-29094-9-git-send-email-armbru@redhat.com
[mreitz: Change iotest 147 accordingly]
Because of this interface change, iotest 147 has to be adapted.
Unfortunately, we cannot just flatten all of the addresses because
nbd-server-start still takes a plain SocketAddress. Therefore, we need
both and this is most easily achieved by writing the SocketAddress into
the code and flattening it where necessary.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-id: 20170330221243.17333-1-mreitz@redhat.com
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
2017-03-31 01:43:16 +08:00
|
|
|
path = s->saddr->u.q_unix.path;
|
|
|
|
} /* else can't represent as pseudo-filename */
|
2014-07-19 02:24:59 +08:00
|
|
|
|
2017-04-28 05:58:17 +08:00
|
|
|
qdict_put_str(opts, "driver", "nbd");
|
2014-07-19 02:24:59 +08:00
|
|
|
|
2016-10-25 21:11:34 +08:00
|
|
|
if (path && s->export) {
|
2014-07-19 02:24:59 +08:00
|
|
|
snprintf(bs->exact_filename, sizeof(bs->exact_filename),
|
2016-10-25 21:11:34 +08:00
|
|
|
"nbd+unix:///%s?socket=%s", s->export, path);
|
|
|
|
} else if (path && !s->export) {
|
2014-07-19 02:24:59 +08:00
|
|
|
snprintf(bs->exact_filename, sizeof(bs->exact_filename),
|
2016-10-25 21:11:34 +08:00
|
|
|
"nbd+unix://?socket=%s", path);
|
|
|
|
} else if (host && s->export) {
|
nbd: Fix filename generation
Export names may be used with nbd+unix, too, fix nbd_refresh_filename()
accordingly. Also, for nbd+tcp, the documented path schema is
"nbd://host[:port]/export", so use it. Furthermore, as can be seen from
that schema, the port is optional.
That makes six single cases for how the filename can be formatted; it is
not easy to generalize these cases without the resulting statement being
completely unreadable, thus there is simply one snprintf() per case.
Finally, taking the options from BDRVNBDState::socket_opts is wrong,
because those will not contain the export name. Just use
BlockDriverState::options instead.
Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-10-09 01:55:15 +08:00
|
|
|
snprintf(bs->exact_filename, sizeof(bs->exact_filename),
|
2016-10-25 21:11:34 +08:00
|
|
|
"nbd://%s:%s/%s", host, port, s->export);
|
|
|
|
} else if (host && !s->export) {
|
nbd: Fix filename generation
Export names may be used with nbd+unix, too, fix nbd_refresh_filename()
accordingly. Also, for nbd+tcp, the documented path schema is
"nbd://host[:port]/export", so use it. Furthermore, as can be seen from
that schema, the port is optional.
That makes six single cases for how the filename can be formatted; it is
not easy to generalize these cases without the resulting statement being
completely unreadable, thus there is simply one snprintf() per case.
Finally, taking the options from BDRVNBDState::socket_opts is wrong,
because those will not contain the export name. Just use
BlockDriverState::options instead.
Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-10-09 01:55:15 +08:00
|
|
|
snprintf(bs->exact_filename, sizeof(bs->exact_filename),
|
2016-10-25 21:11:34 +08:00
|
|
|
"nbd://%s:%s", host, port);
|
nbd: Fix filename generation
Export names may be used with nbd+unix, too, fix nbd_refresh_filename()
accordingly. Also, for nbd+tcp, the documented path schema is
"nbd://host[:port]/export", so use it. Furthermore, as can be seen from
that schema, the port is optional.
That makes six single cases for how the filename can be formatted; it is
not easy to generalize these cases without the resulting statement being
completely unreadable, thus there is simply one snprintf() per case.
Finally, taking the options from BDRVNBDState::socket_opts is wrong,
because those will not contain the export name. Just use
BlockDriverState::options instead.
Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-10-09 01:55:15 +08:00
|
|
|
}
|
|
|
|
|
2016-10-25 21:11:34 +08:00
|
|
|
ov = qobject_output_visitor_new(&saddr_qdict);
|
2017-04-26 15:36:40 +08:00
|
|
|
visit_type_SocketAddress(ov, NULL, &s->saddr, &error_abort);
|
2016-10-25 21:11:34 +08:00
|
|
|
visit_complete(ov, &saddr_qdict);
|
2016-11-02 18:40:03 +08:00
|
|
|
visit_free(ov);
|
2016-10-25 21:11:34 +08:00
|
|
|
qdict_put_obj(opts, "server", saddr_qdict);
|
|
|
|
|
2016-08-15 21:29:26 +08:00
|
|
|
if (s->export) {
|
2017-04-28 05:58:17 +08:00
|
|
|
qdict_put_str(opts, "export", s->export);
|
2014-07-19 02:24:59 +08:00
|
|
|
}
|
2016-08-15 21:29:26 +08:00
|
|
|
if (s->tlscredsid) {
|
2017-04-28 05:58:17 +08:00
|
|
|
qdict_put_str(opts, "tls-creds", s->tlscredsid);
|
2016-02-11 02:41:12 +08:00
|
|
|
}
|
2014-07-19 02:24:59 +08:00
|
|
|
|
2016-10-25 21:11:34 +08:00
|
|
|
qdict_flatten(opts);
|
2014-07-19 02:24:59 +08:00
|
|
|
bs->full_open_options = opts;
|
|
|
|
}
|
|
|
|
|
2009-05-10 06:03:42 +08:00
|
|
|
static BlockDriver bdrv_nbd = {
|
2014-05-08 22:34:43 +08:00
|
|
|
.format_name = "nbd",
|
|
|
|
.protocol_name = "nbd",
|
|
|
|
.instance_size = sizeof(BDRVNBDState),
|
|
|
|
.bdrv_parse_filename = nbd_parse_filename,
|
|
|
|
.bdrv_file_open = nbd_open,
|
2016-07-16 07:23:07 +08:00
|
|
|
.bdrv_co_preadv = nbd_client_co_preadv,
|
|
|
|
.bdrv_co_pwritev = nbd_client_co_pwritev,
|
2016-10-15 02:33:18 +08:00
|
|
|
.bdrv_co_pwrite_zeroes = nbd_client_co_pwrite_zeroes,
|
2014-05-08 22:34:43 +08:00
|
|
|
.bdrv_close = nbd_close,
|
|
|
|
.bdrv_co_flush_to_os = nbd_co_flush,
|
2016-07-16 07:23:02 +08:00
|
|
|
.bdrv_co_pdiscard = nbd_client_co_pdiscard,
|
2015-02-06 19:24:43 +08:00
|
|
|
.bdrv_refresh_limits = nbd_refresh_limits,
|
2014-05-08 22:34:43 +08:00
|
|
|
.bdrv_getlength = nbd_getlength,
|
|
|
|
.bdrv_detach_aio_context = nbd_detach_aio_context,
|
|
|
|
.bdrv_attach_aio_context = nbd_attach_aio_context,
|
2014-07-19 02:24:59 +08:00
|
|
|
.bdrv_refresh_filename = nbd_refresh_filename,
|
2018-03-12 23:21:23 +08:00
|
|
|
.bdrv_co_block_status = nbd_client_co_block_status,
|
2012-11-04 20:04:24 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static BlockDriver bdrv_nbd_tcp = {
|
2014-05-08 22:34:43 +08:00
|
|
|
.format_name = "nbd",
|
|
|
|
.protocol_name = "nbd+tcp",
|
|
|
|
.instance_size = sizeof(BDRVNBDState),
|
|
|
|
.bdrv_parse_filename = nbd_parse_filename,
|
|
|
|
.bdrv_file_open = nbd_open,
|
2016-07-16 07:23:07 +08:00
|
|
|
.bdrv_co_preadv = nbd_client_co_preadv,
|
|
|
|
.bdrv_co_pwritev = nbd_client_co_pwritev,
|
2016-10-15 02:33:18 +08:00
|
|
|
.bdrv_co_pwrite_zeroes = nbd_client_co_pwrite_zeroes,
|
2014-05-08 22:34:43 +08:00
|
|
|
.bdrv_close = nbd_close,
|
|
|
|
.bdrv_co_flush_to_os = nbd_co_flush,
|
2016-07-16 07:23:02 +08:00
|
|
|
.bdrv_co_pdiscard = nbd_client_co_pdiscard,
|
2015-02-06 19:24:43 +08:00
|
|
|
.bdrv_refresh_limits = nbd_refresh_limits,
|
2014-05-08 22:34:43 +08:00
|
|
|
.bdrv_getlength = nbd_getlength,
|
|
|
|
.bdrv_detach_aio_context = nbd_detach_aio_context,
|
|
|
|
.bdrv_attach_aio_context = nbd_attach_aio_context,
|
2014-07-19 02:24:59 +08:00
|
|
|
.bdrv_refresh_filename = nbd_refresh_filename,
|
2018-03-12 23:21:23 +08:00
|
|
|
.bdrv_co_block_status = nbd_client_co_block_status,
|
2012-11-04 20:04:24 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static BlockDriver bdrv_nbd_unix = {
|
2014-05-08 22:34:43 +08:00
|
|
|
.format_name = "nbd",
|
|
|
|
.protocol_name = "nbd+unix",
|
|
|
|
.instance_size = sizeof(BDRVNBDState),
|
|
|
|
.bdrv_parse_filename = nbd_parse_filename,
|
|
|
|
.bdrv_file_open = nbd_open,
|
2016-07-16 07:23:07 +08:00
|
|
|
.bdrv_co_preadv = nbd_client_co_preadv,
|
|
|
|
.bdrv_co_pwritev = nbd_client_co_pwritev,
|
2016-10-15 02:33:18 +08:00
|
|
|
.bdrv_co_pwrite_zeroes = nbd_client_co_pwrite_zeroes,
|
2014-05-08 22:34:43 +08:00
|
|
|
.bdrv_close = nbd_close,
|
|
|
|
.bdrv_co_flush_to_os = nbd_co_flush,
|
2016-07-16 07:23:02 +08:00
|
|
|
.bdrv_co_pdiscard = nbd_client_co_pdiscard,
|
2015-02-06 19:24:43 +08:00
|
|
|
.bdrv_refresh_limits = nbd_refresh_limits,
|
2014-05-08 22:34:43 +08:00
|
|
|
.bdrv_getlength = nbd_getlength,
|
|
|
|
.bdrv_detach_aio_context = nbd_detach_aio_context,
|
|
|
|
.bdrv_attach_aio_context = nbd_attach_aio_context,
|
2014-07-19 02:24:59 +08:00
|
|
|
.bdrv_refresh_filename = nbd_refresh_filename,
|
2018-03-12 23:21:23 +08:00
|
|
|
.bdrv_co_block_status = nbd_client_co_block_status,
|
2008-07-03 21:41:03 +08:00
|
|
|
};
|
2009-05-10 06:03:42 +08:00
|
|
|
|
|
|
|
static void bdrv_nbd_init(void)
|
|
|
|
{
|
|
|
|
bdrv_register(&bdrv_nbd);
|
2012-11-04 20:04:24 +08:00
|
|
|
bdrv_register(&bdrv_nbd_tcp);
|
|
|
|
bdrv_register(&bdrv_nbd_unix);
|
2009-05-10 06:03:42 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
block_init(bdrv_nbd_init);
|