2015-01-09 16:04:38 +08:00
|
|
|
/*
|
|
|
|
* s390 PCI BUS
|
|
|
|
*
|
|
|
|
* Copyright 2014 IBM Corp.
|
|
|
|
* Author(s): Frank Blaschka <frank.blaschka@de.ibm.com>
|
|
|
|
* Hong Bo Li <lihbbj@cn.ibm.com>
|
|
|
|
* Yi Min Zhao <zyimin@cn.ibm.com>
|
|
|
|
*
|
|
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or (at
|
|
|
|
* your option) any later version. See the COPYING file in the top-level
|
|
|
|
* directory.
|
|
|
|
*/
|
|
|
|
|
2016-01-27 02:17:00 +08:00
|
|
|
#include "qemu/osdep.h"
|
2016-05-11 15:10:06 +08:00
|
|
|
#include "qapi/error.h"
|
|
|
|
#include "qapi/visitor.h"
|
2016-01-20 04:51:44 +08:00
|
|
|
#include "cpu.h"
|
2020-10-26 23:34:31 +08:00
|
|
|
#include "hw/s390x/s390-pci-bus.h"
|
|
|
|
#include "hw/s390x/s390-pci-inst.h"
|
2020-10-26 23:34:35 +08:00
|
|
|
#include "hw/s390x/s390-pci-vfio.h"
|
2016-06-23 01:11:19 +08:00
|
|
|
#include "hw/pci/pci_bus.h"
|
2019-08-12 13:23:51 +08:00
|
|
|
#include "hw/qdev-properties.h"
|
2016-10-24 20:50:35 +08:00
|
|
|
#include "hw/pci/pci_bridge.h"
|
2016-06-23 01:11:19 +08:00
|
|
|
#include "hw/pci/msi.h"
|
|
|
|
#include "qemu/error-report.h"
|
2019-05-23 22:35:07 +08:00
|
|
|
#include "qemu/module.h"
|
2015-01-09 16:04:38 +08:00
|
|
|
|
2017-04-01 21:56:30 +08:00
|
|
|
#ifndef DEBUG_S390PCI_BUS
|
|
|
|
#define DEBUG_S390PCI_BUS 0
|
2015-01-09 16:04:38 +08:00
|
|
|
#endif
|
|
|
|
|
2017-04-01 21:56:30 +08:00
|
|
|
#define DPRINTF(fmt, ...) \
|
|
|
|
do { \
|
|
|
|
if (DEBUG_S390PCI_BUS) { \
|
|
|
|
fprintf(stderr, "S390pci-bus: " fmt, ## __VA_ARGS__); \
|
|
|
|
} \
|
|
|
|
} while (0)
|
|
|
|
|
2016-11-23 11:08:29 +08:00
|
|
|
S390pciState *s390_get_phb(void)
|
2016-05-13 14:58:14 +08:00
|
|
|
{
|
|
|
|
static S390pciState *phb;
|
|
|
|
|
|
|
|
if (!phb) {
|
|
|
|
phb = S390_PCI_HOST_BRIDGE(
|
|
|
|
object_resolve_path(TYPE_S390_PCI_HOST_BRIDGE, NULL));
|
|
|
|
assert(phb != NULL);
|
|
|
|
}
|
|
|
|
|
|
|
|
return phb;
|
|
|
|
}
|
|
|
|
|
2017-07-06 22:40:21 +08:00
|
|
|
int pci_chsc_sei_nt2_get_event(void *res)
|
2015-01-09 16:04:38 +08:00
|
|
|
{
|
|
|
|
ChscSeiNt2Res *nt2_res = (ChscSeiNt2Res *)res;
|
|
|
|
PciCcdfAvail *accdf;
|
|
|
|
PciCcdfErr *eccdf;
|
|
|
|
int rc = 1;
|
|
|
|
SeiContainer *sei_cont;
|
2016-05-13 14:58:14 +08:00
|
|
|
S390pciState *s = s390_get_phb();
|
2015-01-09 16:04:38 +08:00
|
|
|
|
|
|
|
sei_cont = QTAILQ_FIRST(&s->pending_sei);
|
|
|
|
if (sei_cont) {
|
|
|
|
QTAILQ_REMOVE(&s->pending_sei, sei_cont, link);
|
|
|
|
nt2_res->nt = 2;
|
|
|
|
nt2_res->cc = sei_cont->cc;
|
2015-03-12 20:53:54 +08:00
|
|
|
nt2_res->length = cpu_to_be16(sizeof(ChscSeiNt2Res));
|
2015-01-09 16:04:38 +08:00
|
|
|
switch (sei_cont->cc) {
|
|
|
|
case 1: /* error event */
|
|
|
|
eccdf = (PciCcdfErr *)nt2_res->ccdf;
|
|
|
|
eccdf->fid = cpu_to_be32(sei_cont->fid);
|
|
|
|
eccdf->fh = cpu_to_be32(sei_cont->fh);
|
|
|
|
eccdf->e = cpu_to_be32(sei_cont->e);
|
|
|
|
eccdf->faddr = cpu_to_be64(sei_cont->faddr);
|
|
|
|
eccdf->pec = cpu_to_be16(sei_cont->pec);
|
|
|
|
break;
|
|
|
|
case 2: /* availability event */
|
|
|
|
accdf = (PciCcdfAvail *)nt2_res->ccdf;
|
|
|
|
accdf->fid = cpu_to_be32(sei_cont->fid);
|
|
|
|
accdf->fh = cpu_to_be32(sei_cont->fh);
|
|
|
|
accdf->pec = cpu_to_be16(sei_cont->pec);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
g_free(sei_cont);
|
|
|
|
rc = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2017-07-06 22:40:21 +08:00
|
|
|
int pci_chsc_sei_nt2_have_event(void)
|
2015-01-09 16:04:38 +08:00
|
|
|
{
|
2016-05-13 14:58:14 +08:00
|
|
|
S390pciState *s = s390_get_phb();
|
2015-01-09 16:04:38 +08:00
|
|
|
|
|
|
|
return !QTAILQ_EMPTY(&s->pending_sei);
|
|
|
|
}
|
|
|
|
|
2016-11-23 11:08:29 +08:00
|
|
|
S390PCIBusDevice *s390_pci_find_next_avail_dev(S390pciState *s,
|
|
|
|
S390PCIBusDevice *pbdev)
|
2016-06-03 15:16:01 +08:00
|
|
|
{
|
2016-11-15 15:51:38 +08:00
|
|
|
S390PCIBusDevice *ret = pbdev ? QTAILQ_NEXT(pbdev, link) :
|
|
|
|
QTAILQ_FIRST(&s->zpci_devs);
|
2016-06-03 15:16:01 +08:00
|
|
|
|
2016-11-15 15:51:38 +08:00
|
|
|
while (ret && ret->state == ZPCI_FS_RESERVED) {
|
|
|
|
ret = QTAILQ_NEXT(ret, link);
|
2016-06-03 15:16:01 +08:00
|
|
|
}
|
|
|
|
|
2016-11-15 15:51:38 +08:00
|
|
|
return ret;
|
2016-06-03 15:16:01 +08:00
|
|
|
}
|
|
|
|
|
2016-11-23 11:08:29 +08:00
|
|
|
S390PCIBusDevice *s390_pci_find_dev_by_fid(S390pciState *s, uint32_t fid)
|
2015-01-09 16:04:38 +08:00
|
|
|
{
|
|
|
|
S390PCIBusDevice *pbdev;
|
|
|
|
|
2016-11-15 15:51:38 +08:00
|
|
|
QTAILQ_FOREACH(pbdev, &s->zpci_devs, link) {
|
|
|
|
if (pbdev->fid == fid) {
|
2015-01-09 16:04:38 +08:00
|
|
|
return pbdev;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2016-04-28 12:33:53 +08:00
|
|
|
void s390_pci_sclp_configure(SCCB *sccb)
|
2015-01-09 16:04:38 +08:00
|
|
|
{
|
2017-07-06 23:13:14 +08:00
|
|
|
IoaCfgSccb *psccb = (IoaCfgSccb *)sccb;
|
2016-11-23 11:08:29 +08:00
|
|
|
S390PCIBusDevice *pbdev = s390_pci_find_dev_by_fid(s390_get_phb(),
|
|
|
|
be32_to_cpu(psccb->aid));
|
2015-01-09 16:04:38 +08:00
|
|
|
uint16_t rc;
|
|
|
|
|
2016-04-19 15:03:13 +08:00
|
|
|
if (!pbdev) {
|
2016-04-28 12:33:53 +08:00
|
|
|
DPRINTF("sclp config no dev found\n");
|
|
|
|
rc = SCLP_RC_ADAPTER_ID_NOT_RECOGNIZED;
|
2016-04-19 15:03:13 +08:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (pbdev->state) {
|
|
|
|
case ZPCI_FS_RESERVED:
|
|
|
|
rc = SCLP_RC_ADAPTER_IN_RESERVED_STATE;
|
|
|
|
break;
|
|
|
|
case ZPCI_FS_STANDBY:
|
|
|
|
pbdev->state = ZPCI_FS_DISABLED;
|
|
|
|
rc = SCLP_RC_NORMAL_COMPLETION;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
rc = SCLP_RC_NO_ACTION_REQUIRED;
|
2016-04-28 12:33:53 +08:00
|
|
|
}
|
2016-05-04 15:56:53 +08:00
|
|
|
out:
|
2016-04-28 12:33:53 +08:00
|
|
|
psccb->header.response_code = cpu_to_be16(rc);
|
|
|
|
}
|
|
|
|
|
s390x/pci: Introduce unplug requests and split unplug handler
PCI on s390x is really weird and how it was modeled in QEMU might not have
been the right choice. Anyhow, right now it is the case that:
- Hotplugging a PCI device will silently create a zPCI device
(if none is provided)
- Hotunplugging a zPCI device will unplug the PCI device (if any)
- Hotunplugging a PCI device will unplug also the zPCI device
As far as I can see, we can no longer change this behavior. But we
should fix it.
Both device types are handled via a single hotplug handler call. This
is problematic for various reasons:
1. Unplugging via the zPCI device allows to unplug devices that are not
hot removable. (check performed in qdev_unplug()) - bad.
2. Hotplug handler chains are not possible for the unplug case. In the
future, the machine might want to override hotplug handlers, to
process device specific stuff and to then branch off to the actual
hotplug handler. We need separate hotplug handler calls for both the
PCI and zPCI device to make this work reliably. All other PCI
implementations are already prepared to handle this correctly, only
s390x is missing.
Therefore, introduce the unplug_request handler and properly perform
unplug checks by redirecting to the separate unplug_request handlers.
When finally unplugging, perform two separate hotplug_handler_unplug()
calls, first for the PCI device, followed by the zPCI device. This now
nicely splits unplugging paths for both devices.
The redirect part is a little hairy, as the user is allowed to trigger
unplug either via the PCI or the zPCI device. So redirect always to the
PCI unplug request handler first and remember if that check has been
performed in the zPCI device. Redirect then to the zPCI device unplug
request handler to perform the magic. Remembering that we already
checked the PCI device breaks the redirect loop.
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190130155733.32742-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2019-01-30 23:57:31 +08:00
|
|
|
static void s390_pci_perform_unplug(S390PCIBusDevice *pbdev)
|
|
|
|
{
|
|
|
|
HotplugHandler *hotplug_ctrl;
|
|
|
|
|
|
|
|
/* Unplug the PCI device */
|
|
|
|
if (pbdev->pdev) {
|
qdev: Let the hotplug_handler_unplug() caller delete the device
When unplugging a device, at one point the device will be destroyed
via object_unparent(). This will, one the one hand, unrealize the
removed device hierarchy, and on the other hand, destroy/free the
device hierarchy.
When chaining hotplug handlers, we want to overwrite a bus hotplug
handler by the machine hotplug handler, to be able to perform
some part of the plug/unplug and to forward the calls to the bus hotplug
handler.
For now, the bus hotplug handler would trigger an object_unparent(), not
allowing us to perform some unplug action on a device after we forwarded
the call to the bus hotplug handler. The device would be gone at that
point.
machine_unplug_handler(dev)
/* eventually do unplug stuff */
bus_unplug_handler(dev)
/* dev is gone, we can't do more unplug stuff */
So move the object_unparent() to the original caller of the unplug. For
now, keep the unrealize() at the original places of the
object_unparent(). For implicitly chained hotplug handlers (e.g. pc
code calling acpi hotplug handlers), the object_unparent() has to be
done by the outermost caller. So when calling hotplug_handler_unplug()
from inside an unplug handler, nothing is to be done.
hotplug_handler_unplug(dev) -> calls machine_unplug_handler()
machine_unplug_handler(dev) {
/* eventually do unplug stuff */
bus_unplug_handler(dev) -> calls unrealize(dev)
/* we can do more unplug stuff but device already unrealized */
}
object_unparent(dev)
In the long run, every unplug action should be factored out of the
unrealize() function into the unplug handler (especially for PCI). Then
we can get rid of the additonal unrealize() calls and object_unparent()
will properly unrealize the device hierarchy after the device has been
unplugged.
hotplug_handler_unplug(dev) -> calls machine_unplug_handler()
machine_unplug_handler(dev) {
/* eventually do unplug stuff */
bus_unplug_handler(dev) -> only unplugs, does not unrealize
/* we can do more unplug stuff */
}
object_unparent(dev) -> will unrealize
The original approach was suggested by Igor Mammedov for the PCI
part, but I extended it to all hotplug handlers. I consider this one
step into the right direction.
To summarize:
- object_unparent() on synchronous unplugs is done by common code
-- "Caller of hotplug_handler_unplug"
- object_unparent() on asynchronous unplugs ("unplug requests") has to
be done manually
-- "Caller of hotplug_handler_unplug"
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190228122849.4296-2-david@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
2019-02-28 20:28:47 +08:00
|
|
|
DeviceState *pdev = DEVICE(pbdev->pdev);
|
|
|
|
|
|
|
|
hotplug_ctrl = qdev_get_hotplug_handler(pdev);
|
|
|
|
hotplug_handler_unplug(hotplug_ctrl, pdev, &error_abort);
|
|
|
|
object_unparent(OBJECT(pdev));
|
s390x/pci: Introduce unplug requests and split unplug handler
PCI on s390x is really weird and how it was modeled in QEMU might not have
been the right choice. Anyhow, right now it is the case that:
- Hotplugging a PCI device will silently create a zPCI device
(if none is provided)
- Hotunplugging a zPCI device will unplug the PCI device (if any)
- Hotunplugging a PCI device will unplug also the zPCI device
As far as I can see, we can no longer change this behavior. But we
should fix it.
Both device types are handled via a single hotplug handler call. This
is problematic for various reasons:
1. Unplugging via the zPCI device allows to unplug devices that are not
hot removable. (check performed in qdev_unplug()) - bad.
2. Hotplug handler chains are not possible for the unplug case. In the
future, the machine might want to override hotplug handlers, to
process device specific stuff and to then branch off to the actual
hotplug handler. We need separate hotplug handler calls for both the
PCI and zPCI device to make this work reliably. All other PCI
implementations are already prepared to handle this correctly, only
s390x is missing.
Therefore, introduce the unplug_request handler and properly perform
unplug checks by redirecting to the separate unplug_request handlers.
When finally unplugging, perform two separate hotplug_handler_unplug()
calls, first for the PCI device, followed by the zPCI device. This now
nicely splits unplugging paths for both devices.
The redirect part is a little hairy, as the user is allowed to trigger
unplug either via the PCI or the zPCI device. So redirect always to the
PCI unplug request handler first and remember if that check has been
performed in the zPCI device. Redirect then to the zPCI device unplug
request handler to perform the magic. Remembering that we already
checked the PCI device breaks the redirect loop.
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190130155733.32742-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2019-01-30 23:57:31 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Unplug the zPCI device */
|
|
|
|
hotplug_ctrl = qdev_get_hotplug_handler(DEVICE(pbdev));
|
|
|
|
hotplug_handler_unplug(hotplug_ctrl, DEVICE(pbdev), &error_abort);
|
qdev: Let the hotplug_handler_unplug() caller delete the device
When unplugging a device, at one point the device will be destroyed
via object_unparent(). This will, one the one hand, unrealize the
removed device hierarchy, and on the other hand, destroy/free the
device hierarchy.
When chaining hotplug handlers, we want to overwrite a bus hotplug
handler by the machine hotplug handler, to be able to perform
some part of the plug/unplug and to forward the calls to the bus hotplug
handler.
For now, the bus hotplug handler would trigger an object_unparent(), not
allowing us to perform some unplug action on a device after we forwarded
the call to the bus hotplug handler. The device would be gone at that
point.
machine_unplug_handler(dev)
/* eventually do unplug stuff */
bus_unplug_handler(dev)
/* dev is gone, we can't do more unplug stuff */
So move the object_unparent() to the original caller of the unplug. For
now, keep the unrealize() at the original places of the
object_unparent(). For implicitly chained hotplug handlers (e.g. pc
code calling acpi hotplug handlers), the object_unparent() has to be
done by the outermost caller. So when calling hotplug_handler_unplug()
from inside an unplug handler, nothing is to be done.
hotplug_handler_unplug(dev) -> calls machine_unplug_handler()
machine_unplug_handler(dev) {
/* eventually do unplug stuff */
bus_unplug_handler(dev) -> calls unrealize(dev)
/* we can do more unplug stuff but device already unrealized */
}
object_unparent(dev)
In the long run, every unplug action should be factored out of the
unrealize() function into the unplug handler (especially for PCI). Then
we can get rid of the additonal unrealize() calls and object_unparent()
will properly unrealize the device hierarchy after the device has been
unplugged.
hotplug_handler_unplug(dev) -> calls machine_unplug_handler()
machine_unplug_handler(dev) {
/* eventually do unplug stuff */
bus_unplug_handler(dev) -> only unplugs, does not unrealize
/* we can do more unplug stuff */
}
object_unparent(dev) -> will unrealize
The original approach was suggested by Igor Mammedov for the PCI
part, but I extended it to all hotplug handlers. I consider this one
step into the right direction.
To summarize:
- object_unparent() on synchronous unplugs is done by common code
-- "Caller of hotplug_handler_unplug"
- object_unparent() on asynchronous unplugs ("unplug requests") has to
be done manually
-- "Caller of hotplug_handler_unplug"
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190228122849.4296-2-david@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
2019-02-28 20:28:47 +08:00
|
|
|
object_unparent(OBJECT(pbdev));
|
s390x/pci: Introduce unplug requests and split unplug handler
PCI on s390x is really weird and how it was modeled in QEMU might not have
been the right choice. Anyhow, right now it is the case that:
- Hotplugging a PCI device will silently create a zPCI device
(if none is provided)
- Hotunplugging a zPCI device will unplug the PCI device (if any)
- Hotunplugging a PCI device will unplug also the zPCI device
As far as I can see, we can no longer change this behavior. But we
should fix it.
Both device types are handled via a single hotplug handler call. This
is problematic for various reasons:
1. Unplugging via the zPCI device allows to unplug devices that are not
hot removable. (check performed in qdev_unplug()) - bad.
2. Hotplug handler chains are not possible for the unplug case. In the
future, the machine might want to override hotplug handlers, to
process device specific stuff and to then branch off to the actual
hotplug handler. We need separate hotplug handler calls for both the
PCI and zPCI device to make this work reliably. All other PCI
implementations are already prepared to handle this correctly, only
s390x is missing.
Therefore, introduce the unplug_request handler and properly perform
unplug checks by redirecting to the separate unplug_request handlers.
When finally unplugging, perform two separate hotplug_handler_unplug()
calls, first for the PCI device, followed by the zPCI device. This now
nicely splits unplugging paths for both devices.
The redirect part is a little hairy, as the user is allowed to trigger
unplug either via the PCI or the zPCI device. So redirect always to the
PCI unplug request handler first and remember if that check has been
performed in the zPCI device. Redirect then to the zPCI device unplug
request handler to perform the magic. Remembering that we already
checked the PCI device breaks the redirect loop.
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190130155733.32742-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2019-01-30 23:57:31 +08:00
|
|
|
}
|
|
|
|
|
2016-04-28 12:33:53 +08:00
|
|
|
void s390_pci_sclp_deconfigure(SCCB *sccb)
|
|
|
|
{
|
2017-07-06 23:13:14 +08:00
|
|
|
IoaCfgSccb *psccb = (IoaCfgSccb *)sccb;
|
2016-11-23 11:08:29 +08:00
|
|
|
S390PCIBusDevice *pbdev = s390_pci_find_dev_by_fid(s390_get_phb(),
|
|
|
|
be32_to_cpu(psccb->aid));
|
2016-04-28 12:33:53 +08:00
|
|
|
uint16_t rc;
|
|
|
|
|
2016-04-19 15:03:13 +08:00
|
|
|
if (!pbdev) {
|
2016-04-28 12:33:53 +08:00
|
|
|
DPRINTF("sclp deconfig no dev found\n");
|
2015-01-09 16:04:38 +08:00
|
|
|
rc = SCLP_RC_ADAPTER_ID_NOT_RECOGNIZED;
|
2016-04-19 15:03:13 +08:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (pbdev->state) {
|
|
|
|
case ZPCI_FS_RESERVED:
|
|
|
|
rc = SCLP_RC_ADAPTER_IN_RESERVED_STATE;
|
|
|
|
break;
|
|
|
|
case ZPCI_FS_STANDBY:
|
|
|
|
rc = SCLP_RC_NO_ACTION_REQUIRED;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
if (pbdev->summary_ind) {
|
|
|
|
pci_dereg_irqs(pbdev);
|
|
|
|
}
|
2016-12-08 13:02:24 +08:00
|
|
|
if (pbdev->iommu->enabled) {
|
|
|
|
pci_dereg_ioat(pbdev->iommu);
|
2016-04-19 15:03:13 +08:00
|
|
|
}
|
|
|
|
pbdev->state = ZPCI_FS_STANDBY;
|
|
|
|
rc = SCLP_RC_NORMAL_COMPLETION;
|
2016-04-27 17:44:17 +08:00
|
|
|
|
2019-01-30 23:57:32 +08:00
|
|
|
if (pbdev->unplug_requested) {
|
s390x/pci: Introduce unplug requests and split unplug handler
PCI on s390x is really weird and how it was modeled in QEMU might not have
been the right choice. Anyhow, right now it is the case that:
- Hotplugging a PCI device will silently create a zPCI device
(if none is provided)
- Hotunplugging a zPCI device will unplug the PCI device (if any)
- Hotunplugging a PCI device will unplug also the zPCI device
As far as I can see, we can no longer change this behavior. But we
should fix it.
Both device types are handled via a single hotplug handler call. This
is problematic for various reasons:
1. Unplugging via the zPCI device allows to unplug devices that are not
hot removable. (check performed in qdev_unplug()) - bad.
2. Hotplug handler chains are not possible for the unplug case. In the
future, the machine might want to override hotplug handlers, to
process device specific stuff and to then branch off to the actual
hotplug handler. We need separate hotplug handler calls for both the
PCI and zPCI device to make this work reliably. All other PCI
implementations are already prepared to handle this correctly, only
s390x is missing.
Therefore, introduce the unplug_request handler and properly perform
unplug checks by redirecting to the separate unplug_request handlers.
When finally unplugging, perform two separate hotplug_handler_unplug()
calls, first for the PCI device, followed by the zPCI device. This now
nicely splits unplugging paths for both devices.
The redirect part is a little hairy, as the user is allowed to trigger
unplug either via the PCI or the zPCI device. So redirect always to the
PCI unplug request handler first and remember if that check has been
performed in the zPCI device. Redirect then to the zPCI device unplug
request handler to perform the magic. Remembering that we already
checked the PCI device breaks the redirect loop.
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190130155733.32742-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2019-01-30 23:57:31 +08:00
|
|
|
s390_pci_perform_unplug(pbdev);
|
2016-04-27 17:44:17 +08:00
|
|
|
}
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
2016-05-04 15:56:53 +08:00
|
|
|
out:
|
2015-01-09 16:04:38 +08:00
|
|
|
psccb->header.response_code = cpu_to_be16(rc);
|
|
|
|
}
|
|
|
|
|
2016-11-23 11:08:29 +08:00
|
|
|
static S390PCIBusDevice *s390_pci_find_dev_by_uid(S390pciState *s, uint16_t uid)
|
2016-05-11 15:10:06 +08:00
|
|
|
{
|
|
|
|
S390PCIBusDevice *pbdev;
|
|
|
|
|
2016-11-15 15:51:38 +08:00
|
|
|
QTAILQ_FOREACH(pbdev, &s->zpci_devs, link) {
|
2016-05-11 15:10:06 +08:00
|
|
|
if (pbdev->uid == uid) {
|
|
|
|
return pbdev;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2017-09-05 18:12:58 +08:00
|
|
|
S390PCIBusDevice *s390_pci_find_dev_by_target(S390pciState *s,
|
|
|
|
const char *target)
|
2016-05-11 15:10:06 +08:00
|
|
|
{
|
|
|
|
S390PCIBusDevice *pbdev;
|
|
|
|
|
|
|
|
if (!target) {
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2016-11-15 15:51:38 +08:00
|
|
|
QTAILQ_FOREACH(pbdev, &s->zpci_devs, link) {
|
2016-05-11 15:10:06 +08:00
|
|
|
if (!strcmp(pbdev->target, target)) {
|
|
|
|
return pbdev;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
s390x/pci: Introduce unplug requests and split unplug handler
PCI on s390x is really weird and how it was modeled in QEMU might not have
been the right choice. Anyhow, right now it is the case that:
- Hotplugging a PCI device will silently create a zPCI device
(if none is provided)
- Hotunplugging a zPCI device will unplug the PCI device (if any)
- Hotunplugging a PCI device will unplug also the zPCI device
As far as I can see, we can no longer change this behavior. But we
should fix it.
Both device types are handled via a single hotplug handler call. This
is problematic for various reasons:
1. Unplugging via the zPCI device allows to unplug devices that are not
hot removable. (check performed in qdev_unplug()) - bad.
2. Hotplug handler chains are not possible for the unplug case. In the
future, the machine might want to override hotplug handlers, to
process device specific stuff and to then branch off to the actual
hotplug handler. We need separate hotplug handler calls for both the
PCI and zPCI device to make this work reliably. All other PCI
implementations are already prepared to handle this correctly, only
s390x is missing.
Therefore, introduce the unplug_request handler and properly perform
unplug checks by redirecting to the separate unplug_request handlers.
When finally unplugging, perform two separate hotplug_handler_unplug()
calls, first for the PCI device, followed by the zPCI device. This now
nicely splits unplugging paths for both devices.
The redirect part is a little hairy, as the user is allowed to trigger
unplug either via the PCI or the zPCI device. So redirect always to the
PCI unplug request handler first and remember if that check has been
performed in the zPCI device. Redirect then to the zPCI device unplug
request handler to perform the magic. Remembering that we already
checked the PCI device breaks the redirect loop.
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190130155733.32742-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2019-01-30 23:57:31 +08:00
|
|
|
static S390PCIBusDevice *s390_pci_find_dev_by_pci(S390pciState *s,
|
|
|
|
PCIDevice *pci_dev)
|
|
|
|
{
|
|
|
|
S390PCIBusDevice *pbdev;
|
|
|
|
|
|
|
|
if (!pci_dev) {
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
QTAILQ_FOREACH(pbdev, &s->zpci_devs, link) {
|
|
|
|
if (pbdev->pdev == pci_dev) {
|
|
|
|
return pbdev;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2016-11-23 11:08:29 +08:00
|
|
|
S390PCIBusDevice *s390_pci_find_dev_by_idx(S390pciState *s, uint32_t idx)
|
2015-01-09 16:04:38 +08:00
|
|
|
{
|
2016-11-09 21:30:50 +08:00
|
|
|
return g_hash_table_lookup(s->zpci_table, &idx);
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
|
|
|
|
2016-11-23 11:08:29 +08:00
|
|
|
S390PCIBusDevice *s390_pci_find_dev_by_fh(S390pciState *s, uint32_t fh)
|
2015-01-09 16:04:38 +08:00
|
|
|
{
|
2016-11-09 21:30:50 +08:00
|
|
|
uint32_t idx = FH_MASK_INDEX & fh;
|
|
|
|
S390PCIBusDevice *pbdev = s390_pci_find_dev_by_idx(s, idx);
|
2015-01-09 16:04:38 +08:00
|
|
|
|
2016-11-09 21:30:50 +08:00
|
|
|
if (pbdev && pbdev->fh == fh) {
|
|
|
|
return pbdev;
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void s390_pci_generate_event(uint8_t cc, uint16_t pec, uint32_t fh,
|
|
|
|
uint32_t fid, uint64_t faddr, uint32_t e)
|
|
|
|
{
|
2015-01-20 17:56:37 +08:00
|
|
|
SeiContainer *sei_cont;
|
2016-05-13 14:58:14 +08:00
|
|
|
S390pciState *s = s390_get_phb();
|
2015-01-09 16:04:38 +08:00
|
|
|
|
2017-10-07 07:49:21 +08:00
|
|
|
sei_cont = g_new0(SeiContainer, 1);
|
2015-01-09 16:04:38 +08:00
|
|
|
sei_cont->fh = fh;
|
|
|
|
sei_cont->fid = fid;
|
|
|
|
sei_cont->cc = cc;
|
|
|
|
sei_cont->pec = pec;
|
|
|
|
sei_cont->faddr = faddr;
|
|
|
|
sei_cont->e = e;
|
|
|
|
|
|
|
|
QTAILQ_INSERT_TAIL(&s->pending_sei, sei_cont, link);
|
|
|
|
css_generate_css_crws(0);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void s390_pci_generate_plug_event(uint16_t pec, uint32_t fh,
|
|
|
|
uint32_t fid)
|
|
|
|
{
|
|
|
|
s390_pci_generate_event(2, pec, fh, fid, 0, 0);
|
|
|
|
}
|
|
|
|
|
2016-04-19 15:03:13 +08:00
|
|
|
void s390_pci_generate_error_event(uint16_t pec, uint32_t fh, uint32_t fid,
|
|
|
|
uint64_t faddr, uint32_t e)
|
2015-01-09 16:04:38 +08:00
|
|
|
{
|
|
|
|
s390_pci_generate_event(1, pec, fh, fid, faddr, e);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void s390_pci_set_irq(void *opaque, int irq, int level)
|
|
|
|
{
|
|
|
|
/* nothing to do */
|
|
|
|
}
|
|
|
|
|
|
|
|
static int s390_pci_map_irq(PCIDevice *pci_dev, int irq_num)
|
|
|
|
{
|
|
|
|
/* nothing to do */
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static uint64_t s390_pci_get_table_origin(uint64_t iota)
|
|
|
|
{
|
|
|
|
return iota & ~ZPCI_IOTA_RTTO_FLAG;
|
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned int calc_rtx(dma_addr_t ptr)
|
|
|
|
{
|
|
|
|
return ((unsigned long) ptr >> ZPCI_RT_SHIFT) & ZPCI_INDEX_MASK;
|
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned int calc_sx(dma_addr_t ptr)
|
|
|
|
{
|
|
|
|
return ((unsigned long) ptr >> ZPCI_ST_SHIFT) & ZPCI_INDEX_MASK;
|
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned int calc_px(dma_addr_t ptr)
|
|
|
|
{
|
|
|
|
return ((unsigned long) ptr >> PAGE_SHIFT) & ZPCI_PT_MASK;
|
|
|
|
}
|
|
|
|
|
|
|
|
static uint64_t get_rt_sto(uint64_t entry)
|
|
|
|
{
|
|
|
|
return ((entry & ZPCI_TABLE_TYPE_MASK) == ZPCI_TABLE_TYPE_RTX)
|
|
|
|
? (entry & ZPCI_RTE_ADDR_MASK)
|
|
|
|
: 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static uint64_t get_st_pto(uint64_t entry)
|
|
|
|
{
|
|
|
|
return ((entry & ZPCI_TABLE_TYPE_MASK) == ZPCI_TABLE_TYPE_SX)
|
|
|
|
? (entry & ZPCI_STE_ADDR_MASK)
|
|
|
|
: 0;
|
|
|
|
}
|
|
|
|
|
2018-02-05 15:22:56 +08:00
|
|
|
static bool rt_entry_isvalid(uint64_t entry)
|
|
|
|
{
|
|
|
|
return (entry & ZPCI_TABLE_VALID_MASK) == ZPCI_TABLE_VALID;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool pt_entry_isvalid(uint64_t entry)
|
|
|
|
{
|
|
|
|
return (entry & ZPCI_PTE_VALID_MASK) == ZPCI_PTE_VALID;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool entry_isprotected(uint64_t entry)
|
|
|
|
{
|
|
|
|
return (entry & ZPCI_TABLE_PROT_MASK) == ZPCI_TABLE_PROTECTED;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* ett is expected table type, -1 page table, 0 segment table, 1 region table */
|
|
|
|
static uint64_t get_table_index(uint64_t iova, int8_t ett)
|
|
|
|
{
|
|
|
|
switch (ett) {
|
|
|
|
case ZPCI_ETT_PT:
|
|
|
|
return calc_px(iova);
|
|
|
|
case ZPCI_ETT_ST:
|
|
|
|
return calc_sx(iova);
|
|
|
|
case ZPCI_ETT_RT:
|
|
|
|
return calc_rtx(iova);
|
|
|
|
}
|
|
|
|
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool entry_isvalid(uint64_t entry, int8_t ett)
|
|
|
|
{
|
|
|
|
switch (ett) {
|
|
|
|
case ZPCI_ETT_PT:
|
|
|
|
return pt_entry_isvalid(entry);
|
|
|
|
case ZPCI_ETT_ST:
|
|
|
|
case ZPCI_ETT_RT:
|
|
|
|
return rt_entry_isvalid(entry);
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Return true if address translation is done */
|
|
|
|
static bool translate_iscomplete(uint64_t entry, int8_t ett)
|
|
|
|
{
|
|
|
|
switch (ett) {
|
|
|
|
case 0:
|
|
|
|
return (entry & ZPCI_TABLE_FC) ? true : false;
|
|
|
|
case 1:
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
static uint64_t get_frame_size(int8_t ett)
|
|
|
|
{
|
|
|
|
switch (ett) {
|
|
|
|
case ZPCI_ETT_PT:
|
|
|
|
return 1ULL << 12;
|
|
|
|
case ZPCI_ETT_ST:
|
|
|
|
return 1ULL << 20;
|
|
|
|
case ZPCI_ETT_RT:
|
|
|
|
return 1ULL << 31;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static uint64_t get_next_table_origin(uint64_t entry, int8_t ett)
|
|
|
|
{
|
|
|
|
switch (ett) {
|
|
|
|
case ZPCI_ETT_PT:
|
|
|
|
return entry & ZPCI_PTE_ADDR_MASK;
|
|
|
|
case ZPCI_ETT_ST:
|
|
|
|
return get_st_pto(entry);
|
|
|
|
case ZPCI_ETT_RT:
|
|
|
|
return get_rt_sto(entry);
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* table_translate: do translation within one table and return the following
|
|
|
|
* table origin
|
|
|
|
*
|
|
|
|
* @entry: the entry being translated, the result is stored in this.
|
|
|
|
* @to: the address of table origin.
|
|
|
|
* @ett: expected table type, 1 region table, 0 segment table and -1 page table.
|
|
|
|
* @error: error code
|
|
|
|
*/
|
|
|
|
static uint64_t table_translate(S390IOTLBEntry *entry, uint64_t to, int8_t ett,
|
|
|
|
uint16_t *error)
|
|
|
|
{
|
|
|
|
uint64_t tx, te, nto = 0;
|
|
|
|
uint16_t err = 0;
|
|
|
|
|
|
|
|
tx = get_table_index(entry->iova, ett);
|
|
|
|
te = address_space_ldq(&address_space_memory, to + tx * sizeof(uint64_t),
|
|
|
|
MEMTXATTRS_UNSPECIFIED, NULL);
|
|
|
|
|
|
|
|
if (!te) {
|
|
|
|
err = ERR_EVENT_INVALTE;
|
2015-01-09 16:04:38 +08:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2018-02-05 15:22:56 +08:00
|
|
|
if (!entry_isvalid(te, ett)) {
|
|
|
|
entry->perm &= IOMMU_NONE;
|
2015-01-09 16:04:38 +08:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2018-02-05 15:22:56 +08:00
|
|
|
if (ett == ZPCI_ETT_RT && ((te & ZPCI_TABLE_LEN_RTX) != ZPCI_TABLE_LEN_RTX
|
|
|
|
|| te & ZPCI_TABLE_OFFSET_MASK)) {
|
|
|
|
err = ERR_EVENT_INVALTL;
|
|
|
|
goto out;
|
|
|
|
}
|
2015-01-09 16:04:38 +08:00
|
|
|
|
2018-02-05 15:22:56 +08:00
|
|
|
nto = get_next_table_origin(te, ett);
|
|
|
|
if (!nto) {
|
|
|
|
err = ERR_EVENT_TT;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (entry_isprotected(te)) {
|
|
|
|
entry->perm &= IOMMU_RO;
|
|
|
|
} else {
|
|
|
|
entry->perm &= IOMMU_RW;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (translate_iscomplete(te, ett)) {
|
|
|
|
switch (ett) {
|
|
|
|
case ZPCI_ETT_PT:
|
|
|
|
entry->translated_addr = te & ZPCI_PTE_ADDR_MASK;
|
|
|
|
break;
|
|
|
|
case ZPCI_ETT_ST:
|
|
|
|
entry->translated_addr = (te & ZPCI_SFAA_MASK) |
|
|
|
|
(entry->iova & ~ZPCI_SFAA_MASK);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
nto = 0;
|
|
|
|
}
|
2015-01-09 16:04:38 +08:00
|
|
|
out:
|
2018-02-05 15:22:56 +08:00
|
|
|
if (err) {
|
|
|
|
entry->perm = IOMMU_NONE;
|
|
|
|
*error = err;
|
|
|
|
}
|
|
|
|
entry->len = get_frame_size(ett);
|
|
|
|
return nto;
|
|
|
|
}
|
|
|
|
|
|
|
|
uint16_t s390_guest_io_table_walk(uint64_t g_iota, hwaddr addr,
|
|
|
|
S390IOTLBEntry *entry)
|
|
|
|
{
|
|
|
|
uint64_t to = s390_pci_get_table_origin(g_iota);
|
|
|
|
int8_t ett = 1;
|
|
|
|
uint16_t error = 0;
|
|
|
|
|
|
|
|
entry->iova = addr & PAGE_MASK;
|
|
|
|
entry->translated_addr = 0;
|
|
|
|
entry->perm = IOMMU_RW;
|
|
|
|
|
|
|
|
if (entry_isprotected(g_iota)) {
|
|
|
|
entry->perm &= IOMMU_RO;
|
|
|
|
}
|
|
|
|
|
|
|
|
while (to) {
|
|
|
|
to = table_translate(entry, to, ett--, &error);
|
|
|
|
}
|
|
|
|
|
|
|
|
return error;
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
|
|
|
|
2017-07-11 11:56:19 +08:00
|
|
|
static IOMMUTLBEntry s390_translate_iommu(IOMMUMemoryRegion *mr, hwaddr addr,
|
2018-06-15 21:57:16 +08:00
|
|
|
IOMMUAccessFlags flag, int iommu_idx)
|
2015-01-09 16:04:38 +08:00
|
|
|
{
|
2016-12-08 13:02:24 +08:00
|
|
|
S390PCIIOMMU *iommu = container_of(mr, S390PCIIOMMU, iommu_mr);
|
2018-02-05 15:22:57 +08:00
|
|
|
S390IOTLBEntry *entry;
|
|
|
|
uint64_t iova = addr & PAGE_MASK;
|
2018-02-05 15:22:56 +08:00
|
|
|
uint16_t error = 0;
|
2015-01-09 16:04:38 +08:00
|
|
|
IOMMUTLBEntry ret = {
|
|
|
|
.target_as = &address_space_memory,
|
|
|
|
.iova = 0,
|
|
|
|
.translated_addr = 0,
|
|
|
|
.addr_mask = ~(hwaddr)0,
|
|
|
|
.perm = IOMMU_NONE,
|
|
|
|
};
|
|
|
|
|
2016-12-08 13:02:24 +08:00
|
|
|
switch (iommu->pbdev->state) {
|
2016-04-19 15:03:13 +08:00
|
|
|
case ZPCI_FS_ENABLED:
|
|
|
|
case ZPCI_FS_BLOCKED:
|
2016-12-08 13:02:24 +08:00
|
|
|
if (!iommu->enabled) {
|
2016-04-19 15:03:13 +08:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
default:
|
2015-10-28 11:30:23 +08:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2015-01-09 16:04:38 +08:00
|
|
|
DPRINTF("iommu trans addr 0x%" PRIx64 "\n", addr);
|
|
|
|
|
2016-12-08 13:02:24 +08:00
|
|
|
if (addr < iommu->pba || addr > iommu->pal) {
|
2018-02-05 15:22:56 +08:00
|
|
|
error = ERR_EVENT_OORANGE;
|
|
|
|
goto err;
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
|
|
|
|
2018-02-05 15:22:57 +08:00
|
|
|
entry = g_hash_table_lookup(iommu->iotlb, &iova);
|
|
|
|
if (entry) {
|
|
|
|
ret.iova = entry->iova;
|
|
|
|
ret.translated_addr = entry->translated_addr;
|
|
|
|
ret.addr_mask = entry->len - 1;
|
|
|
|
ret.perm = entry->perm;
|
|
|
|
} else {
|
|
|
|
ret.iova = iova;
|
|
|
|
ret.addr_mask = ~PAGE_MASK;
|
|
|
|
ret.perm = IOMMU_NONE;
|
|
|
|
}
|
2015-01-09 16:04:38 +08:00
|
|
|
|
2018-02-05 15:22:56 +08:00
|
|
|
if (flag != IOMMU_NONE && !(flag & ret.perm)) {
|
|
|
|
error = ERR_EVENT_TPROTE;
|
|
|
|
}
|
|
|
|
err:
|
|
|
|
if (error) {
|
|
|
|
iommu->pbdev->state = ZPCI_FS_ERROR;
|
|
|
|
s390_pci_generate_error_event(error, iommu->pbdev->fh,
|
|
|
|
iommu->pbdev->fid, addr, 0);
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2017-09-05 18:13:00 +08:00
|
|
|
static void s390_pci_iommu_replay(IOMMUMemoryRegion *iommu,
|
|
|
|
IOMMUNotifier *notifier)
|
|
|
|
{
|
|
|
|
/* It's impossible to plug a pci device on s390x that already has iommu
|
|
|
|
* mappings which need to be replayed, that is due to the "one iommu per
|
|
|
|
* zpci device" construct. But when we support migration of vfio-pci
|
|
|
|
* devices in future, we need to revisit this.
|
|
|
|
*/
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2016-12-08 13:03:18 +08:00
|
|
|
static S390PCIIOMMU *s390_pci_get_iommu(S390pciState *s, PCIBus *bus,
|
|
|
|
int devfn)
|
|
|
|
{
|
|
|
|
uint64_t key = (uintptr_t)bus;
|
|
|
|
S390PCIIOMMUTable *table = g_hash_table_lookup(s->iommu_table, &key);
|
|
|
|
S390PCIIOMMU *iommu;
|
|
|
|
|
|
|
|
if (!table) {
|
2017-10-07 07:49:21 +08:00
|
|
|
table = g_new0(S390PCIIOMMUTable, 1);
|
2016-12-08 13:03:18 +08:00
|
|
|
table->key = key;
|
|
|
|
g_hash_table_insert(s->iommu_table, &table->key, table);
|
|
|
|
}
|
|
|
|
|
|
|
|
iommu = table->iommu[PCI_SLOT(devfn)];
|
|
|
|
if (!iommu) {
|
|
|
|
iommu = S390_PCI_IOMMU(object_new(TYPE_S390_PCI_IOMMU));
|
|
|
|
|
|
|
|
char *mr_name = g_strdup_printf("iommu-root-%02x:%02x.%01x",
|
|
|
|
pci_bus_num(bus),
|
|
|
|
PCI_SLOT(devfn),
|
|
|
|
PCI_FUNC(devfn));
|
|
|
|
char *as_name = g_strdup_printf("iommu-pci-%02x:%02x.%01x",
|
|
|
|
pci_bus_num(bus),
|
|
|
|
PCI_SLOT(devfn),
|
|
|
|
PCI_FUNC(devfn));
|
|
|
|
memory_region_init(&iommu->mr, OBJECT(iommu), mr_name, UINT64_MAX);
|
|
|
|
address_space_init(&iommu->as, &iommu->mr, as_name);
|
2018-02-05 15:22:57 +08:00
|
|
|
iommu->iotlb = g_hash_table_new_full(g_int64_hash, g_int64_equal,
|
|
|
|
NULL, g_free);
|
2016-12-08 13:03:18 +08:00
|
|
|
table->iommu[PCI_SLOT(devfn)] = iommu;
|
|
|
|
|
|
|
|
g_free(mr_name);
|
|
|
|
g_free(as_name);
|
|
|
|
}
|
|
|
|
|
|
|
|
return iommu;
|
|
|
|
}
|
|
|
|
|
2015-01-09 16:04:38 +08:00
|
|
|
static AddressSpace *s390_pci_dma_iommu(PCIBus *bus, void *opaque, int devfn)
|
|
|
|
{
|
|
|
|
S390pciState *s = opaque;
|
2016-12-08 13:03:18 +08:00
|
|
|
S390PCIIOMMU *iommu = s390_pci_get_iommu(s, bus, devfn);
|
2015-01-09 16:04:38 +08:00
|
|
|
|
2016-12-08 13:03:18 +08:00
|
|
|
return &iommu->as;
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static uint8_t set_ind_atomic(uint64_t ind_loc, uint8_t to_be_set)
|
|
|
|
{
|
2020-06-16 12:50:35 +08:00
|
|
|
uint8_t expected, actual;
|
2015-01-09 16:04:38 +08:00
|
|
|
hwaddr len = 1;
|
2020-06-16 12:50:35 +08:00
|
|
|
/* avoid multiple fetches */
|
|
|
|
uint8_t volatile *ind_addr;
|
2015-01-09 16:04:38 +08:00
|
|
|
|
2020-02-20 03:20:42 +08:00
|
|
|
ind_addr = cpu_physical_memory_map(ind_loc, &len, true);
|
2015-01-09 16:04:38 +08:00
|
|
|
if (!ind_addr) {
|
|
|
|
s390_pci_generate_error_event(ERR_EVENT_AIRERR, 0, 0, 0, 0);
|
|
|
|
return -1;
|
|
|
|
}
|
2020-06-16 12:50:35 +08:00
|
|
|
actual = *ind_addr;
|
2015-01-09 16:04:38 +08:00
|
|
|
do {
|
2020-06-16 12:50:35 +08:00
|
|
|
expected = actual;
|
2020-09-23 18:56:46 +08:00
|
|
|
actual = qatomic_cmpxchg(ind_addr, expected, expected | to_be_set);
|
2020-06-16 12:50:35 +08:00
|
|
|
} while (actual != expected);
|
|
|
|
cpu_physical_memory_unmap((void *)ind_addr, len, 1, len);
|
2015-01-09 16:04:38 +08:00
|
|
|
|
2020-06-16 12:50:35 +08:00
|
|
|
return actual;
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void s390_msi_ctrl_write(void *opaque, hwaddr addr, uint64_t data,
|
|
|
|
unsigned int size)
|
|
|
|
{
|
2016-09-06 14:00:44 +08:00
|
|
|
S390PCIBusDevice *pbdev = opaque;
|
2015-01-09 16:04:38 +08:00
|
|
|
uint32_t vec = data & ZPCI_MSI_VEC_MASK;
|
|
|
|
uint64_t ind_bit;
|
|
|
|
uint32_t sum_bit;
|
|
|
|
|
2017-09-05 18:12:58 +08:00
|
|
|
assert(pbdev);
|
|
|
|
DPRINTF("write_msix data 0x%" PRIx64 " idx %d vec 0x%x\n", data,
|
|
|
|
pbdev->idx, vec);
|
2015-01-09 16:04:38 +08:00
|
|
|
|
2016-04-19 15:03:13 +08:00
|
|
|
if (pbdev->state != ZPCI_FS_ENABLED) {
|
2015-12-14 16:50:44 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2015-01-09 16:04:38 +08:00
|
|
|
ind_bit = pbdev->routes.adapter.ind_offset;
|
|
|
|
sum_bit = pbdev->routes.adapter.summary_offset;
|
|
|
|
|
|
|
|
set_ind_atomic(pbdev->routes.adapter.ind_addr + (ind_bit + vec) / 8,
|
|
|
|
0x80 >> ((ind_bit + vec) % 8));
|
|
|
|
if (!set_ind_atomic(pbdev->routes.adapter.summary_addr + sum_bit / 8,
|
|
|
|
0x80 >> (sum_bit % 8))) {
|
2017-02-17 15:26:48 +08:00
|
|
|
css_adapter_interrupt(CSS_IO_ADAPTER_PCI, pbdev->isc);
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static uint64_t s390_msi_ctrl_read(void *opaque, hwaddr addr, unsigned size)
|
|
|
|
{
|
|
|
|
return 0xffffffff;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const MemoryRegionOps s390_msi_ctrl_ops = {
|
|
|
|
.write = s390_msi_ctrl_write,
|
|
|
|
.read = s390_msi_ctrl_read,
|
|
|
|
.endianness = DEVICE_LITTLE_ENDIAN,
|
|
|
|
};
|
|
|
|
|
2016-12-08 13:02:24 +08:00
|
|
|
void s390_pci_iommu_enable(S390PCIIOMMU *iommu)
|
2015-11-04 15:50:45 +08:00
|
|
|
{
|
2019-09-26 22:10:36 +08:00
|
|
|
/*
|
|
|
|
* The iommu region is initialized against a 0-mapped address space,
|
|
|
|
* so the smallest IOMMU region we can define runs from 0 to the end
|
|
|
|
* of the PCI address space.
|
|
|
|
*/
|
2016-12-08 13:02:24 +08:00
|
|
|
char *name = g_strdup_printf("iommu-s390-%04x", iommu->pbdev->uid);
|
2017-07-11 11:56:20 +08:00
|
|
|
memory_region_init_iommu(&iommu->iommu_mr, sizeof(iommu->iommu_mr),
|
|
|
|
TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),
|
2019-09-26 22:10:36 +08:00
|
|
|
name, iommu->pal + 1);
|
2016-12-08 13:02:24 +08:00
|
|
|
iommu->enabled = true;
|
2017-07-11 11:56:19 +08:00
|
|
|
memory_region_add_subregion(&iommu->mr, 0, MEMORY_REGION(&iommu->iommu_mr));
|
2016-12-08 13:02:24 +08:00
|
|
|
g_free(name);
|
2016-05-04 15:06:44 +08:00
|
|
|
}
|
2015-11-04 15:50:45 +08:00
|
|
|
|
2016-12-08 13:02:24 +08:00
|
|
|
void s390_pci_iommu_disable(S390PCIIOMMU *iommu)
|
2016-05-04 15:06:44 +08:00
|
|
|
{
|
2016-12-08 13:02:24 +08:00
|
|
|
iommu->enabled = false;
|
2018-02-05 15:22:57 +08:00
|
|
|
g_hash_table_remove_all(iommu->iotlb);
|
2017-07-11 11:56:19 +08:00
|
|
|
memory_region_del_subregion(&iommu->mr, MEMORY_REGION(&iommu->iommu_mr));
|
2016-12-08 13:02:24 +08:00
|
|
|
object_unparent(OBJECT(&iommu->iommu_mr));
|
2015-11-04 15:50:45 +08:00
|
|
|
}
|
|
|
|
|
2016-11-23 11:08:29 +08:00
|
|
|
static void s390_pci_iommu_free(S390pciState *s, PCIBus *bus, int32_t devfn)
|
2015-01-09 16:04:38 +08:00
|
|
|
{
|
2016-12-08 13:03:18 +08:00
|
|
|
uint64_t key = (uintptr_t)bus;
|
|
|
|
S390PCIIOMMUTable *table = g_hash_table_lookup(s->iommu_table, &key);
|
|
|
|
S390PCIIOMMU *iommu = table ? table->iommu[PCI_SLOT(devfn)] : NULL;
|
2015-01-09 16:04:38 +08:00
|
|
|
|
2016-12-08 13:03:18 +08:00
|
|
|
if (!table || !iommu) {
|
|
|
|
return;
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
2016-12-08 13:03:18 +08:00
|
|
|
|
|
|
|
table->iommu[PCI_SLOT(devfn)] = NULL;
|
2018-02-05 15:22:57 +08:00
|
|
|
g_hash_table_destroy(iommu->iotlb);
|
2016-12-08 13:03:18 +08:00
|
|
|
address_space_destroy(&iommu->as);
|
|
|
|
object_unparent(OBJECT(&iommu->mr));
|
|
|
|
object_unparent(OBJECT(iommu));
|
|
|
|
object_unref(OBJECT(iommu));
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
|
|
|
|
2018-10-02 15:48:11 +08:00
|
|
|
static void s390_pcihost_realize(DeviceState *dev, Error **errp)
|
2015-01-09 16:04:38 +08:00
|
|
|
{
|
|
|
|
PCIBus *b;
|
|
|
|
BusState *bus;
|
|
|
|
PCIHostState *phb = PCI_HOST_BRIDGE(dev);
|
|
|
|
S390pciState *s = S390_PCI_HOST_BRIDGE(dev);
|
|
|
|
|
|
|
|
DPRINTF("host_init\n");
|
|
|
|
|
2018-10-02 15:48:11 +08:00
|
|
|
b = pci_register_root_bus(dev, NULL, s390_pci_set_irq, s390_pci_map_irq,
|
|
|
|
NULL, get_system_memory(), get_system_io(), 0,
|
|
|
|
64, TYPE_PCI_BUS);
|
2015-01-09 16:04:38 +08:00
|
|
|
pci_setup_iommu(b, s390_pci_dma_iommu, s);
|
|
|
|
|
|
|
|
bus = BUS(b);
|
qdev: Drop qbus_set_hotplug_handler() parameter @errp
qbus_set_hotplug_handler() is a simple wrapper around
object_property_set_link().
object_property_set_link() fails when the property doesn't exist, is
not settable, or its .check() method fails. These are all programming
errors here, so passing &error_abort to qbus_set_hotplug_handler() is
appropriate.
Most of its callers do. Exceptions:
* pcie_cap_slot_init(), shpc_init(), spapr_phb_realize() pass NULL,
i.e. they ignore errors.
* spapr_machine_init() passes &error_fatal.
* s390_pcihost_realize(), virtio_serial_device_realize(),
s390_pcihost_plug() pass the error to their callers. The latter two
keep going after the error, which looks wrong.
Drop the @errp parameter, and instead pass &error_abort to
object_property_set_link().
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200630090351.1247703-15-armbru@redhat.com>
2020-06-30 17:03:39 +08:00
|
|
|
qbus_set_hotplug_handler(bus, OBJECT(dev));
|
2015-01-09 16:04:38 +08:00
|
|
|
phb->bus = b;
|
2016-04-14 19:02:39 +08:00
|
|
|
|
2018-10-02 15:48:11 +08:00
|
|
|
s->bus = S390_PCI_BUS(qbus_create(TYPE_S390_PCI_BUS, dev, NULL));
|
qdev: Drop qbus_set_hotplug_handler() parameter @errp
qbus_set_hotplug_handler() is a simple wrapper around
object_property_set_link().
object_property_set_link() fails when the property doesn't exist, is
not settable, or its .check() method fails. These are all programming
errors here, so passing &error_abort to qbus_set_hotplug_handler() is
appropriate.
Most of its callers do. Exceptions:
* pcie_cap_slot_init(), shpc_init(), spapr_phb_realize() pass NULL,
i.e. they ignore errors.
* spapr_machine_init() passes &error_fatal.
* s390_pcihost_realize(), virtio_serial_device_realize(),
s390_pcihost_plug() pass the error to their callers. The latter two
keep going after the error, which looks wrong.
Drop the @errp parameter, and instead pass &error_abort to
object_property_set_link().
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200630090351.1247703-15-armbru@redhat.com>
2020-06-30 17:03:39 +08:00
|
|
|
qbus_set_hotplug_handler(BUS(s->bus), OBJECT(dev));
|
2016-04-14 19:02:39 +08:00
|
|
|
|
2016-12-08 13:03:18 +08:00
|
|
|
s->iommu_table = g_hash_table_new_full(g_int64_hash, g_int64_equal,
|
|
|
|
NULL, g_free);
|
2016-11-09 21:30:50 +08:00
|
|
|
s->zpci_table = g_hash_table_new_full(g_int_hash, g_int_equal, NULL, NULL);
|
2016-11-23 14:26:34 +08:00
|
|
|
s->bus_no = 0;
|
2015-01-09 16:04:38 +08:00
|
|
|
QTAILQ_INIT(&s->pending_sei);
|
2016-11-15 15:51:38 +08:00
|
|
|
QTAILQ_INIT(&s->zpci_devs);
|
2020-10-26 23:34:35 +08:00
|
|
|
QTAILQ_INIT(&s->zpci_dma_limit);
|
2016-11-24 18:10:39 +08:00
|
|
|
|
2017-03-07 11:07:44 +08:00
|
|
|
css_register_io_adapters(CSS_IO_ADAPTER_PCI, true, false,
|
2020-07-08 00:06:04 +08:00
|
|
|
S390_ADAPTER_SUPPRESSIBLE, errp);
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
|
|
|
|
2016-12-13 18:31:25 +08:00
|
|
|
static int s390_pci_msix_init(S390PCIBusDevice *pbdev)
|
2015-01-09 16:04:38 +08:00
|
|
|
{
|
2016-12-13 18:31:25 +08:00
|
|
|
char *name;
|
2015-01-09 16:04:38 +08:00
|
|
|
uint8_t pos;
|
|
|
|
uint16_t ctrl;
|
|
|
|
uint32_t table, pba;
|
|
|
|
|
|
|
|
pos = pci_find_capability(pbdev->pdev, PCI_CAP_ID_MSIX);
|
|
|
|
if (!pos) {
|
2016-12-13 18:31:25 +08:00
|
|
|
return -1;
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
|
|
|
|
2016-02-19 23:18:11 +08:00
|
|
|
ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_FLAGS,
|
2015-01-09 16:04:38 +08:00
|
|
|
pci_config_size(pbdev->pdev), sizeof(ctrl));
|
|
|
|
table = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_TABLE,
|
|
|
|
pci_config_size(pbdev->pdev), sizeof(table));
|
|
|
|
pba = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_PBA,
|
|
|
|
pci_config_size(pbdev->pdev), sizeof(pba));
|
|
|
|
|
|
|
|
pbdev->msix.table_bar = table & PCI_MSIX_FLAGS_BIRMASK;
|
|
|
|
pbdev->msix.table_offset = table & ~PCI_MSIX_FLAGS_BIRMASK;
|
|
|
|
pbdev->msix.pba_bar = pba & PCI_MSIX_FLAGS_BIRMASK;
|
|
|
|
pbdev->msix.pba_offset = pba & ~PCI_MSIX_FLAGS_BIRMASK;
|
|
|
|
pbdev->msix.entries = (ctrl & PCI_MSIX_FLAGS_QSIZE) + 1;
|
2016-09-06 14:00:44 +08:00
|
|
|
|
|
|
|
name = g_strdup_printf("msix-s390-%04x", pbdev->uid);
|
|
|
|
memory_region_init_io(&pbdev->msix_notify_mr, OBJECT(pbdev),
|
|
|
|
&s390_msi_ctrl_ops, pbdev, name, PAGE_SIZE);
|
|
|
|
memory_region_add_subregion(&pbdev->iommu->mr, ZPCI_MSI_ADDR,
|
|
|
|
&pbdev->msix_notify_mr);
|
|
|
|
g_free(name);
|
2016-12-13 18:31:25 +08:00
|
|
|
|
|
|
|
return 0;
|
2016-09-06 14:00:44 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void s390_pci_msix_free(S390PCIBusDevice *pbdev)
|
|
|
|
{
|
|
|
|
memory_region_del_subregion(&pbdev->iommu->mr, &pbdev->msix_notify_mr);
|
|
|
|
object_unparent(OBJECT(&pbdev->msix_notify_mr));
|
|
|
|
}
|
|
|
|
|
2016-11-23 11:08:29 +08:00
|
|
|
static S390PCIBusDevice *s390_pci_device_new(S390pciState *s,
|
2018-11-13 20:17:10 +08:00
|
|
|
const char *target, Error **errp)
|
2016-05-11 15:10:06 +08:00
|
|
|
{
|
2018-11-13 20:17:10 +08:00
|
|
|
Error *local_err = NULL;
|
|
|
|
DeviceState *dev;
|
2016-05-11 15:10:06 +08:00
|
|
|
|
2020-06-10 13:31:59 +08:00
|
|
|
dev = qdev_try_new(TYPE_S390_PCI_DEVICE);
|
2016-05-11 15:10:06 +08:00
|
|
|
if (!dev) {
|
2018-11-13 20:17:10 +08:00
|
|
|
error_setg(errp, "zPCI device could not be created");
|
2016-05-11 15:10:06 +08:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
qom: Use returned bool to check for failure, Coccinelle part
The previous commit enables conversion of
foo(..., &err);
if (err) {
...
}
to
if (!foo(..., errp)) {
...
}
for QOM functions that now return true / false on success / error.
Coccinelle script:
@@
identifier fun = {
object_apply_global_props, object_initialize_child_with_props,
object_initialize_child_with_propsv, object_property_get,
object_property_get_bool, object_property_parse, object_property_set,
object_property_set_bool, object_property_set_int,
object_property_set_link, object_property_set_qobject,
object_property_set_str, object_property_set_uint, object_set_props,
object_set_propv, user_creatable_add_dict,
user_creatable_complete, user_creatable_del
};
expression list args, args2;
typedef Error;
Error *err;
@@
- fun(args, &err, args2);
- if (err)
+ if (!fun(args, &err, args2))
{
...
}
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Line breaks tidied up manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-29-armbru@redhat.com>
2020-07-08 00:05:56 +08:00
|
|
|
if (!object_property_set_str(OBJECT(dev), "target", target, &local_err)) {
|
2018-11-13 20:17:10 +08:00
|
|
|
object_unparent(OBJECT(dev));
|
|
|
|
error_propagate_prepend(errp, local_err,
|
|
|
|
"zPCI device could not be created: ");
|
|
|
|
return NULL;
|
|
|
|
}
|
qdev: Use returned bool to check for qdev_realize() etc. failure
Convert
foo(..., &err);
if (err) {
...
}
to
if (!foo(..., &err)) {
...
}
for qdev_realize(), qdev_realize_and_unref(), qbus_realize() and their
wrappers isa_realize_and_unref(), pci_realize_and_unref(),
sysbus_realize(), sysbus_realize_and_unref(), usb_realize_and_unref().
Coccinelle script:
@@
identifier fun = {
isa_realize_and_unref, pci_realize_and_unref, qbus_realize,
qdev_realize, qdev_realize_and_unref, sysbus_realize,
sysbus_realize_and_unref, usb_realize_and_unref
};
expression list args, args2;
typedef Error;
Error *err;
@@
- fun(args, &err, args2);
- if (err)
+ if (!fun(args, &err, args2))
{
...
}
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information". Nothing to convert there; skipped.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Converted manually.
A few line breaks tidied up manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: <20200707160613.848843-5-armbru@redhat.com>
2020-07-08 00:05:32 +08:00
|
|
|
if (!qdev_realize_and_unref(dev, BUS(s->bus), &local_err)) {
|
2018-11-13 20:17:10 +08:00
|
|
|
object_unparent(OBJECT(dev));
|
|
|
|
error_propagate_prepend(errp, local_err,
|
|
|
|
"zPCI device could not be created: ");
|
|
|
|
return NULL;
|
|
|
|
}
|
2016-05-11 15:10:06 +08:00
|
|
|
|
|
|
|
return S390_PCI_DEVICE(dev);
|
|
|
|
}
|
|
|
|
|
2016-11-23 11:08:29 +08:00
|
|
|
static bool s390_pci_alloc_idx(S390pciState *s, S390PCIBusDevice *pbdev)
|
2016-11-15 15:51:38 +08:00
|
|
|
{
|
|
|
|
uint32_t idx;
|
|
|
|
|
|
|
|
idx = s->next_idx;
|
2016-11-23 11:08:29 +08:00
|
|
|
while (s390_pci_find_dev_by_idx(s, idx)) {
|
2016-11-15 15:51:38 +08:00
|
|
|
idx = (idx + 1) & FH_MASK_INDEX;
|
|
|
|
if (idx == s->next_idx) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
pbdev->idx = idx;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2019-01-14 18:31:06 +08:00
|
|
|
static void s390_pcihost_pre_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
S390pciState *s = S390_PCI_HOST_BRIDGE(hotplug_dev);
|
|
|
|
|
2019-01-30 23:57:30 +08:00
|
|
|
if (!s390_has_feat(S390_FEAT_ZPCI)) {
|
|
|
|
warn_report("Plugging a PCI/zPCI device without the 'zpci' CPU "
|
|
|
|
"feature enabled; the guest will not be able to see/use "
|
|
|
|
"this device");
|
|
|
|
}
|
|
|
|
|
2019-01-14 18:31:06 +08:00
|
|
|
if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) {
|
|
|
|
PCIDevice *pdev = PCI_DEVICE(dev);
|
|
|
|
|
|
|
|
if (pdev->cap_present & QEMU_PCI_CAP_MULTIFUNCTION) {
|
|
|
|
error_setg(errp, "multifunction not supported in s390");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
} else if (object_dynamic_cast(OBJECT(dev), TYPE_S390_PCI_DEVICE)) {
|
|
|
|
S390PCIBusDevice *pbdev = S390_PCI_DEVICE(dev);
|
|
|
|
|
|
|
|
if (!s390_pci_alloc_idx(s, pbdev)) {
|
|
|
|
error_setg(errp, "no slot for plugging zpci device");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-01-30 23:57:29 +08:00
|
|
|
static void s390_pci_update_subordinate(PCIDevice *dev, uint32_t nr)
|
|
|
|
{
|
|
|
|
uint32_t old_nr;
|
|
|
|
|
|
|
|
pci_default_write_config(dev, PCI_SUBORDINATE_BUS, nr, 1);
|
|
|
|
while (!pci_bus_is_root(pci_get_bus(dev))) {
|
|
|
|
dev = pci_get_bus(dev)->parent_dev;
|
|
|
|
|
|
|
|
old_nr = pci_default_read_config(dev, PCI_SUBORDINATE_BUS, 1);
|
|
|
|
if (old_nr < nr) {
|
|
|
|
pci_default_write_config(dev, PCI_SUBORDINATE_BUS, nr, 1);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-12-12 17:16:15 +08:00
|
|
|
static void s390_pcihost_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
|
|
|
|
Error **errp)
|
2015-01-09 16:04:38 +08:00
|
|
|
{
|
2019-01-14 18:31:05 +08:00
|
|
|
S390pciState *s = S390_PCI_HOST_BRIDGE(hotplug_dev);
|
2016-05-13 12:50:09 +08:00
|
|
|
PCIDevice *pdev = NULL;
|
|
|
|
S390PCIBusDevice *pbdev = NULL;
|
2016-05-11 15:10:06 +08:00
|
|
|
|
2016-10-24 20:50:35 +08:00
|
|
|
if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_BRIDGE)) {
|
|
|
|
PCIBridge *pb = PCI_BRIDGE(dev);
|
|
|
|
|
2019-01-30 23:57:29 +08:00
|
|
|
pdev = PCI_DEVICE(dev);
|
2016-10-24 20:50:35 +08:00
|
|
|
pci_bridge_map_irq(pb, dev->id, s390_pci_map_irq);
|
|
|
|
pci_setup_iommu(&pb->sec_bus, s390_pci_dma_iommu, s);
|
|
|
|
|
qdev: Drop qbus_set_hotplug_handler() parameter @errp
qbus_set_hotplug_handler() is a simple wrapper around
object_property_set_link().
object_property_set_link() fails when the property doesn't exist, is
not settable, or its .check() method fails. These are all programming
errors here, so passing &error_abort to qbus_set_hotplug_handler() is
appropriate.
Most of its callers do. Exceptions:
* pcie_cap_slot_init(), shpc_init(), spapr_phb_realize() pass NULL,
i.e. they ignore errors.
* spapr_machine_init() passes &error_fatal.
* s390_pcihost_realize(), virtio_serial_device_realize(),
s390_pcihost_plug() pass the error to their callers. The latter two
keep going after the error, which looks wrong.
Drop the @errp parameter, and instead pass &error_abort to
object_property_set_link().
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200630090351.1247703-15-armbru@redhat.com>
2020-06-30 17:03:39 +08:00
|
|
|
qbus_set_hotplug_handler(BUS(&pb->sec_bus), OBJECT(s));
|
2016-11-23 14:26:34 +08:00
|
|
|
|
|
|
|
if (dev->hotplugged) {
|
2019-01-30 23:57:28 +08:00
|
|
|
pci_default_write_config(pdev, PCI_PRIMARY_BUS,
|
|
|
|
pci_dev_bus_num(pdev), 1);
|
2016-11-23 14:26:34 +08:00
|
|
|
s->bus_no += 1;
|
|
|
|
pci_default_write_config(pdev, PCI_SECONDARY_BUS, s->bus_no, 1);
|
2019-01-30 23:57:29 +08:00
|
|
|
|
|
|
|
s390_pci_update_subordinate(pdev, s->bus_no);
|
2016-11-23 14:26:34 +08:00
|
|
|
}
|
2016-10-24 20:50:35 +08:00
|
|
|
} else if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) {
|
2016-05-13 12:50:09 +08:00
|
|
|
pdev = PCI_DEVICE(dev);
|
|
|
|
|
|
|
|
if (!dev->id) {
|
|
|
|
/* In the case the PCI device does not define an id */
|
|
|
|
/* we generate one based on the PCI address */
|
|
|
|
dev->id = g_strdup_printf("auto_%02x:%02x.%01x",
|
2017-11-29 16:46:26 +08:00
|
|
|
pci_dev_bus_num(pdev),
|
2016-05-13 12:50:09 +08:00
|
|
|
PCI_SLOT(pdev->devfn),
|
|
|
|
PCI_FUNC(pdev->devfn));
|
|
|
|
}
|
|
|
|
|
2016-11-23 11:08:29 +08:00
|
|
|
pbdev = s390_pci_find_dev_by_target(s, dev->id);
|
2016-05-11 15:10:06 +08:00
|
|
|
if (!pbdev) {
|
2018-11-13 20:17:10 +08:00
|
|
|
pbdev = s390_pci_device_new(s, dev->id, errp);
|
2016-05-13 12:50:09 +08:00
|
|
|
if (!pbdev) {
|
2016-08-10 16:10:08 +08:00
|
|
|
return;
|
2016-05-13 12:50:09 +08:00
|
|
|
}
|
2016-05-11 15:10:06 +08:00
|
|
|
}
|
2015-01-09 16:04:38 +08:00
|
|
|
|
2020-10-26 23:34:35 +08:00
|
|
|
pbdev->pdev = pdev;
|
|
|
|
pbdev->iommu = s390_pci_get_iommu(s, pci_get_bus(pdev), pdev->devfn);
|
|
|
|
pbdev->iommu->pbdev = pbdev;
|
|
|
|
pbdev->state = ZPCI_FS_DISABLED;
|
|
|
|
|
2016-05-13 12:50:09 +08:00
|
|
|
if (object_dynamic_cast(OBJECT(dev), "vfio-pci")) {
|
|
|
|
pbdev->fh |= FH_SHM_VFIO;
|
2020-10-26 23:34:35 +08:00
|
|
|
pbdev->iommu->dma_limit = s390_pci_start_dma_count(s, pbdev);
|
2016-05-13 12:50:09 +08:00
|
|
|
} else {
|
|
|
|
pbdev->fh |= FH_SHM_EMUL;
|
|
|
|
}
|
2015-01-09 16:04:38 +08:00
|
|
|
|
2016-12-13 18:31:25 +08:00
|
|
|
if (s390_pci_msix_init(pbdev)) {
|
|
|
|
error_setg(errp, "MSI-X support is mandatory "
|
|
|
|
"in the S390 architecture");
|
|
|
|
return;
|
|
|
|
}
|
2015-01-09 16:04:38 +08:00
|
|
|
|
2016-05-13 12:50:09 +08:00
|
|
|
if (dev->hotplugged) {
|
2019-01-11 05:03:58 +08:00
|
|
|
s390_pci_generate_plug_event(HP_EVENT_TO_CONFIGURED ,
|
2016-05-13 12:50:09 +08:00
|
|
|
pbdev->fh, pbdev->fid);
|
|
|
|
}
|
|
|
|
} else if (object_dynamic_cast(OBJECT(dev), TYPE_S390_PCI_DEVICE)) {
|
|
|
|
pbdev = S390_PCI_DEVICE(dev);
|
|
|
|
|
2019-01-14 18:31:06 +08:00
|
|
|
/* the allocated idx is actually getting used */
|
|
|
|
s->next_idx = (pbdev->idx + 1) & FH_MASK_INDEX;
|
2016-11-15 15:51:38 +08:00
|
|
|
pbdev->fh = pbdev->idx;
|
|
|
|
QTAILQ_INSERT_TAIL(&s->zpci_devs, pbdev, link);
|
2016-11-09 21:30:50 +08:00
|
|
|
g_hash_table_insert(s->zpci_table, &pbdev->idx, pbdev);
|
2019-01-08 23:11:14 +08:00
|
|
|
} else {
|
|
|
|
g_assert_not_reached();
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-12-12 17:16:15 +08:00
|
|
|
static void s390_pcihost_unplug(HotplugHandler *hotplug_dev, DeviceState *dev,
|
|
|
|
Error **errp)
|
2015-01-09 16:04:38 +08:00
|
|
|
{
|
2019-01-14 18:31:05 +08:00
|
|
|
S390pciState *s = S390_PCI_HOST_BRIDGE(hotplug_dev);
|
2016-05-13 12:50:09 +08:00
|
|
|
S390PCIBusDevice *pbdev = NULL;
|
|
|
|
|
s390x/pci: Introduce unplug requests and split unplug handler
PCI on s390x is really weird and how it was modeled in QEMU might not have
been the right choice. Anyhow, right now it is the case that:
- Hotplugging a PCI device will silently create a zPCI device
(if none is provided)
- Hotunplugging a zPCI device will unplug the PCI device (if any)
- Hotunplugging a PCI device will unplug also the zPCI device
As far as I can see, we can no longer change this behavior. But we
should fix it.
Both device types are handled via a single hotplug handler call. This
is problematic for various reasons:
1. Unplugging via the zPCI device allows to unplug devices that are not
hot removable. (check performed in qdev_unplug()) - bad.
2. Hotplug handler chains are not possible for the unplug case. In the
future, the machine might want to override hotplug handlers, to
process device specific stuff and to then branch off to the actual
hotplug handler. We need separate hotplug handler calls for both the
PCI and zPCI device to make this work reliably. All other PCI
implementations are already prepared to handle this correctly, only
s390x is missing.
Therefore, introduce the unplug_request handler and properly perform
unplug checks by redirecting to the separate unplug_request handlers.
When finally unplugging, perform two separate hotplug_handler_unplug()
calls, first for the PCI device, followed by the zPCI device. This now
nicely splits unplugging paths for both devices.
The redirect part is a little hairy, as the user is allowed to trigger
unplug either via the PCI or the zPCI device. So redirect always to the
PCI unplug request handler first and remember if that check has been
performed in the zPCI device. Redirect then to the zPCI device unplug
request handler to perform the magic. Remembering that we already
checked the PCI device breaks the redirect loop.
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190130155733.32742-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2019-01-30 23:57:31 +08:00
|
|
|
if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) {
|
|
|
|
PCIDevice *pci_dev = PCI_DEVICE(dev);
|
|
|
|
PCIBus *bus;
|
|
|
|
int32_t devfn;
|
|
|
|
|
|
|
|
pbdev = s390_pci_find_dev_by_pci(s, PCI_DEVICE(dev));
|
|
|
|
g_assert(pbdev);
|
|
|
|
|
|
|
|
s390_pci_generate_plug_event(HP_EVENT_STANDBY_TO_RESERVED,
|
|
|
|
pbdev->fh, pbdev->fid);
|
|
|
|
bus = pci_get_bus(pci_dev);
|
|
|
|
devfn = pci_dev->devfn;
|
2020-06-10 13:31:56 +08:00
|
|
|
qdev_unrealize(dev);
|
s390x/pci: Introduce unplug requests and split unplug handler
PCI on s390x is really weird and how it was modeled in QEMU might not have
been the right choice. Anyhow, right now it is the case that:
- Hotplugging a PCI device will silently create a zPCI device
(if none is provided)
- Hotunplugging a zPCI device will unplug the PCI device (if any)
- Hotunplugging a PCI device will unplug also the zPCI device
As far as I can see, we can no longer change this behavior. But we
should fix it.
Both device types are handled via a single hotplug handler call. This
is problematic for various reasons:
1. Unplugging via the zPCI device allows to unplug devices that are not
hot removable. (check performed in qdev_unplug()) - bad.
2. Hotplug handler chains are not possible for the unplug case. In the
future, the machine might want to override hotplug handlers, to
process device specific stuff and to then branch off to the actual
hotplug handler. We need separate hotplug handler calls for both the
PCI and zPCI device to make this work reliably. All other PCI
implementations are already prepared to handle this correctly, only
s390x is missing.
Therefore, introduce the unplug_request handler and properly perform
unplug checks by redirecting to the separate unplug_request handlers.
When finally unplugging, perform two separate hotplug_handler_unplug()
calls, first for the PCI device, followed by the zPCI device. This now
nicely splits unplugging paths for both devices.
The redirect part is a little hairy, as the user is allowed to trigger
unplug either via the PCI or the zPCI device. So redirect always to the
PCI unplug request handler first and remember if that check has been
performed in the zPCI device. Redirect then to the zPCI device unplug
request handler to perform the magic. Remembering that we already
checked the PCI device breaks the redirect loop.
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190130155733.32742-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2019-01-30 23:57:31 +08:00
|
|
|
|
|
|
|
s390_pci_msix_free(pbdev);
|
|
|
|
s390_pci_iommu_free(s, bus, devfn);
|
|
|
|
pbdev->pdev = NULL;
|
|
|
|
pbdev->state = ZPCI_FS_RESERVED;
|
|
|
|
} else if (object_dynamic_cast(OBJECT(dev), TYPE_S390_PCI_DEVICE)) {
|
|
|
|
pbdev = S390_PCI_DEVICE(dev);
|
|
|
|
pbdev->fid = 0;
|
|
|
|
QTAILQ_REMOVE(&s->zpci_devs, pbdev, link);
|
|
|
|
g_hash_table_remove(s->zpci_table, &pbdev->idx);
|
2020-10-26 23:34:35 +08:00
|
|
|
if (pbdev->iommu->dma_limit) {
|
|
|
|
s390_pci_end_dma_count(s, pbdev->iommu->dma_limit);
|
|
|
|
}
|
2020-06-10 13:31:56 +08:00
|
|
|
qdev_unrealize(dev);
|
s390x/pci: Introduce unplug requests and split unplug handler
PCI on s390x is really weird and how it was modeled in QEMU might not have
been the right choice. Anyhow, right now it is the case that:
- Hotplugging a PCI device will silently create a zPCI device
(if none is provided)
- Hotunplugging a zPCI device will unplug the PCI device (if any)
- Hotunplugging a PCI device will unplug also the zPCI device
As far as I can see, we can no longer change this behavior. But we
should fix it.
Both device types are handled via a single hotplug handler call. This
is problematic for various reasons:
1. Unplugging via the zPCI device allows to unplug devices that are not
hot removable. (check performed in qdev_unplug()) - bad.
2. Hotplug handler chains are not possible for the unplug case. In the
future, the machine might want to override hotplug handlers, to
process device specific stuff and to then branch off to the actual
hotplug handler. We need separate hotplug handler calls for both the
PCI and zPCI device to make this work reliably. All other PCI
implementations are already prepared to handle this correctly, only
s390x is missing.
Therefore, introduce the unplug_request handler and properly perform
unplug checks by redirecting to the separate unplug_request handlers.
When finally unplugging, perform two separate hotplug_handler_unplug()
calls, first for the PCI device, followed by the zPCI device. This now
nicely splits unplugging paths for both devices.
The redirect part is a little hairy, as the user is allowed to trigger
unplug either via the PCI or the zPCI device. So redirect always to the
PCI unplug request handler first and remember if that check has been
performed in the zPCI device. Redirect then to the zPCI device unplug
request handler to perform the magic. Remembering that we already
checked the PCI device breaks the redirect loop.
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190130155733.32742-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2019-01-30 23:57:31 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void s390_pcihost_unplug_request(HotplugHandler *hotplug_dev,
|
|
|
|
DeviceState *dev,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
S390pciState *s = S390_PCI_HOST_BRIDGE(hotplug_dev);
|
|
|
|
S390PCIBusDevice *pbdev;
|
|
|
|
|
2016-10-24 20:50:35 +08:00
|
|
|
if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_BRIDGE)) {
|
|
|
|
error_setg(errp, "PCI bridge hot unplug currently not supported");
|
|
|
|
} else if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) {
|
s390x/pci: Introduce unplug requests and split unplug handler
PCI on s390x is really weird and how it was modeled in QEMU might not have
been the right choice. Anyhow, right now it is the case that:
- Hotplugging a PCI device will silently create a zPCI device
(if none is provided)
- Hotunplugging a zPCI device will unplug the PCI device (if any)
- Hotunplugging a PCI device will unplug also the zPCI device
As far as I can see, we can no longer change this behavior. But we
should fix it.
Both device types are handled via a single hotplug handler call. This
is problematic for various reasons:
1. Unplugging via the zPCI device allows to unplug devices that are not
hot removable. (check performed in qdev_unplug()) - bad.
2. Hotplug handler chains are not possible for the unplug case. In the
future, the machine might want to override hotplug handlers, to
process device specific stuff and to then branch off to the actual
hotplug handler. We need separate hotplug handler calls for both the
PCI and zPCI device to make this work reliably. All other PCI
implementations are already prepared to handle this correctly, only
s390x is missing.
Therefore, introduce the unplug_request handler and properly perform
unplug checks by redirecting to the separate unplug_request handlers.
When finally unplugging, perform two separate hotplug_handler_unplug()
calls, first for the PCI device, followed by the zPCI device. This now
nicely splits unplugging paths for both devices.
The redirect part is a little hairy, as the user is allowed to trigger
unplug either via the PCI or the zPCI device. So redirect always to the
PCI unplug request handler first and remember if that check has been
performed in the zPCI device. Redirect then to the zPCI device unplug
request handler to perform the magic. Remembering that we already
checked the PCI device breaks the redirect loop.
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190130155733.32742-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2019-01-30 23:57:31 +08:00
|
|
|
/*
|
|
|
|
* Redirect the unplug request to the zPCI device and remember that
|
|
|
|
* we've checked the PCI device already (to prevent endless recursion).
|
|
|
|
*/
|
|
|
|
pbdev = s390_pci_find_dev_by_pci(s, PCI_DEVICE(dev));
|
|
|
|
g_assert(pbdev);
|
|
|
|
pbdev->pci_unplug_request_processed = true;
|
|
|
|
qdev_unplug(DEVICE(pbdev), errp);
|
2016-05-13 12:50:09 +08:00
|
|
|
} else if (object_dynamic_cast(OBJECT(dev), TYPE_S390_PCI_DEVICE)) {
|
|
|
|
pbdev = S390_PCI_DEVICE(dev);
|
2015-01-09 16:04:38 +08:00
|
|
|
|
s390x/pci: Introduce unplug requests and split unplug handler
PCI on s390x is really weird and how it was modeled in QEMU might not have
been the right choice. Anyhow, right now it is the case that:
- Hotplugging a PCI device will silently create a zPCI device
(if none is provided)
- Hotunplugging a zPCI device will unplug the PCI device (if any)
- Hotunplugging a PCI device will unplug also the zPCI device
As far as I can see, we can no longer change this behavior. But we
should fix it.
Both device types are handled via a single hotplug handler call. This
is problematic for various reasons:
1. Unplugging via the zPCI device allows to unplug devices that are not
hot removable. (check performed in qdev_unplug()) - bad.
2. Hotplug handler chains are not possible for the unplug case. In the
future, the machine might want to override hotplug handlers, to
process device specific stuff and to then branch off to the actual
hotplug handler. We need separate hotplug handler calls for both the
PCI and zPCI device to make this work reliably. All other PCI
implementations are already prepared to handle this correctly, only
s390x is missing.
Therefore, introduce the unplug_request handler and properly perform
unplug checks by redirecting to the separate unplug_request handlers.
When finally unplugging, perform two separate hotplug_handler_unplug()
calls, first for the PCI device, followed by the zPCI device. This now
nicely splits unplugging paths for both devices.
The redirect part is a little hairy, as the user is allowed to trigger
unplug either via the PCI or the zPCI device. So redirect always to the
PCI unplug request handler first and remember if that check has been
performed in the zPCI device. Redirect then to the zPCI device unplug
request handler to perform the magic. Remembering that we already
checked the PCI device breaks the redirect loop.
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190130155733.32742-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2019-01-30 23:57:31 +08:00
|
|
|
/*
|
|
|
|
* If unplug was initially requested for the zPCI device, we
|
|
|
|
* first have to redirect to the PCI device, which will in return
|
|
|
|
* redirect back to us after performing its checks (if the request
|
|
|
|
* is not blocked, e.g. because it's a PCI bridge).
|
|
|
|
*/
|
|
|
|
if (pbdev->pdev && !pbdev->pci_unplug_request_processed) {
|
|
|
|
qdev_unplug(DEVICE(pbdev->pdev), errp);
|
2019-01-14 18:31:08 +08:00
|
|
|
return;
|
|
|
|
}
|
s390x/pci: Introduce unplug requests and split unplug handler
PCI on s390x is really weird and how it was modeled in QEMU might not have
been the right choice. Anyhow, right now it is the case that:
- Hotplugging a PCI device will silently create a zPCI device
(if none is provided)
- Hotunplugging a zPCI device will unplug the PCI device (if any)
- Hotunplugging a PCI device will unplug also the zPCI device
As far as I can see, we can no longer change this behavior. But we
should fix it.
Both device types are handled via a single hotplug handler call. This
is problematic for various reasons:
1. Unplugging via the zPCI device allows to unplug devices that are not
hot removable. (check performed in qdev_unplug()) - bad.
2. Hotplug handler chains are not possible for the unplug case. In the
future, the machine might want to override hotplug handlers, to
process device specific stuff and to then branch off to the actual
hotplug handler. We need separate hotplug handler calls for both the
PCI and zPCI device to make this work reliably. All other PCI
implementations are already prepared to handle this correctly, only
s390x is missing.
Therefore, introduce the unplug_request handler and properly perform
unplug checks by redirecting to the separate unplug_request handlers.
When finally unplugging, perform two separate hotplug_handler_unplug()
calls, first for the PCI device, followed by the zPCI device. This now
nicely splits unplugging paths for both devices.
The redirect part is a little hairy, as the user is allowed to trigger
unplug either via the PCI or the zPCI device. So redirect always to the
PCI unplug request handler first and remember if that check has been
performed in the zPCI device. Redirect then to the zPCI device unplug
request handler to perform the magic. Remembering that we already
checked the PCI device breaks the redirect loop.
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190130155733.32742-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2019-01-30 23:57:31 +08:00
|
|
|
pbdev->pci_unplug_request_processed = false;
|
2016-04-27 17:44:17 +08:00
|
|
|
|
s390x/pci: Introduce unplug requests and split unplug handler
PCI on s390x is really weird and how it was modeled in QEMU might not have
been the right choice. Anyhow, right now it is the case that:
- Hotplugging a PCI device will silently create a zPCI device
(if none is provided)
- Hotunplugging a zPCI device will unplug the PCI device (if any)
- Hotunplugging a PCI device will unplug also the zPCI device
As far as I can see, we can no longer change this behavior. But we
should fix it.
Both device types are handled via a single hotplug handler call. This
is problematic for various reasons:
1. Unplugging via the zPCI device allows to unplug devices that are not
hot removable. (check performed in qdev_unplug()) - bad.
2. Hotplug handler chains are not possible for the unplug case. In the
future, the machine might want to override hotplug handlers, to
process device specific stuff and to then branch off to the actual
hotplug handler. We need separate hotplug handler calls for both the
PCI and zPCI device to make this work reliably. All other PCI
implementations are already prepared to handle this correctly, only
s390x is missing.
Therefore, introduce the unplug_request handler and properly perform
unplug checks by redirecting to the separate unplug_request handlers.
When finally unplugging, perform two separate hotplug_handler_unplug()
calls, first for the PCI device, followed by the zPCI device. This now
nicely splits unplugging paths for both devices.
The redirect part is a little hairy, as the user is allowed to trigger
unplug either via the PCI or the zPCI device. So redirect always to the
PCI unplug request handler first and remember if that check has been
performed in the zPCI device. Redirect then to the zPCI device unplug
request handler to perform the magic. Remembering that we already
checked the PCI device breaks the redirect loop.
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190130155733.32742-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2019-01-30 23:57:31 +08:00
|
|
|
switch (pbdev->state) {
|
|
|
|
case ZPCI_FS_STANDBY:
|
|
|
|
case ZPCI_FS_RESERVED:
|
|
|
|
s390_pci_perform_unplug(pbdev);
|
|
|
|
break;
|
|
|
|
default:
|
2019-01-30 23:57:32 +08:00
|
|
|
/*
|
|
|
|
* Allow to send multiple requests, e.g. if the guest crashed
|
|
|
|
* before releasing the device, we would not be able to send
|
|
|
|
* another request to the same VM (e.g. fresh OS).
|
|
|
|
*/
|
|
|
|
pbdev->unplug_requested = true;
|
s390x/pci: Introduce unplug requests and split unplug handler
PCI on s390x is really weird and how it was modeled in QEMU might not have
been the right choice. Anyhow, right now it is the case that:
- Hotplugging a PCI device will silently create a zPCI device
(if none is provided)
- Hotunplugging a zPCI device will unplug the PCI device (if any)
- Hotunplugging a PCI device will unplug also the zPCI device
As far as I can see, we can no longer change this behavior. But we
should fix it.
Both device types are handled via a single hotplug handler call. This
is problematic for various reasons:
1. Unplugging via the zPCI device allows to unplug devices that are not
hot removable. (check performed in qdev_unplug()) - bad.
2. Hotplug handler chains are not possible for the unplug case. In the
future, the machine might want to override hotplug handlers, to
process device specific stuff and to then branch off to the actual
hotplug handler. We need separate hotplug handler calls for both the
PCI and zPCI device to make this work reliably. All other PCI
implementations are already prepared to handle this correctly, only
s390x is missing.
Therefore, introduce the unplug_request handler and properly perform
unplug checks by redirecting to the separate unplug_request handlers.
When finally unplugging, perform two separate hotplug_handler_unplug()
calls, first for the PCI device, followed by the zPCI device. This now
nicely splits unplugging paths for both devices.
The redirect part is a little hairy, as the user is allowed to trigger
unplug either via the PCI or the zPCI device. So redirect always to the
PCI unplug request handler first and remember if that check has been
performed in the zPCI device. Redirect then to the zPCI device unplug
request handler to perform the magic. Remembering that we already
checked the PCI device breaks the redirect loop.
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190130155733.32742-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2019-01-30 23:57:31 +08:00
|
|
|
s390_pci_generate_plug_event(HP_EVENT_DECONFIGURE_REQUEST,
|
|
|
|
pbdev->fh, pbdev->fid);
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
g_assert_not_reached();
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-11-23 14:26:34 +08:00
|
|
|
static void s390_pci_enumerate_bridge(PCIBus *bus, PCIDevice *pdev,
|
|
|
|
void *opaque)
|
|
|
|
{
|
|
|
|
S390pciState *s = opaque;
|
|
|
|
PCIBus *sec_bus = NULL;
|
|
|
|
|
|
|
|
if ((pci_default_read_config(pdev, PCI_HEADER_TYPE, 1) !=
|
|
|
|
PCI_HEADER_TYPE_BRIDGE)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
(s->bus_no)++;
|
2019-01-30 23:57:28 +08:00
|
|
|
pci_default_write_config(pdev, PCI_PRIMARY_BUS, pci_dev_bus_num(pdev), 1);
|
2016-11-23 14:26:34 +08:00
|
|
|
pci_default_write_config(pdev, PCI_SECONDARY_BUS, s->bus_no, 1);
|
|
|
|
pci_default_write_config(pdev, PCI_SUBORDINATE_BUS, s->bus_no, 1);
|
|
|
|
|
|
|
|
sec_bus = pci_bridge_get_sec_bus(PCI_BRIDGE(pdev));
|
|
|
|
if (!sec_bus) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2019-01-30 23:57:28 +08:00
|
|
|
/* Assign numbers to all child bridges. The last is the highest number. */
|
2016-11-23 14:26:34 +08:00
|
|
|
pci_for_each_device(sec_bus, pci_bus_num(sec_bus),
|
|
|
|
s390_pci_enumerate_bridge, s);
|
|
|
|
pci_default_write_config(pdev, PCI_SUBORDINATE_BUS, s->bus_no, 1);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void s390_pcihost_reset(DeviceState *dev)
|
|
|
|
{
|
|
|
|
S390pciState *s = S390_PCI_HOST_BRIDGE(dev);
|
|
|
|
PCIBus *bus = s->parent_obj.bus;
|
2019-01-30 23:57:33 +08:00
|
|
|
S390PCIBusDevice *pbdev, *next;
|
|
|
|
|
|
|
|
/* Process all pending unplug requests */
|
|
|
|
QTAILQ_FOREACH_SAFE(pbdev, &s->zpci_devs, link, next) {
|
|
|
|
if (pbdev->unplug_requested) {
|
|
|
|
if (pbdev->summary_ind) {
|
|
|
|
pci_dereg_irqs(pbdev);
|
|
|
|
}
|
|
|
|
if (pbdev->iommu->enabled) {
|
|
|
|
pci_dereg_ioat(pbdev->iommu);
|
|
|
|
}
|
|
|
|
pbdev->state = ZPCI_FS_STANDBY;
|
|
|
|
s390_pci_perform_unplug(pbdev);
|
|
|
|
}
|
|
|
|
}
|
2016-11-23 14:26:34 +08:00
|
|
|
|
2019-01-30 23:57:28 +08:00
|
|
|
/*
|
|
|
|
* When resetting a PCI bridge, the assigned numbers are set to 0. So
|
|
|
|
* on every system reset, we also have to reassign numbers.
|
|
|
|
*/
|
2016-11-23 14:26:34 +08:00
|
|
|
s->bus_no = 0;
|
|
|
|
pci_for_each_device(bus, pci_bus_num(bus), s390_pci_enumerate_bridge, s);
|
|
|
|
}
|
|
|
|
|
2015-01-09 16:04:38 +08:00
|
|
|
static void s390_pcihost_class_init(ObjectClass *klass, void *data)
|
|
|
|
{
|
|
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
|
|
HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(klass);
|
|
|
|
|
2016-11-23 14:26:34 +08:00
|
|
|
dc->reset = s390_pcihost_reset;
|
2018-10-02 15:48:11 +08:00
|
|
|
dc->realize = s390_pcihost_realize;
|
2019-01-14 18:31:06 +08:00
|
|
|
hc->pre_plug = s390_pcihost_pre_plug;
|
2018-12-12 17:16:15 +08:00
|
|
|
hc->plug = s390_pcihost_plug;
|
s390x/pci: Introduce unplug requests and split unplug handler
PCI on s390x is really weird and how it was modeled in QEMU might not have
been the right choice. Anyhow, right now it is the case that:
- Hotplugging a PCI device will silently create a zPCI device
(if none is provided)
- Hotunplugging a zPCI device will unplug the PCI device (if any)
- Hotunplugging a PCI device will unplug also the zPCI device
As far as I can see, we can no longer change this behavior. But we
should fix it.
Both device types are handled via a single hotplug handler call. This
is problematic for various reasons:
1. Unplugging via the zPCI device allows to unplug devices that are not
hot removable. (check performed in qdev_unplug()) - bad.
2. Hotplug handler chains are not possible for the unplug case. In the
future, the machine might want to override hotplug handlers, to
process device specific stuff and to then branch off to the actual
hotplug handler. We need separate hotplug handler calls for both the
PCI and zPCI device to make this work reliably. All other PCI
implementations are already prepared to handle this correctly, only
s390x is missing.
Therefore, introduce the unplug_request handler and properly perform
unplug checks by redirecting to the separate unplug_request handlers.
When finally unplugging, perform two separate hotplug_handler_unplug()
calls, first for the PCI device, followed by the zPCI device. This now
nicely splits unplugging paths for both devices.
The redirect part is a little hairy, as the user is allowed to trigger
unplug either via the PCI or the zPCI device. So redirect always to the
PCI unplug request handler first and remember if that check has been
performed in the zPCI device. Redirect then to the zPCI device unplug
request handler to perform the magic. Remembering that we already
checked the PCI device breaks the redirect loop.
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190130155733.32742-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2019-01-30 23:57:31 +08:00
|
|
|
hc->unplug_request = s390_pcihost_unplug_request;
|
2018-12-12 17:16:15 +08:00
|
|
|
hc->unplug = s390_pcihost_unplug;
|
2016-03-04 17:24:28 +08:00
|
|
|
msi_nonbroken = true;
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static const TypeInfo s390_pcihost_info = {
|
|
|
|
.name = TYPE_S390_PCI_HOST_BRIDGE,
|
|
|
|
.parent = TYPE_PCI_HOST_BRIDGE,
|
|
|
|
.instance_size = sizeof(S390pciState),
|
|
|
|
.class_init = s390_pcihost_class_init,
|
|
|
|
.interfaces = (InterfaceInfo[]) {
|
|
|
|
{ TYPE_HOTPLUG_HANDLER },
|
|
|
|
{ }
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2016-04-14 19:02:39 +08:00
|
|
|
static const TypeInfo s390_pcibus_info = {
|
|
|
|
.name = TYPE_S390_PCI_BUS,
|
|
|
|
.parent = TYPE_BUS,
|
|
|
|
.instance_size = sizeof(S390PCIBus),
|
|
|
|
};
|
|
|
|
|
2016-11-23 11:08:29 +08:00
|
|
|
static uint16_t s390_pci_generate_uid(S390pciState *s)
|
2016-05-11 15:10:06 +08:00
|
|
|
{
|
|
|
|
uint16_t uid = 0;
|
|
|
|
|
|
|
|
do {
|
|
|
|
uid++;
|
2016-11-23 11:08:29 +08:00
|
|
|
if (!s390_pci_find_dev_by_uid(s, uid)) {
|
2016-05-11 15:10:06 +08:00
|
|
|
return uid;
|
|
|
|
}
|
|
|
|
} while (uid < ZPCI_MAX_UID);
|
|
|
|
|
|
|
|
return UID_UNDEFINED;
|
|
|
|
}
|
|
|
|
|
2016-11-23 11:08:29 +08:00
|
|
|
static uint32_t s390_pci_generate_fid(S390pciState *s, Error **errp)
|
2016-05-11 15:10:06 +08:00
|
|
|
{
|
|
|
|
uint32_t fid = 0;
|
|
|
|
|
2016-10-20 20:57:06 +08:00
|
|
|
do {
|
2016-11-23 11:08:29 +08:00
|
|
|
if (!s390_pci_find_dev_by_fid(s, fid)) {
|
2016-05-11 15:10:06 +08:00
|
|
|
return fid;
|
|
|
|
}
|
2016-10-20 20:57:06 +08:00
|
|
|
} while (fid++ != ZPCI_MAX_FID);
|
2016-05-11 15:10:06 +08:00
|
|
|
|
|
|
|
error_setg(errp, "no free fid could be found");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void s390_pci_device_realize(DeviceState *dev, Error **errp)
|
|
|
|
{
|
|
|
|
S390PCIBusDevice *zpci = S390_PCI_DEVICE(dev);
|
2016-11-23 11:08:29 +08:00
|
|
|
S390pciState *s = s390_get_phb();
|
2016-05-11 15:10:06 +08:00
|
|
|
|
|
|
|
if (!zpci->target) {
|
|
|
|
error_setg(errp, "target must be defined");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2016-11-23 11:08:29 +08:00
|
|
|
if (s390_pci_find_dev_by_target(s, zpci->target)) {
|
2016-05-11 15:10:06 +08:00
|
|
|
error_setg(errp, "target %s already has an associated zpci device",
|
|
|
|
zpci->target);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (zpci->uid == UID_UNDEFINED) {
|
2016-11-23 11:08:29 +08:00
|
|
|
zpci->uid = s390_pci_generate_uid(s);
|
2016-05-11 15:10:06 +08:00
|
|
|
if (!zpci->uid) {
|
|
|
|
error_setg(errp, "no free uid could be found");
|
|
|
|
return;
|
|
|
|
}
|
2016-11-23 11:08:29 +08:00
|
|
|
} else if (s390_pci_find_dev_by_uid(s, zpci->uid)) {
|
2016-05-11 15:10:06 +08:00
|
|
|
error_setg(errp, "uid %u already in use", zpci->uid);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!zpci->fid_defined) {
|
|
|
|
Error *local_error = NULL;
|
|
|
|
|
2016-11-23 11:08:29 +08:00
|
|
|
zpci->fid = s390_pci_generate_fid(s, &local_error);
|
2016-05-11 15:10:06 +08:00
|
|
|
if (local_error) {
|
|
|
|
error_propagate(errp, local_error);
|
|
|
|
return;
|
|
|
|
}
|
2016-11-23 11:08:29 +08:00
|
|
|
} else if (s390_pci_find_dev_by_fid(s, zpci->fid)) {
|
2016-05-11 15:10:06 +08:00
|
|
|
error_setg(errp, "fid %u already in use", zpci->fid);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
zpci->state = ZPCI_FS_RESERVED;
|
2019-01-09 01:37:30 +08:00
|
|
|
zpci->fmb.format = ZPCI_FMB_FORMAT;
|
2016-05-11 15:10:06 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void s390_pci_device_reset(DeviceState *dev)
|
|
|
|
{
|
|
|
|
S390PCIBusDevice *pbdev = S390_PCI_DEVICE(dev);
|
|
|
|
|
|
|
|
switch (pbdev->state) {
|
|
|
|
case ZPCI_FS_RESERVED:
|
|
|
|
return;
|
|
|
|
case ZPCI_FS_STANDBY:
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
pbdev->fh &= ~FH_MASK_ENABLE;
|
|
|
|
pbdev->state = ZPCI_FS_DISABLED;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (pbdev->summary_ind) {
|
|
|
|
pci_dereg_irqs(pbdev);
|
|
|
|
}
|
2016-12-08 13:02:24 +08:00
|
|
|
if (pbdev->iommu->enabled) {
|
|
|
|
pci_dereg_ioat(pbdev->iommu);
|
2016-05-11 15:10:06 +08:00
|
|
|
}
|
|
|
|
|
2019-01-09 01:37:30 +08:00
|
|
|
fmb_timer_free(pbdev);
|
2016-05-11 15:10:06 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void s390_pci_get_fid(Object *obj, Visitor *v, const char *name,
|
|
|
|
void *opaque, Error **errp)
|
|
|
|
{
|
|
|
|
Property *prop = opaque;
|
|
|
|
uint32_t *ptr = qdev_get_prop_ptr(DEVICE(obj), prop);
|
|
|
|
|
|
|
|
visit_type_uint32(v, name, ptr, errp);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void s390_pci_set_fid(Object *obj, Visitor *v, const char *name,
|
|
|
|
void *opaque, Error **errp)
|
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
|
|
|
S390PCIBusDevice *zpci = S390_PCI_DEVICE(obj);
|
|
|
|
Property *prop = opaque;
|
|
|
|
uint32_t *ptr = qdev_get_prop_ptr(dev, prop);
|
|
|
|
|
|
|
|
if (dev->realized) {
|
|
|
|
qdev_prop_set_after_realize(dev, name, errp);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2020-07-08 00:05:48 +08:00
|
|
|
if (!visit_type_uint32(v, name, ptr, errp)) {
|
|
|
|
return;
|
|
|
|
}
|
2016-05-11 15:10:06 +08:00
|
|
|
zpci->fid_defined = true;
|
|
|
|
}
|
|
|
|
|
2017-07-14 10:14:54 +08:00
|
|
|
static const PropertyInfo s390_pci_fid_propinfo = {
|
2016-05-11 15:10:06 +08:00
|
|
|
.name = "zpci_fid",
|
|
|
|
.get = s390_pci_get_fid,
|
|
|
|
.set = s390_pci_set_fid,
|
|
|
|
};
|
|
|
|
|
|
|
|
#define DEFINE_PROP_S390_PCI_FID(_n, _s, _f) \
|
|
|
|
DEFINE_PROP(_n, _s, _f, s390_pci_fid_propinfo, uint32_t)
|
|
|
|
|
|
|
|
static Property s390_pci_device_properties[] = {
|
|
|
|
DEFINE_PROP_UINT16("uid", S390PCIBusDevice, uid, UID_UNDEFINED),
|
|
|
|
DEFINE_PROP_S390_PCI_FID("fid", S390PCIBusDevice, fid),
|
|
|
|
DEFINE_PROP_STRING("target", S390PCIBusDevice, target),
|
|
|
|
DEFINE_PROP_END_OF_LIST(),
|
|
|
|
};
|
|
|
|
|
2019-02-01 20:29:08 +08:00
|
|
|
static const VMStateDescription s390_pci_device_vmstate = {
|
|
|
|
.name = TYPE_S390_PCI_DEVICE,
|
|
|
|
/*
|
|
|
|
* TODO: add state handling here, so migration works at least with
|
|
|
|
* emulated pci devices on s390x
|
|
|
|
*/
|
|
|
|
.unmigratable = 1,
|
|
|
|
};
|
|
|
|
|
2016-05-11 15:10:06 +08:00
|
|
|
static void s390_pci_device_class_init(ObjectClass *klass, void *data)
|
|
|
|
{
|
|
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
|
|
|
|
|
|
dc->desc = "zpci device";
|
2017-10-04 16:51:49 +08:00
|
|
|
set_bit(DEVICE_CATEGORY_MISC, dc->categories);
|
2016-05-11 15:10:06 +08:00
|
|
|
dc->reset = s390_pci_device_reset;
|
|
|
|
dc->bus_type = TYPE_S390_PCI_BUS;
|
|
|
|
dc->realize = s390_pci_device_realize;
|
2020-01-10 23:30:32 +08:00
|
|
|
device_class_set_props(dc, s390_pci_device_properties);
|
2019-02-01 20:29:08 +08:00
|
|
|
dc->vmsd = &s390_pci_device_vmstate;
|
2016-05-11 15:10:06 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static const TypeInfo s390_pci_device_info = {
|
|
|
|
.name = TYPE_S390_PCI_DEVICE,
|
|
|
|
.parent = TYPE_DEVICE,
|
|
|
|
.instance_size = sizeof(S390PCIBusDevice),
|
|
|
|
.class_init = s390_pci_device_class_init,
|
|
|
|
};
|
|
|
|
|
2016-12-08 13:02:24 +08:00
|
|
|
static TypeInfo s390_pci_iommu_info = {
|
|
|
|
.name = TYPE_S390_PCI_IOMMU,
|
|
|
|
.parent = TYPE_OBJECT,
|
|
|
|
.instance_size = sizeof(S390PCIIOMMU),
|
|
|
|
};
|
|
|
|
|
2017-07-11 11:56:20 +08:00
|
|
|
static void s390_iommu_memory_region_class_init(ObjectClass *klass, void *data)
|
|
|
|
{
|
|
|
|
IOMMUMemoryRegionClass *imrc = IOMMU_MEMORY_REGION_CLASS(klass);
|
|
|
|
|
|
|
|
imrc->translate = s390_translate_iommu;
|
2017-09-05 18:13:00 +08:00
|
|
|
imrc->replay = s390_pci_iommu_replay;
|
2017-07-11 11:56:20 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static const TypeInfo s390_iommu_memory_region_info = {
|
|
|
|
.parent = TYPE_IOMMU_MEMORY_REGION,
|
|
|
|
.name = TYPE_S390_IOMMU_MEMORY_REGION,
|
|
|
|
.class_init = s390_iommu_memory_region_class_init,
|
|
|
|
};
|
|
|
|
|
2015-01-09 16:04:38 +08:00
|
|
|
static void s390_pci_register_types(void)
|
|
|
|
{
|
|
|
|
type_register_static(&s390_pcihost_info);
|
2016-04-14 19:02:39 +08:00
|
|
|
type_register_static(&s390_pcibus_info);
|
2016-05-11 15:10:06 +08:00
|
|
|
type_register_static(&s390_pci_device_info);
|
2016-12-08 13:02:24 +08:00
|
|
|
type_register_static(&s390_pci_iommu_info);
|
2017-07-11 11:56:20 +08:00
|
|
|
type_register_static(&s390_iommu_memory_region_info);
|
2015-01-09 16:04:38 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
type_init(s390_pci_register_types)
|