openkylin
/
qemu
mirror of https://gitee.com/openkylin/qemu.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

hpet: QOM'ify some more 

Introduce type constant, avoid FROM_SYSBUS().

Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
[AF: Renamed parent field and renamed variable]
Signed-off-by: Andreas Färber <afaerber@suse.de>
This commit is contained in:
Hu Tao 2013-07-01 18:18:36 +08:00 committed by Andreas Färber
parent a71c7ec529
commit 02f9a6f5da
1 changed files with 13 additions and 6 deletions
hw/timer
hpet.c

19
hw/timer/hpet.c
View File

@ -42,6 +42,9 @@
#define HPET_MSI_SUPPORT 0 #define HPET_MSI_SUPPORT 0
#define TYPE_HPET "hpet"
#define HPET(obj) OBJECT_CHECK(HPETState, (obj), TYPE_HPET)
struct HPETState; struct HPETState;
typedef struct HPETTimer { /* timers */ typedef struct HPETTimer { /* timers */
uint8_t tn; /*timer number*/ uint8_t tn; /*timer number*/
@ -59,7 +62,10 @@ typedef struct HPETTimer { /* timers */
} HPETTimer; } HPETTimer;
typedef struct HPETState { typedef struct HPETState {
SysBusDevice busdev; /*< private >*/
SysBusDevice parent_obj;
/*< public >*/
MemoryRegion iomem; MemoryRegion iomem;
uint64_t hpet_offset; uint64_t hpet_offset;
qemu_irq irqs[HPET_NUM_IRQ_ROUTES]; qemu_irq irqs[HPET_NUM_IRQ_ROUTES];
@ -634,7 +640,8 @@ static const MemoryRegionOps hpet_ram_ops = {
static void hpet_reset(DeviceState *d) static void hpet_reset(DeviceState *d)
{ {
HPETState *s = FROM_SYSBUS(HPETState, SYS_BUS_DEVICE(d)); HPETState *s = HPET(d);
SysBusDevice *sbd = SYS_BUS_DEVICE(d);
int i; int i;
for (i = 0; i < s->num_timers; i++) { for (i = 0; i < s->num_timers; i++) {
@ -657,7 +664,7 @@ static void hpet_reset(DeviceState *d)
s->hpet_offset = 0ULL; s->hpet_offset = 0ULL;
s->config = 0ULL; s->config = 0ULL;
hpet_cfg.hpet[s->hpet_id].event_timer_block_id = (uint32_t)s->capability; hpet_cfg.hpet[s->hpet_id].event_timer_block_id = (uint32_t)s->capability;
hpet_cfg.hpet[s->hpet_id].address = SYS_BUS_DEVICE(d)->mmio[0].addr; hpet_cfg.hpet[s->hpet_id].address = sbd->mmio[0].addr;
/* to document that the RTC lowers its output on reset as well */ /* to document that the RTC lowers its output on reset as well */
s->rtc_irq_level = 0; s->rtc_irq_level = 0;
@ -665,7 +672,7 @@ static void hpet_reset(DeviceState *d)
static void hpet_handle_legacy_irq(void *opaque, int n, int level) static void hpet_handle_legacy_irq(void *opaque, int n, int level)
{ {
HPETState *s = FROM_SYSBUS(HPETState, opaque); HPETState *s = HPET(opaque);
if (n == HPET_LEGACY_PIT_INT) { if (n == HPET_LEGACY_PIT_INT) {
if (!hpet_in_legacy_mode(s)) { if (!hpet_in_legacy_mode(s)) {
@ -681,7 +688,7 @@ static void hpet_handle_legacy_irq(void *opaque, int n, int level)
static int hpet_init(SysBusDevice *dev) static int hpet_init(SysBusDevice *dev)
{ {
HPETState *s = FROM_SYSBUS(HPETState, dev); HPETState *s = HPET(dev);
int i; int i;
HPETTimer *timer; HPETTimer *timer;
@ -746,7 +753,7 @@ static void hpet_device_class_init(ObjectClass *klass, void *data)
} }
static const TypeInfo hpet_device_info = { static const TypeInfo hpet_device_info = {
.name = "hpet", .name = TYPE_HPET,
.parent = TYPE_SYS_BUS_DEVICE, .parent = TYPE_SYS_BUS_DEVICE,
.instance_size = sizeof(HPETState), .instance_size = sizeof(HPETState),
.class_init = hpet_device_class_init, .class_init = hpet_device_class_init,