openkylin
/
qemu
mirror of https://gitee.com/openkylin/qemu.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

hw/gpio/pl061: Document a shortcoming in our implementation 

The Luminary PL061s in the Stellaris LM3S9695 don't all have the same
reset value for GPIOPUR.  We can get away with not letting the board
configure the PUR reset value because we don't actually wire anything
up to the lines which should reset to pull-up.  Add a comment noting
this omission.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
This commit is contained in:
Peter Maydell 2021-07-02 11:40:17 +01:00
parent ef4989b0a8
commit 0642e159d2
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
hw/gpio/pl061.c
View File

@ -453,6 +453,15 @@ static void pl061_enter_reset(Object *obj, ResetType type)
trace_pl061_reset(DEVICE(s)->canonical_path);
/* reset values from PL061 TRM, Stellaris LM3S5P31 & LM3S8962 Data Sheet */
/*
* FIXME: For the LM3S6965, not all of the PL061 instances have the
* same reset values for GPIOPUR, GPIOAFSEL and GPIODEN, so in theory
* we should allow the board to configure these via properties.
* In practice, we don't wire anything up to the affected GPIO lines
* (PB7, PC0, PC1, PC2, PC3 -- they're used for JTAG), so we can
* get away with this inaccuracy.
*/
s->data = 0;
s->old_in_data = 0;
s->dir = 0;