mirror of https://gitee.com/openkylin/qemu.git
qdev-monitor: Improve error message for -device nonexistant
Once upon a time, the error message was: qemu: -device nonexistant: Device "nonexistant" not found. Try -device '?' for a list. But progress marches on, and conversion to QError (commit0204276
) changed it into: Invalid parameter 'driver' Try with argument '?' for a list. Progress didn't stop there, of course. After a couple of iterations, we arrived at the current message (commit6acbe4c
): qemu: -device nonexistant: Parameter 'driver' expects device type Mission accomplished: this is complete mush. We've since abandoned our quest for "rich" error objects, fortunately before it turned all error messages into mush. Time to undo the damage to this one. Make it: qemu: -device nonexistant: nonexistant is not a valid device model name Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Andreas Färber <afaerber@suse.de>
This commit is contained in:
parent
db0f888848
commit
11c308b17a
|
@ -479,7 +479,8 @@ DeviceState *qdev_device_add(QemuOpts *opts)
|
|||
}
|
||||
|
||||
if (!object_class_dynamic_cast(oc, TYPE_DEVICE)) {
|
||||
qerror_report(QERR_INVALID_PARAMETER_VALUE, "driver", "device type");
|
||||
qerror_report(ERROR_CLASS_GENERIC_ERROR,
|
||||
"'%s' is not a valid device model name", driver);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue