From 3818318682c3aaca7856f577ec61e05e5ad449ea Mon Sep 17 00:00:00 2001 From: Luiz Capitulino Date: Fri, 28 Aug 2009 15:27:08 -0300 Subject: [PATCH] Add wrappers to functions used by the Monitor Some functions exported to be used by the Monitor as command handlers are also called in other places as regular functions. When those functions got ported to use the Monitor dictionary to pass argments, the callers will have to setup a dictionary to be able to call them. To avoid this problem, this commit add wrappers to those functions, so that we change the wrapper to accept the dictionary, letting the current functions as is. The following wrappers are being added: - do_help_cmd() - do_pci_device_hot_remove() Signed-off-by: Luiz Capitulino Signed-off-by: Anthony Liguori --- hw/pci-hotplug.c | 5 +++++ monitor.c | 5 +++++ qemu-monitor.hx | 4 ++-- sysemu.h | 1 + 4 files changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c index 26ff808f12..5d44209046 100644 --- a/hw/pci-hotplug.c +++ b/hw/pci-hotplug.c @@ -203,6 +203,11 @@ void pci_device_hot_remove(Monitor *mon, const char *pci_addr) qemu_system_device_hot_add(bus, slot, 0); } +void do_pci_device_hot_remove(Monitor *mon, const char *pci_addr) +{ + pci_device_hot_remove(mon, pci_addr); +} + static int pci_match_fn(void *dev_private, void *arg) { PCIDevice *dev = dev_private; diff --git a/monitor.c b/monitor.c index 41a83e6def..105a49a73a 100644 --- a/monitor.c +++ b/monitor.c @@ -251,6 +251,11 @@ static void help_cmd(Monitor *mon, const char *name) } } +static void do_help_cmd(Monitor *mon, const char *name) +{ + help_cmd(mon, name); +} + static void do_commit(Monitor *mon, const char *device) { int all_devices; diff --git a/qemu-monitor.hx b/qemu-monitor.hx index f56354bc6e..2ef4bf6e6d 100644 --- a/qemu-monitor.hx +++ b/qemu-monitor.hx @@ -9,7 +9,7 @@ STEXI @table @option ETEXI - { "help|?", "s?", help_cmd, "[cmd]", "show the help" }, + { "help|?", "s?", do_help_cmd, "[cmd]", "show the help" }, STEXI @item help or ? [@var{cmd}] Show the help for all commands or just for command @var{cmd}. @@ -517,7 +517,7 @@ Hot-add PCI device. ETEXI #if defined(TARGET_I386) - { "pci_del", "s", pci_device_hot_remove, "[[:]:]", "hot remove PCI device" }, + { "pci_del", "s", do_pci_device_hot_remove, "[[:]:]", "hot remove PCI device" }, #endif STEXI @item pci_del diff --git a/sysemu.h b/sysemu.h index 45aa8b0dd2..64e3983ec8 100644 --- a/sysemu.h +++ b/sysemu.h @@ -212,6 +212,7 @@ void destroy_bdrvs(dev_match_fn *match_fn, void *arg); void pci_device_hot_add(Monitor *mon, const char *pci_addr, const char *type, const char *opts); void drive_hot_add(Monitor *mon, const char *pci_addr, const char *opts); +void do_pci_device_hot_remove(Monitor *mon, const char *pci_addr); void pci_device_hot_remove(Monitor *mon, const char *pci_addr); void pci_device_hot_remove_success(int pcibus, int slot);