openkylin
/
qemu
mirror of https://gitee.com/openkylin/qemu.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

i2c: Add a length check to the SMBus write handling 

Avoid an overflow.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: QEMU Stable <qemu-stable@nongnu.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Corey Minyard 2018-12-03 06:52:50 -06:00 committed by Peter Maydell
parent 4750e1a888
commit 629457a130
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hw/i2c/smbus.c
View File

@ -193,7 +193,11 @@ static int smbus_i2c_send(I2CSlave *s, uint8_t data)
switch (dev->mode) { switch (dev->mode) {
case SMBUS_WRITE_DATA: case SMBUS_WRITE_DATA:
DPRINTF("Write data %02x\n", data); DPRINTF("Write data %02x\n", data);
dev->data_buf[dev->data_len++] = data; if (dev->data_len >= sizeof(dev->data_buf)) {
BADF("Too many bytes sent\n");
} else {
dev->data_buf[dev->data_len++] = data;
}
break; break;
default: default:
BADF("Unexpected write in state %d\n", dev->mode); BADF("Unexpected write in state %d\n", dev->mode);