QMP: Remove duplicate TPM type from query-tpm

Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
This commit is contained in:
Corey Bryant 2013-03-20 12:34:48 -04:00 committed by Luiz Capitulino
parent dcadaa9b40
commit 88ca7bcff1
3 changed files with 12 additions and 17 deletions

8
hmp.c
View File

@ -631,11 +631,11 @@ void hmp_info_tpm(Monitor *mon, const QDict *qdict)
c, TpmModel_lookup[ti->model]);
monitor_printf(mon, " \\ %s: type=%s",
ti->id, TpmType_lookup[ti->type]);
ti->id, TpmTypeOptionsKind_lookup[ti->options->kind]);
switch (ti->tpm_options->kind) {
case TPM_TYPE_OPTIONS_KIND_TPM_PASSTHROUGH_OPTIONS:
tpo = ti->tpm_options->tpm_passthrough_options;
switch (ti->options->kind) {
case TPM_TYPE_OPTIONS_KIND_PASSTHROUGH:
tpo = ti->options->passthrough;
monitor_printf(mon, "%s%s%s%s",
tpo->has_path ? ",path=" : "",
tpo->has_path ? tpo->path : "",

View File

@ -3403,13 +3403,12 @@
#
# A union referencing different TPM backend types' configuration options
#
# @tpm-passthough-options: TPMPassthroughOptions describing the TPM
# passthrough configuration options
# @passthrough: The configuration options for the TPM passthrough type
#
# Since: 1.5
##
{ 'union': 'TpmTypeOptions',
'data': { 'tpm-passthrough-options' : 'TPMPassthroughOptions' } }
'data': { 'passthrough' : 'TPMPassthroughOptions' } }
##
# @TpmInfo:
@ -3420,17 +3419,14 @@
#
# @model: The TPM frontend model
#
# @type: The TPM (backend) type being used
#
# @tpm-options: The TPM (backend) type configuration options
# @options: The TPM (backend) type configuration options
#
# Since: 1.5
##
{ 'type': 'TPMInfo',
'data': {'id': 'str',
'model': 'TpmModel',
'type': 'TpmType',
'tpm-options': 'TpmTypeOptions' } }
'options': 'TpmTypeOptions' } }
##
# @query-tpm:

View File

@ -257,14 +257,13 @@ static TPMInfo *qmp_query_tpm_inst(TPMBackend *drv)
res->id = g_strdup(drv->id);
res->model = drv->fe_model;
res->type = drv->ops->type;
res->tpm_options = g_new0(TpmTypeOptions, 1);
res->options = g_new0(TpmTypeOptions, 1);
switch (res->type) {
switch (drv->ops->type) {
case TPM_TYPE_PASSTHROUGH:
res->tpm_options->kind = TPM_TYPE_OPTIONS_KIND_TPM_PASSTHROUGH_OPTIONS;
res->options->kind = TPM_TYPE_OPTIONS_KIND_PASSTHROUGH;
tpo = g_new0(TPMPassthroughOptions, 1);
res->tpm_options->tpm_passthrough_options = tpo;
res->options->passthrough = tpo;
if (drv->path) {
tpo->path = g_strdup(drv->path);
tpo->has_path = true;