openkylin
/
qemu
mirror of https://gitee.com/openkylin/qemu.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

iommu: Remove FIXME comment about user_creatable=true 

amd-iommu and intel-iommu are really meant to be used with
-device, so they need user_creatable=true. Remove the FIXME
comment.

Cc: Marcel Apfelbaum <marcel@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Acked-by: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20170503203604.31462-5-ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
This commit is contained in:
Eduardo Habkost 2017-05-03 17:35:47 -03:00
parent 950b31dd17
commit 8ab5700ca0
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
hw/i386/amd_iommu.c
View File

@ -1186,10 +1186,7 @@ static void amdvi_class_init(ObjectClass *klass, void* data)
dc->vmsd = &vmstate_amdvi; dc->vmsd = &vmstate_amdvi;
dc->hotpluggable = false; dc->hotpluggable = false;
dc_class->realize = amdvi_realize; dc_class->realize = amdvi_realize;
/* /* Supported by the pc-q35-* machine types */
* FIXME: Set only because we are not sure yet if this device
* will be outside the q35 sysbus whitelist.
*/
dc->user_creatable = true; dc->user_creatable = true;
} }

5
hw/i386/intel_iommu.c
View File

@ -3009,10 +3009,7 @@ static void vtd_class_init(ObjectClass *klass, void *data)
dc->hotpluggable = false; dc->hotpluggable = false;
x86_class->realize = vtd_realize; x86_class->realize = vtd_realize;
x86_class->int_remap = vtd_int_remap; x86_class->int_remap = vtd_int_remap;
/* /* Supported by the pc-q35-* machine types */
* FIXME: Set only because we are not sure yet if this device
* will be outside the q35 sysbus whitelist.
*/
dc->user_creatable = true; dc->user_creatable = true;
} }