From 99e1dec06f343cefecae9baeec0aae2f99f552d5 Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Tue, 8 Nov 2011 15:36:49 +0100 Subject: [PATCH] x86/cpuid: Plug memory leak in cpudef_setfield() To reproduce the leak, put two name options into the same [cpudef] section of target-x86_64.conf. Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- target-i386/cpuid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c index 352c390d0c..99cff65aae 100644 --- a/target-i386/cpuid.c +++ b/target-i386/cpuid.c @@ -950,6 +950,7 @@ static int cpudef_setfield(const char *name, const char *str, void *opaque) int err = 0; if (!strcmp(name, "name")) { + g_free((void *)def->name); def->name = g_strdup(str); } else if (!strcmp(name, "model_id")) { strncpy(def->model_id, str, sizeof (def->model_id));