openkylin
/
qemu
mirror of https://gitee.com/openkylin/qemu.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

checkpatch: handle token pasting better 

The mechanism to find possible type tokens can sometimes be confused and go into an
infinite loop.  This happens for example in QEMU for a line that looks like

         uint## BITS ##_t S = _S, T = _T;                            \
         uint## BITS ##_t as, at, xs, xt, xd;                        \

Because the token pasting operator does not have a space before _t, it does not
match $notPermitted.  However, (?x) is turned on in the regular expression for
modifiers, and thus ##_t matches the empty string.  As a result, annotate_values
goes in an infinite loop.

The solution is simply to remove token pasting operators from the string before
looking for modifiers.  In the example above, the string uintBITS_t will be
evaluated as a candidate modifier.  This is not optimal, but it works as long
as people do not write things like a##s##m, and it fits nicely into sub
possible.

For a similar reason, \# should be rejected always, even if it is not
at end of line or followed by whitespace.

The same patch was sent to the Linux kernel mailing list.

Reported-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Paolo Bonzini 2018-07-04 18:05:43 +02:00
parent 960a479f7f
commit e20122ff0f
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
scripts/checkpatch.pl
View File

@ -1132,11 +1132,10 @@ sub possible {
case| case|
else| else|
asm|__asm__| asm|__asm__|
do| do
\#|
\#\#
)(?:\s|$)| )(?:\s|$)|
^(?:typedef|struct|enum)\b ^(?:typedef|struct|enum)\b|
^\#
)}x; )}x;
warn "CHECK<$possible> ($line)\n" if ($dbg_possible > 2); warn "CHECK<$possible> ($line)\n" if ($dbg_possible > 2);
if ($possible !~ $notPermitted) { if ($possible !~ $notPermitted) {
@ -1146,7 +1145,7 @@ sub possible {
if ($possible =~ /^\s*$/) { if ($possible =~ /^\s*$/) {
} elsif ($possible =~ /\s/) { } elsif ($possible =~ /\s/) {
$possible =~ s/\s*$Type\s*//g; $possible =~ s/\s*(?:$Type|\#\#)\s*//g;
for my $modifier (split(' ', $possible)) { for my $modifier (split(' ', $possible)) {
if ($modifier !~ $notPermitted) { if ($modifier !~ $notPermitted) {
warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible); warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible);