VFIO updates for v2.12

- Fix bug failing to register all but the first group attached to
    a container with kvm-vfio device (Alex Williamson)
 
  - Explicit QLIST init (Yi Lui)
 
  - SPAPR IOMMU v1 fallback (Alexey Kardashevskiy)
 
  - Remove unused structure fields (Alexey Kardashevskiy)
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.14 (GNU/Linux)
 
 iQIcBAABAgAGBQJaMWuEAAoJECObm247sIsiPw4QAIY5/T+mBHXk/DmmPuvZoPjo
 Ma/gAuM/aGf9uH57OPywp7e4OhJuvOCSil8mgHQ/DOF0NLrkjpW5kya6mFrvhX2/
 BBUZM7Q1mAUUb94iYcv9hv+a6mYw+SedfenEs501HAyoOjXgW7NtPzoIk9zCiWHU
 Z6YcBoLNZhKPHIttpB/xOR6qKLJCNzqY/tOPdB3IX3YtLEvjtm6cRYWwtqOAj9YR
 4C7y+uMp1dubeOpAxsxQhO2f+jnAOHzUQT17q+rOr/zQGohxfkBcQ6ehz1MeTqSI
 L7mVsWQ+0qvVNaISHOtrq4W0LTyB1Cd0Qq1D8k6ubc0k3OMUsW5QBKRTriv0WvRV
 gYCsOFKz1v6aOfGvx2UaZnu8I724XDXIIEF3KBz+oxmQhMkxiOTQYy50nsTjwviO
 blMkmqTZ3Kw5gGwQqpPTPi96L2Lnv8GMM3wJ0R2t3eoHwxiI3bfA6zbPFjovpu9Z
 bgkOUZbwQJo0uFg8FysS2XVEZ/Dt8YpOo9fAKbSao+wbii2zr5Q3h4JZqQZIV7Hp
 E8QUbndHbrU54wMMUwHP6s+4VIfDbHSwoFYymK0SvfwqzuiZZEVhRvzqxXOKjABq
 YKCkzKCDF8w8LwfylRUrLfX8RWOmXzl6zPQnAnLA08zYFmWvYQB08cUsI/tNmhNN
 ShDi+1PcTQe1fxe1YK0O
 =uMcZ
 -----END PGP SIGNATURE-----

Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20171213.0' into staging

VFIO updates for v2.12

 - Fix bug failing to register all but the first group attached to
   a container with kvm-vfio device (Alex Williamson)

 - Explicit QLIST init (Yi Lui)

 - SPAPR IOMMU v1 fallback (Alexey Kardashevskiy)

 - Remove unused structure fields (Alexey Kardashevskiy)

# gpg: Signature made Wed 13 Dec 2017 18:03:48 GMT
# gpg:                using RSA key 0x239B9B6E3BB08B22
# gpg: Good signature from "Alex Williamson <alex.williamson@redhat.com>"
# gpg:                 aka "Alex Williamson <alex@shazbot.org>"
# gpg:                 aka "Alex Williamson <alwillia@redhat.com>"
# gpg:                 aka "Alex Williamson <alex.l.williamson@gmail.com>"
# Primary key fingerprint: 42F6 C04E 540B D1A9 9E7B  8A90 239B 9B6E 3BB0 8B22

* remotes/awilliam/tags/vfio-update-20171213.0:
  vfio-pci: Remove unused fields from VFIOMSIXInfo
  vfio/spapr: Allow fallback to SPAPR TCE IOMMU v1
  vfio/common: init giommu_list and hostwin_list of vfio container
  vfio: Fix vfio-kvm group registration

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Peter Maydell 2017-12-14 13:28:06 +00:00
commit f44cedc916
2 changed files with 8 additions and 2 deletions

View File

@ -968,6 +968,7 @@ static int vfio_connect_container(VFIOGroup *group, AddressSpace *as,
if (!ioctl(group->fd, VFIO_GROUP_SET_CONTAINER, &container->fd)) {
group->container = container;
QLIST_INSERT_HEAD(&container->group_list, group, container_next);
vfio_kvm_device_add_group(group);
return 0;
}
}
@ -990,6 +991,8 @@ static int vfio_connect_container(VFIOGroup *group, AddressSpace *as,
container = g_malloc0(sizeof(*container));
container->space = space;
container->fd = fd;
QLIST_INIT(&container->giommu_list);
QLIST_INIT(&container->hostwin_list);
if (ioctl(fd, VFIO_CHECK_EXTENSION, VFIO_TYPE1_IOMMU) ||
ioctl(fd, VFIO_CHECK_EXTENSION, VFIO_TYPE1v2_IOMMU)) {
bool v2 = !!ioctl(fd, VFIO_CHECK_EXTENSION, VFIO_TYPE1v2_IOMMU);
@ -1039,6 +1042,11 @@ static int vfio_connect_container(VFIOGroup *group, AddressSpace *as,
container->iommu_type =
v2 ? VFIO_SPAPR_TCE_v2_IOMMU : VFIO_SPAPR_TCE_IOMMU;
ret = ioctl(fd, VFIO_SET_IOMMU, container->iommu_type);
if (ret) {
container->iommu_type = VFIO_SPAPR_TCE_IOMMU;
v2 = false;
ret = ioctl(fd, VFIO_SET_IOMMU, container->iommu_type);
}
if (ret) {
error_setg_errno(errp, errno, "failed to set iommu for container");
ret = -errno;

View File

@ -93,8 +93,6 @@ typedef struct VFIOMSIXInfo {
uint16_t entries;
uint32_t table_offset;
uint32_t pba_offset;
MemoryRegion mmap_mem;
void *mmap;
unsigned long *pending;
} VFIOMSIXInfo;