openkylin
/
qemu
mirror of https://gitee.com/openkylin/qemu.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

monitor/hmp-cmds: don't silently output when running 'migrate_set_downtime' fails 

Although 'migrate_set_downtime' has been deprecated and replaced
with 'migrate_set_parameter downtime_limit', it has not been
completely eliminated, possibly due to compatibility with older
versions. I think as long as this old parameter is running, we
should report appropriate message when something goes wrong, not
be silent.

before:
(qemu) migrate_set_downtime -1
(qemu)

after:
(qemu) migrate_set_downtime -1
Error: Parameter 'downtime_limit' expects an integer in the range of 0 to 2000 seconds

Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20200603080904.997083-5-maozhongyi@cmss.chinamobile.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
This commit is contained in:
Mao Zhongyi 2020-06-03 16:08:59 +08:00 committed by Dr. David Alan Gilbert
parent 39337f1211
commit fe025508c0
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
monitor/hmp-cmds.c
View File

@ -1189,8 +1189,11 @@ void hmp_migrate_pause(Monitor *mon, const QDict *qdict)
/* Kept for backwards compatibility */ /* Kept for backwards compatibility */
void hmp_migrate_set_downtime(Monitor *mon, const QDict *qdict) void hmp_migrate_set_downtime(Monitor *mon, const QDict *qdict)
{ {
Error *err = NULL;
double value = qdict_get_double(qdict, "value"); double value = qdict_get_double(qdict, "value");
qmp_migrate_set_downtime(value, NULL); qmp_migrate_set_downtime(value, &err);
hmp_handle_error(mon, err);
} }
void hmp_migrate_set_cache_size(Monitor *mon, const QDict *qdict) void hmp_migrate_set_cache_size(Monitor *mon, const QDict *qdict)