qemu/crypto
Markus Armbruster 8cb846db9e crypto: Fix certificate file error handling crash bug
qcrypto_tls_creds_load_cert() passes uninitialized GError *gerr by
reference to g_file_get_contents().  When g_file_get_contents() fails,
it'll try to set a GError.  Unless @gerr is null by dumb luck, this
logs a ERROR_OVERWRITTEN_WARNING warning message and leaves @gerr
unchanged.  qcrypto_tls_creds_load_cert() then dereferences the
uninitialized @gerr.

Fix by initializing @gerr properly.

Fixes: 9a2fd4347c
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20191204093625.14836-2-armbru@redhat.com>
Acked-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
2019-12-18 08:36:15 +01:00
..
Makefile.objs crypto: add support for gcrypt's native XTS impl 2019-10-28 16:20:28 +01:00
aes.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
afalg.c crypto: introduce some common functions for af_alg backend 2017-07-19 10:11:05 +01:00
afalgpriv.h crypto: hash: add afalg-backend hash support 2017-07-19 10:11:05 +01:00
afsplit.c crypto: use auto cleanup for many stack variables 2019-08-22 10:56:57 +01:00
block-luks.c qcrypto-luks: more rigorous header checking 2019-09-26 16:34:02 +01:00
block-luks.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
block-qcow.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
block-qcow.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
block.c crypto: use auto cleanup for many stack variables 2019-08-22 10:56:57 +01:00
blockpriv.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
cipher-afalg.c qapi: Mechanically convert FOO_lookup[...] to FOO_str(...) 2017-09-04 13:09:13 +02:00
cipher-builtin.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
cipher-gcrypt.c crypto: add support for gcrypt's native XTS impl 2019-10-28 16:20:28 +01:00
cipher-nettle.c crypto: add support for nettle's native XTS impl 2019-10-28 16:45:07 +01:00
cipher.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
cipherpriv.h Include less of the generated modular QAPI headers 2018-03-02 13:45:50 -06:00
desrfb.c crypto: finish removing TABs 2019-02-05 16:50:18 +01:00
hash-afalg.c crypto: hmac: add af_alg-backend hmac support 2017-07-19 10:11:05 +01:00
hash-gcrypt.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
hash-glib.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
hash-nettle.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
hash.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
hashpriv.h crypto: hash: add afalg-backend hash support 2017-07-19 10:11:05 +01:00
hmac-gcrypt.c qapi: Mechanically convert FOO_lookup[...] to FOO_str(...) 2017-09-04 13:09:13 +02:00
hmac-glib.c glib: bump min required glib library version to 2.48 2019-08-22 10:46:34 +01:00
hmac-nettle.c crypto: fix function signatures for nettle 2.7 vs 3 2019-07-19 12:48:22 +01:00
hmac.c Include qapi/error.h exactly where needed 2018-02-09 13:50:17 +01:00
hmacpriv.h crypto: hmac: add af_alg-backend hmac support 2017-07-19 10:11:05 +01:00
init.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-essiv.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-essiv.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-plain.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-plain.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-plain64.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-plain64.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgenpriv.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
pbkdf-gcrypt.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
pbkdf-nettle.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
pbkdf-stub.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
pbkdf.c crypto: use auto cleanup for many stack variables 2019-08-22 10:56:57 +01:00
random-gcrypt.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
random-gnutls.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
random-platform.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
secret.c crypto: use auto cleanup for many stack variables 2019-08-22 10:56:57 +01:00
tlscreds.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
tlscredsanon.c crypto: use auto cleanup for many stack variables 2019-08-22 10:56:57 +01:00
tlscredspriv.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
tlscredspsk.c crypto: use auto cleanup for many stack variables 2019-08-22 10:56:57 +01:00
tlscredsx509.c crypto: Fix certificate file error handling crash bug 2019-12-18 08:36:15 +01:00
tlssession.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
trace-events trace-events: Shorten file names in comments 2019-03-22 16:18:07 +00:00
xts.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00