mirror of https://gitee.com/openkylin/qemu.git
b4ba67d9a7
The usual use model for the libqos PCI functions is to map a specific PCI BAR using qpci_iomap() then pass the returned token into IO accessor functions. This, and the fact that iomap() returns a (void *) which actually contains a PCI space address, kind of suggests that the return value from iomap is supposed to be an opaque token. ..except that the callers expect to be able to add offsets to it. Which also assumes the compiler will support pointer arithmetic on a (void *), and treat it as working with byte offsets. To clarify this situation change iomap() and the IO accessors to take a definitely opaque BAR handle (enforced with a wrapper struct) along with an offset within the BAR. This changes both the functions and all the callers. There were a number of places that checked if iomap() returned non-NULL, and or initialized it to NULL before hand. Since iomap() already assert()s if it fails to map the BAR, these tests were mostly pointless and are removed. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Greg Kurz <groug@kaod.org> |
||
|---|---|---|
| .. | ||
| ahci.c | ||
| ahci.h | ||
| fw_cfg.c | ||
| fw_cfg.h | ||
| i2c-imx.c | ||
| i2c-omap.c | ||
| i2c.c | ||
| i2c.h | ||
| libqos-pc.c | ||
| libqos-pc.h | ||
| libqos-spapr.c | ||
| libqos-spapr.h | ||
| libqos.c | ||
| libqos.h | ||
| malloc-generic.c | ||
| malloc-generic.h | ||
| malloc-pc.c | ||
| malloc-pc.h | ||
| malloc-spapr.c | ||
| malloc-spapr.h | ||
| malloc.c | ||
| malloc.h | ||
| pci-pc.c | ||
| pci-pc.h | ||
| pci-spapr.c | ||
| pci-spapr.h | ||
| pci.c | ||
| pci.h | ||
| rtas.c | ||
| rtas.h | ||
| usb.c | ||
| usb.h | ||
| virtio-mmio.c | ||
| virtio-mmio.h | ||
| virtio-pci.c | ||
| virtio-pci.h | ||
| virtio.c | ||
| virtio.h | ||