Go to file
Markus Armbruster d7445b57f4 qapi-visit: Simplify how we visit common union members
For a simple union SU, gen_visit_union() generates a visit of its
single tag member, like this:

    visit_type_SUKind(v, "type", &(*obj)->type, &err);

For a flat union FU with base B, it generates a visit of its base
fields:

    visit_type_B_fields(v, (B **)obj, &err);

Instead, we can simply visit the common members using the same fields
visit function we use for structs, generated with
gen_visit_struct_fields().  This function visits the base if any, then
the local members.

For a simple union SU, visit_type_SU_fields() contains exactly the old
tag member visit, because there is no base, and the tag member is the
only member.  For instance, the code generated for qapi-schema.json's
KeyValue changes like this:

    +static void visit_type_KeyValue_fields(Visitor *v, KeyValue **obj, Error **errp)
    +{
    +    Error *err = NULL;
    +
    +    visit_type_KeyValueKind(v, "type", &(*obj)->type, &err);
    +    if (err) {
    +        goto out;
    +    }
    +
    +out:
    +    error_propagate(errp, err);
    +}
    +
     void visit_type_KeyValue(Visitor *v, const char *name, KeyValue **obj, Error **errp)
     {
         Error *err = NULL;
    @@ -4863,7 +4911,7 @@ void visit_type_KeyValue(Visitor *v, con
         if (!*obj) {
             goto out_obj;
         }
    -    visit_type_KeyValueKind(v, "type", &(*obj)->type, &err);
    +    visit_type_KeyValue_fields(v, obj, &err);
         if (err) {
             goto out_obj;
         }

For a flat union FU, visit_type_FU_fields() contains exactly the old
base fields visit, because there is a base, but no members.  For
instance, the code generated for qapi-schema.json's CpuInfo changes
like this:

     static void visit_type_CpuInfoBase_fields(Visitor *v, CpuInfoBase **obj, Error **errp);

    +static void visit_type_CpuInfo_fields(Visitor *v, CpuInfo **obj, Error **errp)
    +{
    +    Error *err = NULL;
    +
    +    visit_type_CpuInfoBase_fields(v, (CpuInfoBase **)obj, &err);
    +    if (err) {
    +        goto out;
    +    }
    +
    +out:
    +    error_propagate(errp, err);
    +}
    +
     static void visit_type_CpuInfoX86_fields(Visitor *v, CpuInfoX86 **obj, Error **errp)
...
    @@ -3485,7 +3509,7 @@ void visit_type_CpuInfo(Visitor *v, cons
         if (!*obj) {
             goto out_obj;
         }
    -    visit_type_CpuInfoBase_fields(v, (CpuInfoBase **)obj, &err);
    +    visit_type_CpuInfo_fields(v, obj, &err);
         if (err) {
             goto out_obj;
         }

As you see, the generated code grows a bit, but in practice, it's lost
in the noise: qapi-schema.json's qapi-visit.c gains roughly 1%.

This simplification became possible with commit 441cbac "qapi-visit:
Convert to QAPISchemaVisitor, fixing bugs".  It's a step towards
unifying gen_struct() and gen_union().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1453902888-20457-2-git-send-email-armbru@redhat.com>
[improve commit message examples]
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1455778109-6278-6-git-send-email-eblake@redhat.com>
[Commit message tweaked]
2016-02-19 11:08:57 +01:00
audio audio: Clean up includes 2016-02-02 13:57:31 +01:00
backends qom: Swap 'name' next to visitor in ObjectPropertyAccessor 2016-02-08 17:29:56 +01:00
block nbd: enable use of TLS with NBD block driver 2016-02-16 17:16:33 +01:00
bsd-user bsd-user: Clean up includes 2016-02-04 17:01:04 +00:00
contrib contrib: Clean up includes 2016-02-04 17:41:30 +00:00
crypto crypto: ensure qcrypto_hash_digest_len is always defined 2016-02-02 13:02:56 +00:00
default-configs hw: Add support for LSI SAS1068 (mptsas) device 2016-02-09 15:45:26 +01:00
disas disas: Clean up includes 2016-02-04 17:41:30 +00:00
docs qapi: Forbid empty unions and useless alternates 2016-02-19 11:08:56 +01:00
dtc@65cc4d2748 dtc: Update dtc / libfdt submodule to version 1.4.0 2015-06-03 23:56:49 +02:00
fpu all: Clean up includes 2016-02-04 17:41:30 +00:00
fsdev man: virtfs-proxy-helper: Rework awkward sentence 2016-02-11 15:15:46 +03:00
gdb-xml target-ppc: gdbstub: Add VSX support 2016-01-30 23:37:38 +11:00
hw hw/timer: QOM'ify pxa2xx_timer 2016-02-18 14:50:51 +00:00
include hw/sd/sdhci.c: Update to use SDBus APIs 2016-02-18 14:26:33 +00:00
io io: convert QIOChannelBuffer to use uint8_t instead of char 2016-02-15 14:49:18 +00:00
libdecnumber libdecnumber: Clean up includes 2016-02-16 14:29:27 +00:00
linux-headers linux-headers: update from kvm/next 2015-12-17 15:24:34 +01:00
linux-user log: do not unnecessarily include qom/cpu.h 2016-02-03 09:19:10 +00:00
migration migration: fix incorrect memory_global_dirty_log_start outside BQL 2016-02-16 15:34:43 +01:00
nbd nbd: implement TLS support in the protocol negotiation 2016-02-16 17:16:28 +01:00
net qom: Swap 'name' next to visitor in ObjectPropertyAccessor 2016-02-08 17:29:56 +01:00
pc-bios s390x: remove s390-zipl.rom 2016-02-11 15:15:47 +03:00
pixman@87eea99e44 pixman: update internal copy to pixman-0.32.6 2014-09-15 08:14:19 +02:00
po Update language files for QEMU 2.5.0 2015-12-10 13:50:45 +00:00
qapi qapi: Simplify excess input reporting in input visitors 2016-02-19 11:08:56 +01:00
qga qga: Clean up includes 2016-02-04 17:41:30 +00:00
qobject qobject: Document more shortcomings in our number handling 2016-02-08 17:29:54 +01:00
qom qom: add helpers for UserCreatable object types 2016-02-16 17:12:57 +01:00
replay qapi: Swap visit_* arguments for consistent 'name' placement 2016-02-08 17:29:56 +01:00
roms Update OpenBIOS images 2016-02-04 11:17:44 +00:00
scripts qapi-visit: Simplify how we visit common union members 2016-02-19 11:08:57 +01:00
slirp slirp: Clean up includes 2016-02-04 17:41:30 +00:00
stubs all: Clean up includes 2016-02-16 14:29:28 +00:00
target-alpha tcg: Change tcg_global_mem_new_* to take a TCGv_ptr 2016-02-09 10:19:32 +11:00
target-arm target-arm: Add PMUSERENR_EL0 register 2016-02-18 14:26:20 +00:00
target-cris cris: Clean up includes 2016-02-16 14:29:26 +00:00
target-i386 target-i386: Implement FSGSBASE 2016-02-15 14:50:00 +11:00
target-lm32 tcg: Change tcg_global_mem_new_* to take a TCGv_ptr 2016-02-09 10:19:32 +11:00
target-m68k tcg: Change tcg_global_mem_new_* to take a TCGv_ptr 2016-02-09 10:19:32 +11:00
target-microblaze tcg: Change tcg_global_mem_new_* to take a TCGv_ptr 2016-02-09 10:19:32 +11:00
target-mips tcg: Change tcg_global_mem_new_* to take a TCGv_ptr 2016-02-09 10:19:32 +11:00
target-moxie tcg: Change tcg_global_mem_new_* to take a TCGv_ptr 2016-02-09 10:19:32 +11:00
target-openrisc tcg: Change tcg_global_mem_new_* to take a TCGv_ptr 2016-02-09 10:19:32 +11:00
target-ppc target-ppc: Remove hack for ppc_hash64_load_hpte*() with HV KVM 2016-02-17 09:59:30 +11:00
target-s390x tcg: Change tcg_global_mem_new_* to take a TCGv_ptr 2016-02-09 10:19:32 +11:00
target-sh4 tcg: Change tcg_global_mem_new_* to take a TCGv_ptr 2016-02-09 10:19:32 +11:00
target-sparc tcg: Change tcg_global_mem_new_* to take a TCGv_ptr 2016-02-09 10:19:32 +11:00
target-tilegx tcg: Change tcg_global_mem_new_* to take a TCGv_ptr 2016-02-09 10:19:32 +11:00
target-tricore tcg: Change tcg_global_mem_new_* to take a TCGv_ptr 2016-02-09 10:19:32 +11:00
target-unicore32 tcg: Change tcg_global_mem_new_* to take a TCGv_ptr 2016-02-09 10:19:32 +11:00
target-xtensa tcg: Change tcg_global_mem_new_* to take a TCGv_ptr 2016-02-09 10:19:32 +11:00
tcg tcg: Introduce temp_load 2016-02-09 10:45:34 +11:00
tests qapi: Add tests of complex objects within alternate 2016-02-19 11:08:57 +01:00
trace all: Clean up includes 2016-02-04 17:41:30 +00:00
ui ui/cocoa.m: Include qemu/osdep.h 2016-02-08 13:14:40 +00:00
util oslib-posix.c: Move workaround for OSX daemon() deprecation to osdep.h 2016-02-16 14:29:28 +00:00
.dir-locals.el Add .dir-locals.el file to configure emacs coding style 2015-10-08 19:46:01 +03:00
.exrc qemu: add .exrc 2012-09-07 09:02:44 +03:00
.gitignore maint: Ignore ivshmem binaries 2015-11-06 15:42:38 +03:00
.gitmodules PPC: Add u-boot firmware for e500 2014-06-16 13:24:35 +02:00
.mailmap Update mailmap 2013-09-05 09:40:31 -05:00
.travis.yml .travis.yml: reduce the test matrix a little 2016-02-08 18:50:25 +00:00
CODING_STYLE CODING_STYLE: update mixed declaration rules 2015-09-09 15:34:54 +02:00
COPYING
COPYING.LIB
Changelog Use qemu-project.org domain name 2013-10-11 09:34:56 -07:00
HACKING HACKING: Add a section on error handling and reporting 2016-02-09 13:19:49 +01:00
LICENSE vfio: move hw/misc/vfio.c to hw/vfio/pci.c Move vfio.h into include/hw/vfio 2014-12-19 15:24:06 -07:00
MAINTAINERS * switch to C11 atomics (Alex) 2016-02-09 19:34:46 +00:00
Makefile nbd: convert block client to use I/O channels for connection setup 2016-02-16 17:13:22 +01:00
Makefile.objs log: move qemu-log.c into util/ directory 2016-02-03 09:19:10 +00:00
Makefile.target io: add abstract QIOChannel classes 2015-12-18 12:18:05 +00:00
README README: fill out some useful quickstart information 2015-10-13 18:48:46 +02:00
VERSION Open 2.6 development tree 2015-12-17 10:17:08 +00:00
accel.c all: Clean up includes 2016-02-04 17:41:30 +00:00
aio-posix.c all: Clean up includes 2016-02-04 17:41:30 +00:00
aio-win32.c all: Clean up includes 2016-02-04 17:41:30 +00:00
arch_init.c all: Clean up includes 2016-02-04 17:41:30 +00:00
async.c all: Clean up includes 2016-02-04 17:41:30 +00:00
balloon.c all: Clean up includes 2016-02-04 17:41:30 +00:00
block.c all: Clean up includes 2016-02-04 17:41:30 +00:00
blockdev-nbd.c nbd: enable use of TLS with nbd-server-start command 2016-02-16 17:17:49 +01:00
blockdev.c qapi: Swap visit_* arguments for consistent 'name' placement 2016-02-08 17:29:56 +01:00
blockjob.c blockjob: Fix hang in block_job_finish_sync 2016-02-09 13:52:26 +00:00
bootdevice.c qom: Swap 'name' next to visitor in ObjectPropertyAccessor 2016-02-08 17:29:56 +01:00
bt-host.c all: Clean up includes 2016-02-04 17:41:30 +00:00
bt-vhci.c all: Clean up includes 2016-02-04 17:41:30 +00:00
configure Xen 2016-02-12 2016-02-12 17:36:12 +00:00
cpu-exec-common.c exec: Clean up includes 2016-01-29 15:07:22 +00:00
cpu-exec.c log: do not unnecessarily include qom/cpu.h 2016-02-03 09:19:10 +00:00
cpus.c qapi: Fix compilation failure on MIPS and SPARC 2016-02-08 17:29:57 +01:00
cputlb.c exec: Clean up includes 2016-01-29 15:07:22 +00:00
device-hotplug.c all: Clean up includes 2016-02-04 17:41:30 +00:00
device_tree.c all: Clean up includes 2016-02-04 17:41:30 +00:00
disas.c all: Clean up includes 2016-02-04 17:41:30 +00:00
dma-helpers.c all: Clean up includes 2016-02-04 17:41:30 +00:00
dump.c all: Clean up includes 2016-02-04 17:41:30 +00:00
exec.c trivial patches for 2016-02-11 2016-02-11 15:09:33 +00:00
gdbstub.c all: Clean up includes 2016-02-04 17:41:30 +00:00
hmp-commands-info.hx hmp: added io apic dump state 2015-09-25 12:04:42 +02:00
hmp-commands.hx migrate-start-postcopy: Improve text 2015-11-12 17:54:39 +01:00
hmp.c nbd: enable use of TLS with nbd-server-start command 2016-02-16 17:17:49 +01:00
hmp.h migrate_start_postcopy: Command to trigger transition to postcopy 2015-11-10 15:00:26 +01:00
iohandler.c all: Clean up includes 2016-02-04 17:41:30 +00:00
ioport.c all: Clean up includes 2016-02-04 17:41:30 +00:00
iothread.c all: Clean up includes 2016-02-04 17:41:30 +00:00
kvm-all.c kvm-all: trace: strerror fixup 2016-02-09 15:45:26 +01:00
kvm-stub.c all: Clean up includes 2016-02-04 17:41:30 +00:00
main-loop.c all: Clean up includes 2016-02-04 17:41:30 +00:00
memory.c qom: Swap 'name' next to visitor in ObjectPropertyAccessor 2016-02-08 17:29:56 +01:00
memory_mapping.c all: Clean up includes 2016-02-04 17:41:30 +00:00
module-common.c all: Clean up includes 2016-02-04 17:41:30 +00:00
monitor.c all: Clean up includes 2016-02-04 17:41:30 +00:00
numa.c qapi: Swap visit_* arguments for consistent 'name' placement 2016-02-08 17:29:56 +01:00
os-posix.c all: Clean up includes 2016-02-04 17:41:30 +00:00
os-win32.c all: Clean up includes 2016-02-04 17:41:30 +00:00
page_cache.c all: Clean up includes 2016-02-04 17:41:30 +00:00
qapi-schema.json char: introduce support for TLS encrypted TCP chardev backend 2016-01-26 15:58:11 +01:00
qdev-monitor.c all: Clean up includes 2016-02-04 17:41:30 +00:00
qdict-test-data.txt
qemu-bridge-helper.c all: Clean up includes 2016-02-04 17:41:30 +00:00
qemu-char.c char: fix handling of QIO_CHANNEL_ERR_BLOCK 2016-02-16 09:27:59 +01:00
qemu-doc.texi remove libtool support 2016-02-11 15:15:46 +03:00
qemu-ga.texi docs: Style the command and its options in the synopsis 2016-01-26 15:58:11 +01:00
qemu-img-cmds.hx qemu-img: Add progress output for amend 2014-11-03 11:41:48 +00:00
qemu-img.c nbd: convert block client to use I/O channels for connection setup 2016-02-16 17:13:22 +01:00
qemu-img.texi docs: Style the command and its options in the synopsis 2016-01-26 15:58:11 +01:00
qemu-io-cmds.c block: Clean up includes 2016-01-20 13:36:23 +01:00
qemu-io.c nbd: convert block client to use I/O channels for connection setup 2016-02-16 17:13:22 +01:00
qemu-nbd.c nbd: enable use of TLS with qemu-nbd server 2016-02-16 17:17:42 +01:00
qemu-nbd.texi nbd: enable use of TLS with qemu-nbd server 2016-02-16 17:17:42 +01:00
qemu-options-wrapper.h vl.c: In qemu -h output, only print options for the arch we are running as 2011-12-19 10:27:33 -06:00
qemu-options.h vl.c: Move option generation logic into a wrapper file 2011-12-19 10:27:33 -06:00
qemu-options.hx pc: set the OEM fields in the RSDT and the FADT from the SLIC 2016-02-06 20:44:10 +02:00
qemu-seccomp.c all: Clean up includes 2016-02-04 17:41:30 +00:00
qemu-tech.texi doc: Refresh URLs in the qemu-tech documentation 2015-09-25 12:20:21 +02:00
qemu-timer.c all: Clean up includes 2016-02-04 17:41:30 +00:00
qemu.nsi nsis: Add QEMU version information to Windows registry 2015-09-24 20:52:28 +02:00
qemu.sasl sasl: Avoid 'Could not find keytab file' in syslog 2014-03-15 13:54:18 +04:00
qjson.c all: Clean up includes 2016-02-04 17:41:30 +00:00
qmp-commands.hx nbd: enable use of TLS with nbd-server-start command 2016-02-16 17:17:49 +01:00
qmp.c qom: add helpers for UserCreatable object types 2016-02-16 17:12:57 +01:00
qtest.c all: Clean up includes 2016-02-04 17:41:30 +00:00
rules.mak remove libtool support 2016-02-11 15:15:46 +03:00
softmmu_template.h exec.c: Pass MemTxAttrs to iotlb_to_region so it uses the right AS 2016-01-21 14:15:05 +00:00
spice-qemu-char.c all: Clean up includes 2016-02-04 17:41:30 +00:00
tcg-runtime.c all: Clean up includes 2016-02-04 17:41:30 +00:00
tci.c all: Clean up includes 2016-02-04 17:41:30 +00:00
thread-pool.c all: Clean up includes 2016-02-04 17:41:30 +00:00
thunk.c all: Clean up includes 2016-02-04 17:41:30 +00:00
tpm.c all: Clean up includes 2016-02-04 17:41:30 +00:00
trace-events hw: Add support for LSI SAS1068 (mptsas) device 2016-02-09 15:45:26 +01:00
translate-all.c log: do not unnecessarily include qom/cpu.h 2016-02-03 09:19:10 +00:00
translate-all.h translate-all: remove unnecessary argument to tb_invalidate_phys_range 2015-06-05 17:09:59 +02:00
translate-common.c exec: Clean up includes 2016-01-29 15:07:22 +00:00
user-exec.c all: Clean up includes 2016-02-04 17:41:30 +00:00
version.rc Use qemu-project.org domain name 2013-10-11 09:34:56 -07:00
vl.c qom: add helpers for UserCreatable object types 2016-02-16 17:12:57 +01:00
xen-common-stub.c xen: Clean up includes 2016-01-29 15:07:23 +00:00
xen-common.c xen: drop XenXC and associated interface wrappers 2016-02-10 12:01:24 +00:00
xen-hvm-stub.c fix MSI injection on Xen 2016-02-06 20:44:10 +02:00
xen-hvm.c xen: Drop __XEN_LATEST_INTERFACE_VERSION__ checks from prior to Xen 4.2 2016-02-10 12:01:32 +00:00
xen-mapcache.c xen: Clean up includes 2016-01-29 15:07:23 +00:00

README

         QEMU README
         ===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:

  mkdir build
  cd build
  ../configure
  make

Complete details of the process for building and configuring QEMU for
all supported host platforms can be found in the qemu-tech.html file.
Additional information can also be found online via the QEMU website:

  http://qemu-project.org/Hosts/Linux
  http://qemu-project.org/Hosts/W32


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

   git clone git://git.qemu-project.org/qemu.git

When submitting patches, the preferred approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the HACKING and CODING_STYLE files.

Additional information on submitting patches can be found online via
the QEMU website

  http://qemu-project.org/Contribute/SubmitAPatch
  http://qemu-project.org/Contribute/TrivialPatches


Bug reporting
=============

The QEMU project uses Launchpad as its primary upstream bug tracker. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

  https://bugs.launchpad.net/qemu/

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via launchpad.

For additional information on bug reporting consult:

  http://qemu-project.org/Contribute/ReportABug


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

 - qemu-devel@nongnu.org
   http://lists.nongnu.org/mailman/listinfo/qemu-devel
 - #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

  http://qemu-project.org/Contribute/StartHere

-- End