Go to file
Daniel P. Berrange f887cf165d ui: place a hard cap on VNC server output buffer size
The previous patches fix problems with throttling of forced framebuffer updates
and audio data capture that would cause the QEMU output buffer size to grow
without bound. Those fixes are graceful in that once the client catches up with
reading data from the server, everything continues operating normally.

There is some data which the server sends to the client that is impractical to
throttle. Specifically there are various pseudo framebuffer update encodings to
inform the client of things like desktop resizes, pointer changes, audio
playback start/stop, LED state and so on. These generally only involve sending
a very small amount of data to the client, but a malicious guest might be able
to do things that trigger these changes at a very high rate. Throttling them is
not practical as missed or delayed events would cause broken behaviour for the
client.

This patch thus takes a more forceful approach of setting an absolute upper
bound on the amount of data we permit to be present in the output buffer at
any time. The previous patch set a threshold for throttling the output buffer
by allowing an amount of data equivalent to one complete framebuffer update and
one seconds worth of audio data. On top of this it allowed for one further
forced framebuffer update to be queued.

To be conservative, we thus take that throttling threshold and multiply it by
5 to form an absolute upper bound. If this bound is hit during vnc_write() we
forceably disconnect the client, refusing to queue further data. This limit is
high enough that it should never be hit unless a malicious client is trying to
exploit the sever, or the network is completely saturated preventing any sending
of data on the socket.

This completes the fix for CVE-2017-15124 started in the previous patches.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20171218191228.31018-12-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2018-01-12 13:48:54 +01:00
accel Queued TCG patches 2018-01-08 16:17:04 +00:00
audio buildsys: Move audio libs to per object 2017-09-22 10:20:34 +08:00
backends tpm: tpm_emulator: get and set buffer size of device 2017-12-14 23:39:15 -05:00
block block/nbd: fix segmentation fault when .desc is not null-terminated 2018-01-08 09:12:23 -06:00
bsd-user misc: remove headers implicitly included 2017-12-18 17:07:02 +03:00
capstone@22ead3e0bf disas: Add capstone as submodule 2017-10-26 11:56:20 +02:00
chardev chardev: convert the socket server to QIONetListener 2017-12-21 09:30:32 +01:00
contrib contrib: add systemd unit files 2017-12-20 22:29:26 +01:00
crypto crypto: afalg: fix a NULL pointer dereference 2017-11-08 11:05:09 +00:00
default-configs target-arm queue: 2018-01-11 14:34:41 +00:00
disas target/xtensa updates: 2018-01-09 18:23:27 +00:00
docs qapi-docs: fix a comment typo 2017-12-20 19:18:33 +01:00
dtc@e54388015a Update dtc to fix compilation problem on Mac OS 10.6 2018-01-10 12:53:00 +11:00
fpu softfloat: define floatx80_round() 2017-06-29 20:27:39 +02:00
fsdev fsdev: improve error handling of backend init 2018-01-08 11:18:23 +01:00
gdb-xml s390x/gdb: add gs registers 2017-07-14 12:29:49 +02:00
hw target-arm queue: 2018-01-11 14:34:41 +00:00
include target-arm queue: 2018-01-11 14:34:41 +00:00
io io: introduce a network socket listener API 2017-12-15 15:07:26 +00:00
libdecnumber build: remove CONFIG_LIBDECNUMBER 2017-10-16 18:03:52 +02:00
linux-headers linux-headers: update to 4.15-rc1 2017-12-13 17:59:23 +00:00
linux-user linux-user/arm/nwfpe: Check coprocessor number for FPA emulation 2018-01-11 13:25:39 +00:00
migration Remove empty statements 2017-12-18 17:07:02 +03:00
nbd nbd: rename nbd_option and nbd_opt_reply 2018-01-10 12:11:23 -06:00
net net: Remove the legacy "-net channel" parameter 2017-12-22 10:05:26 +08:00
pc-bios pseries: Update SLOF firmware image to qemu-slof-20171214 2018-01-10 12:52:59 +11:00
po po: add missing translations in de, fr, it, zh 2016-12-14 18:47:19 +00:00
qapi block: Document that x-blockdev-change breaks quorum children list 2017-12-22 15:03:41 +01:00
qga sockets: remove obsolete code that updated listen address 2017-12-21 09:22:44 +01:00
qobject qapi: Add qobject_is_equal() 2017-11-17 18:21:30 +01:00
qom tcg: Add CPUState cflags_next_tb 2017-10-24 13:53:41 -07:00
replay migration: pre_save return int 2017-09-27 11:35:59 +01:00
roms pseries: Update SLOF firmware image to qemu-slof-20171214 2018-01-10 12:52:59 +11:00
scripts target-arm queue: 2018-01-11 14:34:41 +00:00
scsi scsi: replace hex constants with #defines 2017-12-21 09:30:32 +01:00
slirp slirp: don't zero the whole ti_i when m == NULL 2017-11-09 18:59:22 +01:00
stubs tpm: add stubs 2017-10-25 01:05:04 -04:00
target target-arm queue: 2018-01-11 14:34:41 +00:00
tcg tcg: Allow 6 arguments to TCG helpers 2017-12-29 12:43:40 -08:00
tests target/xtensa updates: 2018-01-09 18:23:27 +00:00
trace trace: Try using tracefs first 2017-12-18 14:37:36 +00:00
ui ui: place a hard cap on VNC server output buffer size 2018-01-12 13:48:54 +01:00
util * NBD and chardev conversion to QIONetListener (Daniel) 2017-12-21 16:34:23 +00:00
.dir-locals.el Add .dir-locals.el file to configure emacs coding style 2015-10-08 19:46:01 +03:00
.editorconfig add editorconfig 2017-07-20 09:56:56 +02:00
.exrc qemu: add .exrc 2012-09-07 09:02:44 +03:00
.gdbinit .gdbinit: load QEMU sub-commands when gdb starts 2017-06-07 14:38:45 +01:00
.gitignore .gitignore: remove vscclient 2017-12-18 17:07:02 +03:00
.gitmodules disas: Add capstone as submodule 2017-10-26 11:56:20 +02:00
.mailmap MAINTAINERS: Update Paul Burton's email address 2017-11-06 07:36:43 -08:00
.shippable.yml shippable: add win32/64 targets 2017-07-18 10:58:36 +01:00
.travis.yml travis: move make -j flag out of script 2017-07-18 09:39:19 +01:00
CODING_STYLE coding_style: add point about 0x in trace-events 2017-08-01 12:13:07 +01:00
COPYING
COPYING.LIB
COPYING.PYTHON scripts: add argparse module for Python 2.6 compatibility 2017-08-30 12:02:11 +01:00
Changelog Use HTTPS for qemu.org and other domains 2017-11-21 13:34:13 +00:00
HACKING HACKING: document #include order 2017-01-03 16:38:47 +00:00
LICENSE vfio: move hw/misc/vfio.c to hw/vfio/pci.c Move vfio.h into include/hw/vfio 2014-12-19 15:24:06 -07:00
MAINTAINERS ppc patch queue 2018-01-11 2018-01-11 13:24:17 +00:00
Makefile Makefile: add more targets to the UNCHECKED_GOALS rule 2017-12-18 17:07:02 +03:00
Makefile.objs sparc64: introduce trace-events for hw/sparc64 2018-01-09 21:48:19 +00:00
Makefile.target Fix build of console and GUI executables for Windows 2017-11-23 10:46:42 +00:00
README Use HTTPS for qemu.org and other domains 2017-11-21 13:34:13 +00:00
VERSION Open 2.12 development tree 2017-12-13 17:05:59 +00:00
arch_init.c audio: Rename hw/audio/audio.h to hw/audio/soundhw.h 2017-05-19 10:48:54 +02:00
balloon.c trace: switch to modular code generation for sub-directories 2017-01-31 17:11:18 +00:00
block.c block: Keep nodes drained between reopen_queue/multiple 2017-12-22 15:05:32 +01:00
blockdev-nbd.c blockdev: convert internal NBD server to QIONetListener 2017-12-21 09:30:32 +01:00
blockdev.c block: Remove the obsolete -drive boot=on|off parameter 2017-12-22 15:03:41 +01:00
blockjob.c blockjob: Pause job on draining any job BDS 2017-12-22 15:05:32 +01:00
bootdevice.c Makefile: Move bootdevice.o to common-obj-y 2017-07-04 14:39:27 +02:00
bt-host.c all: Clean up includes 2016-02-04 17:41:30 +00:00
bt-vhci.c all: Clean up includes 2016-02-04 17:41:30 +00:00
configure configure: Add aarch64_be-linux-user target 2018-01-11 13:25:32 +00:00
cpus-common.c *_run_on_cpu: introduce run_on_cpu_data type 2016-10-31 15:00:25 +01:00
cpus.c i386: hvf: add code base from Google's QEMU repository 2017-12-22 15:01:20 +01:00
device-hotplug.c blockdev: Split monitor reference from BB creation 2016-03-17 15:47:56 +01:00
device_tree.c device_tree: fix compiler warnings (clang 5) 2017-05-07 09:57:51 +03:00
disas.c disas: Dump insn bytes along with capstone disassembly 2017-11-09 08:46:38 +01:00
dma-helpers.c block: explicitly acquire aiocontext in bottom halves that need it 2017-02-21 11:39:39 +00:00
dump.c dump: fix note_name_equal() 2018-01-02 14:49:54 +01:00
exec.c exec: Don't reuse unassigned_mem_ops for io_mem_rom 2017-12-21 09:30:32 +01:00
gdbstub.c gdbstub: add tracing 2017-12-18 14:37:36 +00:00
hmp-commands-info.hx hmp-commands-info: Change "@findex FOO" to "@findex info FOO" 2017-10-05 10:08:39 +01:00
hmp-commands.hx hmp-commands: Remove the deprecated usb_add and usb_del 2017-12-14 10:16:52 +00:00
hmp.c block: Don't acquire AioContext in hmp_qemu_io() 2017-12-22 15:03:41 +01:00
hmp.h migrate: HMP migate_continue 2017-10-23 18:03:31 +02:00
ioport.c trace: switch to modular code generation for sub-directories 2017-01-31 17:11:18 +00:00
iothread.c iothread: fix iothread_stop() race condition 2017-12-19 10:25:09 +00:00
memory.c memory: remove unused memory_region_set_global_locking() 2017-12-18 17:07:02 +03:00
memory_ldst.inc.c exec: introduce memory_ldst.inc.c 2016-12-22 16:00:23 +01:00
memory_mapping.c dump: fix memory_mapping_filter leak 2017-06-04 18:42:55 +03:00
module-common.c all: Clean up includes 2016-02-04 17:41:30 +00:00
monitor.c misc: remove old i386 dependency 2017-12-18 17:07:02 +03:00
numa.c numa: remove unused #include 2017-12-18 17:07:02 +03:00
os-posix.c os-posix: Drop misleading comment 2017-10-16 21:01:37 +03:00
os-win32.c shutdown: Add source information to SHUTDOWN and RESET 2017-05-23 13:28:17 +02:00
qapi-schema.json qmp: remove qmp_cpu 2017-12-20 19:18:33 +01:00
qdev-monitor.c pci-assign: Remove 2017-11-05 14:52:10 +01:00
qdict-test-data.txt
qemu-bridge-helper.c all: Remove unnecessary glib.h includes 2016-06-07 18:19:24 +03:00
qemu-doc.texi hw/ppc: Remove the deprecated spapr-pci-vfio-host-bridge device 2018-01-10 12:53:00 +11:00
qemu-ga.texi qemu-ga: Remove stray 'q' in documentation 2016-10-28 18:17:23 +03:00
qemu-img-cmds.hx qemu-img: add --shrink flag for resize 2017-09-26 15:00:32 +02:00
qemu-img.c block: Add errp to bdrv_snapshot_goto() 2017-11-21 14:48:22 +01:00
qemu-img.texi qemu-img.1: Image invalidation on qemu-img commit 2017-10-26 14:59:18 +02:00
qemu-io-cmds.c block: Keep nodes drained between reopen_queue/multiple 2017-12-22 15:05:32 +01:00
qemu-io.c qemu-io: Add -C for opening with copy-on-read 2017-10-06 16:28:58 +02:00
qemu-keymap.c tools: add qemu-keymap 2017-10-16 14:50:54 +02:00
qemu-nbd.c blockdev: convert qemu-nbd server to QIONetListener 2017-12-21 09:30:32 +01:00
qemu-nbd.texi nbd: Add qemu-nbd -D for human-readable description 2016-11-02 09:28:55 +01:00
qemu-option-trace.texi docs: update manpage for stderr->log rename 2017-02-13 13:38:31 +00:00
qemu-options-wrapper.h qemu-options: Remove stray colons from output of --help 2017-12-20 09:04:27 +01:00
qemu-options.h Clean up ill-advised or unusual header guards 2016-07-12 16:20:46 +02:00
qemu-options.hx Block layer patches 2018-01-08 13:44:01 +00:00
qemu-seccomp.c seccomp: add resourcecontrol argument to command line 2017-09-15 10:15:06 +02:00
qemu-tech.texi qemu-doc: merge qemu-tech and qemu-doc 2016-10-07 10:05:54 +02:00
qemu.nsi Use HTTPS for qemu.org and other domains 2017-11-21 13:34:13 +00:00
qemu.sasl Default to GSSAPI (Kerberos) instead of DIGEST-MD5 for SASL 2017-05-09 14:41:47 +01:00
qmp.c qmp: remove qmp_cpu 2017-12-20 19:18:33 +01:00
qtest.c qtest: Don't perform side effects inside assertion 2017-09-15 09:05:19 +02:00
replication.c replication: Introduce new APIs to do replication operation 2016-09-13 11:00:56 +01:00
replication.h replication: Introduce new APIs to do replication operation 2016-09-13 11:00:56 +01:00
rules.mak docs: create interop/ subdirectory 2017-06-15 11:18:39 +02:00
thunk.c thunk: assert nb_fields is valid 2017-07-31 13:06:39 +03:00
tpm.c tpm: remove tpm_register_model() 2017-12-14 23:39:15 -05:00
trace-events gdbstub: add tracing 2017-12-18 14:37:36 +00:00
version.rc Use HTTPS for qemu.org and other domains 2017-11-21 13:34:13 +00:00
vl.c block: Remove the deprecated -hdachs option 2017-12-22 15:03:41 +01:00

README

         QEMU README
         ===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

  https://qemu.org/Hosts/Linux
  https://qemu.org/Hosts/Mac
  https://qemu.org/Hosts/W32


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

   git clone git://git.qemu.org/qemu.git

When submitting patches, the preferred approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the HACKING and CODING_STYLE files.

Additional information on submitting patches can be found online via
the QEMU website

  https://qemu.org/Contribute/SubmitAPatch
  https://qemu.org/Contribute/TrivialPatches


Bug reporting
=============

The QEMU project uses Launchpad as its primary upstream bug tracker. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

  https://bugs.launchpad.net/qemu/

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via launchpad.

For additional information on bug reporting consult:

  https://qemu.org/Contribute/ReportABug


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

 - qemu-devel@nongnu.org
   https://lists.nongnu.org/mailman/listinfo/qemu-devel
 - #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

  https://qemu.org/Contribute/StartHere

-- End