qemu/hw/ipmi
Marc-André Lureau 265b578c58 object: fix OBJ_PROP_LINK_UNREF_ON_RELEASE ambivalence
A link property can be set during creation, with
object_property_add_link() and later with object_property_set_link().

add_link() doesn't add a reference to the target object, while
set_link() does.

Furthemore, OBJ_PROP_LINK_UNREF_ON_RELEASE flags, set during add_link,
says whether a reference must be released when the property is destroyed.
This can lead to leaks if the property was later set_link(), as the
added reference is never released.

Instead, rename OBJ_PROP_LINK_UNREF_ON_RELEASE to OBJ_PROP_LINK_STRONG
and use that has an indication on how the link handle reference
management in set_link().

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20180531195119.22021-3-marcandre.lureau@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2018-06-12 12:07:30 +02:00
..
Makefile.objs ipmi: fix build config variable name for ipmi_bmc_extern.o 2016-11-01 19:21:09 +02:00
ipmi.c object: fix OBJ_PROP_LINK_UNREF_ON_RELEASE ambivalence 2018-06-12 12:07:30 +02:00
ipmi_bmc_extern.c ipmi: disable IRQ and ATN on an external disconnect 2018-01-30 15:52:53 -06:00
ipmi_bmc_sim.c ipmi: Allow BMC device properties to be set 2018-01-30 15:52:53 -06:00
isa_ipmi_bt.c ipmi: Fix macro issues 2018-01-30 15:52:53 -06:00
isa_ipmi_kcs.c ipmi: Use proper struct reference for KCS vmstate 2018-06-01 15:13:46 +02:00