From 36b3f9bee103b77476bf395ffd37545b5c8845c0 Mon Sep 17 00:00:00 2001 From: Pino Toscano Date: Tue, 14 Jul 2020 09:41:53 +0200 Subject: [PATCH] i18n: further improve label for controller It seems that the index is optional, so use a proper string for this case. Fixes commit 00fa6366824669aa6ba65f73fdf8eb115dd2d3b7 in this file. Reviewed-by: Cole Robinson Signed-off-by: Pino Toscano --- virtManager/details/details.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/virtManager/details/details.py b/virtManager/details/details.py index 5a2a855b..89f3e0be 100644 --- a/virtManager/details/details.py +++ b/virtManager/details/details.py @@ -254,11 +254,13 @@ def _label_for_device(dev): return _("Filesystem %(path)s") % {"path": dev.target[:8]} if devtype == "controller": idx = dev.index - if idx is None: - idx = "" - return _("Controller %(controller)s %(index)s") % { + if idx is not None: + return _("Controller %(controller)s %(index)s") % { + "controller": vmmAddHardware.controller_pretty_desc(dev), + "index": idx, + } + return _("Controller %(controller)s") % { "controller": vmmAddHardware.controller_pretty_desc(dev), - "index": idx, } if devtype == "rng": if dev.device: