openkylin
/
virt-manager
mirror of https://gitee.com/openkylin/virt-manager.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

details: enable resizing of displays with new GtkVnc 

The 1.2.0 release of GtkVnc introduces support for remote desktop
resize. This is also supported in QEMU >= 6.0.0 when using virtio-gpu.

This introduces support for resize without forcing a new min version of
GtkVnc by just checking for existance of the new API. We don't attempt
to check if the current QEMU instance supports resize, as we gracefully
degrade - the guest simply won't resize and will be rendered as before.

Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2021-04-08 12:48:57 +01:00 committed by Cole Robinson
parent 965480e8bc
commit 499739cee3
2 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
virtManager/details/console.py
View File

@ -5,8 +5,11 @@
# This work is licensed under the GNU GPLv2 or later.
# See the COPYING file in the top-level directory.
import gi
gi.require_version('GtkVnc', '2.0')
from gi.repository import Gtk
from gi.repository import Gdk
from gi.repository import GtkVnc
from virtinst import log
@ -487,12 +490,12 @@ class vmmConsolePages(vmmGObjectUI):
def _viewer_get_resizeguest_tooltip(self):
tooltip = ""
if self._viewer:
if self._viewer.viewer_type != "spice":
tooltip = (
_("Graphics type '%s' does not support auto resize.") %
self._viewer.viewer_type)
elif not self._viewer.console_has_agent():
tooltip = _("Guest agent is not available.")
if self._viewer.viewer_type == "spice":
if not self._viewer.console_has_agent():
tooltip = _("Guest agent is not available.")
elif self._viewer.viewer_type == "vnc":
if not hasattr(GtkVnc.Display, "set_allow_resize"):
tooltip = _("GTK-VNC viewer is too old")
return tooltip
def _sync_resizeguest_with_display(self):

5
virtManager/details/viewers.py
View File

@ -408,8 +408,11 @@ class VNCViewer(Viewer):
self._display.set_credential(GtkVnc.DisplayCredential.PASSWORD, cred)
def _set_resizeguest(self, val):
ignore = val
if hasattr(self._display, "set_allow_resize"):
self._display.set_allow_resize(val) # pylint: disable=no-member
def _get_resizeguest(self):
if hasattr(self._display, "set_allow_resize"):
return self._display.get_allow_resize() # pylint: disable=no-member
return False
def _get_usb_widget(self):