openkylin
/
virt-manager
mirror of https://gitee.com/openkylin/virt-manager.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix a segfault when the connection is dropped 

The error dialog window was created on the "tick" thread, causing a
crash in GTK.  Fix it by moving its invocation to the main thread.
This commit is contained in:
Giuseppe Scrivano 2013-03-11 09:21:48 +01:00 committed by Cole Robinson
parent a6881c6ff1
commit 823c3b20b5
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/virtManager/engine.py
View File

@ -291,8 +291,9 @@ class vmmEngine(vmmGObject):
logging.debug("Closing connection since libvirtd " logging.debug("Closing connection since libvirtd "
"appears to have stopped") "appears to have stopped")
else: else:
self.err.show_err(_("Error polling connection '%s': %s") % error_msg = _("Error polling connection '%s': %s") \
(conn.get_uri(), e)) % (conn.get_uri(), e)
self.idle_add(lambda: self.err.show_err(error_msg))
self.idle_add(conn.close) self.idle_add(conn.close)

1
todo.txt
View File

@ -26,7 +26,6 @@ website: wiki-ify the whole thing, drop static content, move site styling into v
Misc issues Misc issues
=========== ===========
If libvirt connection is dropped, app segfaults
segfault if open test:///default, then try and open testdriver that libvirt can't parse XML segfault if open test:///default, then try and open testdriver that libvirt can't parse XML