openkylin
/
virt-manager
mirror of https://gitee.com/openkylin/virt-manager.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

addstorage: remove _check_ideal_path 

This feature has been added few years ago.  I don't think, that it's a
good feature, as it can ask a user to use different storage than he
actually wants to use.  One thing is automatically create a new storage
for user, if he let as do that, but we shouldn't annoy a user with this
question as he probably don't want to use the proposed storage.  For
example he would like to use different storage pool or while importing
existing storage.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1232599

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Pavel Hrdina 2015-07-23 14:31:55 +02:00 committed by Cole Robinson
parent 6279c3a3d8
commit 9f26bbb5e9
1 changed files with 0 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
virtManager/addstorage.py
View File

@ -252,34 +252,6 @@ class vmmAddStorage(vmmGObjectUI):
def is_default_storage(self):
return self.widget("config-storage-create").get_active()
def _check_ideal_path(self, path, vmname, collidelist):
# See if the ideal disk path (/default/pool/vmname.img)
# exists, and if unused, prompt the use for using it
conn = self.conn.get_backend()
ideal = self._get_ideal_path(vmname)
if ideal in collidelist:
return path
do_exist = False
ret = True
try:
do_exist = virtinst.VirtualDisk.path_definitely_exists(conn, ideal)
ret = virtinst.VirtualDisk.path_in_use_by(conn, ideal)
except:
logging.exception("Error checking default path usage")
if not do_exist or ret:
return path
do_use = self.err.yes_no(
_("The following storage already exists, but is not\n"
"in use by any virtual machine:\n\n%s\n\n"
"Would you like to reuse this storage?") % ideal)
if do_use:
return ideal
return path
def validate_storage(self, vmname,
path=None, size=None, sparse=None,
device="disk", fmt=None, collidelist=None):
@ -314,9 +286,6 @@ class vmmAddStorage(vmmGObjectUI):
else:
path = self.widget("config-storage-entry").get_text().strip()
if is_default:
path = self._check_ideal_path(path, vmname, collidelist)
if not path and device in ["disk", "lun"]:
return self.err.val_err(_("A storage path must be specified."))