tests: Ensure osdict.py aliases is never extended

tests/misc.py

@@ -120,3 +120,12 @@ class TestMisc(unittest.TestCase):
             raise AssertionError("The following files should require gtk "
                 "version of gtk-3.8, which is what we target:\n" +
                 "\n".join([("%s version=%s" % tup) for tup in failures]))
+
+    def test_libosinfo_aliases_ro(self):
+        from virtinst import osdict
+        aliases = getattr(osdict, "_aliases")
+
+        if len(aliases) != 39:
+            raise AssertionError(_("osdict._aliases changed size. It "
+                "should never be extended, since it is only for back "
+                "compat with pre-libosinfo osdict."))

virtinst/osdict.py

@@ -25,6 +25,8 @@ from datetime import datetime
 from gi.repository import Libosinfo as libosinfo
 from inspect import isfunction
 
+# This is only for back compatibility with pre-libosinfo support.
+# This should never change.
 _aliases = {
     "altlinux" : "altlinux1.0",
     "debianetch" : "debian4",