From b764773cfeb827f8b4d2915fc6f4856ecc09f6f8 Mon Sep 17 00:00:00 2001 From: Cole Robinson Date: Thu, 27 Aug 2020 15:21:29 -0400 Subject: [PATCH] domain: Remove qemu VNC SKIPAUTH bug workaround This was added in cb182f7e3 in Mar 2017 to work around a bug in qemu 2.9. This bug only affects the case of virt-manager running locally with that version, which after three years should be rare to non-existent. Remove the workaround Signed-off-by: Cole Robinson --- virtManager/object/domain.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/virtManager/object/domain.py b/virtManager/object/domain.py index f212408e..c3db1335 100644 --- a/virtManager/object/domain.py +++ b/virtManager/object/domain.py @@ -984,15 +984,6 @@ class vmmDomain(vmmLibvirtObject): def open_graphics_fd(self): flags = 0 - - # Ugly workaround for VNC bug where the display cannot be opened - # if the listen type is "none". This bug was fixed in QEMU-2.9.0. - graphics = self.xmlobj.devices.graphics[0] - if (graphics.type == "vnc" and - graphics.get_first_listen_type() == "none" and - not self.conn.support.conn_vnc_none_auth()): - flags = libvirt.VIR_DOMAIN_OPEN_GRAPHICS_SKIPAUTH - return self._backend.openGraphicsFD(0, flags) def list_snapshots(self):