storagebrowser: Remove stable_defaults handling

It simply makes vmdk disk images not selectable. I don't even know
if that's relevant for RHEL7+ anymore, but if it is, maintaining
code for disabling this in the UI doesn't make the situation any
better IMO

virtManager/addhardware.py

@@ -1560,7 +1560,6 @@ class vmmAddHardware(vmmGObjectUI):
         if self._storagebrowser is None:
             self._storagebrowser = vmmStorageBrowser(self.conn)
 
-        self._storagebrowser.set_stable_defaults(self.vm.stable_defaults())
         self._storagebrowser.set_finish_cb(set_storage_cb)
         self._storagebrowser.set_browse_reason(reason)
 

virtManager/choosecd.py

@@ -136,8 +136,6 @@ class vmmChooseCD(vmmGObjectUI):
             self.storage_browser = vmmStorageBrowser(self.conn)
             self.storage_browser.set_finish_cb(self.set_storage_path)
 
-        self.storage_browser.set_stable_defaults(self.vm.stable_defaults())
-
         if self.media_type == vmmMediaCombo.MEDIA_FLOPPY:
             self.storage_browser.set_browse_reason(
                                     self.config.CONFIG_DIR_FLOPPY_MEDIA)

virtManager/create.py

@@ -1417,7 +1417,6 @@ class vmmCreate(vmmGObjectUI):
         if self._storage_browser is None:
             self._storage_browser = vmmStorageBrowser(self.conn)
 
-        self._storage_browser.set_stable_defaults(self._stable_defaults())
         self._storage_browser.set_vm_name(self._get_config_name())
         self._storage_browser.set_finish_cb(callback)
         self._storage_browser.set_browse_reason(reason)

virtManager/fsdetails.py

@@ -310,7 +310,6 @@ class vmmFSDetails(vmmGObjectUI):
         if self.storage_browser is None:
             self.storage_browser = vmmStorageBrowser(self.conn)
 
-        self.storage_browser.set_stable_defaults(self.vm.stable_defaults())
         self.storage_browser.set_finish_cb(set_storage_cb)
         self.storage_browser.set_browse_reason(reason)
 

virtManager/storagebrowse.py

@@ -22,9 +22,6 @@ class vmmStorageBrowser(vmmGObjectUI):
         # Passed to browse_local
         self._browse_reason = None
 
-        # Whether we should abide stable defaults
-        self._stable_defaults = False
-
         self.storagelist = vmmStorageList(self.conn, self.builder, self.topwin,
             self._vol_sensitive_cb)
         self._init_ui()
@@ -71,8 +68,6 @@ class vmmStorageBrowser(vmmGObjectUI):
         self._browse_reason = reason
     def set_vm_name(self, name):
         self.storagelist.set_name_hint(name)
-    def set_stable_defaults(self, val):
-        self._stable_defaults = val
 
     def _init_ui(self):
         self.storagelist.connect("browse-clicked", self._browse_clicked)
@@ -128,9 +123,6 @@ class vmmStorageBrowser(vmmGObjectUI):
         if ((self._browse_reason == self.config.CONFIG_DIR_FS) and
             fmt != 'dir'):
             return False
-        elif self._stable_defaults:
-            if fmt == "vmdk":
-                return False
         return True