Cole Robinson
382391eadb
Clean up gtk STOCK and various image usage
...
- Remove most use of deprecated stock icons. Without it the UI will
be a lot more ugly in Fedora 36
- Remove deprecated ImageMenuItem usage, convert to regular MenuItem
- Remove most embedded button images
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2022-02-19 15:33:42 -05:00
Cole Robinson
fe7f4db6e7
host: Use libvirtobject.run_status
...
Fixes uitest coverage when the host doesn't have any inactive
non-domain objects
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-05-22 16:17:02 -04:00
Cole Robinson
e45a2228dc
objects: Erase the notion of connkey
...
Make it explicit that all uses of this is actually the object
name. We already leaked this abstraction in several places so better
to make it explicit. This also communicates to users that this is a
field that is not immutable so it shouldn't be used as a unique key
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-01 14:27:11 -04:00
Cole Robinson
8ff0da7664
connection: Pass object in -added/-removed signals
...
And not connkey. connkey == name, and name can change with object
rename, so it's a bad pattern to propagate that connkey can be used
as a static lookup key for objects. This begins unwinding it
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-01 14:27:11 -04:00
Cole Robinson
9a9eb165ed
uitests: Add host*.py coverage
...
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-08-26 15:20:05 -04:00
Cole Robinson
886339e8dd
virtManager: add coverage annotations and remove dead code
...
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-08-26 15:20:05 -04:00
Cole Robinson
8f4341bee8
host: Move xmleditor init earlier
...
It can be triggered via callbacks which may fire early,
so initialize it first
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-08-26 15:20:05 -04:00
Cole Robinson
d9b3108436
hostnets: Fix some UI issues with initial offline conn
...
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-08-26 15:20:05 -04:00
Cole Robinson
766d7c47c3
hostnets: Remove route UI label
...
This is an uncommon configuration. Users can see
the details in the XML editor
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-08-26 15:20:05 -04:00
Cole Robinson
1aff5a611e
connection: Remove is_*_capable wrappers
...
Call the conn.support check directly. Move the check logging to
the initial startup path
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-01-24 15:39:41 -05:00
Cole Robinson
3062b5ce08
virtManager: Move a lot of misc files to lib/
2019-06-17 00:12:32 -04:00
Cole Robinson
f107e39989
Switch to more traditional logging structure
...
Init a shared log instance in virtinst/logger.py, and use that
throughout the code base, so we aren't calling directly into
'logging'. This helps protect our logging output from being
cluttered with other library output, as happens with some
'requests' usage
2019-06-17 00:12:31 -04:00
Cole Robinson
2c03ea5c92
hostnets: Remove SR-IOV info listing
...
This is fairly advanced stuff and it should be fine to get this
info from the XML editor page
2019-06-16 23:48:51 -04:00
Cole Robinson
59873f3876
hostnets: Remove QoS viewing/editing
...
This is fairly niche, and can be reviewed or edited with the XML
editor
2019-06-16 20:25:42 -04:00
Pavel Hrdina
d6b6397ce0
virtManager: xmleditor: warn when switching to XML tab
...
If there are unapplied changes in the UI warn user when they tries to
switch to XML editor.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2019-06-15 15:05:28 +02:00
Cole Robinson
5f4510b4df
hostnets: add xmleditor UI
2019-06-13 07:13:43 -04:00
Cole Robinson
b5a664bd1b
virtinst: move UI only functions into virtManager
...
These throw off code coverage testing. They are mostly:
* pretty* device helpers
* network + snapshot validation + creation routines
2019-06-09 18:33:45 -04:00
Cole Robinson
274d686252
host: Ellipsize long net/pool object names
...
https://bugzilla.redhat.com/show_bug.cgi?id=1698088#c5
Reported-by: Martin Kolman <mkolman@redhat.com>
2019-04-18 15:31:14 -04:00
Cole Robinson
c3ea2d3119
host: Don't try to confirm changes on window close
...
It's a bit of a pain to get right, so only do it on net/pool list
change
2019-04-14 18:24:04 -04:00
Cole Robinson
f7ba2f2f99
error: Add helper confirm_unapplied_changes
...
For the common dialog we use to confirm changes
2019-04-14 18:24:04 -04:00
Cole Robinson
86a13699ce
host: separate out hostnets.ui and hostnets.py
...
Helps organize things by limiting the files to a single class of
operations, and follows the storagelist.py pattern
2019-04-14 18:23:58 -04:00