0638e72f1f
Remove 'Choose CD', rework details and create media change
...
The new UI is handled in mediacombo. It's a combobox+entry. The
combobox is prepopulated with host cdrom/floppy devices, and
previously used media paths from gsettings
The new VM wizard no longer has separate UI for cdrom device vs
ISO media. The choosecd dialog is gone all together, and media
is changed with the 'apply' button like all other details changes
2018-10-06 19:37:16 -04:00
8ff5d750da
details: Disable hardware list search
...
Can cause weird things with row focusing
2018-10-06 14:24:02 -04:00
256bd2bcf8
uitests: console: fix fullscreen test on second monitor
2018-10-06 13:17:59 -04:00
977a8ced52
addhardware: Fix cdrom icon (bz 1608530)
2018-10-06 13:04:45 -04:00
c9f0641700
cliconfig: Remove --preferred-distros
...
It's less relevant with our new search based OS list
2018-10-06 12:33:15 -04:00
e6738d9827
cliconfig: Remove --default-qemu-user
...
Libvirt has given us this info in capabilities for a long time,
this shouldn't matter anymore
2018-10-06 12:30:59 -04:00
a4097b7691
cli: Merge multiple instances of single use opts
...
So --memory 123,maxmem=456 --memory 555 is equivalent to
--memory 555,maxmem=45
2018-10-05 13:23:20 -04:00
03439dd9a3
cli: Remove some --sysinfo examples
...
This is a sufficiently uncommon option, it doesn't need 5 examples
2018-10-04 20:52:32 -04:00
40dc4b1131
support: Limit qemu-xhci check to qemu 2.9.0
2018-10-04 20:48:43 -04:00
945c0125db
cli: Remove VirtStreamHandler
...
This was needed at one point to make our logging not throw
exceptions when passed non-ascii text, like logging translated
errors. pretty sure python 3 and probably python2.7 fixed all
those issues, so lets drop it
2018-10-04 19:45:06 -04:00
877cbade4a
tests: Move OLD_OSINFO check to central place
...
Other tests may need it in the future
2018-10-04 19:29:41 -04:00
9edca3486a
virt-manager: Wire up support for default mode=host-model
...
Simplify things a long the way
2018-10-04 14:43:44 -04:00
469fed08a0
guest: Default to cpu mode=host-model if libvirt is new enough
...
We check whether host-model is exposed in domcapabilities, which
indicates host-model is using the smarter new safer method in
cooperation with qemu
2018-10-04 14:43:41 -04:00
76334bfabd
guest: Add DomainCapabilities caching
2018-10-04 12:30:14 -04:00
210cb858bc
controller: usb: Use ports=15 for usb3
...
It's the max that qemu supports, so why not add as many as possible.
Gerd indicated in private mail that he didn't know of any issues
with it.
2018-10-04 11:55:57 -04:00
b807cfa744
details: Handle qemu-xhci as USB3
...
And fix it in addhardware too
2018-10-04 09:53:36 -04:00
35dd99f172
cli: Don't hardcode nec-xhci for --controller usb3
...
Use our helper function to choose the optimal model
2018-10-04 09:24:43 -04:00
b51104ad22
guest: Tweak error with invalid --os-variant
...
Try to point people in the right direction if they specify an
unknown distro name on the cli, like was reported here:
https://bugzilla.redhat.com/show_bug.cgi?id=1576473
2018-10-03 19:32:09 -04:00
046a242bd4
guest: Use USB3 for x86 qemu if OS supports it
...
Using new annotations in osinfo-db
2018-10-03 19:02:07 -04:00
c539f06eeb
cli: Give better --controller examples
...
ich9-ehci1 isn't a recommended configuration
2018-10-03 18:52:33 -04:00
8227b820ee
osinfo: warn when using deprecated osinfo IDs
...
At some point in the future it could be a good idea to drop the _aliases
mapping altogether; it will be hard to do so, in case the users are not
informed that they are using a deprecated ID.
(crobinso: Tweak format and message)
Signed-off-by: Pino Toscano <ptoscano@redhat.com>
2018-10-02 11:41:34 -04:00
4ad74278ca
cli: add memory backing access_mode & source_type
...
Allow to set some memory backing options, ex:
--memorybacking access_mode=shared,source_type=anonymous
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2018-10-02 11:12:13 -04:00
8326adb997
oslist: Hide dialog if search field is empty
...
Behavior here was kinda inconsistent
2018-10-02 10:26:04 -04:00
f3045b6404
oslist: Expand popover to horizontal size of the search entry
...
Makes the window more usable by default
2018-10-02 10:26:04 -04:00
9db3b5c7e5
ui: create: Drop lots of indentation
...
Makes better use of horizontal space
2018-10-02 10:26:04 -04:00
92c610e782
connection: avoid failing on NoneType in _hostinfo
...
There is a potential race of a backend to be opened and being true on
self._backend.is_open but self._hostinfo not being set yet.
Avoid spurial bugs due to that by also checking against None before
accessing subelements ot self._hostinfo
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
2018-10-01 13:58:52 -04:00
760dc32bac
osdict: Clarify comment about rhel virtio-serial hack
2018-10-01 11:39:58 -04:00
ff3d6c65d8
Fix some pep8 warnings
2018-10-01 11:37:28 -04:00
d389e93586
tests: Fix with latest libosinfo
...
And add some logic to skip these tests on older libosinfo as well
2018-10-01 11:34:51 -04:00
b2e7986c7b
osdict: Switch device lookups to be ID based
...
I'm not positive device names will never change, but presumably the IDs
won't, so use them instead
2018-10-01 11:24:45 -04:00
757910a1bb
cli: Add --metadata os_name= and os_full_id=
...
Allows changing the libosinfo metadata for an existing vm via virt-xml
2018-09-30 20:55:32 -04:00
b19f94299b
details: Add OS name view/edit, + oslist rework
...
This is just a big nasty commit.
Turn the OS inspection page into an always available page that
shows the libosinfo name from the domain metadata XML. Use oslist.py
and have it absorb more of the common behavior needed by create.py
and details.py. Add UI tests for it all
2018-09-30 20:55:32 -04:00
75c64151b1
engine: Exit app if if --show-X bits fail
...
We were missing some cases. Simplify the code while we are at it
and add some extra ui test cases
2018-09-30 20:55:18 -04:00
65e1187c10
osdict: Add a helpful __repr__
2018-09-30 09:37:14 -04:00
31e4b72a8b
osdict: Drop Glib.Date API usage
...
Use python datetime instead, it's more python friendly
2018-09-29 15:22:44 -04:00
97ea737386
devices: interface: Have x86 fallback model be e1000
...
libvirt will use rtl8139, but the qemu default changed a while
ago to e1000, and libvirt has diverged. e1000 is more modern and
considered the better default here, so use it
2018-09-29 14:35:28 -04:00
627bfabc32
pylint: Silence output on Fedora 29
2018-09-29 14:27:34 -04:00
4adb1c8c30
pycodestyle: fix W605 invalid escape sequence
2018-09-29 13:59:19 -04:00
2d44912a70
pycodestyle: Disable W504 line break after binary operator
2018-09-29 13:59:15 -04:00
7356afcca7
osdict: Use USB tablet if no OS specified
...
Most OS users will be installing benefit from it, so make it the
default
2018-09-29 13:36:42 -04:00
184b96a815
virtinst: util: Remove unused validate_uuid
...
We let libvirt error nowadays
2018-09-14 15:19:03 -04:00
87d19ebf36
tests: Add rhel5 and win10 kvm XML tests
2018-09-14 14:37:12 -04:00
e2c817f06f
ui: details: Get rid of some unused widgets
2018-09-13 16:06:18 -04:00
a741f595ea
guest: Drop update_defaults
...
Fold its one purpose into the UEFI setting bits, fix it and test it
2018-09-13 15:59:27 -04:00
d7ff46f7f5
guest: Encode the cli --os-variant in the XML
...
And add some testdriver examples of it
2018-09-13 15:11:22 -04:00
86ef998023
guest: Lookup osinfo object from libosinfo metadata XML
2018-09-13 15:03:36 -04:00
bad5eabd93
domain: Add metadata.libosinfo
...
From the libosinfo discussion here:
https://www.redhat.com/archives/libosinfo/2018-September/msg00003.html
This is a cross-app schema for tracking libosinfo OS ID in the
domain <metadata> XML. Example:
<metadata>
<libosinfo:libosinfo xmlns:libosinfo="http://libosinfo.org/xmlns/libvirt/domain/1.0 ">
<libosinfo:os id="http://fedoraproject.org/fedora/17 "/>
</libosinfo:libosinfo>
</metadata>
2018-09-13 12:39:56 -04:00
baaab74b6d
xmlapi: Rework xmlns setting slightly
...
So the xmlns is not always set on the top element. We need this for
custom <metadata> support
2018-09-13 12:39:56 -04:00
841d5126d2
xmlapi: Move namespace mappings to the relevant classes
...
So we don't need to update xmlapi.py to account for additions
2018-09-13 09:34:04 -04:00
6063538750
guest: Replace os_variant with set_os_name
...
And have callers directly access osinfo.name if they need it
2018-09-12 17:24:28 -04:00
Cole Robinson