Pavel Hrdina
3ff35898a4
refactor detection of guest type capabilities
...
Each guest type can have its own capabilities and we should always ask
only for those capabilities.
The old approach was to get capabilities from libvirt and then for
example cycle trough all guests and return True, if any guest type
supports kvm or pae, etc.
Now we check those capabilities only for the correct guest type
according to defaults and input from user.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-07-14 13:11:40 -04:00
Pavel Hrdina
349220d188
tests/virtconvtest: skip test if unar is missing
...
If you are running all tests, we should properly skip the test, if something
is missing instead of silently ignore that tests.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
(crobinso: make it skip the test, rather than raise an exception)
2015-07-14 13:00:04 -04:00
Kevin Zhao
8dbe96fc01
virt-manager : add support for architecture type "s390x".
...
For architecture "s390x",the disk and the network device are base
on "virtio" bus.The cdrom is based on "scsi".So set the default
cdrom bus as "scsi",the default bus as "virtio".Also the default
machine type is set to "s390-ccw-virtio" as it is the only supported
in "s390x".Also add a test cast of virt-install by cdrom in s390x.
(crobinso: Tweak test suite and minor formatting stuff)
2015-07-14 12:45:32 -04:00
Cole Robinson
612123563e
tests: Add test for CPU clearing
...
Currently broken, fixed by the next patch
2015-07-14 11:53:02 -04:00
Cole Robinson
b82b739d5a
tests: Fix output to work the same with libvirt <console> change
...
See this thread for the original patches:
https://www.redhat.com/archives/virt-tools-list/2015-June/msg00091.html
But this fix is nicer since it will work before those libvirt changes as
well.
2015-06-08 17:41:16 -04:00
Cole Robinson
19e35b0a5b
Fix test output with libvirt 1.2.16
2015-06-06 14:52:16 -04:00
Giuseppe Scrivano
f5a13510eb
clone: do not use a '/' separator when using a disk file under /
...
It avoids file names like //foo.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1210564
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-06-06 00:00:40 +02:00
Cole Robinson
832293f3fd
test_urls: Update latest distro detection
2015-06-05 16:30:53 -04:00
Lin Ma
9b99eff73d
test_urls: Add opensuse 13.x tests
...
Because the content file is changed little bit in 13.2, Both of
urls of 13.1 and 13.2 need to be tested.
From: Charles Arnold <carnold@suse.com>
Signed-off-by: Lin Ma <lma@suse.com>
2015-06-05 16:00:20 -04:00
Cole Robinson
2d572e02bd
tests: Fix tests on F22 libvirt
2015-05-20 14:00:15 -04:00
Cole Robinson
8a20a71c46
uiutil: Merge set_combo_entry into set_list_selection
2015-05-19 18:29:46 -04:00
Chen Hanxiao
24302dfdfd
tests: fix test cases failed by 'vmport'
...
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2015-05-11 04:55:14 -04:00
Marc-André Lureau
e2184ea2cf
tests: add some vmport tests
...
Message-Id: <1428012248-5767-6-git-send-email-marcandre.lureau@gmail.com>
2015-05-04 12:40:14 -04:00
Marc-André Lureau
ea4aa9ffc4
virtinst: add new vmport domain feature
...
This should be available with libvirt 1.2.16
Message-Id: <1428012248-5767-2-git-send-email-marcandre.lureau@gmail.com>
2015-05-04 12:40:13 -04:00
Cole Robinson
7e7c606ff7
pylint: Disable unidiomatic-typecheck, not really worth fixing
2015-05-02 19:48:04 -04:00
Cole Robinson
fa08d0ada5
clitest: Fix tests on F21
2015-05-02 16:41:21 -04:00
Cole Robinson
33cfe883c6
guest: arm kvm should use host-passthrough, not model=host
...
Seems to work with libvirt, not sure if it was ever broken as the comment
suggested.
2015-04-23 10:14:58 -04:00
Cole Robinson
bbb048cbd0
clitest: Add KVM tests for aarch64, armv7, ppc64le
2015-04-22 20:28:47 -04:00
Cole Robinson
6fd3983f6d
tests: Clean up capabilities test data
...
Make it clear which ones are used for the caps unit tests, and which
are for cli/UI testing and can be updated at will. And drop a bunch
of outdated stuff.
2015-04-22 19:05:06 -04:00
Cole Robinson
8a3e3391c8
clitest: Drop explicit fake.iso filename
...
Just use one of the other files we stub out
2015-04-22 18:00:00 -04:00
Cole Robinson
d4bf3b58a0
clitest: Drop prompttest infrastructure
...
Just fake it for the one remaining test
2015-04-22 18:00:00 -04:00
Cole Robinson
070664b9e7
tests: Enable property checking for all objects
...
And loosen restrictions a bit so any read/write will trigger the
tracking.
2015-04-22 16:26:03 -04:00
Cole Robinson
4c361933ea
tests: Have the property checker work on whole test suite
...
Not just xmlparse.py. So we can test a new property via clitest and
not always via xmlparse
2015-04-21 20:15:37 -04:00
Cole Robinson
ccc0da3e51
tests: Add specific VM for virtxml tests
...
Decouple it from test-many-devices which is really about manual testing
of virt-manager UI. It's annoying that every time test-many-devices is
extended we need to regenerate all the virtxml tests.
2015-04-21 19:50:41 -04:00
Cole Robinson
93f826a8b2
cli: Replace add --check option (bz 1063471)
...
For fine grained enabling/disabling validation checks. Use this to
replace the heavy handed --force option.
2015-04-11 19:48:35 -04:00
Cole Robinson
0f3d86ac9e
guest: Disable PM for virt-install as well
...
We are just mirroring the behavior that virt-manager (and boxes) have
used for a while now.
In my experience the average user is confused by their VMs suspending,
so for our sake I'd rather make people opt into this feature.
2015-04-11 18:02:45 -04:00
Cole Robinson
a2c7d62ec4
guest: Disable spice image compression for local VMs
...
The image compression setting has a noticably detrimental effect on
spice graphics quality. It's meant to be used for spice VDI but the
vast majority of people don't use spice in a way that makes bandwidth
usage matter.
Boxes has already done this for a while as well:
https://mail.gnome.org/archives/commits-list/2013-March/msg14904.html
Turn it off by default if creating the VM on a local connection.
2015-04-11 17:53:17 -04:00
Cole Robinson
20d37422fe
virt-install: Fill in a bunch of --graphics spice options (bz 1110017)
2015-04-11 16:56:27 -04:00
Cole Robinson
9a789c19e2
virt-install: Support --hostdev scsi passthrough (bz 1054912)
...
Pass it a type=scsi nodedev name, and we will set things up correctly.
2015-04-11 15:55:09 -04:00
Giuseppe Scrivano
616df760be
storage: copy allocation and capacity also on cross-pool clones
...
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1210265
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-04-10 16:40:49 +02:00
Chen Hanxiao
06c05ca078
test: fix a testcase
...
commit 92c42bc5a0
breaks testsuit.
Fix it.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2015-04-09 22:44:50 -04:00
Cole Robinson
92c42bc5a0
details: Improve UI labeling of keyboard devices
2015-04-09 13:36:40 -04:00
Cole Robinson
527c49dec2
virt-install: Add --input option
...
For configuring VM <input> devices
2015-04-09 13:22:40 -04:00
Cole Robinson
058c06972e
Break out shared storage UI to storagelist.py (bz 1060433)
...
We were already sharing a chunk of this in a haphazard way. Now officially
break it all out, similar to netlist.py. This mostly unifies the views
of host->storage and storagebrowser.py
2015-04-09 12:31:24 -04:00
Cole Robinson
a5d03fdf6e
guest: Don't unconditionally overwrite on_poweroff/on_crash
2015-04-07 19:53:15 -04:00
Cole Robinson
86f1133777
guest: Encode defaults into the XML at install time
...
Previously we made all the default encoding non-permanent by XML objects
before generating the XML, making changes to the copies, and restoring
to the old state after the XML is returned to the user.
This allows us to call start_install multiple times with the same Guest
object and not alter it's original config... but that feature isn't really
useful anymore, and this behavior makes the 'customize before install'
dialog difficult to handle.
So drop most of it, and fix some of the minor fallout.
2015-04-07 18:36:06 -04:00
Cole Robinson
a773a66a3f
virtcli: Export config variables in a class object
...
Makes things easier to extend later
2015-04-06 15:54:35 -04:00
Cole Robinson
e29f216503
guest: Use sata by default for q35 cdrom, non-virtio (bz #1207834 )
2015-04-06 13:43:18 -04:00
Cole Robinson
3a36d95da0
details: Explicitly label virtio scsi disks + controllers
2015-04-04 20:06:40 -04:00
Cole Robinson
3d6831ec8f
virt-install: Deprecate --print-step, just use --print-xml
...
argparse lets us handle this in a back compat fashion, so let's simplify
the CLI.
2015-04-04 17:10:45 -04:00
Cole Robinson
393aed191e
urlfetcher: Detect centos URLs as centos, not rhel variants
2015-04-04 15:41:13 -04:00
Cole Robinson
d0c65b30a4
osdict: Simplify a bunch of the checks, drop some legacy stuff
2015-04-04 15:32:35 -04:00
Cole Robinson
7275da5702
tests: Split out osdict and uriparse from misc.py
2015-04-04 14:43:12 -04:00
Cole Robinson
a7dbc5e250
tests: Add more osdict.py coverage
2015-04-04 14:43:12 -04:00
Cole Robinson
595b5b4bdf
osdict: Drop explicit 'type' class
...
create.py is the only thing that cares about this nowadays, so we can
work with things to make it all simpler.
2015-04-04 12:48:50 -04:00
Cole Robinson
bd9ab2d5b5
osdict: Add toplevel OSDB as API entry point
...
Makes code more readable, and lazy loading simpler.
2015-04-04 12:06:41 -04:00
Cole Robinson
81a1910d90
capabilities: Rename no_install_options -> has_install_options
...
It's easier to visually parse the wording
2015-04-03 17:25:29 -04:00
Cole Robinson
fe9ffe86f6
capabilities: Drop xen-only bios virt checks
...
These only work for xen x86, and are less relevant nowadays since HW
virt has been around for a very long time. Also it's tough to be sure
that we aren't giving a bogus warning.
2015-04-03 17:25:29 -04:00
Cole Robinson
f5b13a6e19
Drop all references to xenner, it's long dead
2015-04-03 16:45:43 -04:00
Cole Robinson
d4dfbd41b5
capabilities: Use XMLBuilder for cpu_map parsing
...
And clean up the internal bits a little
2015-04-03 16:45:43 -04:00
Cole Robinson
cac4ac1401
capabilities: Switch to use XMLBuilder
...
Just a cleanup to finally unify all the XML objects around the same
API, and drop a bunch of old cruft.
2015-04-03 16:45:42 -04:00
Giuseppe Scrivano
3ff34c79e2
tests: check that clone keeps the same image format for disks
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-04-02 10:04:58 +02:00
Cole Robinson
82e9684fa6
urlfetcher: Make debian treearch checking more generic
...
Use regex parsing rather than a whitelist
2015-03-27 13:06:26 -04:00
Cole Robinson
e7666390ff
test_inject: Add Fedora 22 URL
2015-03-26 19:37:17 -04:00
Cole Robinson
ba95aa91e6
test_urls: Update fedora URLs
2015-03-26 19:28:53 -04:00
Cole Robinson
e125aa69d8
nodedev: Handle busted 'system' XML
...
Libvirt can generated invalid XML for the system nodedev device:
https://bugzilla.redhat.com/show_bug.cgi?id=1184131
This hits at least two people, so catch this specific case, but the
real fix is libvirt not outputing busted XML.
2015-03-26 18:04:23 -04:00
Cole Robinson
dc1737e623
cpu: Drop vendor and features if setting host-model (bz 1190851)
...
Otherwise via virt-manager we can try to set a <cpu> with a <vendor>
but no <model>, and libvirt complains.
2015-03-26 17:08:15 -04:00
Cole Robinson
7866e291f6
guest: Never use vmvga if host is RHEL (bz 1147662)
...
We basically need to do this independent of whether the build is configured
for RHEL defaults or not
2015-03-25 09:04:51 -04:00
Cole Robinson
af2aea8bbc
tests: xmlconfig: Drop needless version limiting
2015-03-25 08:58:09 -04:00
Cole Robinson
cfe9e7dc7e
virt-install: Make '--cpu none' work with aarch64
2015-03-23 17:46:09 -04:00
Cole Robinson
08a72a4aec
connection: Clean up stable_defaults, improve test coverage
2015-03-23 16:49:32 -04:00
Cole Robinson
0273ee2fac
tests: Move some test suite hacks into the code, increase coverage
2015-03-23 16:25:31 -04:00
Cole Robinson
8220e4c60f
virtinst: Drop unused stable_defaults field
2015-03-23 16:17:07 -04:00
Giuseppe Scrivano
31836e2b5d
virtinst: add support for <disk> sgio attribute
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-16 20:32:40 +01:00
Giuseppe Scrivano
478ba6d885
Use virtio-net only when it is supported
...
Do not use the model specified by the OS if it is "virtio-net" and
virtionet is not supported.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1177113
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-25 15:32:54 +01:00
Giuseppe Scrivano
00aea929ef
tests: check that vmvga is not used on RHEL
...
And fix typo in last commit
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-24 19:03:59 +01:00
Cole Robinson
c7c772b200
virt-install: Default to --boot uefi
...
Try to use --boot uefi if the user hasn't already specified loader params,
or a kernel to boot. If we can't determine a UEFI setup, just print a
warning.
2015-02-22 10:25:51 -05:00
Cole Robinson
a04307cd70
virt-install: Add --boot uefi
...
Will enable UEFI if we know libvirt + hypervisor support it, and libvirt
is advertising a suitable UEFI binary.
2015-02-22 10:25:47 -05:00
Cole Robinson
4efc814d7f
connection: Add domain caps handling for fake URIs
...
Allows us to pass in custom domcaps content for testing purposes
2015-02-22 10:25:47 -05:00
Anatoly Belikov
e44b95149b
devicedisk: fix source name attribute for gluster volumes
...
(crobinso: Small code tweak, and add test cases)
2015-01-29 11:31:43 -05:00
Giuseppe Scrivano
dc169c1406
tests: check that HYPER-V is not enabled on win7 guest with UEFI
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-01-27 20:52:06 +01:00
Cole Robinson
5018233f63
tests: Test --channel none
2015-01-09 10:52:59 -05:00
Cole Robinson
aa772f01e1
guest: Prefer virtio-scsi for arm mach-virt
...
Since it gives us disk hotplug, and CDROM devices, etc.
This requires fairly recent patches to UEFI/OVMF/AAVMF
2014-12-17 15:23:05 -05:00
Chen Hanxiao
08007d56fe
test_urls: remove commented fedora21 alpha urls
...
Discoverd by pep8 '# ' style.
introduced by 92b443df
We forgot to delete it.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-12-12 10:10:17 +08:00
Chen Hanxiao
5d0c68cc0c
clitest: replace DIR from current pwd to '/var'
...
Introduced by f16dc4dd34
This will cause test case failure on different machines.
Use '/var' to replace it.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-12-12 10:05:40 +08:00
Cole Robinson
92b443df55
test_urls: Update
2014-12-10 13:39:18 -05:00
Cole Robinson
0370d3b796
devicedisk: Never raise error for missing TYPE_VOLUME
...
We can't predict when it's expected or not, so just never raise the
error and let libvirt error if the user is trying do things at
create time.
2014-12-10 13:22:42 -05:00
Cole Robinson
9ae3dbe05b
virt-install: Fix --disk pool=NETPOOL,size=... creation
2014-12-10 13:22:42 -05:00
Cole Robinson
cb124bccbd
testdriver: Add more gluster examples
2014-12-10 13:22:42 -05:00
Cole Robinson
e1ab165b1a
cli: Don't try to create storage with source_pool + size
2014-12-10 13:22:42 -05:00
Cole Robinson
117cbfe12f
devicedisk: Don't set driver name=unknown for rbd vols
2014-12-10 13:22:42 -05:00
Cole Robinson
f16dc4dd34
tests: clitest: Lots of house cleaning
...
Drop redundant tests, organize things better, add more tests where we
can stick new cli device options and view the output, since that's the
most common extension.
2014-12-10 13:22:42 -05:00
Martin Kletzander
2890d70a79
tests/testdriver: Don't use invalid uid values
...
The value 4294967295 used in the testdriver for sheepdog volume is not
valid on 32bit systems as it won't fit in uid_t and libvirt will fail
parsing that.
Running "./setup.py test" then fails with:
raise libvirtError('virConnectOpenAuth() failed')
libvirt.libvirtError: XML error: malformed owner element
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-10 10:06:54 +01:00
Cole Robinson
464ebabc5a
virt-install: Wire up --disk vol= for network volumes
...
This involves convering pool/vol XML to disk source bits
2014-12-09 18:23:22 -05:00
Cole Robinson
214872498d
test: Set volume type in testdriver XML
2014-12-09 17:50:16 -05:00
Cole Robinson
e61311fc8a
storage: More support for network pools
...
Including parsing multiple hosts, filling reasonably defaults, making
sure the createpool wizard does the correct thing, etc.
2014-12-09 16:12:47 -05:00
Cole Robinson
838d7f015c
tests: Drop a bunch of redundant xmlconfig tests
...
These are mostly covered by clitests. Keep the important ones around
for code coverage.
2014-12-09 13:19:56 -05:00
Cole Robinson
9952764dda
virt-install: Make --disk $URL 'just work'
...
If VirtualDisk.path is set to a URL, parse it and fill in all the
source_* values automagically.
2014-12-09 10:45:26 -05:00
Cole Robinson
3ac272e635
uri: Add unit tests, fix some bugs
2014-12-09 10:15:53 -05:00
Cole Robinson
81009caa54
tests: clitest: Drop explict readonly file testing
...
This was originally to hit certain code paths in virtinst that are long
gone, and was causing issues for running the test suite in certain
situations:
http://www.redhat.com/archives/virt-tools-list/2014-December/msg00010.html
2014-12-09 07:13:27 -05:00
Cole Robinson
cd305da3f8
virt-install: support network --disk's
...
Handle type=network in devicedisk.py, and wire up all the network fields
for virt-install --disk. Right now it requires manually spelling out
all the protocol, name, host/port etc fields.
The one 'magic' bit is that VirtualDisk.path will be a pretty URL when
all those network fields are specified. This is keeps things mostly
working in various parts of the code where we expect 'path' to be an
identifier for a VirtualDisk.
2014-12-06 21:00:51 -05:00
Cole Robinson
c5f5827499
tests: xmlparse: Simplify disk lookup
2014-12-06 21:00:07 -05:00
Cole Robinson
86682c8c54
virt-install: Support --disk source_pool,source_volume
...
For setting type=volume disks. This requires some reworking of
devicedisk bits
2014-12-06 17:14:16 -05:00
Cole Robinson
7e7b1bdd4e
tests: Order disks in same order libvirt shows them
2014-12-06 16:43:53 -05:00
Cole Robinson
7b8e850bc0
clitest: Sanitize diff output some more
2014-12-06 16:32:10 -05:00
Cole Robinson
cf0206a58c
devicedisk: Break apart set_create_storage
...
And break about the vol_install vs local clone storage creators. And
just generally delete a lot of code. The commit aint pretty but it works
and deletes a ton of hacks
2014-12-05 23:28:53 -05:00
Cole Robinson
40a5ec75b7
tests: Switch away from set_create_storage
2014-12-05 21:49:10 -05:00
Cole Robinson
2acbf52ce3
cli: If creating storage, always build vol_install
...
This is the start of moving this logic out of devicedisk
2014-12-05 20:00:11 -05:00
Cole Robinson
0389ab23a7
diskbackend: Remove backing by pool object
...
It just muddles things up for a minor edge case. The autopoolify logic
should catch all practical cases we care about.
2014-12-04 19:45:00 -05:00
Cole Robinson
a75aa47daf
devicedisk: Use consistent capitalization for property names
2014-12-04 16:30:18 -05:00
Cole Robinson
e71e5cd9dd
devicedisk: Open code _xmlpath handling
...
Rather than depend on xmlbuilder infrastructure. We will need to extend
this logic for network disks, and it's easier this way.
2014-12-04 15:28:14 -05:00
Cole Robinson
e992cc15b2
virt-xml: Disable clearxml= for devices
...
It doesn't work in the general case, and users can just --remove and
--add devices as needed for the same effect
2014-12-04 15:28:14 -05:00
Cole Robinson
8d6ffafa1b
tests: testdriver: More network storage examples
2014-12-04 13:06:20 -05:00
Cole Robinson
899bff4c4d
tests: Quiet things with non-latest libvirt
2014-12-04 13:04:02 -05:00
Giuseppe Scrivano
d2e6271337
Revert "tests: fix tests suite with last libvirt version"
...
This reverts commit 9477f06376
.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-12-01 18:00:16 +01:00
Giuseppe Scrivano
9477f06376
tests: fix tests suite with last libvirt version
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-12-01 17:02:22 +01:00
Giuseppe Scrivano
51e5a47120
virt-manager: reset vgamem for video when changing device type
...
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1169295
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-12-01 17:02:22 +01:00
Giuseppe Scrivano
9d633879b1
tests: fix failures with libvirt upstream version
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-11-25 10:42:51 +01:00
Cole Robinson
26828b52cc
guest: Use virtio-scsi for arm machvirt CDROM
...
Since it's the only option we have to actually use the CDROM
2014-11-20 11:27:09 -05:00
Cole Robinson
60e62e2676
osdict: Add back compat 'virtio26' entry
...
We used to have that in the old osdict. Map it to fedora10 which gives
virtio net/block but nothing else, which matches the old behavior.
2014-11-17 10:22:37 -05:00
Anatoly Belikov
78c52a13f1
add gluster and sheepdog pool/volume to testdriver.xml
2014-11-16 15:46:27 -05:00
Martin Kletzander
339ead9f70
tests: fix failure on 32-bit machines
...
clitest.py used the value 100000000000 (100 PB) for memory size, which
was parsed as 0 by older libvirt. Latest release (1.2.10) has the
parsing fixed and properly reports an error on overflow. Changing the
memory size to 4000000 (4 TB) is still an overcommit, at least most
development machines and it works properly.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-11-05 09:00:58 +01:00
Cole Robinson
baee53fbaa
util: Simplify default_bridge to not confuse pylint
2014-10-27 19:53:25 -04:00
Cole Robinson
cbf38cbe9f
pylint: Ignore new warnings
2014-10-27 19:53:25 -04:00
Giuseppe Scrivano
cce5827195
virtinst: add support for disk type="volume"
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-26 16:24:59 +02:00
Cole Robinson
42ac7a3036
guest: Set optimal arm CPU defaults
...
If doing arm kvm, use cpu=host. Otherwise, specify cortex-a57 for aarch64
so we actually get a 64bit cpu
2014-09-23 16:18:23 -04:00
Cole Robinson
c4162f6708
Use -M virt as default machine for arm/aarch64
...
Centralize the default machine logic in caps and use it consistently
2014-09-23 16:05:48 -04:00
Cole Robinson
0182ba3ead
guest: Use virtio for arm -M virt
...
In fact it's the only thing it supports
2014-09-23 15:12:02 -04:00
Cole Robinson
92db9bd4dd
tests: Add some more arm tests
...
Many are broken for now, but they will help validate we are setting
the correct defaults with subsequent patches.
2014-09-23 15:08:47 -04:00
Cole Robinson
c216302743
tests: capabilities: Add aarch64 test data
2014-09-23 14:56:44 -04:00
Cole Robinson
86417d42ca
osxml: Ensure kernel/initrd/dtb are absolute paths
2014-09-23 14:32:01 -04:00
Cole Robinson
4c4bdbb8b8
cli: Allow embedding comma in kernel_args
...
And fix can_comma for aliases
2014-09-23 14:14:21 -04:00
Cole Robinson
30db9ece22
osdict: Add qemu-ga for RHEL6 and RHEL7 guests (bz 1139109)
2014-09-22 17:33:55 -04:00
Cole Robinson
b3fa8bb650
tests: Ensure osdict.py aliases is never extended
2014-09-21 15:26:03 -04:00
Cole Robinson
df50fdc323
testdriver: Add a host-model and host-passthrough usage
2014-09-21 10:17:51 -04:00
Cole Robinson
eda5eea549
virt-install: Switch --cpu host to use host-model, not copy (bz 1133155)
...
host-model offers us other protections now, like ensuring we don't try
to use a host cpu feature that qemu doesn't support.
http://bugzilla.redhat.com/show_bug.cgi?id=1133155
2014-09-20 20:44:13 -04:00
Cole Robinson
64106230bd
virt-install: Add hidden option --test-media-detection
...
Can help with debugging and test cases
2014-09-20 20:32:19 -04:00
Cole Robinson
3933ff101b
guest: Limit number of default usb redirdevs to 2 (bug 1135488)
...
If we use 4 devices here, we fill up all the emulated USB2 slots,
and directly assigned devices are forced to fall back to USB1
https://bugzilla.redhat.com/show_bug.cgi?id=1135488
2014-09-20 20:16:31 -04:00
Cole Robinson
d7e1a40352
virt-install: Deprecate --nodisks in favor of --disk none
2014-09-20 19:16:13 -04:00
Cole Robinson
57ae284ad4
virt-install: Deprecate --nonetworks in favor of --network none
...
Follows the pattern used by the other cli options
2014-09-20 19:02:38 -04:00
Cole Robinson
e3de3d8b69
virt-convert: Fix pointing to relative config file
2014-09-20 18:29:20 -04:00
Cole Robinson
1bfdf0575f
test_inject: Drop old bits, add f21 and rhel7, reorg a bit
2014-09-20 15:58:52 -04:00
Cole Robinson
6a8194ebc7
docs: Document virtio-scsi better, and add explicit test cases for it
2014-09-20 15:03:19 -04:00
Cole Robinson
5130d959e5
cli: Advertise the --host-device option as --hostdev
...
It annoys me that all the other CLI options map to the libvirt XML name,
except this one. Of course, keep the old option around for back compat,
just give precendence to the new option.
2014-09-20 14:29:34 -04:00
Cole Robinson
c88d085d03
virt-xml: Make --remove-device --host-device <str> work
...
Need to add some infrastructure for arbitrary lookup functions
2014-09-20 14:22:29 -04:00
Cole Robinson
dd67c48233
connection: Handle nodedev polling too
...
And cleanup up a bunch of nodedev functions as a result
2014-09-20 12:04:49 -04:00
Cole Robinson
8cd4958a19
cli: Break out function to disable libvirt error printing
...
We need it early in the test suite
2014-09-20 12:04:37 -04:00
Cole Robinson
55739055fd
ui: Set all files to minimum requirement of gtk 3.8
...
That way gives us better feedback from glade
2014-09-19 21:19:26 -04:00
Cole Robinson
d119a1bf6a
pylint: Disable cyclic-import check
...
Yeah it has a point... but the code works fine in practice, and the
remaining issues will need some decent reorg to fix.
2014-09-19 20:13:52 -04:00
Cole Robinson
052220cfc8
virtinst: Add DomainCapabilities parser
2014-09-17 18:29:24 -04:00
Giuseppe Scrivano
17a37ea39b
virt-install: add tests for OVMF
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-16 09:47:02 +02:00
Chen Hanxiao
30c3434916
test: update compare_check flags for auto-clone cases
...
auto-clone cases use SUPPORT_CONN_BARE_BACKINGSTORE,
which check libvirt 1.2.4.
Change it to SUPPORT_CONN_LOADER_ROM(1.2.9)
and drop SUPPORT_CONN_BARE_BACKINGSTORE.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-09-16 10:03:27 +08:00
Chen Hanxiao
4a83ea3a83
test: skip unit tests affected by loader extention before libvirt 1.2.9
...
libvirt commit for 1.2.9
68bf13dbef8342eaee0bf57c73cebb60b7de11e8
conf: Extend <loader/> and introduce <nvram/>
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-09-16 10:02:57 +08:00
Giuseppe Scrivano
1341928e92
test: Fix tests with latest libvirt
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-15 11:27:35 +02:00
Cole Robinson
a8843e5807
virtinst: Remove redundant LiveCDInstaller
...
DistroInstaller can basically do the same thing. This also gives us distro
detection when using virt-install --livecd
2014-09-07 13:42:56 -04:00
Cole Robinson
a722eeac78
virt-install: Enable libosinfo detection for --cdrom
...
This streamlines virt-manager and virt-install implementations, requiring
installer.distro_detect to be called if we want distro detection. As
a side effect, we now get CDROM detection for free.
2014-09-07 12:20:26 -04:00
Cole Robinson
eb01bc1b61
osdict: Disable virtioconsole default
...
We used to enable this for Fedora 18+, because systemd would
autostart a getty on /dev/hvc0 which made 'virsh console' work
out of the box for a login prompt. However now in Fedora
virtio-console is compiled as a module, and systemd doesn't
detect it in time to start a getty. So the benefit of using
it as the default is erased, and we reverted to this.
More info: https://bugzilla.redhat.com/show_bug.cgi?id=1039742
2014-09-06 18:37:20 -04:00
Cole Robinson
5aafe008bc
Remove virt-image, as scheduled
...
As promised with the last release, remove virt-image. In 6 months I didn't
hear a peep from any actual users that cared.
2014-09-06 18:05:43 -04:00
Cole Robinson
2e7d477156
urlfetcher: Bunch of distro detection fixes
...
And update test_urls to ensure it's passing
2014-09-06 16:42:09 -04:00
Cole Robinson
7d25dbe7a3
osdict: Always use vmvga for ubuntu
...
There's been a couple reports recently that virt-manager's default of video
model=qxl doesn't work well with latest ubuntu 14.04:
https://bugzilla.redhat.com/show_bug.cgi?id=1129803
https://lists.fedoraproject.org/pipermail/virt/2014-August/004105.html
However vmvga works, so let's use it for all ubuntu versions and not just a
couple of them. Marc Deslauriers confirmed it should be safe.
2014-09-06 13:45:15 -04:00
Cole Robinson
d89888a7bd
osdict: Don't force encode cirrus as the video default
...
Forcing cirrus isn't correct for non-x86 architectures, so let's have
libvirt fill in the default so there's only one place to fix it.
2014-09-06 13:45:15 -04:00
Chen Hanxiao
cff8e32c55
virt-install: support setting hugepages/page/[@size, @unit, @nodeset] for memorybacking
...
libvirt commit
136ad49740f017aabcac48d02d2df6ab7b0195e9
introduce ./hugepages/page/[@size, @unit, @nodeset]
for memory backing.
This patch will add support in virt-install.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-07-30 14:34:03 +08:00
Cole Robinson
8ea634f9e4
guest: Enable Hyper-v Enlightenments for Windows VMs
...
These are the recommended defaults for all windows VMs, when using
a new enough libvirt + kvm. Some more details in this boxes bug report:
https://bugzilla.gnome.org/show_bug.cgi?id=732811
2014-07-07 18:24:40 -04:00
Giuseppe Scrivano
57d26e6265
virtinst: parse "bandwith" node in network definition
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-26 15:26:37 +02:00
Cole Robinson
f6e214d438
testdriver: Add network <bandwidth> example
2014-06-26 08:50:08 -04:00
Chen Hanxiao
d3d76beb5b
guest: fix order in _XML_PROP_ORDER
...
re-order xml values according to libvirt code.
a) move "blkiotune" "memtune" ahead of "memoryBacking"
b) move "resource" ahead of "pm"
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-05 08:52:24 +08:00
Chen Hanxiao
d1b0fade1d
virt-install: add --resource support
...
This patch will enable setting
resource partition configuration.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-04 10:08:05 +08:00
Cole Robinson
da73e4980b
virt-install: Add --boot initargs=
...
Expects a shell escaped string which we split into individual initarg bits
2014-05-31 17:15:03 -04:00
Cole Robinson
eca6cd9471
virt-convert: Don't print 'convert' output with --print-xml
2014-05-31 16:41:30 -04:00
Cole Robinson
42fe235cbf
virt-install: Add --network portgroup= option
2014-05-31 14:30:07 -04:00
Cole Robinson
1c608f3ba8
network: Parse <portgroup> XML
2014-05-31 14:20:56 -04:00
Chen Hanxiao
3c45262526
virt-install: add --events support
...
This patch will enable setting event configuration:
on_poweroff, on_reboot and on_crash.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-05-29 09:46:24 +08:00
Cole Robinson
f397d96ca6
virt-install: Don't require install option with --print-xml (bz 1095789)
2014-05-11 19:19:00 -04:00
Cole Robinson
ea89dfb53f
tests: Don't fail on non-latest libvirt
2014-05-11 19:11:45 -04:00
Chen Hanxiao
c28516e73c
test: Fix tests with latest libvirt
...
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-05-05 11:00:35 +08:00
Cole Robinson
196ff823b3
Fix warnings with latest pep8
2014-05-02 10:20:59 -04:00
Jim Minter
764063dfe9
virt-install --disk discard= support
...
(crobinso: Remove default overriding, add test cases)
2014-04-29 10:38:30 -04:00
Chen Hanxiao
35c9afad45
test: fix a pylint
...
After commit 7594cef35f
,
pylint show a "access to a protected member" warning.
This patch introduces a static method to solve it.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-10 23:15:55 +08:00
Roman Bogorodskiy
7594cef35f
tests: fix TestCapabilities.testCPUMap
...
testCPUMap() tries to open /usr/share/libvirt/cpu_map.xml file
and that fails if libvirt is not installed on the system
or cpu_map.xml path is different.
Force it to use tests/capabilities-xml/cpu_map.xml file instead.
2014-04-08 18:13:03 +02:00
Cole Robinson
a398d245cb
Clean up pylint integration
...
- Drop no longer needed disable= bits
- Use string names for all skipped pylint messages
2014-04-02 19:00:24 -04:00
Chen Hanxiao
89c45af26d
interface: check ip address format
...
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-31 22:25:36 +08:00
Marc-André Lureau
5882f05e3e
addhw: add CharDevice.source_channel
...
This property maps to channel/source/@channel domain XML.
2014-03-25 17:42:57 -04:00
Giuseppe Scrivano
db6d001b0e
tests: fix to not fail with libosinfo
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-24 12:40:42 +01:00
Cole Robinson
b49f647e0c
details: Fix unsetting autoport values
2014-03-22 18:29:08 -04:00
Cole Robinson
9050998028
cli: Rename --membacking to --memorybacking
...
More consistent with the existing --memory option, and the
XML block name.
2014-03-22 12:28:23 -04:00
Cole Robinson
a5b3c1d2f8
guest: Drop back compat hugepage attribute
2014-03-22 12:25:28 -04:00
Chen Hanxiao
7096c3708e
virt-install: Add --membacking option
...
Add option --membacking for "Memory Backing".
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-22 12:16:24 -04:00
Chen Hanxiao
58a07d04fb
remove memoryBacking parameters from --memory
...
Remove some "Memory Backing" parameters from --memory,
and keep 'hugepages' for backward compatibility.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-22 12:16:24 -04:00
Cole Robinson
8562c3258e
More pylint fixes
2014-03-22 11:21:19 -04:00
Cole Robinson
d763126862
Turn off some warnings with latest pylint
2014-03-22 10:01:19 -04:00
Chen Hanxiao
008feeb09a
Add more parameters for memoryBacking
...
Add support for parameters nosharepages and locked
if using option --memory.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-14 21:23:23 +08:00
Giuseppe Scrivano
81696a5144
virtinst: use libvirt getCPUModelNames when available
...
Read the list of CPU models trough getCPUModelNames instead of
accessing directly the file cpu_map.xml.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1060316
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-13 19:00:54 +01:00
Giuseppe Scrivano
6c2645f0d2
virtinst: drop parsing of cpu features
...
As for the previous patch, this information is not used anywhere and
this information should be retrieved using the libvirt baselineCPU
API.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-13 16:50:40 +01:00
Giuseppe Scrivano
143a689592
virtinst: drop cpu_map parsing of arch features
...
This information is not used anywhere and there is no way to read
it directly from libvirt without parsing the cpu_map.xml file.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-13 16:50:37 +01:00
Cole Robinson
f23c031af4
ui: Drop minimum version to match RHEL7
...
And add unit test to catch future dependency issues
2014-03-10 11:17:58 -04:00
Giuseppe Scrivano
75349b9cf0
lxc: define a private network for OS containers
...
By default, specify the the "<privnet>" feature with LXC operating
system containers.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1040406
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-10 15:48:42 +01:00
Chen Hanxiao
40c1f5fdb8
clitest: put fake iso under /tmp dir
...
commit 797afb3b27
bring a dir depending issue when using
fake iso.
Test output will be undecided when virt-manager source
in different dirs.
This patch will touch a fake iso under /tmp,
so test case will pass on most of the machines.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-07 09:06:27 +01:00
Cole Robinson
797afb3b27
virt-install: Fix --location iso again, and test it (bz 1071513)
2014-03-06 12:46:46 -05:00
Cole Robinson
75a2e12dc0
tests: Fix a few failures with older libvirt
2014-03-06 11:29:23 -05:00
Cole Robinson
b4e4f68376
cli: Add --graphics defaultMode
2014-02-27 17:43:59 -05:00
Cole Robinson
dd577de636
tests: Remove 'support' module, not very useful these days
2014-02-25 15:06:36 -05:00
Cole Robinson
a2ab8a2643
tests: 'skip' a test if compare check fails
...
And make latest tests dependent on libvirt.git version
2014-02-25 15:05:58 -05:00
Chen Hanxiao
a48f75078d
virt-install: Add --memtune option
...
This patch provides the ability to
tune memroy tunable parameters for the domain.
Also add test cases for --memtune option
and update man page.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-24 21:02:31 -05:00
Chen Hanxiao
6722d2049e
tests: update test suites output with the last libvirt
...
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-24 11:33:42 +01:00
Chen Hanxiao
0dceb24b3b
virtinst: fix an issue of disk bus caculation
...
commit 466c2bcf9c
will generate the same index for
'hda' and 'hdaa'.
Also break test cases.
This patch will fix this.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-23 13:31:48 +08:00
Martin Kletzander
55d5b35e50
Fix generate_target once more
...
Passing a zero to the generate_target() function's as pref_ctrl
parameter makes the 'if pref_ctrl' conditions obviously false. Also
the range created was starting from 0 and not from 1. Apart from
fixing this, also fix tests so they actually test something this time.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-18 08:14:32 +01:00
Cole Robinson
63b27ceae1
caps: Simplify guest lookup routines
...
Checking for acceleration should always be done, API users can opt out
by requesting a specific domain type.
2014-02-17 11:54:11 -05:00
Cole Robinson
20b103d910
tests: test_inject: Minor fixups
2014-02-14 11:35:29 -05:00
Martin Kletzander
a9c791b5b8
Add target_to_num method
...
Opposite to num_to_target. It will be used in future patch.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-12 21:55:32 +01:00
Martin Kletzander
4196f4287b
Use proper python version
...
since we work with python2 only, mentioning it in all shebangs make
the commands from git work even when python3 is set as default.
This also fixes one test where command being ran is 'virt-xml' through
subprocess.Popen().
While at that, add '-tt' where possible in order to make everyone use
same indentation characters.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-12 21:55:32 +01:00