210cb858bc
controller: usb: Use ports=15 for usb3
...
It's the max that qemu supports, so why not add as many as possible.
Gerd indicated in private mail that he didn't know of any issues
with it.
2018-10-04 11:55:57 -04:00
35dd99f172
cli: Don't hardcode nec-xhci for --controller usb3
...
Use our helper function to choose the optimal model
2018-10-04 09:24:43 -04:00
b51104ad22
guest: Tweak error with invalid --os-variant
...
Try to point people in the right direction if they specify an
unknown distro name on the cli, like was reported here:
https://bugzilla.redhat.com/show_bug.cgi?id=1576473
2018-10-03 19:32:09 -04:00
046a242bd4
guest: Use USB3 for x86 qemu if OS supports it
...
Using new annotations in osinfo-db
2018-10-03 19:02:07 -04:00
c539f06eeb
cli: Give better --controller examples
...
ich9-ehci1 isn't a recommended configuration
2018-10-03 18:52:33 -04:00
8227b820ee
osinfo: warn when using deprecated osinfo IDs
...
At some point in the future it could be a good idea to drop the _aliases
mapping altogether; it will be hard to do so, in case the users are not
informed that they are using a deprecated ID.
(crobinso: Tweak format and message)
Signed-off-by: Pino Toscano <ptoscano@redhat.com>
2018-10-02 11:41:34 -04:00
4ad74278ca
cli: add memory backing access_mode & source_type
...
Allow to set some memory backing options, ex:
--memorybacking access_mode=shared,source_type=anonymous
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2018-10-02 11:12:13 -04:00
760dc32bac
osdict: Clarify comment about rhel virtio-serial hack
2018-10-01 11:39:58 -04:00
ff3d6c65d8
Fix some pep8 warnings
2018-10-01 11:37:28 -04:00
b2e7986c7b
osdict: Switch device lookups to be ID based
...
I'm not positive device names will never change, but presumably the IDs
won't, so use them instead
2018-10-01 11:24:45 -04:00
757910a1bb
cli: Add --metadata os_name= and os_full_id=
...
Allows changing the libosinfo metadata for an existing vm via virt-xml
2018-09-30 20:55:32 -04:00
b19f94299b
details: Add OS name view/edit, + oslist rework
...
This is just a big nasty commit.
Turn the OS inspection page into an always available page that
shows the libosinfo name from the domain metadata XML. Use oslist.py
and have it absorb more of the common behavior needed by create.py
and details.py. Add UI tests for it all
2018-09-30 20:55:32 -04:00
65e1187c10
osdict: Add a helpful __repr__
2018-09-30 09:37:14 -04:00
31e4b72a8b
osdict: Drop Glib.Date API usage
...
Use python datetime instead, it's more python friendly
2018-09-29 15:22:44 -04:00
97ea737386
devices: interface: Have x86 fallback model be e1000
...
libvirt will use rtl8139, but the qemu default changed a while
ago to e1000, and libvirt has diverged. e1000 is more modern and
considered the better default here, so use it
2018-09-29 14:35:28 -04:00
627bfabc32
pylint: Silence output on Fedora 29
2018-09-29 14:27:34 -04:00
4adb1c8c30
pycodestyle: fix W605 invalid escape sequence
2018-09-29 13:59:19 -04:00
7356afcca7
osdict: Use USB tablet if no OS specified
...
Most OS users will be installing benefit from it, so make it the
default
2018-09-29 13:36:42 -04:00
184b96a815
virtinst: util: Remove unused validate_uuid
...
We let libvirt error nowadays
2018-09-14 15:19:03 -04:00
a741f595ea
guest: Drop update_defaults
...
Fold its one purpose into the UEFI setting bits, fix it and test it
2018-09-13 15:59:27 -04:00
d7ff46f7f5
guest: Encode the cli --os-variant in the XML
...
And add some testdriver examples of it
2018-09-13 15:11:22 -04:00
86ef998023
guest: Lookup osinfo object from libosinfo metadata XML
2018-09-13 15:03:36 -04:00
bad5eabd93
domain: Add metadata.libosinfo
...
From the libosinfo discussion here:
https://www.redhat.com/archives/libosinfo/2018-September/msg00003.html
This is a cross-app schema for tracking libosinfo OS ID in the
domain <metadata> XML. Example:
<metadata>
<libosinfo:libosinfo xmlns:libosinfo="http://libosinfo.org/xmlns/libvirt/domain/1.0 ">
<libosinfo:os id="http://fedoraproject.org/fedora/17 "/>
</libosinfo:libosinfo>
</metadata>
2018-09-13 12:39:56 -04:00
baaab74b6d
xmlapi: Rework xmlns setting slightly
...
So the xmlns is not always set on the top element. We need this for
custom <metadata> support
2018-09-13 12:39:56 -04:00
841d5126d2
xmlapi: Move namespace mappings to the relevant classes
...
So we don't need to update xmlapi.py to account for additions
2018-09-13 09:34:04 -04:00
6063538750
guest: Replace os_variant with set_os_name
...
And have callers directly access osinfo.name if they need it
2018-09-12 17:24:28 -04:00
2549e60698
guest: Add an entry point for setting machine=q35 default
...
We will want this at some point, but it's dependent on libosinfo
work
2018-09-12 15:35:49 -04:00
4e30161f44
guest: Absorb UEFI default setup
...
Rather than force callers to deal with it
2018-09-12 14:02:23 -04:00
e903d374c2
guest: Always encode machine= in XML
...
Don't rely on libvirt's default. This makes any XML changes more
explicit, and can help other parts of the code that may depend on
a machine type being encoded
2018-09-12 12:16:47 -04:00
ec69ae44b6
capabilities: Drop build_virtinst_guest
...
Same as lookup_virtinst_guest
2018-09-06 20:54:59 -04:00
1c05db691d
guest: Cache capsinfo
...
Don't repeatedly look it up, was slowing down the test suite by about 5%
2018-09-06 20:38:59 -04:00
a2fa799478
capabilities: Drop lookup_virtinst_guest
...
Users should just init Guest() directly, and call
set_capabilities_defaults if they need default arch data
2018-09-06 20:28:05 -04:00
e61f2b991b
guest: Re-organize function locations
2018-09-06 20:12:49 -04:00
5f22f41da4
guest: Absorb capabilities defaults setup
...
Rather than forcing API users to go through the capabilities APIs.
This lets us simplify things in virt-install quite a bit, and is
needed for smarter machine type defaults
2018-09-06 20:12:49 -04:00
12a7a18be0
cli: Fix traceback detection
2018-09-06 18:39:14 -04:00
a754718889
devices: disk: Use uppercase naming for mode lists
2018-09-06 16:51:14 -04:00
63287c83fb
addhardware: Move disk bus listing to virtinst
...
Drop the stable_default stuff as domcaps usage should make
it obsolete for any cases we care about
2018-09-06 16:40:49 -04:00
a09a46289a
addhardware: Move controller list logic to virtinst
...
And tweak the UI defaults a bit, preferring virtio-scsi and
usb3
2018-09-06 16:05:12 -04:00
7994dc90c8
addhardware: Move video model list to virtinst
...
And make it smart about the hypervisor
2018-09-06 14:45:05 -04:00
b3865d7b0d
addhardware: Drop tcp/udp/dev char support
...
I know openstack uses tcp consoles but for end users I've never
really heard about it. RHEL compiles out udp as well. I'm fine telling
users to go to the cli and use virt-xml for this use case.
Use this opportunity to drop a lot of code that only simplified the
case when there are tons of char options we need to consider
2018-09-06 13:28:21 -04:00
cd07d6af34
sound: Track recommended models in virtinst
...
Change addhardware to show an editable model entry, like the
details wizard
2018-09-06 13:28:21 -04:00
be1f5a6e25
devices: Remove a bunch of unused static lists
2018-09-06 13:28:21 -04:00
2b7043cd85
createpool: Fix showing formats
...
But shrink the format list to 'auto' only, but also add a text entry
so users can type their own
2018-09-06 13:28:21 -04:00
c5033c02d5
fsdetails: Use combo entry for format list
...
And stop listing all the crazy qemu formats
2018-09-06 13:28:21 -04:00
242844fefa
osdict: Make the broken uefi+hyperv bit more explicit
...
And add links to the relevant bug reports
2018-09-04 14:55:40 -04:00
4394eff9fa
xmlbuilder: Drop last usages of set_converter
...
Unfold most of them into manual property() wrappers. It's a bit
noisier but the logic is easier to follow.
2018-09-04 14:55:04 -04:00
bd35f4711c
devices: disk: Rename setup() to build_storage()
...
It's more explicit. Plus drop the supposedly generic setup()
entry point, storage is handled specially everywhere so it's
not a generic interface
2018-09-04 14:55:04 -04:00
ebd6091cc8
devices: interface: Simplify is_conflict_net calls
...
We don't return a non-fatal error these days, so adjust all callers
to only handle failure
2018-09-04 14:55:04 -04:00
c27cdc67de
devices: interface: Convert setup() to validate()
...
That's all it's doing. Fold in mac validation while we are here
2018-09-04 14:55:04 -04:00
43f40950eb
devices: Remove some redundant char/rng xml callbacks
...
I think these aren't needed after the default fixing stuff, or maybe
past xmlbuilder fixes
2018-09-04 14:55:04 -04:00
Cole Robinson