2ac54ac001
guest: Drop self.installer and start_install wrapper
...
This changes all the callers to invoke start_install directly on the
Installer object. We still stash the installer instance inside the
guest object in create.py, just for simplicity
2018-09-04 14:55:04 -04:00
c154bbacd4
guest: Fold add_default_devices into set_defaults
...
It doesn't have any need anymore to be separate
2018-09-04 14:55:04 -04:00
256ca7f3fb
virt-install: Simplify install method validation a bit
...
And drop the --pxe --nonetwork collision check, it's near pointless
2018-09-04 14:55:04 -04:00
1e76496fa8
storage: remove default_cb usage
2018-09-04 14:55:04 -04:00
221dd00cb9
devices: disk: remove default_cb usage
2018-09-04 14:55:04 -04:00
fff3c88f9c
devices: disk: Absorb Guest bus/target default setting
...
Simplifies cli stuff as a nice side effect
2018-09-04 14:55:04 -04:00
ef83565e48
devices: hostdev: Add set_defaults
2018-09-04 14:55:04 -04:00
64dc334538
devices: interface: Add set_default function
...
Move all the Guest network default logic to it, and drop a now
redundant test
2018-09-04 14:55:04 -04:00
347143982a
devices: Add set_defaults for memballon, redirdev, rng, smartcard
2018-09-04 14:55:04 -04:00
31bda5bbb6
devices: watchdog: Add set_defaults
2018-09-04 14:55:04 -04:00
d25ce81439
guest: Force qxl/vga more often
...
Letting libvirt choose gives us cirrus, which is really bad.
So for x86 for it more
2018-09-04 14:55:04 -04:00
fdd1cc5ca8
guest: Make spice default device additions explicit
...
Don't lump it in with setting video defaults
2018-09-04 14:55:04 -04:00
c3515fa469
guest: Drop multifunction address magic
...
Seems sufficiently obscure that if someone is manually specifying
addresses we can require them to pass multifunction as well
2018-09-04 14:55:04 -04:00
3c62685bf1
uitests: Use Ctrl_L+Alt_L+Z as a grab keys when testing prefs
...
Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
2018-09-04 13:30:14 -04:00
568a39f1ee
uitests: Increase click offset for window drag
...
On KDE the testManagerWindowCleanup test clicks right on the border and
the drag operation fails, bringing down the test. Clicking a bit lower
fixes this issue.
Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
2018-09-04 13:30:14 -04:00
fb7b295e21
uitests: Fix selection of items in long menus that don't fit on screen
...
Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
2018-09-04 13:30:14 -04:00
895668fa9a
uitests: Fix onscreen to return True only when full widget is on screen
...
Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
2018-09-04 13:30:14 -04:00
bf823fdb3c
details: Pin network-model label directly to combo to simplify tests
...
This approach is used in majority of other places and allows the
combobox items to be selected directly instead of typing text in tests.
Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
2018-09-04 13:17:19 -04:00
c81d722a19
uitests: Improve robustness of click_combo_entry()
...
Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
2018-09-04 13:17:19 -04:00
1f2b9b8342
uitests: Don't fail when requiested file is not visible
...
Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
2018-09-04 13:17:19 -04:00
10290cbf48
tests: uitests: Fix remote dbus test
...
My last patch broke it!
2018-09-04 13:17:19 -04:00
40461c58ef
tests: uitests: Fail if virt-manager is already running
...
We don't want to connect to an existing app and possibly mess
up host state
2018-09-04 12:44:05 -04:00
e6c7e46a54
details: Add support for disk detect zeroes option
2018-09-04 11:39:50 -04:00
6f301ba0aa
tests: clitest: Fix failure when isoinfo not installed
...
https://ci.centos.org/job/virt-manager-master-check/systems=libvirt-fedora-rawhide/410/display/redirect
support usage cleanup broke self.skip_test
2018-09-04 10:01:20 -04:00
ad70393ed9
tests: Fix breakage with libvirt.git
...
https://ci.centos.org/job/virt-manager-master-check/systems=libvirt-fedora-rawhide/409/
Added validation to hugepages nodeset. Just drop the test case, we
test it elsewhere too
2018-09-04 09:21:23 -04:00
67e139dc5f
tests: magicuri: Fix specifying caps path
2018-09-02 10:06:44 -04:00
d5638eb140
osdict: Make qemu_ga support solely dependent on virtio-serial support
...
We shouldn't concern ourselves with whether the OS supports qemu_ga
out of the box, just set up the channel regardless, as long as
virtio-serial is supported.
This adds the channel for some aarch64 cases which didn't have OS
specified, but that's desired IMO
2018-09-01 13:23:01 -04:00
4e63267a4f
urldetect: Rename urldistro to matching_distros
...
Allow store classes to track multiple matching types, and use this
to ditch the custom urldistro logic in osdict altogether
2018-09-01 13:23:01 -04:00
6ce3865576
test_urls: Point to latest fedora dev URL
2018-09-01 13:23:01 -04:00
6ae8e51901
osdict: Remove unused functions
2018-09-01 13:23:01 -04:00
fb1bb26373
support: Drop lots more checks
...
- Remove anything for less than qemu 0.12 or libvirt 0.10, basically
rhel6 vintage stuff
- Open code some simple checks
- Remove some that are only used for unnecessary error reporting
2018-08-31 22:21:15 -04:00
a5ef8a2995
support: Drop a few more support checks only used in tests/
2018-08-31 18:31:17 -04:00
967ca4eeda
virtinst: Drop direct 'support' usage
...
Except from connection. This requires some reorg in clitest and
some minor changes in a few other places
2018-08-31 18:31:17 -04:00
d8514e19c8
guest: Drop arm vexpress virtio-mmio support
...
This case will still work, but be a bit slower, which is fine. Nowadays
-M virt is much better for virt usage and nearly everyone is using that,
so save us the complication. This was really only useful when
bootstrapping arm virt support
2018-08-31 17:31:09 -04:00
ea413be214
xmlbuilder: Rename get_xml_config -> get_xml
...
The config part is redundant. Should have done this a long time ago
2018-08-31 16:52:02 -04:00
2b41e130d8
connection: rename fetch_all_guests->fetch_all_domains
...
The virtinst class is erroneously called Guest, but these
functions are dealing with libvirt <domain> XML, so rename them
2018-08-31 16:50:46 -04:00
83a9e613e9
tests: uitests: Fix breakage
...
Needs adapting to latest TPM addhw work, and armv7 UEFI support
2018-08-31 16:47:10 -04:00
b1eb07c26a
guest: Don't add usb tablet for xen PV
...
xen PV doesn't have USB support
2018-08-22 08:38:33 -04:00
8d45dba43d
cli: Add --boot bootloader=
2018-08-22 07:38:34 -04:00
2b35183352
guest: Don't hardcode /usr/bin/pygrub for xenpv
...
Let libvirt/libxl fill it in. This was required for rhel5 xen at
least, but we don't support that anymore and modern libvirt seems
to do the right thing and fill it in for us.
2018-08-22 07:37:32 -04:00
7cd41ab9ea
guest: Default to e1000e if machine=q35
...
And libosinfo doesn't have any specific recommendation for us
2018-08-21 16:36:38 -04:00
2da06fec95
guest: Default to ich9 if machine=q35 (bz 1388177)
...
It's the pci-e version which we should prefer for q35
https://bugzilla.redhat.com/show_bug.cgi?id=1388177
2018-08-21 16:35:34 -04:00
f9600ca31b
virt-install: Remove smm validation and q35 default setting
...
The validation is already handled by libvirt, and setting q35 for
smm=on is overkill and just hardcoding some libvirt logic here.
I think the 'secboot' detection in Guest.py is the preferred
magic here, otherwise let users specify all the correct values.
2018-08-21 15:39:27 -04:00
eb0f4a612f
virt-install: Support armv7l and i686 uefi
2018-08-08 15:14:21 -04:00
4484f473cd
char: Track/Show the state of virtio channels in channel details
...
crobinso: Add a test case
Signed-off-by: Lin Ma <lma@suse.com>
2018-07-12 15:25:23 -04:00
931936a328
virtinst: Remove only auto-generated channel source path
...
In attempt to fix https://bugzilla.redhat.com/show_bug.cgi?id=1270696
this code was introduced but it removes the path for all channel
devices. We need to limit it only to the devices that have
auto-generated source path.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1591670
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2018-06-28 16:45:14 +02:00
3a4cf07a28
virtinst: allow adding host block devices to LXC containers
...
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
2018-06-19 15:07:45 -04:00
a2a022a879
virtinst: allow adding host character devices to LXC containers
...
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
2018-06-19 15:07:42 -04:00
bba3d04558
virtinst: allow adding host network devices to LXC containers
...
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
2018-06-19 15:05:28 -04:00
7a2abb5abf
installer: Remove --location nfs support
...
Removal was discussed here:
https://www.redhat.com/archives/virt-tools-list/2018-May/msg00011.html
Basically I don't think many people use this, the feature is very
inflexible, it's hard to test, and users can essentially do it
themselves with a bit more effort.
2018-06-12 14:07:50 -04:00
Cole Robinson