259c70a090
error: Drop unused parent callback
2018-03-17 18:49:55 -04:00
defdfd4b51
engine: Fix backtrace from manager->exit
2018-03-17 18:47:13 -04:00
591dda6d1e
uitests: connect: Test double click to open
2018-03-17 18:46:40 -04:00
edc79a3272
uitests: Add VM 'doubleclick' open testing
2018-03-17 18:46:40 -04:00
97db1ac18a
manager: Simplify row management a bit
...
Drop the self.rows dict, use more pygobject row[] convenience
helpers, add some helper properties for VM
2018-03-17 18:46:40 -04:00
7de9028221
manager: Fix some menu item sensitivity issues
2018-03-17 18:46:40 -04:00
b423d8ffe7
uitests: cli: test --connect with a bad URI
2018-03-17 18:46:40 -04:00
b5377f8f0f
engine: Make a decorator function for showing startup errors
2018-03-17 18:46:40 -04:00
3c1e0a8a12
virtManager/*: Give pylint hints about singleton classes
...
It can't seem to figure out that what 'cls' is in this context,
so make it explicit.
2018-03-17 18:46:39 -04:00
7ad15769dc
virt-manager: fix git startup on wayland
...
Apparently we need to do these env settings much earlier...
2018-03-17 13:14:04 -04:00
483a8de6c1
systray: Change window tracking a bit
...
We should only prevent app closing if the systray is actually embedded
2018-03-17 12:18:38 -04:00
9ec865e4c0
systray: Only create statusicon if showing
...
Since even if it's marked as not visible, it can cause some movement
on the gnome3 topbar with topicons extension
2018-03-17 11:42:12 -04:00
dac860e8ce
engine: Show modal startup errors if window open fails
2018-03-16 19:09:55 -04:00
ee817c32ce
s/connect_opt_out/connect_once/ for open-completed callback
...
Forgot about that helper function...
2018-03-16 18:05:52 -04:00
ad632383c8
virt-manager: if new --connect fails, don't save the URI
2018-03-16 18:05:52 -04:00
6969066b9f
cli: Don't double print uncaught exceptions with --debug
...
We have an excepthook that logs uncaught exceptions for good
reason, but if printing --debug to stdout this exception gets
printed twice when we invoke the stock __excepthook__. Skip that
in the debug_stdout case.
2018-03-16 17:56:05 -04:00
2f0e730efc
error: Don't double log summary
...
details is often composed of a summary + traceback, so if users copy
it into a bug report we get all the info. But when logging the contents
we don't want to double log the summary, so try to strip it out
2018-03-16 17:30:39 -04:00
465b04ea18
Remove gconf->gsettings conversion script
...
It was first released with v1.2.0 in May 2015. I think that's long
enough for people to have run the app and had their settings
converted.
2018-03-16 14:41:53 -04:00
c9b2ec163f
preferences: Add UI for disabling spice usb autoredir
...
We already have a gconf key and command line option for this.
Drop the CLI option and add UI for it, we should have just done
that to begin with
2018-03-16 14:38:22 -04:00
30cc70ccf4
virt-manager: Drop --no-conn-autostart
...
It was mildly interesting back before libvirt supported threads but
I don't think anyone cares about it now.
2018-03-16 14:19:35 -04:00
f5562e77ae
tests: uitests: Make an addhw test less flakey
2018-03-15 21:24:48 -04:00
dabbc8d5bd
engine: Remove centralized conn.open handling
...
Move connection opening logic to each caller, since needs are
slightly different.
2018-03-15 21:24:48 -04:00
5ebe8b8184
create: Fix customize dialog launching
...
After the increment/decrement rework
2018-03-15 21:24:48 -04:00
b72db888f6
ui: create: Fix container rootpw mismerge
2018-03-15 21:24:48 -04:00
cad809fe80
Make all dialogs clean up when vm/conn disappears
...
Moves all the window cleanup handling to each class and audit for
all --test-leak-debug errors and fix
2018-03-15 21:24:48 -04:00
2ee69edc8e
snapshots: Fix generating screenshot after py3 conversion
2018-03-15 21:24:48 -04:00
20d5c1887a
baseclass: Export GObject.SignalFlags.RUN_FIRST
...
Saves some typing and imports
2018-03-15 21:24:48 -04:00
1d17b98852
engine: Move most remaining window tracking to UI classes
...
Kind of a big mess but it was difficult to untangle piecemeal.
Basically this drops nearly all the centralized window tracking
in engine.py and moves it to each UI class. If manager.py wants
to open a details window it does it directly, and vmmDetails tracks
the window object list itself. This simplifies things and makes
the code easier to follow.
There's still some weirdness with vmmConnect and connection callbacks,
but future patches will break those apart.
2018-03-15 21:24:48 -04:00
92aea7c565
engine: Have windows increment/decrement windows directly
2018-03-15 21:24:48 -04:00
9fa9777f1c
engine: Have windows call exit_app directly
2018-03-15 21:24:48 -04:00
6180a3c81f
engine: Cleanup function names, comments, etc.
2018-03-15 21:24:48 -04:00
58f872a205
clone: Convert to per-connection singleton-ish pattern
...
And convert the dialog VM handling to match other dialogs
2018-03-15 21:24:48 -04:00
b94a9fdffb
migrate: convert to singleton
2018-03-15 21:24:48 -04:00
a915b089cd
migrate: Drop cached conn list
...
Not needed since we have connmanager now
2018-03-15 21:24:48 -04:00
65b512ae6f
delete: Convert to singleton
2018-03-15 21:24:48 -04:00
1780d0e9f0
details: Call inspection VM refresh directly
2018-03-15 21:24:48 -04:00
f088537798
engine: break out vmmConnectionManager
...
Have a separate class for tracking the connection list, and emitting
conn-added and conn-removed signals. It exists as a singleton instance
that UI classes can talk directly to
2018-03-15 21:24:48 -04:00
befafe9dc7
engine: connect conn-added in UI classes
...
This creates a weird situation where we pass the engine to those
classes UI functions, but this is a step towards untangling that.
While here, get rid of the conn-added connect magic and add a
simpler way to access the connection list from the engine
2018-03-15 21:24:48 -04:00
2dcfaafcac
inspection: Show inspection error in details page
2018-03-15 21:24:48 -04:00
c21e0db6ea
inspection: Remove startup delay
...
Like the comment says it shouldn't matter
2018-03-15 21:24:48 -04:00
48e97e85a6
inspection: Skip for test connections
2018-03-15 21:24:48 -04:00
6b1278ccda
prefs: Add a setting to enable/disable libguestfs inspection
...
Rather than key it on the library being available. Makes it much
easier to test both modes of behavior.
Fix up a few inspection bugs while I'm in the area, and convert
it to be more singleton like.
2018-03-15 21:24:48 -04:00
6959a41ff2
connection: Drop vm-added emission on connect
...
We don't use this for most other signals and it's kind of unexpected
2018-03-15 21:24:48 -04:00
3187078f10
config: Convert to singleton
2018-03-15 21:24:48 -04:00
33def3c4af
preferences: Convert to singleton
2018-03-15 21:24:48 -04:00
b6a61818af
about: Convert to singleton
2018-03-15 21:24:48 -04:00
717ff72684
engine: Move VM action callbacks to vmmenu.py
...
Call the callbacks directly rather than using signals. engine.py
has become a bit of a catchall for shared functionality and this
is a step towards disentangling it
2018-03-15 21:24:48 -04:00
42e4cc33bf
systray: Fix VM leak on conn close
2018-03-15 21:24:48 -04:00
fbf1bc80b5
connection: Dispatch object remove signals on close
2018-03-15 21:24:48 -04:00
b25c38816a
pylint: Enable 'fixme' checking
...
Using these for long term TODO type items is not effective, however
it's nice to label things as FIXME during a coding session and have
pylint warn you about them before pushing.
2018-03-15 21:24:48 -04:00
Cole Robinson