9cffcef66e
tests: test_urls: Update
...
And only have one ftp test, since ftp is sloooow
2017-08-29 11:57:14 -04:00
d71ef83942
tests: test_urls: Rework to better handle multiple archs
2017-08-29 11:57:14 -04:00
b44aa0e3bb
pycodestyle: fix all E131 warnings
...
Fix all E131:
Continuation line unaligned for hanging indent
Also remove ignore options of E131
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2017-08-26 20:03:21 +08:00
e902fa5550
urlfetcher: force binary mode with FTP servers (bz #1462838 )
2017-08-17 16:10:46 -04:00
e76b904656
engine: improve message about missing binaries
...
The message when failing to connect can be misleading as package names
will differ per Distribution as well as not apply for e.g. self built
binaries.
This changes the message in a way to be more generic not implying literal
package names.
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
2017-08-16 17:32:18 -04:00
c92aade081
pycodestyle: fix all E203 warnings
...
Fix all E203 whitespace before ':'
Also remove E203 ignore option of pycodestyle
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2017-08-11 00:01:38 +08:00
34c80e56cd
Prep for release 1.4.2
2017-08-08 18:14:48 -04:00
5183971bc6
README.md: mention virt-* cli tools
2017-08-08 15:58:38 -04:00
cf522bfc0c
engine: Remove manual line wrapping of connect error messages
...
This was needed once upon a time when the UI was wrong, but it
wraps correctly now
2017-08-07 18:17:00 -04:00
9e7426b64f
engine: Drop offer to install askpass package (bz 1354304)
...
Dealing with packagekit across desktops and in a consistent
manner is a pain. This code path is rarely exercised and difficult
to test, so just fallback to giving a hint error message and
let the user install if they care.
2017-08-07 17:41:52 -04:00
cc72f74f97
packageutils: Ensure packages argument is a list
...
It's easy to screw this up from the callers, and gives weird
interactions with apper
2017-08-07 17:27:30 -04:00
4cdae27cb2
engine: With --test-first-run, don't try default URI detection
...
default URI detection gets testing via the 'connect' dialog, this
makes it easier to test the fallback when no packages are locally
present
2017-08-07 17:27:30 -04:00
08a7eaed4d
config: If --test-first-run, fill in some default package names
...
Simplifies testing the feature from git
2017-08-07 17:25:55 -04:00
69449d7b94
virt-manager: Remove needless cli option renaming
2017-08-07 17:22:03 -04:00
cd20536143
Use gtk-stop icon for the "Stop" action
...
When stopping the pools or the interfaces use the gtk-stop icon.
Currently this is inconsistant with the virtual network tab.
https://bugzilla.redhat.com/show_bug.cgi?id=1352974
2017-08-03 13:06:02 -04:00
c4826444e9
storage: Fix 'srcname' referenced before assignment (bz #1474766 )
...
https://bugzilla.redhat.com/show_bug.cgi?id=1474766
2017-08-03 12:38:37 -04:00
b93cc3bbc9
pycodestyle: Do not use bare 'except:'
...
A bare 'except:' catches all exceptions [1], including SystemExit,
KeyboardInterrupt, and GeneratorExit (which is not an error and should
not normally be caught by user code). In situations where you need to
catch all “normal” errors, you can catch the base class for all normal
exceptions, Exception [2].
[1] https://docs.python.org/2/howto/doanddont.html#except
[2] https://docs.python.org/2/library/exceptions.html#Exception
2017-08-02 13:57:43 -04:00
2fd6d9aa32
tests: Upgrade pep8 to pycodestyle
...
The PEP8 [1] project has been renamed to pycodestyle [2].
[1] https://github.com/codeclimate/pep8
[2] https://github.com/pycqa/pycodestyle
2017-08-02 13:23:20 -04:00
00ffb3340e
Remove unintentionally added '+'
2017-08-02 13:15:27 -04:00
89e5783cad
create: Auto-generate fs path if not provided
...
Use default place to store file systems of bootstraped containers.
If the current user has effective UID 0 use:
/var/lib/libvirt/filesystems/<container-name>
otherwise use:
~/.local/share/libvirt/filesystems/<container-name>
2017-08-02 13:13:57 -04:00
c5264a2390
create: Stop if virt-bootstrap has failed
...
Prevent container creation if virt-bootstrap has not finished
successfully.
2017-08-02 13:13:17 -04:00
6f8206dc55
uitests: newvm: Fix after CPU UI tweaks
2017-07-20 17:54:11 -04:00
1a09a05dc7
tests: Add a clone test for importing nvram directory
...
Need to use some callback magic to fake it like there's a file in
an existing directory
2017-07-20 17:51:06 -04:00
a9903ae0e0
connection: Remove clear_cache callback
...
It doesn't actually accomplish what we want for the virt-manager case,
and cache_new_pool should cover our needs now
2017-07-20 17:30:37 -04:00
4792c7cb8e
connection: Add a default impl of cache_new_pool
...
Inserts it into the cache, and adds its associated volumes too
2017-07-20 17:30:36 -04:00
a9d9c0d035
connection: rename s/add_new_pool/cache_new_pool/g
...
Better describes exactly what's going on
2017-07-20 17:29:55 -04:00
6b586e2bed
tests: Rework connection caching
...
Drop the callbacks and instead prime the connection's internal cache.
This will simplify upcoming changes
2017-07-20 17:28:38 -04:00
5b51c98ae5
storage: Check for pool name collisions against the pool cache
...
Rather than using storagePoolLookupByName. This will save some API
calls, but the main benefit is that it can help shake out cache
issues.
2017-07-20 17:28:38 -04:00
55aa23b400
connection: Return copys of cached object lists
...
Incase any users manipulate the lists, we don't want that to affect
our caching. Could prevent future mistakes
2017-07-20 17:28:38 -04:00
4e4a6c817f
connection: Rework cache function layout slightly
...
Have the internal polling functions not touch the connection cache.
This let's us not worry about the connection cache in the test suite,
where clear_cache wasn't 100% correct.
2017-07-20 17:28:38 -04:00
5cffae0c68
connection: Fix virt-manager UI cache_new_pool impl
...
The current implementation calls _new_object_cb, which isn't
expected to be run from a non-main thread, and can cause crashes.
https://bugzilla.redhat.com/show_bug.cgi?id=1457170
Switch the impl to just wait for 3 seconds for the pool to show
up in our cache.
2017-07-20 17:28:36 -04:00
e241f4c957
tests: Open a new connection for each test
...
To ensure we are testing each time from a clean state. Isn't causing
obvious issues in practice at the moment but it may with future
changes
2017-07-20 17:27:22 -04:00
d3074141c8
cloner: Remove redundant setup() method
...
The functional callers use the individual setup methods, let's drop the
helper function and adjust the test suite
2017-07-20 17:27:22 -04:00
9863a963fe
virtManager: clone: drop redundant clone setup
...
We already handle all these steps in the validation() step, which
happens directly before this code.
2017-07-20 17:27:22 -04:00
091c6155d2
ui: host: Fix some interface panel spacing
2017-07-20 17:27:22 -04:00
1e3e9a9fc4
uitests: Add 'host' window smoke tests
2017-07-20 17:27:22 -04:00
ec917e992a
cloner: Drop redundant libvirt call
...
The disk should already have looked up the parent pool object
2017-07-19 12:59:41 -04:00
65b0331b72
cloner: Throw explicit error if NVRAM is missing
...
Otherwise it comes off like a coding error
2017-07-19 12:57:42 -04:00
98b5ea8b2c
connection: Drop disabling of cache_object_fetch
...
All cases we care about either provide their own callbacks, or
explicitly want this caching, so enable it unconditionally
2017-07-19 12:57:36 -04:00
21ce859356
gfxdetails: add checkbox for password visibility toggle
...
This patch add a checkbox for password visibility toggle.
As we stored password of SPICE/VNC in clear text in XML,
it's easy to use in UI.
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2017-07-19 12:26:02 -04:00
5c66c7010c
baseclass: Document some functions
...
And drop a bit of redundant code that we haven't needed for a while
2017-07-19 10:35:19 -04:00
7d03190cb5
spice: s/OK/Close/ in USB redirection dialog (bz 1465907)
...
To make it more clear that USB redirection happens immediately
https://bugzilla.redhat.com/show_bug.cgi?id=1465907
2017-07-17 15:46:12 -04:00
a0a8470362
connection: Cache host arch CPU model list on startup
...
Rather than hardcode x86_64
2017-07-17 11:47:01 -04:00
ca56f74ed7
capabilities: Fix model list caching for different archs (bz 1451113)
...
We could return cached x86_64 results for aarch64 VMs
https://bugzilla.redhat.com/show_bug.cgi?id=1451113
2017-07-17 11:47:01 -04:00
2eaf084b04
capabilities: Drop cpu_map.xml handling
...
We've had getCPUModelNames in libvirt for years now, and this
functionality isn't critical anyways, so drop the fallback
2017-07-17 11:47:01 -04:00
b5c9321b07
osxml: run abspath on passed nvram value
2017-07-17 09:16:45 -04:00
c6fdfbf3c3
cli: disk: add driver_detect_zeroes= support
2017-07-15 13:39:04 -04:00
640e559774
man: virt-install: Make some VNC references more generic
...
Since these parameters apply to SPICE too
2017-07-14 19:48:56 -04:00
85cbf9e64d
ui: create: modernize layout for memory/cpu page
2017-07-14 19:23:35 -04:00
90e03297b1
create: Show details of container bootstrap
...
Get get information about the progress from virt-bootstrap
and show it on GUI.
2017-07-13 14:45:28 -04:00
Cole Robinson