b513388979
domain: Remove internal 'cloning' marker
...
qemu nowadays should reject the common cases here with its default
image locking. Our impl wasn't very good anyways so let's just leave
it up to the lower layers
2019-06-16 17:32:41 -04:00
9c8e879ff0
virt-install: Add --boot firmware=
2019-06-16 17:15:08 -04:00
53f075ab76
virt-xml: Warn if libvirt discards our defined changes
...
This can happen if we try to remove a default device, like
a ps2 mouse on x86, but it can happen for many other reasons as well
https://bugzilla.redhat.com/show_bug.cgi?id=1405263
2019-06-16 17:08:59 -04:00
f7854d0a84
virt-xml: Use VIR_DOMAIN_XML_SECURE
...
Otherwise we will lose data when editing VMs
2019-06-16 16:48:50 -04:00
52c6094c65
virt-xml: Denest and comment code flow a bit
...
Add lots of early exits to remove implicit fall through
behavior that I find hard to follow
2019-06-16 16:47:05 -04:00
0221471e4f
virt-xml: If no XML diff is generated, explicitly warn
2019-06-16 16:37:48 -04:00
9ed926a898
spec: Add --with=virtconvert
...
We may consider removing virt-convert in the future, and we
don't want to ship it on RHEL. So app some spec machinery to
exclude it from the RPM
2019-06-16 15:00:39 -04:00
4973564e65
virt-clone: add --skip-copy option
...
This is the flip side to the --force-copy option. We already
have the plumbing internally
https://bugzilla.redhat.com/show_bug.cgi?id=1564865
2019-06-16 14:41:54 -04:00
44cf01cee1
setup: Fix test_urls coverage testing
...
And exclude some error handling
2019-06-16 14:41:54 -04:00
88f52f956e
urldetect: Don't use dict ordering for URL detection
...
ALLSTORES was implicitly using dict() ordering. This exposed
a bug in our code on debian ci which was nice, but it should
be deterministic. Hardcode the ordering
2019-06-16 14:41:54 -04:00
df82856021
tests: Finish cloner.py coverage
2019-06-16 14:37:56 -04:00
03ded3e2bc
urldetect: Fix sles11 ppc64 media detection
...
https://bugzilla.redhat.com/show_bug.cgi?id=1379653
2019-06-16 13:50:36 -04:00
52f0b1c91e
devices: disk: Handle unset source_protocol
...
This can't happen with libvirt processed XML, but could
be triggered via virt-install command line.
https://bugzilla.redhat.com/show_bug.cgi?id=1482636
2019-06-16 11:01:47 -04:00
dcd0b2ac81
cloner: Fill out test coverage
2019-06-15 16:15:01 -04:00
d6b6397ce0
virtManager: xmleditor: warn when switching to XML tab
...
If there are unapplied changes in the UI warn user when they tries to
switch to XML editor.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2019-06-15 15:05:28 +02:00
5eb5913f34
domain: Ensure nvram path before trying to access it
...
https://bugzilla.redhat.com/show_bug.cgi?id=1667025
2019-06-14 21:50:08 -04:00
524002da02
virt-xml: Abide domain name for --build-xml
...
https://bugzilla.redhat.com/show_bug.cgi?id=1648939
2019-06-14 21:37:50 -04:00
d61f9d9995
details: Check for mac conflict in customize wizard
...
https://bugzilla.redhat.com/show_bug.cgi?id=1660467
2019-06-14 21:11:37 -04:00
d40975c493
guest: Add back spice virtio-serial for windows
...
This was removed in v2.0.0, but we've had some complains since then
https://bugzilla.redhat.com/show_bug.cgi?id=1660123
2019-06-14 20:51:43 -04:00
c52e220504
devices: disk: Handle pool=iscsi-direct volumes
...
I don't have a working setup for this so I'm not positive
it actually works, but this roughly matches what I see in
libvirt test suite data and docs
https://bugzilla.redhat.com/show_bug.cgi?id=1658511
2019-06-14 20:35:41 -04:00
147a3b4790
preferences: Disable systray option if we know it won't work
...
Basically on wayland, if appindicator isn't available
https://bugzilla.redhat.com/show_bug.cgi?id=1666597
2019-06-14 20:05:09 -04:00
aabde5bbe6
domain: Remove pre-startup USB collision check
...
Libvirt nowadays will throw an explicit warning about this
exact situation. It doesn't guide people to virt-manager UI, but
then again it should be obscure enough that it doesn't warrant this
special corner case code to inform the user
2019-06-14 20:04:18 -04:00
b9981b4623
createpool: Drop disk and netfs pool source listing
...
Both of these are awkward to use and IMO not really useful.
2019-06-14 17:16:48 -04:00
ab7b3c189f
Move virtcli/cliconfig.py to virtinst/buildconfig.py
...
There's really no reason for the split, just contain it all
within virtinst for simplicity
2019-06-14 17:12:19 -04:00
0e5fb7d7c2
data: appstream: add keywords and translations link
2019-06-14 16:09:29 -04:00
ef972cf2ea
virtinst: support: add full code coverage testing
2019-06-14 14:00:13 -04:00
54a28485df
tests: Use assertRaises more
2019-06-14 13:04:56 -04:00
f6b87bd6d6
virt-xml: Remove virt_xml_setup hack
...
Not sure why this was originally required, but I can't think how
to even trigger this occasion nowadays
2019-06-14 12:38:51 -04:00
bd7d213cf8
virt-xml: Add more test coverage
2019-06-14 12:37:35 -04:00
fbe388b26a
virt-install: Warn if mem less than OS recommended
...
And if mem is abnormally low, like it appears user tried to specify
GiB not MiB
2019-06-14 11:24:10 -04:00
c37d6a7260
installer: Log warning when we set network-install resources
...
So the cli user will see it
2019-06-13 22:01:02 -04:00
34f42cc673
installer: Make test suite override paths a bit more descriptive
...
Have them incorporate the basename of the path we are replacing.
This gives some validation that we are manipulating the correct files
2019-06-13 21:53:41 -04:00
aafbca9e75
tests: Fix running on non-latest osinfo-db
2019-06-13 21:27:59 -04:00
17ac0d017c
virt-install: Drop --os-variant suboption parsing
...
Not sure I want to go down that route if we can avoid it. Instead
just fold the full_id support into the existing option handling.
Streamline the OSVariantData usage throughout the cli tools
2019-06-13 21:25:05 -04:00
21723706f5
virt-install: Add --install OSNAME
...
Replace the unreleased --os-variant OSNAME,install=location with just
--install OSNAME
Unwind the --unattended dependency on upfront --os-variant while
we are at it, since they are all intertwined. Now we can just do:
virt-install --install OSNAME
and
virt-install --install OSNAME --unattended
2019-06-13 20:26:26 -04:00
839eea3587
virt-install: Split build_installer out a bit
2019-06-13 18:46:58 -04:00
ee119c3bb2
guest: Add skip_default_osinfo
...
We set this to True in virt-install, which will cause an explicit
error to be thrown if some part of the cli parser tries to access
osinfo before it's been set, because then we have a circular dependency
between cli config -> installer -> osinfo -> cli config
2019-06-13 18:29:39 -04:00
d9729855ee
guest: break out disable_hyperv_for_uefi
...
Having this at set_uefi time complicates the domain XML building
machinery, where we don't want things to have osinfo access.
Rearrange it so that editing cases call this explicitly, and
the XML builder just deals with it at the set_defaults time
2019-06-13 17:55:37 -04:00
8c8fec6cb1
cli: Rename parse_option_strings update= to editing=
...
Makes it more clear what the distinction is. Set this in the parser
class so the cli infrastructure can access it
2019-06-13 17:37:26 -04:00
f36e8b36bc
virt-install: Rework install option detection a bit
...
Add an explicit no_install to Installer to encode that the user is
not expecting an install phase. Use that to determine later if any
install options were specified. This saves later code from having
to deal with installer=None, and is the basis for further clarifications
2019-06-13 16:36:21 -04:00
3b396e8321
virt-install: Split out --wait handling into a helper class
...
And add much more clitest coverage
2019-06-13 16:02:58 -04:00
8234b55fe8
tests: clitest: Fill in much more virt-install coverage
2019-06-13 16:02:52 -04:00
5077f97000
guest: Add a comment about the vcpu situation
2019-06-13 14:42:37 -04:00
7ef20e26b0
Revert "guest: Don't hardcode vcpus = 1"
...
This reverts commit 66fe00ddee
2019-06-13 14:40:06 -04:00
3cc42c2f24
virt-install: Drop install option collision errors
...
It's getting hard to track this correctly with the addition of
--install. Drop it. The important thing is validating when no install
options were specified
2019-06-13 14:13:29 -04:00
c5bbf2f48d
virt-install: Drop --transient and --noreboot rejection
...
It's a nonsensical request but it should be obscure enough to not
warrant explicit validation
2019-06-13 14:05:22 -04:00
1e8f2413d7
unattended: Move the windows method=cdrom logic into installer
...
And warn about it. This isn't triggerable at the moment due to
virt-install hackery but that will change
2019-06-13 14:00:04 -04:00
a9d33d49db
osdict: Add testing and finish of code coverage
2019-06-13 14:00:04 -04:00
19bcec651c
virt-install: Push validation down into the installer
...
It's hard to validate whether something like --extra-args or
--initrd-inject is supported based on the command line arguments. It's
easier to let the installer.py figure it out because it's the
authoritative source
2019-06-13 14:00:04 -04:00
9cbe5f9742
virt-install: Move --install kernel/initrd handling to installtreemedia
...
This essentially gives us kernel upload, http access, and initrd inject
for free, and ensures that the source file is kept in pristine shape
2019-06-13 14:00:04 -04:00
Cole Robinson