d6fbdf717d
virtManager: when present, prefer the user specified in capabilities
...
Prefer the user specified in the host capabilities to the default one
when checking for the access to disk images.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-11-18 09:05:22 +01:00
bd782d5757
snapshots: Another s/State/VM State/ change
2013-11-10 11:17:12 -05:00
8dcb65bd50
create: Fix default qemu-ga setup (bz 1016613)
...
We were adding default devices before setting the OS value, which qemu_ga
setup depends on.
2013-11-09 18:52:05 -05:00
eb33bd34e7
Misc improvements to some debug messages
2013-11-09 18:17:29 -05:00
bcfa8d287f
serialcon: Release the text console when the VM window is closed (bz 1016445)
2013-11-09 17:54:47 -05:00
5798c5b9b4
virt-manager: prefer os.makedirs to os.mkdir when creating cache dir
...
Ensure the parent directories exist when attempting to create the
cache directory.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1016435
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-11-05 18:15:11 +01:00
1ac755e7b2
details: Fix processor tab display for some LXC guests
...
With LXC domain, the 'current' attribute of 'vcpu' element is not
always present, but the code is still depending on it.
2013-10-29 11:24:52 +01:00
2b7aa33887
engine: Fix started libvirt daemon requirement
...
This patch makes virt-manager usable again without systemd (or dbus).
When started without systemd, but with libvirtd properly working,
there was error reported, and virt-manager didn't even try to connect
to the destination.
This patch modifies the behavior in two ways. When connection is
added with "do_start=False" it will still try to connect, but won't
error out when unsuccessful. The second modification is that upon
startup, the idle_connect() function will error out only if we failed
starting libvirtd _and_ we couldn't connect to the uri. So if we
failed starting libvirtd, but could connect, there is no disruption
for the user.
2013-10-29 11:24:52 +01:00
408771004f
virt-manager: show correctly EGD RNG devices information
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:41:19 +01:00
a7519dc1e9
virt-manager: fix adding EGD RNG devices in UDP mode
...
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1001773
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:41:14 +01:00
0df75c7603
headers: update "Red Hat, Inc." copyright for the year 2013
...
Ensure that any file touched by a @redhat.com author in 2013 has an
updated copyright header.
The files were updated using the build-aux/update-copyright gnulib
script and manually added where the copyright line wasn't present.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:22:26 +01:00
2301f19e4b
asyncjob: Fix simple error callback
2013-10-09 17:41:08 -04:00
cea22b17d7
storagebrowse: Fix signal cleanup after multiple runs
2013-10-08 10:23:15 -04:00
a991c21d08
details: Fix reporting current VM cpus
2013-10-07 18:12:12 -04:00
79196cdfcf
console: Fix console_active() logic
2013-10-06 15:30:01 -04:00
3f532fe263
VirtualDisk: Handle the blktap default
...
And cache the blktap lookup once for the localhost
2013-10-06 13:17:35 -04:00
ef878a5d49
addhw: Fix a few issues with char dev combinations
2013-10-06 13:04:21 -04:00
102417ca0c
addhw: Make sure to set device defaults
2013-10-06 13:00:30 -04:00
56b9f6187b
Streamline support checks
...
Just use one function check_support
2013-10-06 10:08:04 -04:00
18fa751059
Add qemu-guest-agent channel automatically for supported OS
2013-10-06 09:19:59 -04:00
dae3678d26
guest: Absorb more default device checks
2013-10-06 08:30:33 -04:00
fdb79b9832
snapshots: Add a right click menu for start/stop
2013-10-05 14:57:58 -04:00
111f4353a3
snapshots: new: Grab name focus, make activate create the snapshot
2013-10-05 14:47:10 -04:00
89646fe841
addhw: Filter root hubs out of USB device list
2013-10-05 14:40:38 -04:00
c5b5df8db2
storagebrowse: Select default pool on first run
2013-10-05 14:15:11 -04:00
ff73f1119e
details: If we know the channel target name, pretty list it
2013-10-05 14:04:49 -04:00
34f23165b6
addhw: Add channel option for auto socket allocation
2013-10-05 13:54:28 -04:00
5f1187e4c3
addhw: Don't show target_type for every char device
2013-10-05 13:33:55 -04:00
9d21d2bb02
addhw: List known channel names in a comboboxentry
2013-10-05 13:27:11 -04:00
24137cdfe9
addhw: Add 'console' option for adding virtio consoles
2013-10-05 13:22:53 -04:00
8e460dce1d
create: Hide arch expander if there aren't any connections
2013-10-05 10:31:02 -04:00
ca5e849ec6
create: Reset distro detection labels after each run
2013-10-05 10:29:16 -04:00
97f5717ef7
snapshots: Fix showing async dialogs for revert/delete
2013-10-05 10:03:56 -04:00
e7e97a8088
domain: If title present, print only it
...
Forcing the name to be in the picture reduces the usefulness IMO
2013-10-04 11:50:19 -04:00
c005cc84d6
virt-manager: Future-proof disk 'removable' check box
...
Currently only QEMU is supported so we only show the check box when
it's used. The future-proofing is that we'll show it for an explicitly
set non-default value, even for hypervisors we don't think support it.
2013-10-04 08:17:25 -04:00
c45e1ef6b8
virt-manager: Add checkbox controlling disk 'removable' flag
...
(crobinso: Fix to use grid rework)
2013-10-04 08:08:44 -04:00
d83b2c02fa
virt-manager: Add USB3 convenience option to the controller UI
...
and a --controller usb3 option to virt-install
2013-10-03 16:34:28 -04:00
db6ef91b0b
console: spice: don't set port=None
...
Can happen if defaultMode=secure, only a tlsport is allocated
2013-10-03 15:54:15 -04:00
27298c8a80
addhw: Fix disk naming from 'customize' dialog (bz 744137)
2013-10-02 19:58:21 -04:00
2954995a28
domain: Fix deleting VM in test driver
2013-10-02 19:57:50 -04:00
18d8512699
Move the 'default graphics type' logic into Guest
...
So we can share it, and make virt-install more robust
2013-10-02 18:06:52 -04:00
2218a03154
details: Rip out 'would you like to add/remove spicevmc' bit
...
This was originally there for when we weren't defaulting to spice.
We basically do that now, so people shouldn't have much need to
switch spice on/off for an existing guest. Plus if we wanted to
be far about it we would want to add/remove qxl as well but there
it's just getting rediculous.
2013-10-02 18:04:56 -04:00
a2cbb9f500
support: s/CONN_HV/CONN/g
...
We don't need to distinguish these days.
2013-10-02 16:41:23 -04:00
9c57c72eac
Default to adding USB2 for new enough KVM
...
We enable this for virt-install as well. To avoid it, you can do either
--controller usb,model=none or --controller usb
2013-10-02 15:54:35 -04:00
9194feb1f5
virt-manager: Default to qcow2 on kvm
...
qcow2 enables fancy features like snapshots and is generally more
desktopy, which we purport to be.
We only do this on not horribly old libvirt/qemu, and only on qemu
connections. This may work for xen but I'm not going to turn it on
until someone tests it.
2013-10-02 15:34:34 -04:00
1294965aa3
config: Move all the cliconfig data passing into vmmConfig
...
Setting it in virt-manager is pretty redundant
2013-10-02 14:53:41 -04:00
7cb84f5ba5
preferences: Explicitly list system default
2013-10-02 14:47:21 -04:00
7b264eac74
create: Don't add graphics for arm
2013-10-02 13:30:18 -04:00
83b6dc7ea4
create: Incorporate non-default arch into default guest name
2013-10-02 13:23:49 -04:00
fc2cef8eb2
create: Sort arch and mach lists, put supports variants at the top
2013-10-02 13:23:49 -04:00
7c7f3ad0b2
create: Fix some spacing issues
2013-10-02 12:35:59 -04:00
d6f96f72d5
create: Add kernel/initrd install option for arm
...
Basically just show kernel/initrd options for the 'import' install
method on non-x86.
2013-10-02 12:35:59 -04:00
89ba152f00
Fix a problem in the create window
...
This error is fixed:
Traceback (most recent call last):
File "src/virt-manager/virtManager/create.py", line 335, in reset_state
self.set_conn(activeconn, force_validate=True)
File "src/virt-manager/virtManager/create.py", line 201, in set_conn
self.set_conn_state()
File "src/virt-manager/virtManager/create.py", line 594, in set_conn_state
self.conn.netdev_error, True)
File "src/virt-manager/virtManager/create.py", line 611, in set_net_warn
net_warn_icon.set_visible(show_warn)
File "/usr/lib/python2.7/site-packages/gi/types.py", line 113, in function
return info.invoke(*args, **kwargs)
TypeError: Argument 1 does not allow None as a value
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-02 15:39:16 +02:00
910c3a93ad
domain: Fix 'customize install' after snapshot changes
2013-10-02 07:42:24 -04:00
71350543d1
create: Desensitive irrelevant install options if arch changes
2013-10-02 07:35:02 -04:00
c18c94d157
create: A couple mini layout tweaks
2013-10-01 17:55:27 -04:00
42389214af
create: Add 'machine' option for non-x86 arch
2013-10-01 17:40:44 -04:00
0697e5f349
create: More arch/type handling
...
Hide the 'type' field on non-xen: we shouldn't need to expose
kvm vs. qemu in the UI, just assume if kvm is available we use it.
Hide arch if there's only one available. And hide the whole expander
if we hid both sub fields.
2013-10-01 17:27:58 -04:00
67c62e68de
create: Move name to last page, arch/type to first page
...
Moving name to the end allows us to do things like generate a default
name based on the chosen OS type, which we do here. This is bz 736951
Moving arch/type to the front page of the wizard simplifies validation
and will be needed to intuitively install arm guests without a bunch
of hacky workarounds.
2013-10-01 16:53:59 -04:00
7009bd2560
createvol: Bunch of misc improvements
...
- Hide backing store for formats that don't support it
- Hide allocation for qcow2 since it doesn't do anything
- Automatically select the storage format as specified in prefs
2013-10-01 14:50:47 -04:00
bdaa0e511a
Log object name with XML diff on redefine
2013-10-01 10:21:44 -04:00
868fbd9fc9
snapshots: Add screenshot support
...
Show a screenshot in the 'new snapshot' wizard. If we successfully create
that snapshot, save the screenshot in
~/.cache/virt-manager/$connuri/$vmuuid/snap-screenshot-$snapname.$ext
And show it in the snapshot details overview. We don't do any reaping
on snapshot delete, vm delete, etc, but that could be added later.
2013-10-01 10:14:51 -04:00
d44f863c2d
details: Disable snapshot buttons if conn or guest doesn't have support
2013-09-30 20:33:42 -04:00
023953d4ac
addhw: Fix cache default again :/
2013-09-30 20:00:40 -04:00
8f1ea67cad
Don't lose current selection if redefining net/pool/iface/snapshot
2013-09-30 19:55:21 -04:00
707a00c950
storagepool: Fix rename
2013-09-30 19:55:21 -04:00
6043a88a0c
snapshots: Add some specific UI for external snapshots
...
We sort them separately in the snapshot list, explicitly mention that
they are 'external', and add a UI field listing the memory/disk
details.
In general mixing internal and external snapshots is a recipe for
confusion and disaster, so I think the best thing to do is at least
acknowledge their presence in the UI but not make any attempt to
predict what will or will not work.
2013-09-30 19:55:21 -04:00
6f469d7947
snapshots: List VM status in 'new snapshot' window
2013-09-30 17:40:01 -04:00
e72944d171
snapshots: Make the list entries a bit prettier
2013-09-30 17:36:38 -04:00
45e84d46ec
snapshots: Make state type/icon UI match other usage
2013-09-30 17:12:24 -04:00
3629dabeb0
snapshots: new: Add default and escape action
2013-09-30 16:37:46 -04:00
b3e2d26337
snapshots: new: Automatically generate a snapshot name
2013-09-30 16:33:45 -04:00
34c502560f
storage: Drop unused static function
...
This allows us to simplify the parameters for find_free_name
2013-09-30 16:22:12 -04:00
01577d3d88
snapshots: Desensitize 'finish' if no name entered
2013-09-30 16:22:12 -04:00
36837fd3af
snapshots: Drop reporting of 'current' snapshot
...
It's a useless distinction in our UI
2013-09-30 16:22:12 -04:00
85ec41c3c9
snapshots: Fix initial UI state when guest has no snapshots
2013-09-30 15:52:37 -04:00
b1d3987aaa
domain: Fix deleting a VM that has snapshots (bz 821518)
2013-09-30 15:38:35 -04:00
844a567e7b
details: Don't silently drop managed save when renaming VM
...
Instead just error about it. Until there's an actual libvirt 'rename'
API we can't do much better than that.
2013-09-30 15:38:35 -04:00
98a95b2e2d
network: Add install() command, remove function from vmmConnection
...
This is the pattern used by other virtinst objects
2013-09-30 15:38:34 -04:00
b9bcc84d35
libvirtobject: Remove no longer needed sanitize_xml helper
2013-09-30 15:38:34 -04:00
2b74c46909
snapshots: Pretty up the 'new snapshot' dialog
2013-09-30 15:38:12 -04:00
ccb96e9e4a
VirtualDisk: Add cache modes 'directsync' and 'unsafe' (bz 844907)
2013-09-30 14:30:50 -04:00
9de21be907
virt-manager: Drop --experimental-snapshot-ui
...
We are just sticking with internal snapshots only
2013-09-30 14:30:50 -04:00
8f0bfb1ad6
host: Allow renaming a storage pool
2013-09-29 12:28:01 -04:00
369a17160a
host: Allow renaming virtual networks
2013-09-29 12:14:00 -04:00
74e8fff069
clone: Fix a few misc issues
2013-09-29 11:31:03 -04:00
b6adf48e56
createvol: Add UI for specifying backing store
2013-09-29 10:53:37 -04:00
cd7837bc4b
domain: Clean up some support checks
...
We don't need to cache things since virtinst/connection does it for
us.
2013-09-29 09:58:31 -04:00
52e4976462
pollhelpers: Add fetch_volumes helper
...
That does the listAllVolumes support check to speed us up a bit.
2013-09-29 09:33:17 -04:00
a9a085340b
support: Rename SUPPORT_STORAGE to SUPPORT_POOL
...
It's more accurate. And fix up comments about back compat which no
longer apply.
2013-09-29 09:21:42 -04:00
72058f2bbf
support: Remove unused nodedev support checks
2013-09-29 09:19:56 -04:00
7a5dc7c544
devicedisk: path_in_use_by: Check backing stores as well
...
Plumb through a fetch_all_vols helper for this, and do all the
caching bits.
2013-09-28 21:07:18 -04:00
375790075d
details: Drop combo_or_label paradigm, use combobox entries
...
So we can handle unknown XML values and give users more flexibility
for things we can't predict.
2013-09-28 14:25:37 -04:00
40a9e61ba2
details: Fix looking up nodedev mapping for usb devices
2013-09-27 18:40:00 -04:00
fd00ad74e2
devicehostdev: Drop device creation helper
...
Goes against other device paradigms, and is cleaner when we unwind it.
2013-09-27 18:28:28 -04:00
1212cf43a9
DomainFeatures: Drop __getitem__ helpers
...
They just complicate matters
2013-09-27 15:08:44 -04:00
927c596daa
Fix host/details graphs to not over expand
2013-09-27 14:17:57 -04:00
090bc60ade
error: Drop padding with checkboxes, looks weird
2013-09-27 13:43:43 -04:00
fa47586b37
createnet: Use blue header like other wizards
2013-09-27 13:36:22 -04:00
419b2d0ca6
createvol: Hide format UI if no formats supported
2013-09-27 13:20:45 -04:00
Giuseppe Scrivano