Commit Graph

3463 Commits

Author SHA1 Message Date
Cole Robinson 7f66926721 Fix first time remote URL installs from virt-manager (bz 1049852)
On first run, the remote URL install handling creates a storage pool
for /var/lib/libvirt/boot on the remote host. After this, it clears
the VirtualConnection's object cache, so the next time all pools are
fetched, it returns an accurate list.

However that clear_cache call wasn't propagated up to virt-manager's
cache. Add a new cb to fix it.
2014-01-18 14:57:39 -05:00
Cole Robinson a82b60dcff capabilities: Remove some public API back compat 2014-01-18 13:23:30 -05:00
Cole Robinson 178805e265 asyncjob: Constrain size of text label 2014-01-18 13:23:05 -05:00
Cole Robinson dcd67be2db osdict: Use virtio console and qemu ga for RHEL7 2014-01-18 13:06:09 -05:00
Cole Robinson 073b3a69e3 urlfetcher: Use inst.repo kernel option for new RH distros (bz 1026841) 2014-01-18 13:04:47 -05:00
Cole Robinson 962994f72f osdict: RHEL7 has a public beta, so it's 'supported' now 2014-01-18 10:35:55 -05:00
Cole Robinson 077eac8c1d createinterface: Fix creating bridge with unconfigured interface (bz 1048351) 2014-01-17 20:25:08 -05:00
Cole Robinson 62cfac18dc host: Fix looking up interfaces on repopulate signal 2014-01-17 20:23:29 -05:00
Cole Robinson e151146cad cloner: Don't validate new clone name (bz 1054771)
Our validation check might not be up to date, WRT what characters are
acceptable. So if we try to --auto-clone an existing valid VM with
some characters we aren't expecting, we cause ourselves to error.

Just skip the validation and let libvirt complain if something is wrong.
2014-01-17 18:44:26 -05:00
Cole Robinson d040bf3573 Drop the len <= 50 validation check for domain names
Just let libvirt error out, since we have no idea if this is still
relevant.
2014-01-17 18:42:15 -05:00
Cole Robinson 958dea6c5f createnet: Use typical name validation pattern 2014-01-17 18:40:30 -05:00
Cole Robinson 594e26d772 Change the kvm default cpu to 'nearest host cpu model'
This makes new x86 kvm guests use the host's CPU model as reported by
libvirt capabilities output. This is a reasonable compromise for now
to increase performance while we wait for libvirt/qemu to fix host-model.
2014-01-17 17:41:26 -05:00
Cole Robinson 7003a3a528 prefs: Allow changing the default VM CPU mode/model config
Add a preference for changing the default CPU mode/model. The options are:

- default (whatever virt-manager chooses as the default)
- hypervisor default (no <cpu> block, what we've always done)
- nearest host cpu model (just the 'model' from caps->host->cpu)
- copy host cpu (the entire <cpu> block from caps->host)

The setting only applies to KVM guests, not tested with anything else.
The default is left as is for now (hypervisor default).

copy host CPU will one day use mode='host-model', when it does what
we want. At that point we will probably make it the default
2014-01-17 17:41:26 -05:00
Cole Robinson b215b27854 prefs: Modernize glade file
tables->grids
clean up some legacy spacing
make a new 'new vm' tab which will expand shortly
2014-01-17 15:30:10 -05:00
Cole Robinson 849141552d details: Fix stdout spew on hw_update error
Not sure what caused this, but its easy enough to avoid
2014-01-17 14:22:49 -05:00
Giuseppe Scrivano 770b173337 doc: state correctly the number of possible values for --network=
95170e8892 added --network=direct
without updating the number of possible values for --network in the
man page.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-01-15 15:55:10 +01:00
Cole Robinson 6d2f937c99 virt-install: --host-device: add driver_name option 2014-01-14 18:09:21 -05:00
Cole Robinson b57a2094ff Probe entire backing chain when checking if path is in use 2014-01-14 17:44:14 -05:00
Cole Robinson 330bcd9c8b delete: Track kernel/initrd/dtb as well 2014-01-14 17:26:29 -05:00
Cole Robinson 79ce0dcdc5 details: Fix changing media for two different cdroms
We weren't updating the target device of the choosecd dialog, so only
the first targetted device was ever updated.
2014-01-14 17:18:02 -05:00
Cole Robinson 66096a7eeb choosecd: Check path-in-use collision (bz 1028197) 2014-01-14 17:11:51 -05:00
Cole Robinson 765b1ed7d6 Track kernel/initrd/dtb in 'path in use by' UI 2014-01-14 16:57:32 -05:00
Cole Robinson 6dd41e6944 create: Disable 'fully allocate' if qcow2 is the default
Since it doesn't support full allocation
2014-01-14 16:03:58 -05:00
Chen Hanxiao 2bee4a128d panic notifier: display default value if not set
If we didn't set values for @type and @iobase in
XML, libvirt will use the default value.
Currently, virt-manager will display "-" if we don't
set any values.
This patch will use default value for display.
And update test case to cover this scenario.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-14 09:58:09 -05:00
Cole Robinson 6db30432a5 domain: Use support infra to check if memory stats supported 2014-01-12 17:53:53 -05:00
Cole Robinson 55d6b7f377 prefs: Allow disabling all memorystats polling
Similar to how we allow disabling disk/net polling, not sure yet what
effect it might have on remote connections, so best to add this option
just to be safe.

Unlike disk/net stats, we enable this checking by default.
2014-01-12 17:39:21 -05:00
Cole Robinson 2dffdff328 addhw: disk: Split bus and device into two combo boxes
Prior to this we had them in the same combo box, which had grown quite
large.
2014-01-12 16:52:26 -05:00
Cole Robinson 44bad869ae addhw: Stick disk format and cache under 'advanced options' 2014-01-12 16:09:14 -05:00
Cole Robinson bd111d411c addhw: Only allow panic device if libvirt supports it 2014-01-12 15:16:06 -05:00
Cole Robinson f02b85d913 guest: Don't add qemu-ga on ARM where virtio slots are limited 2014-01-12 14:58:43 -05:00
Cole Robinson 52bb0f6067 nodedev: Include PCI vendor in pretty name
Pretty important if trying to distinguish between devices
2014-01-12 14:52:33 -05:00
Cole Robinson cad64c0dc1 nodedev: Remove subdev for pretty_name, it's pointless 2014-01-12 14:52:15 -05:00
Cole Robinson dd57f2f221 create: Don't reset method choice when arch changes if it's still valid 2014-01-12 14:41:25 -05:00
Cole Robinson d12c986b98 Use BUTTON size for all status icons 2014-01-12 14:36:03 -05:00
Cole Robinson 0b8ba7760e details: Fix status icon shrinking on state change.
No idea why this is happening or what is causing it, but
forcing the icon width fixes things...
2014-01-12 14:35:35 -05:00
Cole Robinson a70077172e urlfetcher: Don't mandate boot.iso in treeinfo for Generic distro
Hit this if doing --location /path/to/mounted/RHS.iso

https://bugzilla.redhat.com/show_bug.cgi?id=1039456
2014-01-11 16:24:13 -05:00
Cole Robinson d38d019aeb distroinstaller: Make each media type explicit 2014-01-11 16:10:38 -05:00
Cole Robinson 02d07996b0 addhw: Fix a pep8 error 2014-01-11 16:08:42 -05:00
Cole Robinson 0c80c69918 installer: Drop needless property redirection 2014-01-11 15:28:21 -05:00
Cole Robinson f055b07a61 details: Couple mini 'panic' UI cleanups 2014-01-11 15:08:00 -05:00
Chen Hanxiao c7a374b51d virt-manager: add support for adding panic notifier device
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-11 14:53:20 -05:00
Chen Hanxiao a90a375bda virt-manager: add support for showing panic notifier device
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-11 14:53:19 -05:00
Chen Hanxiao 8419835b1d virtinst: add support for panic notifier device
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-11 14:32:18 -05:00
Chen Hanxiao 2427254ffe set cov as None if python-coverage not installed
If we didn't install python-coverage, we could not
run 'python setup.py test'.
This patch fixes this little bug.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-11 13:24:38 -05:00
Martin Kletzander 7906b1cc41 Fix toolbar toggling in details window
When refreshing the details window after it has been already
initialized, we don't change the value of the View->Toolbar item in
the menus on which then the toggle_toolbar() depends and due to the
menu keeping the old value, the toolbar might (not) be shown even if
it should not (or should) be.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1049145
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-01-11 13:20:48 -05:00
Chen Hanxiao 644f92a60f docs: fix a typo in virt-install man page
s/hardisk/harddisk

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-11 13:20:48 -05:00
Cole Robinson 95170e8892 virt-install: Support --network source, source_mode, target
The latter two bits are needed for macvtap configuration.
2014-01-06 15:17:32 -05:00
Thorsten Behrens b5da599aef Base mem statistics on virDomainMemoryStats if available.
Attempt to query domain memory stats via virDomainMemoryStats.

(crobinso: remove the broken fallback, since it's confusing)
2014-01-06 12:08:55 -05:00
Thorsten Behrens 77b1143965 Add memory stats widget also to manager tree view.
(crobinso: Fix an initialization issue)
2014-01-06 12:08:55 -05:00
Giuseppe Scrivano 0724f1cdaa virt-manager: use DISPLAY in the error message only when it is set
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1038496
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-01-03 10:02:18 +01:00