openkylin
/
virt-manager
mirror of https://gitee.com/openkylin/virt-manager.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity
7,534 Commits 7 Branches 6 Tags 91 MiB
Commit Graph

7534 Commits

Author SHA1 Message Date
Cole Robinson d140596ce9 uitests: try to make flakey createvm test more robust 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson 1684049fa3 virtManager: Misc coverage annotations 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson dc41f61e5e uitests: Add combo selection helpers and use them 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson c405dd2741 setup: Add --tb=native to pytest options 
I find it much easier to read

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson 3f59d9de84 uitests: More usage of storagebrowser helper 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson 73b61ffbc9 uitests: Use our loop check() helper for all asserts 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson 627fa2f611 addhardware: Simplify input_pretty_name 
Drop the 'Generic' prefix for all strings which isn't particularly
meaningful.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 147f918ffd addhardware: Use dictionary pattern for pretty labels 
It's shorter and saves us the pain of adding coverage
for every option

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson ab92693a56 uitests: finish preferences.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson b1ddc6344a uitests: make test_createvm.py asserts more robust 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson fd5216c184 uitests: Finish createconn.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 35d4687237 uitests: Rename test_newvm.py to test_createvm.py 
To mirror the code name

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson bb1180fb40 Move virtmanager test cli handling to testmock.py 
We will be adding more stuff here, so let's move it out
of the main virt-manager script

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 5ccbcb898f uitests: Finish netlist.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson ea49c1d932 netlist: Rework the 'no network' case 
Always force a network selection. If we have to fall back to
manual bridge UI because nothing else exists, show a warning.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 0283f26ace uitests: test createvm.py with an inactive default network 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 153dcba126 uitests: test createvm.py with an empty connection 
Fix the 'No networking' createvm case that it shows was broken

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 7fef49e99f uitests: Test createvm.py with a fake session URI 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 463c42773c createvm: Drop explicit warning about no net + URL install 
This case should be exceedingly rare, and we already show
a visual warning about 'no network'. So let's drop this

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson aab71cc4d0 tests: Move all testdriver XML to the same dir 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson bc32852e17 connection: Remove unused 'vm-renamed' signal 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson f15cdd732d graphics: Remove spice GL/rendernode version support warnings 
The versions we are warning about are all over 4 years old, and
these warnings were initially just informative to help users know
when the config wasn't going to work. Drop most of it. Still warn
in the UI when a VM misconfig will prevent spice GL from working

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson c2dbdbfab1 uitests: Finish snapshot.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 5ecacfdfed uitests: Finish error.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 4b4f2ddba3 uitests: Finish addstorage.py coverage 
We need to wire up some craziness to make path permission
searching fail, but this is a critical area to get correct
so it is worth it

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 95bf8bf6b9 uitests: Cover more createvm validation checks 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson e3be4b677e error: Remove some dead code 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 2f4aa652d3 error: Try not to split val_err over multiple lines 
Helps grepping for val_err usage, and grepping for error strings

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson be2b308ae4 createvm: Break out _validate_oscontainer_bootstrap 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson d111df4e62 uitests: Finish uiutil.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson fea7f3e262 uitests: Finish storagebrowser.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 57f916461f uitests: Finish fsdetails.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 7bfe8139c0 uitests: Add module_trace.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 28f57cbf2f uitests: Finish oslist.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson fe323be0ad uitests: Finish mediacombo.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 5c10f4e394 storagebrowse: Fix set_browse_reason 
We can't call this at init time, we need to do UI changes on demand

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson c323ecfd55 fsdetails: Rework xml builder APIs 
Don't have the caller call a validate function, they all catch
errors anyways. Let the build step raise error if there's a problem

Drop some validation checks that libvirt should be performing for us

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 4c439cda21 uitests: Add vsockdetails full coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson bc9d6cf6d5 Drop some explicit openvz handling 
I don't think many, if any, people are using virt-manager with
openvz. Drop the specific handling the filesystem UI, users can use
the raw XML editor if they need special behavior

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 7a63fb95ec object: Finish off non-domain code coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 9d34d1da0b libvirtobject: Centralize most tick() implementations 
Basically all non-domain objects just need to check to see
if status changed, which will also refresh the XML if
a change occurs. This all works to ensure we are initializing
XML at tick time

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson f22e060190 Always assume objects support .isActive() 
All drivers that support the listAll APIs, which we depend on,
also are new enough to support isActive, so stop checking support

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 9a9eb165ed uitests: Add host*.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 6f8c305d62 tests: uitests: Add createvol.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 0babd6b27f createnet: Add full uitest coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 886339e8dd virtManager: add coverage annotations and remove dead code 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 27d1b4d4bd uitests: Make test_mediachange more resilient 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 7342d9a11b uitests: Add _click_alert_button helper 
Centralizes a pattern we were using all over the place

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 8f4341bee8 host: Move xmleditor init earlier 
It can be triggered via callbacks which may fire early,
so initialize it first

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson 543ddba9f2 hoststorage: Fix some UI issues with initial offline conn 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00