2f12823cb5
snapshots: Maintain selection after refresh
2018-01-18 16:55:57 -05:00
75210ed37c
Replace StringIO with io.(StringIO or BytesIO)
...
StringIO and cStringIO modules no longer exists in Python 3. [1]
Use either io.StringIO [2] for text or io.BytesIO [3] for bytes.
[1] http://docs.python.org/3.0/whatsnew/3.0.html
[2] https://docs.python.org/3/library/io.html#text-i-o
[3] https://docs.python.org/3/library/io.html#binary-i-o
2017-10-20 13:18:31 -04:00
04e35b2d85
pycodestyle: fix all E124 warnings
...
Fix all E124:
Closing bracket does not match visual indentation
Also remove ignore options of E124
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2017-09-09 23:21:42 +08:00
c92aade081
pycodestyle: fix all E203 warnings
...
Fix all E203 whitespace before ':'
Also remove E203 ignore option of pycodestyle
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2017-08-11 00:01:38 +08:00
b93cc3bbc9
pycodestyle: Do not use bare 'except:'
...
A bare 'except:' catches all exceptions [1], including SystemExit,
KeyboardInterrupt, and GeneratorExit (which is not an error and should
not normally be caught by user code). In situations where you need to
catch all “normal” errors, you can catch the base class for all normal
exceptions, Exception [2].
[1] https://docs.python.org/2/howto/doanddont.html#except
[2] https://docs.python.org/2/library/exceptions.html#Exception
2017-08-02 13:57:43 -04:00
a51929fcd3
snapshots: Handle XML chars in snapshot name (bz 1468912)
...
https://bugzilla.redhat.com/show_bug.cgi?id=1468912
2017-07-10 17:51:04 -04:00
f551d7e55d
Replace file() usage with open()
...
Same semantics, but the latter is needed for python3
2017-05-05 14:53:12 -04:00
62feeb02a8
Switch to python3 style 'except X as Y' notation
...
Which also works with python2.7
2017-05-05 14:52:11 -04:00
c0a3234633
baseclass: share wizard cursor setting code
2017-04-27 15:00:17 -04:00
911dac0dfa
snapshot: start snapshot when double-click the item of snapshot list
...
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2016-08-02 13:20:15 -04:00
3aa941571a
uiutil: Drop check for old pygobject row handling
...
Once upon a time it couldn't handle setting a row value to None,
but we've bumped the dep now
2016-05-17 17:49:56 -04:00
f4dfb6de9d
Fix recent pylint/pep8 output
2016-04-18 16:42:12 -04:00
0fbe8e7a1f
translation: fix wrong usage of _() function
...
All the strings have to be at first translated and then we can fill the
formated and translated string.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-06-05 16:33:51 -04:00
42648f45f0
libvirtobject: Clean up XML invalidation
...
Make sure we aren't invalidating things when we are using events. Don't
overload APIs so much.
2015-04-10 17:50:06 -04:00
226c4562d5
virtManager: Switch to relative imports
2014-09-12 16:28:38 -04:00
de8e39ba53
snapshots: alert users for unapplied changes
...
The UI works slightly different than with other "unapplied changes"
alerts, as it changes anyway to the selected snapshot, no matter what
the user chooses.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-08-01 09:30:21 +02:00
f5b29c0416
snapshots: allow deleting multiple snapshots
...
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1124818
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-08-01 09:30:21 +02:00
724c6499f0
snapshots: add button to force snapshots list refresh
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-08-01 09:30:21 +02:00
2272166844
snapshots: Fix screenshot with qxl+spice (bz 1089780)
2014-04-29 13:26:26 -04:00
a398d245cb
Clean up pylint integration
...
- Drop no longer needed disable= bits
- Use string names for all skipped pylint messages
2014-04-02 19:00:24 -04:00
9d743ab4c8
snapshots: Tweak warning before run
...
Make it clear that VM configuration changes will also be dropped if
reverting to a snapshot while the VM is offline.
Suggested-by: Jorge Fábregas <jorge.fabregas@gmail.com>
2014-03-26 08:54:10 -04:00
99eaf059ae
Fix deprecation warnings on F21/rawhide
2014-02-25 15:57:38 -05:00
e4711061c4
snapshots: Make sure 'current' icon is always visible (bz 1065074)
2014-02-14 10:20:37 -05:00
09390b8151
snapshots: Show indication of the 'current' snapshot (bz 1017385)
2014-02-01 11:25:35 -05:00
889ec18031
uiutil: Use list selection helpers everywhere
2014-01-27 10:46:14 -05:00
708a2737cf
Split uihelpers into sharedui and uiutil
...
Reserve uiutil for the little gtk helper functions, rest goes into shared
UI (which all should probably be factored into their own files but thats
a task for another day)
2014-01-26 18:15:50 -05:00
58d5e0b799
uihelpers: Move a few more functions closer to their callers
2014-01-26 17:51:15 -05:00
d12c986b98
Use BUTTON size for all status icons
2014-01-12 14:36:03 -05:00
bd782d5757
snapshots: Another s/State/VM State/ change
2013-11-10 11:17:12 -05:00
fdb79b9832
snapshots: Add a right click menu for start/stop
2013-10-05 14:57:58 -04:00
111f4353a3
snapshots: new: Grab name focus, make activate create the snapshot
2013-10-05 14:47:10 -04:00
97f5717ef7
snapshots: Fix showing async dialogs for revert/delete
2013-10-05 10:03:56 -04:00
bdaa0e511a
Log object name with XML diff on redefine
2013-10-01 10:21:44 -04:00
868fbd9fc9
snapshots: Add screenshot support
...
Show a screenshot in the 'new snapshot' wizard. If we successfully create
that snapshot, save the screenshot in
~/.cache/virt-manager/$connuri/$vmuuid/snap-screenshot-$snapname.$ext
And show it in the snapshot details overview. We don't do any reaping
on snapshot delete, vm delete, etc, but that could be added later.
2013-10-01 10:14:51 -04:00
d44f863c2d
details: Disable snapshot buttons if conn or guest doesn't have support
2013-09-30 20:33:42 -04:00
8f1ea67cad
Don't lose current selection if redefining net/pool/iface/snapshot
2013-09-30 19:55:21 -04:00
6043a88a0c
snapshots: Add some specific UI for external snapshots
...
We sort them separately in the snapshot list, explicitly mention that
they are 'external', and add a UI field listing the memory/disk
details.
In general mixing internal and external snapshots is a recipe for
confusion and disaster, so I think the best thing to do is at least
acknowledge their presence in the UI but not make any attempt to
predict what will or will not work.
2013-09-30 19:55:21 -04:00
6f469d7947
snapshots: List VM status in 'new snapshot' window
2013-09-30 17:40:01 -04:00
e72944d171
snapshots: Make the list entries a bit prettier
2013-09-30 17:36:38 -04:00
45e84d46ec
snapshots: Make state type/icon UI match other usage
2013-09-30 17:12:24 -04:00
3629dabeb0
snapshots: new: Add default and escape action
2013-09-30 16:37:46 -04:00
b3e2d26337
snapshots: new: Automatically generate a snapshot name
2013-09-30 16:33:45 -04:00
01577d3d88
snapshots: Desensitize 'finish' if no name entered
2013-09-30 16:22:12 -04:00
36837fd3af
snapshots: Drop reporting of 'current' snapshot
...
It's a useless distinction in our UI
2013-09-30 16:22:12 -04:00
85ec41c3c9
snapshots: Fix initial UI state when guest has no snapshots
2013-09-30 15:52:37 -04:00
b9bcc84d35
libvirtobject: Remove no longer needed sanitize_xml helper
2013-09-30 15:38:34 -04:00
2b74c46909
snapshots: Pretty up the 'new snapshot' dialog
2013-09-30 15:38:12 -04:00
a7b1414dc5
libvirtobject: Make parseclass non-optional
...
All libvirtobject child classes have an associated XMLBuilder now, so
make it mandatory.
2013-09-23 08:34:50 -04:00
6da801f944
Set list selection signals in glade, not code
2013-09-22 16:29:58 -04:00
d338bce329
Rename ui files to match source file names
2013-09-22 16:10:16 -04:00
Cole Robinson