cd07d6af34
sound: Track recommended models in virtinst
...
Change addhardware to show an editable model entry, like the
details wizard
2018-09-06 13:28:21 -04:00
84a68d56de
addhardware: Don't disable filesystem on rhel
...
It might be compiled out, but just let qemu reporting fail. The
proper way to fix this expose it in domain capabilities or similar
2018-09-06 13:28:21 -04:00
da00a52159
storagebrowser: Remove stable_defaults handling
...
It simply makes vmdk disk images not selectable. I don't even know
if that's relevant for RHEL7+ anymore, but if it is, maintaining
code for disabling this in the UI doesn't make the situation any
better IMO
2018-09-06 13:28:21 -04:00
2b7043cd85
createpool: Fix showing formats
...
But shrink the format list to 'auto' only, but also add a text entry
so users can type their own
2018-09-06 13:28:21 -04:00
c5033c02d5
fsdetails: Use combo entry for format list
...
And stop listing all the crazy qemu formats
2018-09-06 13:28:21 -04:00
f13d10590d
createvol: Only show raw+qcow2 as file formats
...
And turn the combo into a text entry, so users can enter their
own if they want. raw and qcow2 covers the vast majority of usecases
2018-09-06 13:28:21 -04:00
f499bc9638
details: Use browse mode for hw-list
...
Meaning a row can never be unselected. Drop some redundant code
afterwards
2018-09-05 19:37:55 -04:00
a4d0d49d88
details: Centralize device row lookup
2018-09-05 19:20:23 -04:00
b4b7c7b520
details: IP address fixes/improvements
...
* Tweak the UI
* Add accelerator for the refresh button
* Make the IP labels selectable
* Drop the IP prefix from the UI, it's not the important bit
* Call DHCPLeases on the network instead to support this for more
drivers, like LXC
* Cache the IP results in the domain/network object wrappers
* Catch and log errors
* Poll for IP address when first visiting the interface page
2018-09-05 14:58:32 -04:00
3bd582331e
details: Show ipv4 and ipv6 address in details page of interface
...
If the interface's type is 'network', then code uses lease as one of
parameters of interface_addresses to get ipv4 and ipv6 address.
If the result is negative, then uses agent to try again, If the result
is still negative, uses arp for final try.
Signed-off-by: Lin Ma <lma@suse.com>
2018-09-05 12:33:11 -04:00
a500191b60
domain: Add function interface_addresses to return ipv4 and ipv6
...
It returns a dict that consisting of ipv4 and ipv6 which only match the
given mac, it returns None in exception.
Signed-off-by: Lin Ma <lma@suse.com>
2018-09-05 12:33:11 -04:00
e96e52bc28
addhardware: Add support for disk detect zeroes option
...
Complete this part of feature for commit e6c7e46a
2018-09-05 10:26:32 -04:00
a919a1ae4e
addhardware: Add support for disk discard option
...
Complete this part of feature for commit d13b793b
2018-09-05 10:26:12 -04:00
4394eff9fa
xmlbuilder: Drop last usages of set_converter
...
Unfold most of them into manual property() wrappers. It's a bit
noisier but the logic is easier to follow.
2018-09-04 14:55:04 -04:00
bd35f4711c
devices: disk: Rename setup() to build_storage()
...
It's more explicit. Plus drop the supposedly generic setup()
entry point, storage is handled specially everywhere so it's
not a generic interface
2018-09-04 14:55:04 -04:00
ebd6091cc8
devices: interface: Simplify is_conflict_net calls
...
We don't return a non-fatal error these days, so adjust all callers
to only handle failure
2018-09-04 14:55:04 -04:00
c27cdc67de
devices: interface: Convert setup() to validate()
...
That's all it's doing. Fold in mac validation while we are here
2018-09-04 14:55:04 -04:00
8aa01dab78
details: Remove UI display fields for egd RNG
...
In practice no one is using this, so it's not worth maintaining
specific UI to show its details
2018-09-04 14:55:04 -04:00
852d7b564d
virtinst: Remove name field validate_cb usage
...
Either openly do this at callers, or wrap it in a validate() call.
Doing this at set time has always had issues, like the self.replace hack
2018-09-04 14:55:04 -04:00
2ac54ac001
guest: Drop self.installer and start_install wrapper
...
This changes all the callers to invoke start_install directly on the
Installer object. We still stash the installer instance inside the
guest object in create.py, just for simplicity
2018-09-04 14:55:04 -04:00
c154bbacd4
guest: Fold add_default_devices into set_defaults
...
It doesn't have any need anymore to be separate
2018-09-04 14:55:04 -04:00
f1bbc5f67a
guest: move set_install_defaults to installer class
...
It's only called explicitly in one place, so update the caller
2018-09-04 14:55:04 -04:00
068c8aedd2
installer: Remove ContainerInstaller and ImportInstaller
...
Fold their non-logic into the base Installer class
2018-09-04 14:55:04 -04:00
1e76496fa8
storage: remove default_cb usage
2018-09-04 14:55:04 -04:00
d5bff2c987
guest: Remove default_cb usage
...
This lets us simplify things in create.py a bit, since we don't
need to manually encode a UUID
2018-09-04 14:55:04 -04:00
6215f790f5
devices: filesystem: Add set_defaults
...
Requires a bit of rework in virt-manager handling, which had lots
of explicit "default" handling
2018-09-04 14:55:04 -04:00
0f918a4bd5
addhw: Move interface model list to virtinst
...
So we are keeping the default and model list logic closer together,
as its similar
2018-09-04 14:55:04 -04:00
347143982a
devices: Add set_defaults for memballon, redirdev, rng, smartcard
2018-09-04 14:55:04 -04:00
698c72e60d
devices: sound: Add set_defaults
2018-09-04 14:55:04 -04:00
1b0f325813
devices: video: Add set_defaults
2018-09-04 14:55:04 -04:00
7738b8f407
devices: panic: Add set_defaults
...
Move default handling out of Guest and default_cb callbacks, and
make implement it in a standard set_defaults function
2018-09-04 14:55:04 -04:00
41daf1227c
choosecd: Emit cdrom-chosen signal after the dialog has been closed
...
This fixes the testChooseCDHotplug UI test: the cdrom-chosen signal
opens an alert and it does not get focus because it's being opened
before the dialog is closed. As a result, the tests timeout waiting for
the alert to get focus. Emitting the signal after the closure of the
dialog fixes this issue.
Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
2018-09-04 13:30:14 -04:00
e6c7e46a54
details: Add support for disk detect zeroes option
2018-09-04 11:39:50 -04:00
d13b793bfa
details: Add support for disk discard option
2018-09-04 11:39:50 -04:00
fb1bb26373
support: Drop lots more checks
...
- Remove anything for less than qemu 0.12 or libvirt 0.10, basically
rhel6 vintage stuff
- Open code some simple checks
- Remove some that are only used for unnecessary error reporting
2018-08-31 22:21:15 -04:00
967ca4eeda
virtinst: Drop direct 'support' usage
...
Except from connection. This requires some reorg in clitest and
some minor changes in a few other places
2018-08-31 18:31:17 -04:00
ea413be214
xmlbuilder: Rename get_xml_config -> get_xml
...
The config part is redundant. Should have done this a long time ago
2018-08-31 16:52:02 -04:00
2b41e130d8
connection: rename fetch_all_guests->fetch_all_domains
...
The virtinst class is erroneously called Guest, but these
functions are dealing with libvirt <domain> XML, so rename them
2018-08-31 16:50:46 -04:00
348b7e092c
sshtunnels: Fix bytes vs str in error reporting
2018-08-22 07:29:52 -04:00
ef4e0dbc4f
details: ADD checkbox to plug/unplug network interface
...
Hardware Details -> NIC of every VM should now contain checkbox for
interface's link state. This checkbox edits domain's XML by changing
<link state='up/down'/>. If XML doesn't contain this tag, virt manager
assumes state "up".
https://bugzilla.redhat.com/show_bug.cgi?id=1614532
Signed-off-by: Simon Kobyda <skobyda@redhat.com>
2018-08-17 10:49:26 +02:00
cab540792f
create: Support UEFI installs for armv7l
...
Will be supported with Fedora 29
https://fedoraproject.org/wiki/Changes/uEFIforARMv7
We should probably limit this by selected OS, but that's tricky
with the wizard as it is, so lets see if anyone cares
2018-08-08 15:14:21 -04:00
a55761c593
details: Use _disable_device_remove helper to set the remove tooltip
...
Signed-off-by: Lin Ma <lma@suse.com>
2018-08-08 10:25:41 -04:00
0c1fff2494
details: Disallow removing virtio-serial controller if devices attach to it
...
Signed-off-by: Lin Ma <lma@suse.com>
2018-07-31 10:57:56 -04:00
6099ca674e
details: Add _disable_device_remove helper
2018-07-31 10:49:42 -04:00
5212ab992e
details: Reset Remove tooltip on hardware selection
...
Otherwise it can be out of date
Reported-by: Lin Ma <lma@suse.com>
2018-07-31 10:37:50 -04:00
cacf2abe6b
details: Show attached disk info in sata, ide and floppy controller page
...
Reflect controllers <-> disks mapping relationship for not only scsi,
But other storage controllers.
As a bonus, These controllers are not allowed to be removed if there are
disks attached to them.
Signed-off-by: Lin Ma <lma@suse.com>
2018-07-31 10:16:45 -04:00
4484f473cd
char: Track/Show the state of virtio channels in channel details
...
crobinso: Add a test case
Signed-off-by: Lin Ma <lma@suse.com>
2018-07-12 15:25:23 -04:00
8f78b33d1c
Output the qemu guest agent lifecycle events in debug mode
...
Signed-off-by: Lin Ma <lma@suse.com>
2018-07-12 15:19:34 -04:00
ef3bcff14a
libvirtenummap: Map state vals of agent event to libvirt enum names
...
Signed-off-by: Lin Ma <lma@suse.com>
2018-07-12 15:19:34 -04:00
099ec95ac8
connection: Add callback parameter for function _add_domain_xml_event
...
Further patches will pass in the callback instead of the default one.
Signed-off-by: Lin Ma <lma@suse.com>
2018-07-12 15:19:34 -04:00
Cole Robinson