886339e8dd
virtManager: add coverage annotations and remove dead code
...
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-08-26 15:20:05 -04:00
15a2354559
i18n: use single strings for connection/uri
...
Create single strings for connection/uri hints & tooltips, so it is
easier to translate them, and there are not glued like puzzles.
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Pino Toscano <ptoscano@redhat.com>
2020-07-14 11:23:57 -04:00
67ef81895e
virtManager: Convert to CSS for most color usage
...
* Add CSS data in config.py and install it
* Strip out all hardcoded colors and use style class annotations
* Fix colors to be more theme appropriate to fix dark theme look
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-02-03 07:05:11 -05:00
aadaaf8785
manager: Don't hardcode black text color
...
Improves readability on dark theme
Resolves : #52
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2019-10-02 10:32:04 -04:00
3062b5ce08
virtManager: Move a lot of misc files to lib/
2019-06-17 00:12:32 -04:00
fa3f25dc1c
virtManager: rename connect.py -> createconn.py
...
connect.py is too ambiguous, and this naming is more consistent
2019-06-17 00:12:32 -04:00
121cf5528d
virtManager: rename create.py -> createvm.py
...
To be more consistent with other create wizard naming
2019-06-17 00:12:32 -04:00
f107e39989
Switch to more traditional logging structure
...
Init a shared log instance in virtinst/logger.py, and use that
throughout the code base, so we aren't calling directly into
'logging'. This helps protect our logging output from being
cluttered with other library output, as happens with some
'requests' usage
2019-06-17 00:12:31 -04:00
388850f04e
virtinst: Rename util to xmlutil
...
The only functions left in there are largely for xml handling, so
make it explicit
2019-06-07 18:21:24 -04:00
ecc3e3d34e
support: add is_libvirt_error_no_domain
...
Repurpose the generic util.exception_is_libvirt_error for the one
purpose that it's actually used, add it as a SupportCache staticmethod,
and test it
2019-06-07 16:44:14 -04:00
3784864e10
baseclass: Add is_visible
...
Remove the duplicated implementations everywhere
2019-04-14 17:05:14 -04:00
927d668215
virtManager: Use popup_at_pointer
...
Added in gtk 3.22 to fix some wayland ambiguity. Needed for sway wm
multimonitor apparently:
https://bugzilla.redhat.com/show_bug.cgi?id=1694379
2019-04-07 13:54:00 -04:00
a00152d72a
manager: fix some --test-leak-debug issues
2018-10-13 14:27:10 -04:00
48e32b429d
Fix copyright header to specify GPLv2 or later, not GPLv2 only.
...
The copyright headers in every file were chjanged in this previous commit
commit b6dcee8eb7
2018-04-04 16:51:37 -04:00
b6dcee8eb7
Use consistent and minimal license header for every file
2018-03-21 07:29:40 -04:00
97db1ac18a
manager: Simplify row management a bit
...
Drop the self.rows dict, use more pygobject row[] convenience
helpers, add some helper properties for VM
2018-03-17 18:46:40 -04:00
7de9028221
manager: Fix some menu item sensitivity issues
2018-03-17 18:46:40 -04:00
3c1e0a8a12
virtManager/*: Give pylint hints about singleton classes
...
It can't seem to figure out that what 'cls' is in this context,
so make it explicit.
2018-03-17 18:46:39 -04:00
dac860e8ce
engine: Show modal startup errors if window open fails
2018-03-16 19:09:55 -04:00
ee817c32ce
s/connect_opt_out/connect_once/ for open-completed callback
...
Forgot about that helper function...
2018-03-16 18:05:52 -04:00
dabbc8d5bd
engine: Remove centralized conn.open handling
...
Move connection opening logic to each caller, since needs are
slightly different.
2018-03-15 21:24:48 -04:00
cad809fe80
Make all dialogs clean up when vm/conn disappears
...
Moves all the window cleanup handling to each class and audit for
all --test-leak-debug errors and fix
2018-03-15 21:24:48 -04:00
1d17b98852
engine: Move most remaining window tracking to UI classes
...
Kind of a big mess but it was difficult to untangle piecemeal.
Basically this drops nearly all the centralized window tracking
in engine.py and moves it to each UI class. If manager.py wants
to open a details window it does it directly, and vmmDetails tracks
the window object list itself. This simplifies things and makes
the code easier to follow.
There's still some weirdness with vmmConnect and connection callbacks,
but future patches will break those apart.
2018-03-15 21:24:48 -04:00
92aea7c565
engine: Have windows increment/decrement windows directly
2018-03-15 21:24:48 -04:00
9fa9777f1c
engine: Have windows call exit_app directly
2018-03-15 21:24:48 -04:00
58f872a205
clone: Convert to per-connection singleton-ish pattern
...
And convert the dialog VM handling to match other dialogs
2018-03-15 21:24:48 -04:00
b94a9fdffb
migrate: convert to singleton
2018-03-15 21:24:48 -04:00
65b512ae6f
delete: Convert to singleton
2018-03-15 21:24:48 -04:00
f088537798
engine: break out vmmConnectionManager
...
Have a separate class for tracking the connection list, and emitting
conn-added and conn-removed signals. It exists as a singleton instance
that UI classes can talk directly to
2018-03-15 21:24:48 -04:00
befafe9dc7
engine: connect conn-added in UI classes
...
This creates a weird situation where we pass the engine to those
classes UI functions, but this is a step towards untangling that.
While here, get rid of the conn-added connect magic and add a
simpler way to access the connection list from the engine
2018-03-15 21:24:48 -04:00
6959a41ff2
connection: Drop vm-added emission on connect
...
We don't use this for most other signals and it's kind of unexpected
2018-03-15 21:24:48 -04:00
33def3c4af
preferences: Convert to singleton
2018-03-15 21:24:48 -04:00
b6a61818af
about: Convert to singleton
2018-03-15 21:24:48 -04:00
717ff72684
engine: Move VM action callbacks to vmmenu.py
...
Call the callbacks directly rather than using signals. engine.py
has become a bit of a catchall for shared functionality and this
is a step towards disentangling it
2018-03-15 21:24:48 -04:00
4c7c45908f
manager: Fix mem, disk, net stats graphs (bz 1543896)
...
python2/3 division compat messed this up
https://bugzilla.redhat.com/show_bug.cgi?id=1543896
2018-02-09 14:02:04 -05:00
6712261510
Python 2/3 division compatability
...
In Python 2 the classic devision of integers returns an integer
but in Python 3 it might return float.
Example:
- Python 2: - Python 3:
>>> 9 / 4 >>> 9 / 4
2 2.25
>>> 9 // 4 >>> 9 // 4
2 2
>>> 9 / 4.0 >>> 9 / 4.0
2.25 2.25
>>> 9 // 4.0 >>> 9 // 4.0
2.0 2.0
For more info see: https://www.python.org/dev/peps/pep-0238/
2018-01-27 15:30:17 -05:00
08049bfb0b
manager: Add accessible names to conn context menu
...
Needed to differentiate identical menu items in the ui test suite
2018-01-09 17:58:55 -05:00
d82022bd2c
manager: Drop python2 only cmp() usage
...
Manually implement it
2017-10-21 19:41:33 -04:00
b44aa0e3bb
pycodestyle: fix all E131 warnings
...
Fix all E131:
Continuation line unaligned for hanging indent
Also remove ignore options of E131
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2017-08-26 20:03:21 +08:00
c92aade081
pycodestyle: fix all E203 warnings
...
Fix all E203 whitespace before ':'
Also remove E203 ignore option of pycodestyle
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2017-08-11 00:01:38 +08:00
b93cc3bbc9
pycodestyle: Do not use bare 'except:'
...
A bare 'except:' catches all exceptions [1], including SystemExit,
KeyboardInterrupt, and GeneratorExit (which is not an error and should
not normally be caught by user code). In situations where you need to
catch all “normal” errors, you can catch the base class for all normal
exceptions, Exception [2].
[1] https://docs.python.org/2/howto/doanddont.html#except
[2] https://docs.python.org/2/library/exceptions.html#Exception
2017-08-02 13:57:43 -04:00
62feeb02a8
Switch to python3 style 'except X as Y' notation
...
Which also works with python2.7
2017-05-05 14:52:11 -04:00
107aa2b134
manager: Fix window size tracking on wayland (bug 1375175)
...
The method we were using is a common implementation bug,
explained here: https://wiki.gnome.org/HowDoI/SaveWindowState
https://bugzilla.redhat.com/show_bug.cgi?id=1375175
2016-12-13 13:34:09 -05:00
0891fc9ee1
manager: Clean up new conn/vm handling
2016-05-20 11:44:18 -04:00
c65e9d1e16
manager: fix --show-domain * manager conn populating
...
We need to register the conn internally before connecting
vm-added, otherwise the VMs don't end up in the UI
2016-05-20 11:44:18 -04:00
3aa941571a
uiutil: Drop check for old pygobject row handling
...
Once upon a time it couldn't handle setting a row value to None,
but we've bumped the dep now
2016-05-17 17:49:56 -04:00
f4dfb6de9d
Fix recent pylint/pep8 output
2016-04-18 16:42:12 -04:00
febe0abdd2
virt-manager: Drop manual dbusapi, use GtkApplication
...
So I was confused here and completely missed that GtkApplication is
meant to handle the common case of invoking actions in an existing
app instance. So drop the manual dbus server and use the simpler
Gtk support.
Fix a bunch of other errors in this area too
2015-12-06 15:41:49 -05:00
fedf2e7b66
ui: improve pause/resume tooltip
...
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1238618
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-11-12 13:13:19 +01:00
3e049583cc
details: Drop ignorePause variable; just block the signals
2015-11-10 18:30:31 -05:00
Cole Robinson