3d07b28a36
device: disk: Rename path property to get/set_source_path
...
This makes it more clear that 'path' is really a special designation
with a bunch of complicated logic behind it. It's also easier to
grep for
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-11 19:06:32 -05:00
b3ff59c75c
device: disk: Move <source> XML handling to its own class
...
Makes DeviceDisk less complicated, helps with readability
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-11 18:07:50 -05:00
fa322588b4
tests: Drop most unittest usage from virtinst tests
...
Kill usage of the TestCase class, move more to pytest standard
style
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-19 13:46:46 -04:00
b79ee9565f
tests: Rename test_xmlconfig.py to test_misc.py
...
That's what it is now, just a collection of misc virtinst tests
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-19 13:46:33 -04:00
4c4753d910
tests: break out test_disk.py
...
Move a bunch of misc disk/diskbackend tests to this file
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-19 13:46:22 -04:00
0ac9ff3488
tests: Drop a bunch of redundant xmlparse/xmlconfig tests
...
For the few bits we are hitting specific code paths, break them
out or fold them into other test cases
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-19 13:46:08 -04:00
71ac3ee044
tests: Convert to use pytest style 'assert'
...
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-19 13:44:50 -04:00
ac51ff8684
cli: Fill in all --filesystem suboptions
...
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-11 09:00:33 -04:00
9c1453a253
disk: lookup volumes in disk.set_backend_for_existing_path
...
Seems like it should be doing this.
Make use of that helper in cloner afterwards
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-05 15:49:55 -04:00
38405a477c
tests: Add *DIR helper variables
...
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-08-30 14:23:24 -04:00
34c6d1c7ea
virtinst: cpu: Move topology elements to their own class
...
This is a no-op but will help with a future bug fix
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-08-27 19:41:28 -04:00
aa89a48371
xmlutil: Centralize all 'programming error' exceptions
...
Raise them directly instead of adding the hard to read conditional
into the function
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-07-17 19:08:27 -04:00
e7bb021c4c
diskbackend: Add lots of test coverage
...
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-01-29 08:38:18 -05:00
04c0d48ef7
devices: disk: Always set a stub storage backend
...
This reworks the existing code to never have storage_backend = None,
instead carrying around a stub class, and resolving the actual
storage info when necessary. This makes the logic easier to follow.
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-01-29 06:52:29 -05:00
4cb775773f
devices: disk: Add change_bus()
...
Taken from virt-manager code. Move it here because it is strictly
an XML operation, and it will be easier to unit test
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-01-29 06:44:33 -05:00
11d6536542
guest: Finish off test coverage
...
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-01-27 13:08:12 -05:00
dcab14e0b4
domain: cpu: Finish test coverage
...
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-01-27 13:08:12 -05:00
6f95ebc7fd
devices: controller: Add get_attached_devices
...
Move the opencoded impl out of virt-manager details.py and into
virtinst, since this is entirely about XML comparison. Add tests for
it
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-01-27 13:08:12 -05:00
ec580f82a2
tests: Cover Guest.find_device and Device.compare_device
...
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-01-27 07:38:53 -05:00
e784376699
tests: Rename all test files to have test_ prefix
...
This will help for a possible future conversion to pytest
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-01-27 06:57:37 -05:00
Cole Robinson