virt-manager/virtManager
Pavel Hrdina c0710c74ff choosecd: change order of check operations
The current order of check operations is wrong.  First we set the new
path for the disk in question and after that we check whether some
guest already uses a disk with the same path.

The issue is that virt-manager returns a cached list of guests in
path_in_use_by() and the cached guest has the disk path already
updated.

Ideally we don't update the path at all, but we do it to run some
checks before the path is actually changed.  In order to fix the
referenced bug, change the order of check operations.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1453094

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2017-09-19 20:04:39 -04:00
..
__init__.py headers: update "Red Hat, Inc." copyright for the year 2013 2013-10-28 17:22:26 +01:00
about.py virtManager: Switch to relative imports 2014-09-12 16:28:38 -04:00
addhardware.py pycodestyle: fix all E124 warnings 2017-09-09 23:21:42 +08:00
addstorage.py pycodestyle: Do not use bare 'except:' 2017-08-02 13:57:43 -04:00
asyncjob.py pycodestyle: fix all E203 warnings 2017-08-11 00:01:38 +08:00
baseclass.py pycodestyle: Do not use bare 'except:' 2017-08-02 13:57:43 -04:00
choosecd.py choosecd: change order of check operations 2017-09-19 20:04:39 -04:00
clone.py pycodestyle: fix all E131 warnings 2017-08-26 20:03:21 +08:00
config.py pycodestyle: fix all E203 warnings 2017-08-11 00:01:38 +08:00
connect.py pycodestyle: Do not use bare 'except:' 2017-08-02 13:57:43 -04:00
connectauth.py pycodestyle: Do not use bare 'except:' 2017-08-02 13:57:43 -04:00
connection.py connection: change blacklist from array to dict 2017-09-09 10:12:12 +02:00
console.py Switch to python3 style 'except X as Y' notation 2017-05-05 14:52:11 -04:00
create.py pycodestyle: fix all E203 warnings 2017-08-11 00:01:38 +08:00
createinterface.py pycodestyle: fix all E131 warnings 2017-08-26 20:03:21 +08:00
createnet.py pycodestyle: fix all E203 warnings 2017-08-11 00:01:38 +08:00
createpool.py pycodestyle: fix all E203 warnings 2017-08-11 00:01:38 +08:00
createvol.py pycodestyle: fix all E203 warnings 2017-08-11 00:01:38 +08:00
delete.py pycodestyle: fix all E203 warnings 2017-08-11 00:01:38 +08:00
details.py details: Fix displaying isa panic device 2017-09-15 19:36:58 -04:00
domain.py domain: invalidate domain caps if machine type is changed 2017-09-19 10:40:09 +02:00
engine.py engine: improve message about missing binaries 2017-08-16 17:32:18 -04:00
error.py spice: s/OK/Close/ in USB redirection dialog (bz 1465907) 2017-07-17 15:46:12 -04:00
fsdetails.py fsdetails: Simplify ram conversion 2017-06-27 14:21:18 -04:00
gfxdetails.py pycodestyle: fix all E203 warnings 2017-08-11 00:01:38 +08:00
graphwidgets.py pycodestyle: fix all E203 warnings 2017-08-11 00:01:38 +08:00
host.py pycodestyle: fix all E203 warnings 2017-08-11 00:01:38 +08:00
inspection.py pycodestyle: Do not use bare 'except:' 2017-08-02 13:57:43 -04:00
interface.py interface: don't print error for active interface without an IP address 2017-05-10 12:35:42 +02:00
keyring.py pycodestyle: fix all E203 warnings 2017-08-11 00:01:38 +08:00
libvirtobject.py pycodestyle: Do not use bare 'except:' 2017-08-02 13:57:43 -04:00
manager.py pycodestyle: fix all E131 warnings 2017-08-26 20:03:21 +08:00
mediacombo.py pycodestyle: Do not use bare 'except:' 2017-08-02 13:57:43 -04:00
migrate.py pycodestyle: fix all E203 warnings 2017-08-11 00:01:38 +08:00
module_trace.py module_trace: Only show main thread APIs by default 2014-09-21 12:05:02 -04:00
netlist.py pycodestyle: Do not use bare 'except:' 2017-08-02 13:57:43 -04:00
network.py libvirtobject: Drop redefine_cached 2015-04-10 17:23:11 -04:00
nodedev.py Use node device lifecycle events 2016-08-11 10:14:30 -04:00
packageutils.py packageutils: Ensure packages argument is a list 2017-08-07 17:27:30 -04:00
preferences.py pycodestyle: fix all E203 warnings 2017-08-11 00:01:38 +08:00
serialcon.py pycodestyle: Do not use bare 'except:' 2017-08-02 13:57:43 -04:00
snapshots.py pycodestyle: fix all E124 warnings 2017-09-09 23:21:42 +08:00
sshtunnels.py sshtunnels: use <listen> element to get UNIX socket for graphics 2017-09-09 10:11:42 +02:00
storagebrowse.py pycodestyle: fix all E203 warnings 2017-08-11 00:01:38 +08:00
storagelist.py pycodestyle: fix all E203 warnings 2017-08-11 00:01:38 +08:00
storagepool.py Switch to python3 style 'except X as Y' notation 2017-05-05 14:52:11 -04:00
systray.py pycodestyle: Do not use bare 'except:' 2017-08-02 13:57:43 -04:00
uiutil.py pycodestyle: Do not use bare 'except:' 2017-08-02 13:57:43 -04:00
viewers.py pycodestyle: Do not use bare 'except:' 2017-08-02 13:57:43 -04:00
vmmenu.py We can't clone a VM in some scenarios, 2016-10-06 23:12:59 +08:00