Commit Graph

42 Commits

Author SHA1 Message Date
Jinbo Wang 4e9a89f2e6
Don't switch focus to DEBUG CONSOLE if launching in integratedTerminal (#595)
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
2019-05-31 13:36:56 +08:00
Jinbo Wang f807d54243
Add a global setting to specify the default console to launch the program (#594)
* Add a global setting to specify the default console to launch the program

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Address review comments

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
2019-05-31 11:30:09 +08:00
Jinbo Wang 01f7735b72
Auto add --enable-preview vmArgs for java 12 project (#561)
* Auto add --enable-preview vmArgs for java 12 project

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* make tslint happy

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Use new generic api to check project preview flag

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Address review comments

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Make tslint happy

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
2019-04-15 13:31:14 +08:00
Jinbo Wang 7abda57511
Provide jarmanifest/argfile approachs to shorten the command line (#532)
* Provide jarmainifest/argfile approachs to shorten the command line

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Add new launch.json config to README

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Fix the localizable words per comments

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Add auto mode to auto detect the right approach to shorten command line

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* fix build error

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Address the review comments

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Differentiate the command line length limit for different OS

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
2019-02-21 14:53:36 +08:00
Jinbo Wang 5ab4fd83ed
Add an user setting to control whether to build the workspace before debugging (#485)
* Add an user setting to control whether to build the workspace before debuging

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Add Chinese translation for the new setting

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
2018-12-03 13:30:12 +08:00
Jinbo Wang 6b383e9e48
Refine the launch json (#481)
* Refine the launch json

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Fix review comments

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Remove the unimportant options from default launch.json

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
2018-11-30 11:26:06 +08:00
Jinbo Wang 447d2dfd69
resolveDebugConfiguration returns null to tell vscode to continue generating launch.json (#430)
* resolveDebugConfiguration returns null to tell vscode to continue generating launch.json

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Use truthy to check the value is empty or not
2018-09-18 12:21:38 +08:00
Jinbo Wang 7dc2273755
Use Language Server consistent java home to launch debuggee (#428)
* Use Language Server consistent java home to launch debuggee

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* refactor checkJavaHome to getJavaHome
2018-09-18 10:42:15 +08:00
Yan Zhang f191fbd4d7
Use telemetry wrapper to unify BI format. (#417)
* Use telemetry wrapper to unify BI format.

* Turn off debug mode.

* Resolve comments: not export help function.
2018-09-14 16:37:35 +08:00
Jinbo Wang 8eb2078de6
Fix the display order and icon issues for main class prompt wizard (#426)
* Fix the display order and icon issues for main class prompt wizard

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Fix review comments

* Add return type for the function declaration

* fix the code format

* use _.get to guard the undefined case\
2018-09-14 12:43:53 +08:00
Andy Xu(devdiv) f4b5507914
fix undefined workspace folder (#425) 2018-09-13 10:12:16 +08:00
Andy Xu(devdiv) 8944deef16
Fix issue #398:Not allowing {fileBasenameNoExtension} (#416)
* Fix issue #398:Not allowing {fileBasenameNoExtension} to be used in main class launch configuration
2018-09-12 10:35:06 +08:00
Jinbo Wang 51619efd5e
Use codeLens to run Java program (#410)
* Use codeLens to run Java program

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Move codeLens action name to local constants

* use lodash _.flatten to flatten the codeLens result

* Add return statement
2018-09-11 13:41:58 +08:00
Jinbo Wang b3ce6810f0
Change active editor oct icon to file-text instead of clock (#419)
* Change active editor oct icon to file-text instead of clock

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Make tslint happy
2018-09-11 11:19:18 +08:00
Andy Xu(devdiv) 140474e956
Accept both string and string array in args and vmArgs. (#414)
* Accept both string and string array in args and vmArgs.
2018-09-10 12:55:56 +08:00
Jinbo Wang 5031c63df5
Fix the duplicated error dialog after the user clicks Learn More (#380)
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
2018-08-28 16:20:00 +08:00
Jinbo Wang 8ac5ca5c38
Validate mainClass and projectName before launch (#368)
* Validate mainClass and projectName before launch

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Fix review comments

1. Better naming about validate and fix mainClass and ProjectName.
2. Use lodash library to find the debug configuration index from the
workspaceConfiguration list.

* Revert 'errorMessage' to the neutral 'message' for IValidationResult scheme

* Pass containsExternalClasspaths flag to the mainClass validator

* Correct the learn more link for mainClass configError

* Fix learn more link for mainClass configError

* Remove extra empty line

* Use lodash _.isEmpty to check empty array

* Use try/catch to handle the rejected/exceptional case
2018-08-28 11:16:01 +08:00
Yan Zhang 76af46219d
Robustness: judge no launch.json exists. (#377)
* Robustness: judge no launch.json exists.

* Use a common function to judge an empty config.

* Update configurationProvider.ts

* Update configurationProvider.ts

* Add comments to reduce ambiguity.
2018-08-27 12:44:43 +08:00
Jinbo Wang c40301a1ed
Put recently used main class in the top (#372)
* Put recently used main class in the top

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Refactor the History interface to an accurate name

* Combine all the boolean operations in one statement

* Rename getId to getKey to keep properties consistent
2018-08-27 10:21:55 +08:00
Jinbo Wang ae23fcb02e
"Learn More" link jumps to the associated troubleshooting paragraph directly (#371)
* Learn More link to the corresponding troubleshooting paragraph directly

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Update LS troubleshooting anchor point

* make tslint happy

* Give a meaningful sample message instead of xyz

* Refactor IMessage interface
2018-08-22 14:37:55 +08:00
Jinbo Wang 0e86ed2cc7
Add a troubleshooting page for the frequently asked errors (#341)
* Add a troubleshooting page for the frequently asked errors

* Update the wrong link and remove the unnecessary separator

* Update Troubleshooting.md

* Make tslint happy

* Refine the words per review

* Add the missing items parameter for showErrorMessage function

* Log the troubleshooting usage

* Add a reference in README to link to troubleshooting page

* Update the fix steps for illegal request type error

* Refine the description words for differnt errors

* Add jdk troubleshooting item

* Add a link to submit an issue

* Add compilation as a try step for ClassNotFoundException

* Add the missing license header

* Resolve the review comments for troubleshooting doc

* Extract dup code to a helper function

* Merge activation event to usage data

* Refactor showMessage utility method

* Add opn to dependency list

* update package-lock.json
2018-08-01 14:35:48 +08:00
Yan Zhang 2344c606cb
Improve launch.json auto-generation UX (#342)
* remove 'attach' config from default

* add default launch config with empty mainClass

* add back default attach config
2018-07-19 10:46:06 +08:00
Andy Xu(devdiv) 4b1be3c9c3
doesn't popup error message when user cancels the main class selection. (#267)
* doesn't popup error message when user cancels the main class selection.

* add detailed type declaration

* remove the useless check, since pickItems.length will always be larger than 0

* doesn't popup error message when user cancels the main class selection.

* remove trailing spacess.
2018-04-02 09:42:49 +08:00
Summer 1334496a0c
wait for build succeeded before launch debug session (#257) 2018-03-30 09:40:29 +08:00
Andy Xu(devdiv) ab595f02b1
fix issue 187:If only 1 main class detected, proceed and start it dir… (#262)
* fix issue 187:If only 1 main class detected, proceed and start it directly
2018-03-27 10:54:44 +08:00
Jinbo Wang d77e395d75 Support stopOnEntry and launchInTerminal in launch.json (#177)
* Define launchInTerminal config in launch.json

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Support stopOnEntry and launchInTerminal in launch.json

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Fix review comments

* fix review comments
2017-11-29 22:00:37 +08:00
Xuan Zhou 676af6d425
only do rebuild for single file (#176)
Signed-off-by: xuzho <xuzho@microsoft.com>
2017-11-28 18:23:23 +08:00
Yaohai Zheng 4bbf1ef372
Add project scope when resolving multiple-root project. (#174) 2017-11-22 14:03:06 +08:00
Andy Xu(devdiv) 609a1b7054
Version 0.3.1 (#161) (#166)
* Fix the issue 146 which cause the petclinic project unable to start.

* update package lock file and remove useless comment
2017-11-17 17:26:07 +08:00
Andy Xu(devdiv) 5063601997
fix issue https://github.com/Microsoft/vscode-java-debug/issues/146 (#148) 2017-11-09 19:53:47 +08:00
Jinbo Wang 9ef63e6d7f
Remove stopOnEntry for perf issue (#147)
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
2017-11-09 19:53:38 +08:00
Andy Xu(devdiv) 96f2b7c3de
Get debug settings from user preference and send it to debuggee (#135)
* 1. watch user settings for changed event, apply it when change happens
2. get debug settings from user settings and send it to debuggee

* change settings names

* merge log level to other settings.

* update desc to debug settings.

* update description for better clause

* update description for better clause

* fix typo

* update description for better clause
2017-11-09 14:43:39 +08:00
Jinbo Wang 4b9ee81de5
Disable stopOnEntry by default (#143)
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
2017-11-09 14:40:23 +08:00
Xuan Zhou f26aa26330
fix regression: launch.json isn't generated for project (#141)
* fix regression: launch.json isn't generated for project

Signed-off-by: xuzho <xuzho@microsoft.com>

* resolve comments and choose option1

Signed-off-by: xuzho <xuzho@microsoft.com>
2017-11-08 16:55:09 +08:00
Xuan Zhou 2ce2d772c1
support stopOnEntry (#133)
* support stopOnEntry

Signed-off-by: xuzho <xuzho@microsoft.com>

* update readme

Signed-off-by: xuzho <xuzho@microsoft.com>
2017-11-07 17:22:47 +08:00
Xuan Zhou ae3b9d7996
build workspace before trigger debug and support single file debug (#129)
* build workspace before trigger debug and support single file debug

Signed-off-by: xuzho <xuzho@microsoft.com>

* update requirement

Signed-off-by: xuzho <xuzho@microsoft.com>
2017-11-07 16:05:24 +08:00
Jinbo Wang 6c1fa39e3e
Support java 9 (#124)
* Support java 9

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Make tslint happy

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* Fix review comments

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* update readme

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
2017-11-06 18:12:32 +08:00
Jinbo Wang 80490fa150
Customize launching connector to support cwd and enviroment variable (#119)
* Customize launching connector to support cwd and enviroment variable

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* disable tslint rule for 'Interpolation will only work for template strings' error

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
2017-11-01 09:45:25 +08:00
Xuan Zhou 2dde11921a add progress when initializing debug config (#106)
Signed-off-by: xuzho <xuzho@microsoft.com>
2017-10-23 10:00:52 +08:00
Xuan Zhou a24afa0571 resolve mainclass (#88)
* update: always return all mainclass/project

Signed-off-by: xuzho <xuzho@microsoft.com>

* resolve comments

Signed-off-by: xuzho <xuzho@microsoft.com>

* use es6 template literal

Signed-off-by: xuzho <xuzho@microsoft.com>

* resolve merge failure

Signed-off-by: xuzho <xuzho@microsoft.com>
2017-10-18 19:37:14 +08:00
Yaohai Zheng 6e258f754c Refine the code. (#99) 2017-10-17 12:37:02 +08:00
Jinbo Wang e08d0177c7 fix feature break from October VSCode insider (#87)
* fix feature break from October VSCode insider

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* fix review comments

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* showErrorMessage API only supports printing a string variable and throw exception for Object

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

* remove unnecessary log

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
2017-10-15 22:55:04 -05:00