From b83a36a8aead4b76c2c4025283590e1afd7e500a Mon Sep 17 00:00:00 2001 From: jinhyuk-kim-ca <71794373+jinhyuk-kim-ca@users.noreply.github.com> Date: Sat, 13 Mar 2021 00:22:28 -0500 Subject: [PATCH] support ShowError option in Pivot table (#802) --- pivotTable.go | 2 ++ pivotTable_test.go | 1 + xmlPivotTable.go | 4 ++-- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/pivotTable.go b/pivotTable.go index ff21ac1..42a9473 100644 --- a/pivotTable.go +++ b/pivotTable.go @@ -34,6 +34,7 @@ type PivotTableOption struct { PageOverThenDown bool MergeItem bool CompactData bool + ShowError bool ShowRowHeaders bool ShowColHeaders bool ShowRowStripes bool @@ -308,6 +309,7 @@ func (f *File) addPivotTable(cacheID, pivotTableID int, pivotTableXML string, op PageOverThenDown: &opt.PageOverThenDown, MergeItem: &opt.MergeItem, CompactData: &opt.CompactData, + ShowError: &opt.ShowError, DataCaption: "Values", Location: &xlsxLocation{ Ref: hcell + ":" + vcell, diff --git a/pivotTable_test.go b/pivotTable_test.go index 42103f3..40d58d4 100644 --- a/pivotTable_test.go +++ b/pivotTable_test.go @@ -38,6 +38,7 @@ func TestAddPivotTable(t *testing.T) { ShowRowHeaders: true, ShowColHeaders: true, ShowLastColumn: true, + ShowError: true, })) // Use different order of coordinate tests assert.NoError(t, f.AddPivotTable(&PivotTableOption{ diff --git a/xmlPivotTable.go b/xmlPivotTable.go index dc8b765..9c4be50 100644 --- a/xmlPivotTable.go +++ b/xmlPivotTable.go @@ -31,7 +31,7 @@ type xlsxPivotTableDefinition struct { DataCaption string `xml:"dataCaption,attr"` GrandTotalCaption string `xml:"grandTotalCaption,attr,omitempty"` ErrorCaption string `xml:"errorCaption,attr,omitempty"` - ShowError bool `xml:"showError,attr,omitempty"` + ShowError *bool `xml:"showError,attr"` MissingCaption string `xml:"missingCaption,attr,omitempty"` ShowMissing bool `xml:"showMissing,attr,omitempty"` PageStyle string `xml:"pageStyle,attr,omitempty"` @@ -48,7 +48,7 @@ type xlsxPivotTableDefinition struct { VisualTotals bool `xml:"visualTotals,attr,omitempty"` ShowMultipleLabel bool `xml:"showMultipleLabel,attr,omitempty"` ShowDataDropDown bool `xml:"showDataDropDown,attr,omitempty"` - ShowDrill *bool `xml:"showDrill,attr,omitempty"` + ShowDrill *bool `xml:"showDrill,attr"` PrintDrill bool `xml:"printDrill,attr,omitempty"` ShowMemberPropertyTips bool `xml:"showMemberPropertyTips,attr,omitempty"` ShowDataTips bool `xml:"showDataTips,attr,omitempty"`