p30928647
/
excelize
1
0
Fork 1
Code Issues Pull Requests Projects Releases 23 Wiki Activity

Fixed #825, improves compatibility for comments with absolute XML path

This commit is contained in:
xuri 2021-04-26 22:51:35 +08:00
parent f5a20fa03f
commit e5c5ecc379
No known key found for this signature in database
GPG Key ID: BA5E5BB1C948EDF7
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
comment.go
View File

@ -39,7 +39,14 @@ func parseFormatCommentsSet(formatSet string) (*formatComment, error) {
func (f *File) GetComments() (comments map[string][]Comment) {
comments = map[string][]Comment{}
for n, path := range f.sheetMap {
if d := f.commentsReader("xl" + strings.TrimPrefix(f.getSheetComments(filepath.Base(path)), "..")); d != nil {
target := f.getSheetComments(filepath.Base(path))
if target == "" {
continue
}
if !filepath.IsAbs(target) {
target = "xl" + strings.TrimPrefix(target, "..")
}
if d := f.commentsReader(strings.TrimPrefix(target, "/")); d != nil {
sheetComments := []Comment{}
for _, comment := range d.CommentList.Comment {
sheetComment := Comment{}

1
comment_test.go
View File

@ -40,6 +40,7 @@ func TestAddComments(t *testing.T) {
comments := f.GetComments()
assert.EqualValues(t, 2, len(comments["Sheet1"]))
assert.EqualValues(t, 1, len(comments["Sheet2"]))
assert.EqualValues(t, len(NewFile().GetComments()), 0)
}
func TestDecodeVMLDrawingReader(t *testing.T) {